<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[174950] releases/WebKitGTK/webkit-2.6</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/174950">174950</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2014-10-21 05:25:11 -0700 (Tue, 21 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/174217">r174217</a> - AX: Default orientation for aria scrollbars should be vertical
https://bugs.webkit.org/show_bug.cgi?id=137341
Reviewed by Chris Fleizach.
Source/WebCore:
Default orientation for aria scrollbars regarding w3c spec should be vertical
No new tests, covering by existing one.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::orientation):
LayoutTests:
Update expectation and test for having new test case.
* accessibility/aria-scrollbar-role-expected.txt:
* accessibility/aria-scrollbar-role.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit26LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit26LayoutTestsaccessibilityariascrollbarroleexpectedtxt">releases/WebKitGTK/webkit-2.6/LayoutTests/accessibility/aria-scrollbar-role-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit26LayoutTestsaccessibilityariascrollbarrolehtml">releases/WebKitGTK/webkit-2.6/LayoutTests/accessibility/aria-scrollbar-role.html</a></li>
<li><a href="#releasesWebKitGTKwebkit26SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit26SourceWebCoreaccessibilityAccessibilityRenderObjectcpp">releases/WebKitGTK/webkit-2.6/Source/WebCore/accessibility/AccessibilityRenderObject.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit26LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog (174949 => 174950)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog 2014-10-21 12:23:33 UTC (rev 174949)
+++ releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog 2014-10-21 12:25:11 UTC (rev 174950)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-10-02 Krzysztof Czech <k.czech@samsung.com>
+
+ AX: Default orientation for aria scrollbars should be vertical
+ https://bugs.webkit.org/show_bug.cgi?id=137341
+
+ Reviewed by Chris Fleizach.
+
+ Update expectation and test for having new test case.
+
+ * accessibility/aria-scrollbar-role-expected.txt:
+ * accessibility/aria-scrollbar-role.html:
+
</ins><span class="cx"> 2014-10-01 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Add basic caching for Document.cookie API
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26LayoutTestsaccessibilityariascrollbarroleexpectedtxt"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/LayoutTests/accessibility/aria-scrollbar-role-expected.txt (174949 => 174950)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/LayoutTests/accessibility/aria-scrollbar-role-expected.txt 2014-10-21 12:23:33 UTC (rev 174949)
+++ releases/WebKitGTK/webkit-2.6/LayoutTests/accessibility/aria-scrollbar-role-expected.txt 2014-10-21 12:25:11 UTC (rev 174950)
</span><span class="lines">@@ -1,4 +1,5 @@
</span><span class="cx"> scrollbar
</span><ins>+scrollbar
</ins><span class="cx"> This tests that the ARIA scrollbar role works correctly
</span><span class="cx">
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="lines">@@ -8,6 +9,9 @@
</span><span class="cx"> PASS scroller.intValue is 55
</span><span class="cx"> PASS scroller.orientation is 'AXOrientation: AXVerticalOrientation'
</span><span class="cx"> PASS scroller.orientation is 'AXOrientation: AXHorizontalOrientation'
</span><ins>+PASS scroller.role is 'AXRole: AXScrollBar'
+PASS scroller.intValue is 55
+PASS scroller.orientation is 'AXOrientation: AXVerticalOrientation'
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26LayoutTestsaccessibilityariascrollbarrolehtml"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/LayoutTests/accessibility/aria-scrollbar-role.html (174949 => 174950)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/LayoutTests/accessibility/aria-scrollbar-role.html 2014-10-21 12:23:33 UTC (rev 174949)
+++ releases/WebKitGTK/webkit-2.6/LayoutTests/accessibility/aria-scrollbar-role.html 2014-10-21 12:25:11 UTC (rev 174950)
</span><span class="lines">@@ -5,9 +5,9 @@
</span><span class="cx"> </head>
</span><span class="cx"> <body id="body">
</span><span class="cx">
</span><del>-<div tabindex=0 id="scroller" aria-valuenow="55" role="scrollbar" aria-orientation="vertical">scrollbar</div>
</del><ins>+<div tabindex=0 id="scroller1" aria-valuenow="55" role="scrollbar" aria-orientation="vertical">scrollbar</div>
+<div tabindex=0 id="scroller2" aria-valuenow="55" role="scrollbar">scrollbar</div>
</ins><span class="cx">
</span><del>-
</del><span class="cx"> <p id="description"></p>
</span><span class="cx"> <div id="console"></div>
</span><span class="cx">
</span><span class="lines">@@ -17,14 +17,21 @@
</span><span class="cx">
</span><span class="cx"> if (window.accessibilityController) {
</span><span class="cx">
</span><del>- document.getElementById("scroller").focus();
</del><ins>+ document.getElementById("scroller1").focus();
</ins><span class="cx"> var scroller = accessibilityController.focusedElement;
</span><span class="cx"> shouldBe("scroller.role", "'AXRole: AXScrollBar'");
</span><span class="cx"> shouldBe("scroller.intValue", "55");
</span><span class="cx"> shouldBe("scroller.orientation", "'AXOrientation: AXVerticalOrientation'");
</span><span class="cx">
</span><del>- document.getElementById("scroller").setAttribute("aria-orientation", "horizontal");
</del><ins>+ document.getElementById("scroller1").setAttribute("aria-orientation", "horizontal");
</ins><span class="cx"> shouldBe("scroller.orientation", "'AXOrientation: AXHorizontalOrientation'");
</span><ins>+
+ // Default orientation should be vertical for scrollbars
+ document.getElementById("scroller2").focus();
+ scroller = accessibilityController.focusedElement;
+ shouldBe("scroller.role", "'AXRole: AXScrollBar'");
+ shouldBe("scroller.intValue", "55");
+ shouldBe("scroller.orientation", "'AXOrientation: AXVerticalOrientation'");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> </script>
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog (174949 => 174950)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog 2014-10-21 12:23:33 UTC (rev 174949)
+++ releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog 2014-10-21 12:25:11 UTC (rev 174950)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-10-02 Krzysztof Czech <k.czech@samsung.com>
+
+ AX: Default orientation for aria scrollbars should be vertical
+ https://bugs.webkit.org/show_bug.cgi?id=137341
+
+ Reviewed by Chris Fleizach.
+
+ Default orientation for aria scrollbars regarding w3c spec should be vertical
+
+ No new tests, covering by existing one.
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::orientation):
+
</ins><span class="cx"> 2014-10-02 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> Fix minimal build warnings
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26SourceWebCoreaccessibilityAccessibilityRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (174949 => 174950)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-10-21 12:23:33 UTC (rev 174949)
+++ releases/WebKitGTK/webkit-2.6/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-10-21 12:25:11 UTC (rev 174950)
</span><span class="lines">@@ -2652,6 +2652,9 @@
</span><span class="cx"> return AccessibilityOrientationHorizontal;
</span><span class="cx"> if (equalIgnoringCase(ariaOrientation, "vertical"))
</span><span class="cx"> return AccessibilityOrientationVertical;
</span><ins>+
+ if (isScrollbar())
+ return AccessibilityOrientationVertical;
</ins><span class="cx">
</span><span class="cx"> return AccessibilityObject::orientation();
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>