<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[174954] releases/WebKitGTK/webkit-2.6</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/174954">174954</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2014-10-21 06:33:06 -0700 (Tue, 21 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/174273">r174273</a> - REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/173531">r173531</a>): Use after free in WebCore::RenderStyle::fontMetrics /
WebCore::CSSPrimitiveValue::computeLengthDouble
https://bugs.webkit.org/show_bug.cgi?id=136864
Reviewed by Andreas Kling.
Source/WebCore:
FontLoader previously called updateDocumentStyleIfNeeded,
which would reset styles currently in use as part of
the tabIndex calculation. The FontLoader should instead
wait for pending stylesheets to load.
Tests: fast/css/fontloader-tab-index.html
* css/FontLoader.cpp:
(WebCore::FontLoader::notifyWhenFontsReady): Do not immediately
call loadingDone().
(WebCore::FontLoader::loadingDone): Wait for stylesheets to
finish loading rather than updating document styles.
* css/FontLoader.h:
(WebCore::FontLoader::loading): Include JS font loads when testing
for the loading state.
LayoutTests:
Test that getting the tab index on a body element with
font-relative measurements to a local @font-face do not
cause a crash.
* fast/css/fontloader-tab-index-expected.html: Added.
* fast/css/fontloader-tab-index.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit26LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit26SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit26SourceWebCorecssFontLoadercpp">releases/WebKitGTK/webkit-2.6/Source/WebCore/css/FontLoader.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit26SourceWebCorecssFontLoaderh">releases/WebKitGTK/webkit-2.6/Source/WebCore/css/FontLoader.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit26LayoutTestsfastcssfontloadertabindexexpectedhtml">releases/WebKitGTK/webkit-2.6/LayoutTests/fast/css/fontloader-tab-index-expected.html</a></li>
<li><a href="#releasesWebKitGTKwebkit26LayoutTestsfastcssfontloadertabindexhtml">releases/WebKitGTK/webkit-2.6/LayoutTests/fast/css/fontloader-tab-index.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit26LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog (174953 => 174954)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog 2014-10-21 13:23:38 UTC (rev 174953)
+++ releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog 2014-10-21 13:33:06 UTC (rev 174954)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-10-03 Bear Travis <betravis@adobe.com>
+
+ REGRESSION (r173531): Use after free in WebCore::RenderStyle::fontMetrics /
+ WebCore::CSSPrimitiveValue::computeLengthDouble
+ https://bugs.webkit.org/show_bug.cgi?id=136864
+
+ Reviewed by Andreas Kling.
+
+ Test that getting the tab index on a body element with
+ font-relative measurements to a local @font-face do not
+ cause a crash.
+
+ * fast/css/fontloader-tab-index-expected.html: Added.
+ * fast/css/fontloader-tab-index.html: Added.
+
</ins><span class="cx"> 2014-10-02 Krzysztof Czech <k.czech@samsung.com>
</span><span class="cx">
</span><span class="cx"> AX: Default orientation for aria scrollbars should be vertical
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26LayoutTestsfastcssfontloadertabindexexpectedhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.6/LayoutTests/fast/css/fontloader-tab-index-expected.html (0 => 174954)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/LayoutTests/fast/css/fontloader-tab-index-expected.html (rev 0)
+++ releases/WebKitGTK/webkit-2.6/LayoutTests/fast/css/fontloader-tab-index-expected.html 2014-10-21 13:33:06 UTC (rev 174954)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+<!doctype html>
+<html>
+<head>
+<style>
+@font-face {
+ font-family: 'times';
+ src: local('Lucida Grande');
+}
+body {
+ margin: 1ex;
+}
+</style>
+</head>
+<body>
+Fetching tabIndex should not cause a crash when involving font-relative units on the body element of the document.
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit26LayoutTestsfastcssfontloadertabindexhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.6/LayoutTests/fast/css/fontloader-tab-index.html (0 => 174954)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/LayoutTests/fast/css/fontloader-tab-index.html (rev 0)
+++ releases/WebKitGTK/webkit-2.6/LayoutTests/fast/css/fontloader-tab-index.html 2014-10-21 13:33:06 UTC (rev 174954)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+<!doctype html>
+<html>
+<head>
+<style>
+@font-face {
+ font-family: 'times';
+ src: local('Lucida Grande');
+}
+body {
+ margin: 1ex;
+}
+</style>
+</head>
+<body>
+<script>
+var idx = document.querySelector("body").tabIndex;
+</script>
+Fetching tabIndex should not cause a crash when involving font-relative units on the body element of the document.
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit26SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog (174953 => 174954)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog 2014-10-21 13:23:38 UTC (rev 174953)
+++ releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog 2014-10-21 13:33:06 UTC (rev 174954)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2014-10-03 Bear Travis <betravis@adobe.com>
+
+ REGRESSION (r173531): Use after free in WebCore::RenderStyle::fontMetrics /
+ WebCore::CSSPrimitiveValue::computeLengthDouble
+ https://bugs.webkit.org/show_bug.cgi?id=136864
+
+ Reviewed by Andreas Kling.
+
+ FontLoader previously called updateDocumentStyleIfNeeded,
+ which would reset styles currently in use as part of
+ the tabIndex calculation. The FontLoader should instead
+ wait for pending stylesheets to load.
+
+ Tests: fast/css/fontloader-tab-index.html
+
+ * css/FontLoader.cpp:
+ (WebCore::FontLoader::notifyWhenFontsReady): Do not immediately
+ call loadingDone().
+ (WebCore::FontLoader::loadingDone): Wait for stylesheets to
+ finish loading rather than updating document styles.
+ * css/FontLoader.h:
+ (WebCore::FontLoader::loading): Include JS font loads when testing
+ for the loading state.
+
</ins><span class="cx"> 2014-10-02 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> XMLHttpRequestProgressEventThrottle shouldn't throttle / defer progress events if there are no listeners
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26SourceWebCorecssFontLoadercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/css/FontLoader.cpp (174953 => 174954)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/Source/WebCore/css/FontLoader.cpp 2014-10-21 13:23:38 UTC (rev 174953)
+++ releases/WebKitGTK/webkit-2.6/Source/WebCore/css/FontLoader.cpp 2014-10-21 13:33:06 UTC (rev 174954)
</span><span class="lines">@@ -211,12 +211,11 @@
</span><span class="cx"> void FontLoader::notifyWhenFontsReady(PassRefPtr<VoidCallback> callback)
</span><span class="cx"> {
</span><span class="cx"> m_callbacks.append(callback);
</span><del>- loadingDone();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void FontLoader::loadingDone()
</span><span class="cx"> {
</span><del>- if (loading())
</del><ins>+ if (loading() || !m_document->haveStylesheetsLoaded())
</ins><span class="cx"> return;
</span><span class="cx"> if (!m_loadingDoneEvent && m_callbacks.isEmpty())
</span><span class="cx"> return;
</span><span class="lines">@@ -224,9 +223,6 @@
</span><span class="cx"> if (FrameView* view = m_document->view()) {
</span><span class="cx"> if (view->isInLayout() || view->needsLayout())
</span><span class="cx"> return;
</span><del>- m_document->updateStyleIfNeeded();
- if (view->needsLayout())
- return;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (m_loadingDoneEvent)
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit26SourceWebCorecssFontLoaderh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/css/FontLoader.h (174953 => 174954)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.6/Source/WebCore/css/FontLoader.h 2014-10-21 13:23:38 UTC (rev 174953)
+++ releases/WebKitGTK/webkit-2.6/Source/WebCore/css/FontLoader.h 2014-10-21 13:33:06 UTC (rev 174954)
</span><span class="lines">@@ -68,7 +68,7 @@
</span><span class="cx">
</span><span class="cx"> void notifyWhenFontsReady(PassRefPtr<VoidCallback>);
</span><span class="cx">
</span><del>- bool loading() const { return m_numLoadingFromCSS > 0; }
</del><ins>+ bool loading() const { return m_numLoadingFromCSS > 0 || m_numLoadingFromJS > 0; }
</ins><span class="cx">
</span><span class="cx"> virtual ScriptExecutionContext* scriptExecutionContext() const;
</span><span class="cx"> virtual EventTargetInterface eventTargetInterface() const;
</span></span></pre>
</div>
</div>
</body>
</html>