<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[174897] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/174897">174897</a></dd>
<dt>Author</dt> <dd>mark.lam@apple.com</dd>
<dt>Date</dt> <dd>2014-10-20 11:52:37 -0700 (Mon, 20 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Factor out JITCode::typeName() for debugging use.
<https://webkit.org/b/137888>
Reviewed by Geoffrey Garen.
JITCode's printInternal() currently decodes the JITType into a string and
prints it. This change factors out the part that decodes the JITType into
JITCode::typeName() so that we can call it from lldb while debugging to
quickly decode a JITType value.
* jit/JITCode.cpp:
(JSC::JITCode::typeName):
(WTF::printInternal):
* jit/JITCode.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITCodecpp">trunk/Source/JavaScriptCore/jit/JITCode.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITCodeh">trunk/Source/JavaScriptCore/jit/JITCode.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (174896 => 174897)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-10-20 18:41:42 UTC (rev 174896)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-10-20 18:52:37 UTC (rev 174897)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-10-20 Mark Lam <mark.lam@apple.com>
+
+ Factor out JITCode::typeName() for debugging use.
+ <https://webkit.org/b/137888>
+
+ Reviewed by Geoffrey Garen.
+
+ JITCode's printInternal() currently decodes the JITType into a string and
+ prints it. This change factors out the part that decodes the JITType into
+ JITCode::typeName() so that we can call it from lldb while debugging to
+ quickly decode a JITType value.
+
+ * jit/JITCode.cpp:
+ (JSC::JITCode::typeName):
+ (WTF::printInternal):
+ * jit/JITCode.h:
+
</ins><span class="cx"> 2014-10-20 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed Windows Build Fix #2 after r174892.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITCodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JITCode.cpp (174896 => 174897)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JITCode.cpp 2014-10-20 18:41:42 UTC (rev 174896)
+++ trunk/Source/JavaScriptCore/jit/JITCode.cpp 2014-10-20 18:52:37 UTC (rev 174897)
</span><span class="lines">@@ -43,6 +43,27 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+const char* JITCode::typeName(JITType jitType)
+{
+ switch (jitType) {
+ case None:
+ return "None";
+ case HostCallThunk:
+ return "Host";
+ case InterpreterThunk:
+ return "LLInt";
+ case BaselineJIT:
+ return "Baseline";
+ case DFGJIT:
+ return "DFG";
+ case FTLJIT:
+ return "FTL";
+ default:
+ CRASH();
+ return "";
+ }
+}
+
</ins><span class="cx"> JSValue JITCode::execute(VM* vm, ProtoCallFrame* protoCallFrame)
</span><span class="cx"> {
</span><span class="cx"> void* entryAddress;
</span><span class="lines">@@ -233,29 +254,7 @@
</span><span class="cx">
</span><span class="cx"> void printInternal(PrintStream& out, JSC::JITCode::JITType type)
</span><span class="cx"> {
</span><del>- switch (type) {
- case JSC::JITCode::None:
- out.print("None");
- return;
- case JSC::JITCode::HostCallThunk:
- out.print("Host");
- return;
- case JSC::JITCode::InterpreterThunk:
- out.print("LLInt");
- return;
- case JSC::JITCode::BaselineJIT:
- out.print("Baseline");
- return;
- case JSC::JITCode::DFGJIT:
- out.print("DFG");
- return;
- case JSC::JITCode::FTLJIT:
- out.print("FTL");
- return;
- default:
- CRASH();
- return;
- }
</del><ins>+ out.print("%s", JSC::JITCode::typeName(type));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WTF
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITCodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JITCode.h (174896 => 174897)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JITCode.h 2014-10-20 18:41:42 UTC (rev 174896)
+++ trunk/Source/JavaScriptCore/jit/JITCode.h 2014-10-20 18:52:37 UTC (rev 174897)
</span><span class="lines">@@ -62,6 +62,8 @@
</span><span class="cx"> FTLJIT
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+ static const char* typeName(JITType);
+
</ins><span class="cx"> static JITType bottomTierJIT()
</span><span class="cx"> {
</span><span class="cx"> return BaselineJIT;
</span></span></pre>
</div>
</div>
</body>
</html>