<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[174864] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/174864">174864</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2014-10-18 12:04:31 -0700 (Sat, 18 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>WorkQueue dispatches functions but isn’t a FunctionDispatcher
https://bugs.webkit.org/show_bug.cgi?id=137853
Reviewed by Anders Carlsson.
Source/WebKit2:
* Platform/WorkQueue.h: Changed to inherit from FunctionDispatcher.
Source/WTF:
* wtf/FunctionDispatcher.h: Added header guards.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfFunctionDispatcherh">trunk/Source/WTF/wtf/FunctionDispatcher.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2PlatformWorkQueueh">trunk/Source/WebKit2/Platform/WorkQueue.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (174863 => 174864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2014-10-18 18:13:05 UTC (rev 174863)
+++ trunk/Source/WTF/ChangeLog 2014-10-18 19:04:31 UTC (rev 174864)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2014-10-18 Dan Bernstein <mitz@apple.com>
+
+ WorkQueue dispatches functions but isn’t a FunctionDispatcher
+ https://bugs.webkit.org/show_bug.cgi?id=137853
+
+ Reviewed by Anders Carlsson.
+
+ * wtf/FunctionDispatcher.h: Added header guards.
+
</ins><span class="cx"> 2014-10-17 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GLIB] Add API to GMainLoopSource to schedule sources after a delay in microseconds
</span></span></pre></div>
<a id="trunkSourceWTFwtfFunctionDispatcherh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/FunctionDispatcher.h (174863 => 174864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/FunctionDispatcher.h 2014-10-18 18:13:05 UTC (rev 174863)
+++ trunk/Source/WTF/wtf/FunctionDispatcher.h 2014-10-18 19:04:31 UTC (rev 174864)
</span><span class="lines">@@ -23,6 +23,9 @@
</span><span class="cx"> * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><ins>+#ifndef FunctionDispatcher_h
+#define FunctionDispatcher_h
+
</ins><span class="cx"> #include <functional>
</span><span class="cx"> #include <wtf/ThreadSafeRefCounted.h>
</span><span class="cx">
</span><span class="lines">@@ -44,3 +47,5 @@
</span><span class="cx"> } // namespace WTF
</span><span class="cx">
</span><span class="cx"> using WTF::FunctionDispatcher;
</span><ins>+
+#endif // FunctionDispatcher_h
</ins></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (174863 => 174864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-10-18 18:13:05 UTC (rev 174863)
+++ trunk/Source/WebKit2/ChangeLog 2014-10-18 19:04:31 UTC (rev 174864)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2014-10-18 Dan Bernstein <mitz@apple.com>
+
+ WorkQueue dispatches functions but isn’t a FunctionDispatcher
+ https://bugs.webkit.org/show_bug.cgi?id=137853
+
+ Reviewed by Anders Carlsson.
+
+ * Platform/WorkQueue.h: Changed to inherit from FunctionDispatcher.
+
</ins><span class="cx"> 2014-10-18 Michael Catanzaro <mcatanzaro@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Improve documentation of webkit_web_view_get_tls_info()
</span></span></pre></div>
<a id="trunkSourceWebKit2PlatformWorkQueueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Platform/WorkQueue.h (174863 => 174864)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Platform/WorkQueue.h 2014-10-18 18:13:05 UTC (rev 174863)
+++ trunk/Source/WebKit2/Platform/WorkQueue.h 2014-10-18 19:04:31 UTC (rev 174864)
</span><span class="lines">@@ -34,6 +34,7 @@
</span><span class="cx"> #include <chrono>
</span><span class="cx"> #include <functional>
</span><span class="cx"> #include <wtf/Forward.h>
</span><ins>+#include <wtf/FunctionDispatcher.h>
</ins><span class="cx"> #include <wtf/Functional.h>
</span><span class="cx"> #include <wtf/HashMap.h>
</span><span class="cx"> #include <wtf/RefCounted.h>
</span><span class="lines">@@ -51,7 +52,7 @@
</span><span class="cx"> #include <DispatchQueueEfl.h>
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-class WorkQueue : public ThreadSafeRefCounted<WorkQueue> {
</del><ins>+class WorkQueue final : public FunctionDispatcher {
</ins><span class="cx"> public:
</span><span class="cx"> enum class QOS {
</span><span class="cx"> UserInteractive,
</span><span class="lines">@@ -62,9 +63,9 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> static PassRefPtr<WorkQueue> create(const char* name, QOS = QOS::Default);
</span><del>- ~WorkQueue();
</del><ins>+ virtual ~WorkQueue();
</ins><span class="cx">
</span><del>- void dispatch(std::function<void ()>);
</del><ins>+ virtual void dispatch(std::function<void ()>) override;
</ins><span class="cx"> void dispatchAfter(std::chrono::nanoseconds, std::function<void ()>);
</span><span class="cx">
</span><span class="cx"> #if OS(DARWIN)
</span></span></pre>
</div>
</div>
</body>
</html>