<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[174772] trunk/Websites/bugs.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/174772">174772</a></dd>
<dt>Author</dt> <dd>ddkilzer@apple.com</dd>
<dt>Date</dt> <dd>2014-10-16 09:01:19 -0700 (Thu, 16 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Display legal text when uploading a patch with a new bug
* js/attachment.js:
(setContentTypeDisabledState): Make this work on the Enter Bug
page so that the "Submit Bug" button changes to
"Agree and Submit Bug" when the "patch" checkbox is checked, and
it changes back to "Submit Bug" when unchecked.
* template/en/custom/attachment/createformcontents.html.tmpl:
Include the attachment/patchlegalese.html.tmpl template when
returning the page so that it will be shown when the "patch"
checkbox is checked. Set the 'product' variable from the CGI
variable of the same name.
* template/en/custom/attachment/patchlegalese.html.tmpl: Add the
'expert_fields' class to the <tr> element so that it gets
shown/hidden when the Show/Hide Advanced Fields links are
clicked.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesbugswebkitorgjsattachmentjs">trunk/Websites/bugs.webkit.org/js/attachment.js</a></li>
<li><a href="#trunkWebsitesbugswebkitorgtemplateencustomattachmentcreateformcontentshtmltmpl">trunk/Websites/bugs.webkit.org/template/en/custom/attachment/createformcontents.html.tmpl</a></li>
<li><a href="#trunkWebsitesbugswebkitorgtemplateencustomattachmentpatchlegalesehtmltmpl">trunk/Websites/bugs.webkit.org/template/en/custom/attachment/patchlegalese.html.tmpl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesbugswebkitorgjsattachmentjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/bugs.webkit.org/js/attachment.js (174771 => 174772)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/bugs.webkit.org/js/attachment.js 2014-10-16 16:01:18 UTC (rev 174771)
+++ trunk/Websites/bugs.webkit.org/js/attachment.js 2014-10-16 16:01:19 UTC (rev 174772)
</span><span class="lines">@@ -55,9 +55,23 @@
</span><span class="cx"> // if WEBKIT_CHANGES
</span><span class="cx"> if (isdisabled) {
</span><span class="cx"> document.getElementById('legal').style.display = "table-row";
</span><del>- document.getElementById('create').value = "Agree and Submit";
</del><ins>+ var createButton = document.getElementById('create');
+ if (createButton && createButton.value == "Submit")
+ createButton.value = "Agree and Submit";
+ else {
+ var commitButton = document.getElementById('commit');
+ if (commitButton && commitButton.value == "Submit Bug")
+ commitButton.value = "Agree and Submit Bug";
+ }
</ins><span class="cx"> } else {
</span><del>- document.getElementById('create').value = "Submit";
</del><ins>+ var createButton = document.getElementById('create');
+ if (createButton && createButton.value == "Agree and Submit")
+ createButton.value = "Submit";
+ else {
+ var commitButton = document.getElementById('commit');
+ if (commitButton && commitButton.value == "Agree and Submit Bug")
+ commitButton.value = "Submit Bug";
+ }
</ins><span class="cx"> document.getElementById('legal').style.display = "none";
</span><span class="cx"> }
</span><span class="cx"> // endif WEBKIT_CHANGES
</span></span></pre></div>
<a id="trunkWebsitesbugswebkitorgtemplateencustomattachmentcreateformcontentshtmltmpl"></a>
<div class="modfile"><h4>Modified: trunk/Websites/bugs.webkit.org/template/en/custom/attachment/createformcontents.html.tmpl (174771 => 174772)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/bugs.webkit.org/template/en/custom/attachment/createformcontents.html.tmpl 2014-10-16 16:01:18 UTC (rev 174771)
+++ trunk/Websites/bugs.webkit.org/template/en/custom/attachment/createformcontents.html.tmpl 2014-10-16 16:01:19 UTC (rev 174772)
</span><span class="lines">@@ -91,6 +91,11 @@
</span><span class="cx"> [% END %]
</span><span class="cx"> </td>
</span><span class="cx"> </tr>
</span><ins>+[%# if WEBKIT_CHANGES %]
+[% USE CGI %]
+[% cgi_product = CGI.param('product') %]
+[% PROCESS attachment/patchlegalese.html.tmpl product = cgi_product %]
+[%# endif // WEBKIT_CHANGES %]
</ins><span class="cx">
</span><span class="cx"> [% BLOCK content_types %]
</span><span class="cx"> [%# WEBKIT_CHANGES: Added XHTML source and SVG image. %]
</span></span></pre></div>
<a id="trunkWebsitesbugswebkitorgtemplateencustomattachmentpatchlegalesehtmltmpl"></a>
<div class="modfile"><h4>Modified: trunk/Websites/bugs.webkit.org/template/en/custom/attachment/patchlegalese.html.tmpl (174771 => 174772)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/bugs.webkit.org/template/en/custom/attachment/patchlegalese.html.tmpl 2014-10-16 16:01:18 UTC (rev 174771)
+++ trunk/Websites/bugs.webkit.org/template/en/custom/attachment/patchlegalese.html.tmpl 2014-10-16 16:01:19 UTC (rev 174772)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx">
</span><span class="cx"> [%# if WEBKIT_CHANGES %]
</span><span class="cx"> [% IF (product == "WebKit" || product == "Security") %]
</span><del>- <tr id="legal" style="display: none;">
</del><ins>+ <tr id="legal" class="expert_fields" style="display: none;">
</ins><span class="cx"> <th>Legal:</th>
</span><span class="cx"> <td>
</span><span class="cx"> <b>WebKit Contribution Terms:</b><br/>
</span></span></pre>
</div>
</div>
</body>
</html>