<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[174776] trunk/Websites/bugs.webkit.org/js/field.js</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/174776">174776</a></dd>
<dt>Author</dt> <dd>ddkilzer@apple.com</dd>
<dt>Date</dt> <dd>2014-10-16 09:01:23 -0700 (Thu, 16 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Re-fix Bug 26950: Make the summary and alias fields support click-to-edit <https://bugs.webkit.org/show_bug.cgi?id=26950>
* js/field.js: Port the changes from <a href="http://trac.webkit.org/projects/webkit/changeset/45538">r45538</a> to Bugzilla 4.2.5.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesbugswebkitorgjsfieldjs">trunk/Websites/bugs.webkit.org/js/field.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesbugswebkitorgjsfieldjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/bugs.webkit.org/js/field.js (174775 => 174776)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/bugs.webkit.org/js/field.js 2014-10-16 16:01:23 UTC (rev 174775)
+++ trunk/Websites/bugs.webkit.org/js/field.js 2014-10-16 16:01:23 UTC (rev 174776)
</span><span class="lines">@@ -219,15 +219,24 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /* Hide input/select fields and show the text with (edit) next to it */
</span><del>-function hideEditableField( container, input, action, field_id, original_value, new_value ) {
</del><ins>+function hideEditableField( container, input, action, field_array, original_value, new_value ) {
+ var field_id = field_array instanceof Array ? field_array.shift() : field_array;
</ins><span class="cx"> YAHOO.util.Dom.removeClass(container, 'bz_default_hidden');
</span><span class="cx"> YAHOO.util.Dom.addClass(input, 'bz_default_hidden');
</span><span class="cx"> YAHOO.util.Event.addListener(action, 'click', showEditableField,
</span><span class="cx"> new Array(container, input, field_id, new_value));
</span><span class="cx"> if(field_id != ""){
</span><ins>+ YAHOO.util.Event.addListener(field_id + '_nonedit_display', 'click', showEditableField,
+ new Array(container, input, undefined, undefined, field_id));
</ins><span class="cx"> YAHOO.util.Event.addListener(window, 'load', checkForChangedFieldValues,
</span><span class="cx"> new Array(container, input, field_id, original_value));
</span><span class="cx"> }
</span><ins>+ for (var field2_id in field_array){
+ if(field2_id != ""){
+ YAHOO.util.Event.addListener(field2_id + '_nonedit_display', 'click', showEditableField,
+ new Array(container, input, undefined, undefined, field2_id));
+ }
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /* showEditableField (e, ContainerInputArray)
</span><span class="lines">@@ -239,6 +248,7 @@
</span><span class="cx"> * var ContainerInputArray[1]: the input area and label that will be displayed
</span><span class="cx"> * var ContainerInputArray[2]: the input/select field id for which the new value must be set
</span><span class="cx"> * var ContainerInputArray[3]: the new value to set the input/select field to when (take) is clicked
</span><ins>+ * var ContainerInputArray[4]: [optional] the id of the input element to focus
</ins><span class="cx"> */
</span><span class="cx"> function showEditableField (e, ContainerInputArray) {
</span><span class="cx"> var inputs = new Array();
</span><span class="lines">@@ -272,10 +282,19 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>- // focus on the first field, this makes it easier to edit
- inputs[0].focus();
- if ( type == "input" ) {
- inputs[0].select();
</del><ins>+ var elementToFocus = YAHOO.util.Dom.get(ContainerInputArray[4]);
+ if (elementToFocus) {
+ // focus on the requested field
+ elementToFocus.focus();
+ if ( elementToFocus.tagName.toLowerCase() == "input" ) {
+ elementToFocus.select();
+ }
+ } else {
+ // focus on the first field, this makes it easier to edit
+ inputs[0].focus();
+ if ( type == "input" ) {
+ inputs[0].select();
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> YAHOO.util.Event.preventDefault(e);
</span><span class="lines">@@ -322,7 +341,7 @@
</span><span class="cx"> function hideAliasAndSummary(short_desc_value, alias_value) {
</span><span class="cx"> // check the short desc field
</span><span class="cx"> hideEditableField( 'summary_alias_container','summary_alias_input',
</span><del>- 'editme_action','short_desc', short_desc_value);
</del><ins>+ 'editme_action', new Array('short_desc', 'alias'), short_desc_value);
</ins><span class="cx"> // check that the alias hasn't changed
</span><span class="cx"> var bz_alias_check_array = new Array('summary_alias_container',
</span><span class="cx"> 'summary_alias_input', 'alias', alias_value);
</span></span></pre>
</div>
</div>
</body>
</html>