<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[174679] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/174679">174679</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-10-14 03:49:09 -0700 (Tue, 14 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Minibrowser : Add home buton and keyboard support for home page load
https://bugs.webkit.org/show_bug.cgi?id=137486
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-10-14
Reviewed by Philippe Normand.
* MiniBrowser/gtk/BrowserWindow.c:
(loadHomePage): Callback for home page load.
(browser_window_init):
* MiniBrowser/gtk/BrowserWindow.h:
* MiniBrowser/gtk/main.c:
(main):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsMiniBrowsergtkBrowserWindowc">trunk/Tools/MiniBrowser/gtk/BrowserWindow.c</a></li>
<li><a href="#trunkToolsMiniBrowsergtkBrowserWindowh">trunk/Tools/MiniBrowser/gtk/BrowserWindow.h</a></li>
<li><a href="#trunkToolsMiniBrowsergtkmainc">trunk/Tools/MiniBrowser/gtk/main.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (174678 => 174679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-10-14 10:05:03 UTC (rev 174678)
+++ trunk/Tools/ChangeLog 2014-10-14 10:49:09 UTC (rev 174679)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-10-14 Rohit Kumar <kumar.rohit@samsung.com>
+
+ [GTK] Minibrowser : Add home buton and keyboard support for home page load
+ https://bugs.webkit.org/show_bug.cgi?id=137486
+
+ Reviewed by Philippe Normand.
+
+ * MiniBrowser/gtk/BrowserWindow.c:
+ (loadHomePage): Callback for home page load.
+ (browser_window_init):
+ * MiniBrowser/gtk/BrowserWindow.h:
+ * MiniBrowser/gtk/main.c:
+ (main):
+
</ins><span class="cx"> 2014-10-14 Manuel Rego Casasnovas <rego@igalia.com>
</span><span class="cx">
</span><span class="cx"> import-w3c-tests doesn't prefix property values
</span></span></pre></div>
<a id="trunkToolsMiniBrowsergtkBrowserWindowc"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (174678 => 174679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c 2014-10-14 10:05:03 UTC (rev 174678)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c 2014-10-14 10:49:09 UTC (rev 174679)
</span><span class="lines">@@ -546,6 +546,11 @@
</span><span class="cx"> webkit_web_view_stop_loading(window->webView);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+static void loadHomePage(BrowserWindow *window, gpointer user_data)
+{
+ webkit_web_view_load_uri(window->webView, BROWSER_DEFAULT_URL);
+}
+
</ins><span class="cx"> static void browserWindowFinalize(GObject *gObject)
</span><span class="cx"> {
</span><span class="cx"> BrowserWindow *window = BROWSER_WINDOW(gObject);
</span><span class="lines">@@ -637,6 +642,10 @@
</span><span class="cx"> gtk_accel_group_connect(window->accelGroup, GDK_KEY_Escape, 0, GTK_ACCEL_VISIBLE,
</span><span class="cx"> g_cclosure_new_swap(G_CALLBACK(stopPageLoad), window, NULL));
</span><span class="cx">
</span><ins>+ /* Load home page */
+ gtk_accel_group_connect(window->accelGroup, GDK_KEY_Home, GDK_MOD1_MASK, GTK_ACCEL_VISIBLE,
+ g_cclosure_new_swap(G_CALLBACK(loadHomePage), window, NULL));
+
</ins><span class="cx"> GtkWidget *toolbar = gtk_toolbar_new();
</span><span class="cx"> window->toolbar = toolbar;
</span><span class="cx"> gtk_orientable_set_orientation(GTK_ORIENTABLE(toolbar), GTK_ORIENTATION_HORIZONTAL);
</span><span class="lines">@@ -679,6 +688,12 @@
</span><span class="cx"> gtk_widget_add_accelerator(GTK_WIDGET(item), "clicked", window->accelGroup, GDK_KEY_F, GDK_CONTROL_MASK, GTK_ACCEL_VISIBLE);
</span><span class="cx"> gtk_widget_show(GTK_WIDGET(item));
</span><span class="cx">
</span><ins>+ item = gtk_tool_button_new_from_stock(GTK_STOCK_HOME);
+ g_signal_connect_swapped(item, "clicked", G_CALLBACK(loadHomePage), window);
+ gtk_toolbar_insert(GTK_TOOLBAR(toolbar), item, -1);
+ gtk_widget_add_accelerator(GTK_WIDGET(item), "clicked", window->accelGroup, GDK_KEY_Home, GDK_MOD1_MASK, GTK_ACCEL_VISIBLE);
+ gtk_widget_show(GTK_WIDGET(item));
+
</ins><span class="cx"> item = gtk_tool_item_new();
</span><span class="cx"> gtk_tool_item_set_expand(item, TRUE);
</span><span class="cx"> gtk_container_add(GTK_CONTAINER(item), window->uriEntry);
</span></span></pre></div>
<a id="trunkToolsMiniBrowsergtkBrowserWindowh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.h (174678 => 174679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.h 2014-10-14 10:05:03 UTC (rev 174678)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.h 2014-10-14 10:49:09 UTC (rev 174679)
</span><span class="lines">@@ -37,6 +37,7 @@
</span><span class="cx"> #define BROWSER_IS_WINDOW(obj) (G_TYPE_CHECK_INSTANCE_TYPE((obj), BROWSER_TYPE_WINDOW))
</span><span class="cx"> #define BROWSER_IS_WINDOW_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE((klass), BROWSER_TYPE_WINDOW))
</span><span class="cx"> #define BROWSER_WINDOW_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS((obj), BROWSER_TYPE_WINDOW, BrowserWindowClass))
</span><ins>+#define BROWSER_DEFAULT_URL "http://www.webkitgtk.org/"
</ins><span class="cx">
</span><span class="cx"> typedef struct _BrowserWindow BrowserWindow;
</span><span class="cx"> typedef struct _BrowserWindowClass BrowserWindowClass;
</span></span></pre></div>
<a id="trunkToolsMiniBrowsergtkmainc"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/gtk/main.c (174678 => 174679)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/gtk/main.c 2014-10-14 10:05:03 UTC (rev 174678)
+++ trunk/Tools/MiniBrowser/gtk/main.c 2014-10-14 10:49:09 UTC (rev 174679)
</span><span class="lines">@@ -279,7 +279,7 @@
</span><span class="cx"> for (i = 0; uriArguments[i]; i++)
</span><span class="cx"> createBrowserWindow(uriArguments[i], webkitSettings);
</span><span class="cx"> } else
</span><del>- createBrowserWindow("http://www.webkitgtk.org/", webkitSettings);
</del><ins>+ createBrowserWindow(BROWSER_DEFAULT_URL, webkitSettings);
</ins><span class="cx">
</span><span class="cx"> g_clear_object(&webkitSettings);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>