<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[174655] trunk/Tools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/174655">174655</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2014-10-13 11:46:30 -0700 (Mon, 13 Oct 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Add more detailed wait time information to EWS metrics
https://bugs.webkit.org/show_bug.cgi?id=137649

Reviewed by Daniel Bates.

Added average and worst time (we used to only have median), and also a percentage
of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.

There is always some wait due to the polling nature of the queues, which is well understood
and doesn't need to be measured. What needs to be measured is whether there is enough
bot machines to process patches as soon as they are submitted.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
(Analyzer.prototype._analyzeBubblePerformance):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
(MetricsBubbleView.prototype._update):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMetricsAnalyzerjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMetricsBubbleViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMetricsAnalyzerjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js (174654 => 174655)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js        2014-10-13 18:28:25 UTC (rev 174654)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js        2014-10-13 18:46:30 UTC (rev 174655)
</span><span class="lines">@@ -393,6 +393,7 @@
</span><span class="cx">         }
</span><span class="cx"> 
</span><span class="cx">         var waitTimes = [];
</span><ins>+        var patchesThatWaitedMoreThan3Minutes = [];
</ins><span class="cx">         var totalTimes = [];
</span><span class="cx">         var totalTimesForPatchesThatWereNotRetried = [];
</span><span class="cx">         var totalTimesForPatchesThatSpinnedAndPassedOrFailed = [];
</span><span class="lines">@@ -408,6 +409,9 @@
</span><span class="cx">             // Wait time is equally interesting for all patches.
</span><span class="cx">             waitTimes.push(patch.wait_duration);
</span><span class="cx"> 
</span><ins>+            if (patch.wait_duration &gt; 3 * 60)
+                patchesThatWaitedMoreThan3Minutes.push(patchID);
+
</ins><span class="cx">             if (patch.resolution === &quot;not processed&quot;)
</span><span class="cx">                 patchesThatDidNotComplete.push(patchID);
</span><span class="cx"> 
</span><span class="lines">@@ -449,6 +453,8 @@
</span><span class="cx">             averageTotalTimeForPatchesThatSpinnedAndPassedOrFailedInSeconds: totalTimesForPatchesThatSpinnedAndPassedOrFailed.average(),
</span><span class="cx">             medianWaitTimeInSeconds: waitTimes.median(),
</span><span class="cx">             averageWaitTimeInSeconds: waitTimes.average(),
</span><ins>+            maximumWaitTimeInSeconds: Math.max.apply(Math, waitTimes),
+            patchesThatWaitedMoreThan3MinutesCount: patchesThatWaitedMoreThan3Minutes.length,
</ins><span class="cx">             patchesThatCausedInternalError: patchesThatCausedInternalError,
</span><span class="cx">         };
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMetricsBubbleViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js (174654 => 174655)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js        2014-10-13 18:28:25 UTC (rev 174654)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js        2014-10-13 18:46:30 UTC (rev 174655)
</span><span class="lines">@@ -162,7 +162,12 @@
</span><span class="cx">         }
</span><span class="cx"> 
</span><span class="cx">         addDivider(this.element);
</span><del>-        addLine(this.element, &quot;Median wait time before processing started: &quot; + pluralizeMinutes(this._results.medianWaitTimeInSeconds) + &quot;.&quot;);
</del><ins>+        addLine(this.element, &quot;Wait time before processing started:&quot;);
+        addLine(this.element, &quot;- median: &quot; + pluralizeMinutes(this._results.medianWaitTimeInSeconds) + &quot;;&quot;);
+        addLine(this.element, &quot;- average: &quot; + pluralizeMinutes(this._results.averageWaitTimeInSeconds) + &quot;.&quot;);
+        addLine(this.element, &quot;- worst: &quot; + pluralizeMinutes(this._results.maximumWaitTimeInSeconds) + &quot;.&quot;);
+        if (this._results.medianWaitTimeInSeconds &lt; 3 * 60 &amp;&amp; this._results.patchesThatWaitedMoreThan3MinutesCount)
+            addLine(this.element, formatPercentage(this._results.patchesThatWaitedMoreThan3MinutesCount / this._results.totalPatches) + &quot; of patches had a wait time of more than 3 minutes.&quot;);
</ins><span class="cx"> 
</span><span class="cx">         if (this._results.patchesThatCausedInternalError.length) {
</span><span class="cx">             addDivider(this.element);
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (174654 => 174655)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog        2014-10-13 18:28:25 UTC (rev 174654)
+++ trunk/Tools/ChangeLog        2014-10-13 18:46:30 UTC (rev 174655)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-10-13  Alexey Proskuryakov  &lt;ap@apple.com&gt;
+
+        Add more detailed wait time information to EWS metrics
+        https://bugs.webkit.org/show_bug.cgi?id=137649
+
+        Reviewed by Daniel Bates.
+
+        Added average and worst time (we used to only have median), and also a percentage
+        of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
+
+        There is always some wait due to the polling nature of the queues, which is well understood
+        and doesn't need to be measured. What needs to be measured is whether there is enough
+        bot machines to process patches as soon as they are submitted.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
+        (Analyzer.prototype._analyzeBubblePerformance):
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
+        (MetricsBubbleView.prototype._update):
+
</ins><span class="cx"> 2014-10-11  Jer Noble  &lt;jer.noble@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
</span></span></pre>
</div>
</div>

</body>
</html>