<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[174633] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/174633">174633</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-10-11 09:22:32 -0700 (Sat, 11 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL] Enable WebP support.
https://bugs.webkit.org/show_bug.cgi?id=136156
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2014-10-11
Reviewed by Gyuyoung Kim.
.:
Add WebP package finding rule.
* Source/cmake/OptionsEfl.cmake:
Source/WebCore:
Add WebP library and inlcude path to WebCore path for WK2 Efl.
No new tests since existing feature is just enabled for WK2 Efl.
* PlatformEfl.cmake:
Source/WTF:
Enable WTF_USE_WEBP macro for WK2 Efl.
* wtf/Platform.h:
Tools:
Include libwebp-dev package to support WebP for WK2 Efl.
* efl/install-dependencies:
LayoutTests:
Clarify skipped webp test for Webkit EFL.
* platform/efl/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformeflTestExpectations">trunk/LayoutTests/platform/efl/TestExpectations</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfPlatformh">trunk/Source/WTF/wtf/Platform.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorePlatformEflcmake">trunk/Source/WebCore/PlatformEfl.cmake</a></li>
<li><a href="#trunkSourcecmakeOptionsEflcmake">trunk/Source/cmake/OptionsEfl.cmake</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolseflinstalldependencies">trunk/Tools/efl/install-dependencies</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (174632 => 174633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2014-10-11 07:08:59 UTC (rev 174632)
+++ trunk/ChangeLog 2014-10-11 16:22:32 UTC (rev 174633)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-10-11 KwangHyuk Kim <hyuki.kim@samsung.com>
+
+ [EFL] Enable WebP support.
+ https://bugs.webkit.org/show_bug.cgi?id=136156
+
+ Reviewed by Gyuyoung Kim.
+
+ Add WebP package finding rule.
+
+ * Source/cmake/OptionsEfl.cmake:
+
</ins><span class="cx"> 2014-10-07 Pascal Jacquemart <p.jacquemart@samsung.com>
</span><span class="cx">
</span><span class="cx"> [EFL] Enable custom URI schemes with CustomProtocols
</span></span></pre></div>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (174632 => 174633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-10-11 07:08:59 UTC (rev 174632)
+++ trunk/LayoutTests/ChangeLog 2014-10-11 16:22:32 UTC (rev 174633)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-10-11 KwangHyuk Kim <hyuki.kim@samsung.com>
+
+ [EFL] Enable WebP support.
+ https://bugs.webkit.org/show_bug.cgi?id=136156
+
+ Reviewed by Gyuyoung Kim.
+
+ Clarify skipped webp test for Webkit EFL.
+
+ * platform/efl/TestExpectations:
+
</ins><span class="cx"> 2014-10-10 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Make these animation tests not timeout if hit testing fails.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/TestExpectations (174632 => 174633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/TestExpectations 2014-10-11 07:08:59 UTC (rev 174632)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2014-10-11 16:22:32 UTC (rev 174633)
</span><span class="lines">@@ -1101,13 +1101,13 @@
</span><span class="cx"> webkit.org/b/84777 ietestcenter/css3/multicolumn/column-width-applies-to-015.htm [ ImageOnlyFailure ]
</span><span class="cx">
</span><span class="cx"> # Requires WebP support.
</span><del>-Bug(EFL) fast/canvas/canvas-toDataURL-webp.html
-Bug(EFL) fast/images/webp-image-decoding.html
-Bug(EFL) fast/images/webp-color-profile-lossless.html
-Bug(EFL) fast/images/webp-color-profile-lossy-alpha.html
-Bug(EFL) fast/images/webp-color-profile-lossy.html
-Bug(EFL) http/tests/images/webp-partial-load.html
-Bug(EFL) http/tests/images/webp-progressive-load.html
</del><ins>+Bug(EFL) fast/canvas/canvas-toDataURL-webp.html [ Skip ]
+# Requires WebP 0.2 support.
+Bug(EFL) fast/images/webp-image-decoding.html [ Skip ]
+# Requires WebP 0.3 and color profile support.
+Bug(EFL) fast/images/webp-color-profile-lossless.html [ Skip ]
+Bug(EFL) fast/images/webp-color-profile-lossy-alpha.html [ Skip ]
+Bug(EFL) fast/images/webp-color-profile-lossy.html [ Skip ]
</ins><span class="cx">
</span><span class="cx"> # Requires MEDIA_SOURCE support.
</span><span class="cx"> webkit.org/b/95296 http/tests/media/media-source [ Skip ]
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (174632 => 174633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2014-10-11 07:08:59 UTC (rev 174632)
+++ trunk/Source/WTF/ChangeLog 2014-10-11 16:22:32 UTC (rev 174633)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-10-11 KwangHyuk Kim <hyuki.kim@samsung.com>
+
+ [EFL] Enable WebP support.
+ https://bugs.webkit.org/show_bug.cgi?id=136156
+
+ Reviewed by Gyuyoung Kim.
+
+ Enable WTF_USE_WEBP macro for WK2 Efl.
+
+ * wtf/Platform.h:
+
</ins><span class="cx"> 2014-10-11 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
</span></span></pre></div>
<a id="trunkSourceWTFwtfPlatformh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/Platform.h (174632 => 174633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/Platform.h 2014-10-11 07:08:59 UTC (rev 174632)
+++ trunk/Source/WTF/wtf/Platform.h 2014-10-11 16:22:32 UTC (rev 174633)
</span><span class="lines">@@ -468,6 +468,9 @@
</span><span class="cx"> #define WTF_USE_FREETYPE 1
</span><span class="cx"> #define WTF_USE_HARFBUZZ 1
</span><span class="cx"> #define WTF_USE_SOUP 1
</span><ins>+#endif
+
+#if PLATFORM(GTK) || PLATFORM(EFL)
</ins><span class="cx"> #define WTF_USE_WEBP 1
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (174632 => 174633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-10-11 07:08:59 UTC (rev 174632)
+++ trunk/Source/WebCore/ChangeLog 2014-10-11 16:22:32 UTC (rev 174633)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-10-11 KwangHyuk Kim <hyuki.kim@samsung.com>
+
+ [EFL] Enable WebP support.
+ https://bugs.webkit.org/show_bug.cgi?id=136156
+
+ Reviewed by Gyuyoung Kim.
+
+ Add WebP library and inlcude path to WebCore path for WK2 Efl.
+ No new tests since existing feature is just enabled for WK2 Efl.
+
+ * PlatformEfl.cmake:
+
</ins><span class="cx"> 2014-10-11 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
</span></span></pre></div>
<a id="trunkSourceWebCorePlatformEflcmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/PlatformEfl.cmake (174632 => 174633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/PlatformEfl.cmake 2014-10-11 07:08:59 UTC (rev 174632)
+++ trunk/Source/WebCore/PlatformEfl.cmake 2014-10-11 16:22:32 UTC (rev 174633)
</span><span class="lines">@@ -310,6 +310,7 @@
</span><span class="cx"> ${LIBXSLT_LIBRARIES}
</span><span class="cx"> ${PNG_LIBRARIES}
</span><span class="cx"> ${SQLITE_LIBRARIES}
</span><ins>+ ${WEBP_LIBRARIES}
</ins><span class="cx"> ${X11_X11_LIB}
</span><span class="cx"> ${ZLIB_LIBRARIES}
</span><span class="cx"> )
</span><span class="lines">@@ -331,6 +332,7 @@
</span><span class="cx"> ${LIBXML2_INCLUDE_DIR}
</span><span class="cx"> ${LIBXSLT_INCLUDE_DIR}
</span><span class="cx"> ${SQLITE_INCLUDE_DIR}
</span><ins>+ ${WEBP_INCLUDE_DIRS}
</ins><span class="cx"> ${GLIB_INCLUDE_DIRS}
</span><span class="cx"> ${LIBSOUP_INCLUDE_DIRS}
</span><span class="cx"> ${ZLIB_INCLUDE_DIRS}
</span></span></pre></div>
<a id="trunkSourcecmakeOptionsEflcmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/cmake/OptionsEfl.cmake (174632 => 174633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/cmake/OptionsEfl.cmake 2014-10-11 07:08:59 UTC (rev 174632)
+++ trunk/Source/cmake/OptionsEfl.cmake 2014-10-11 16:22:32 UTC (rev 174633)
</span><span class="lines">@@ -22,6 +22,7 @@
</span><span class="cx"> find_package(Threads REQUIRED)
</span><span class="cx"> find_package(JPEG REQUIRED)
</span><span class="cx"> find_package(PNG REQUIRED)
</span><ins>+find_package(WebP REQUIRED)
</ins><span class="cx"> find_package(ZLIB REQUIRED)
</span><span class="cx">
</span><span class="cx"> set(glib_components gio gobject gthread)
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (174632 => 174633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-10-11 07:08:59 UTC (rev 174632)
+++ trunk/Tools/ChangeLog 2014-10-11 16:22:32 UTC (rev 174633)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-10-11 KwangHyuk Kim <hyuki.kim@samsung.com>
+
+ [EFL] Enable WebP support.
+ https://bugs.webkit.org/show_bug.cgi?id=136156
+
+ Reviewed by Gyuyoung Kim.
+
+ Include libwebp-dev package to support WebP for WK2 Efl.
+
+ * efl/install-dependencies:
+
</ins><span class="cx"> 2014-10-11 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
</span></span></pre></div>
<a id="trunkToolseflinstalldependencies"></a>
<div class="modfile"><h4>Modified: trunk/Tools/efl/install-dependencies (174632 => 174633)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/efl/install-dependencies 2014-10-11 07:08:59 UTC (rev 174632)
+++ trunk/Tools/efl/install-dependencies 2014-10-11 16:22:32 UTC (rev 174633)
</span><span class="lines">@@ -61,6 +61,7 @@
</span><span class="cx"> libtiff4-dev \
</span><span class="cx"> libudev-dev \
</span><span class="cx"> libvorbis-dev \
</span><ins>+ libwebp-dev \
</ins><span class="cx"> libxcomposite-dev \
</span><span class="cx"> libxcursor-dev \
</span><span class="cx"> libxinerama-dev \
</span></span></pre>
</div>
</div>
</body>
</html>