<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[174385] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/174385">174385</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-10-06 22:26:20 -0700 (Mon, 06 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make webkit-patch find-users useful
https://bugs.webkit.org/show_bug.cgi?id=137475
Reviewed by Alexey Proskuryakov.
Make find-users use the CommitterList instead of accessing Bugzilla.
This essentially exposes the same functionality as webkitbot's whois command.
* Scripts/webkitpy/tool/commands/findusers.py:
(FindUsers.execute):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpytoolcommandsfinduserspy">trunk/Tools/Scripts/webkitpy/tool/commands/findusers.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (174384 => 174385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-10-07 04:42:01 UTC (rev 174384)
+++ trunk/Tools/ChangeLog 2014-10-07 05:26:20 UTC (rev 174385)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-10-06 Ryosuke Niwa <rniwa@webkit.org>
+
+ Make webkit-patch find-users useful
+ https://bugs.webkit.org/show_bug.cgi?id=137475
+
+ Reviewed by Alexey Proskuryakov.
+
+ Make find-users use the CommitterList instead of accessing Bugzilla.
+
+ This essentially exposes the same functionality as webkitbot's whois command.
+
+ * Scripts/webkitpy/tool/commands/findusers.py:
+ (FindUsers.execute):
+
</ins><span class="cx"> 2014-10-06 Chris Fleizach <cfleizach@apple.com>
</span><span class="cx">
</span><span class="cx"> AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpytoolcommandsfinduserspy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/tool/commands/findusers.py (174384 => 174385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/tool/commands/findusers.py 2014-10-07 04:42:01 UTC (rev 174384)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/findusers.py 2014-10-07 05:26:20 UTC (rev 174385)
</span><span class="lines">@@ -1,4 +1,5 @@
</span><span class="cx"> # Copyright (c) 2011 Google Inc. All rights reserved.
</span><ins>+# Copyright (c) 2014 Apple Inc. All rights reserved.
</ins><span class="cx"> #
</span><span class="cx"> # Redistribution and use in source and binary forms, with or without
</span><span class="cx"> # modification, are permitted provided that the following conditions are
</span><span class="lines">@@ -27,6 +28,7 @@
</span><span class="cx"> # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">
</span><span class="cx"> from webkitpy.tool.multicommandtool import Command
</span><ins>+from webkitpy.common.config.committers import CommitterList
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> class FindUsers(Command):
</span><span class="lines">@@ -35,10 +37,6 @@
</span><span class="cx">
</span><span class="cx"> def execute(self, options, args, tool):
</span><span class="cx"> search_string = args[0]
</span><del>- login_userid_pairs = tool.bugs.queries.fetch_login_userid_pairs_matching_substring(search_string)
- for (login, user_id) in login_userid_pairs:
- user = tool.bugs.fetch_user(user_id)
- groups_string = ", ".join(user['groups']) if user['groups'] else "none"
- print "%s <%s> (%s) (%s)" % (user['name'], user['login'], user_id, groups_string)
- else:
- print "No users found matching '%s'" % search_string
</del><ins>+ users = CommitterList().contributors_by_search_string(search_string)
+ for user in users:
+ print user
</ins></span></pre>
</div>
</div>
</body>
</html>