<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[174173] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/174173">174173</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2014-10-01 14:34:12 -0700 (Wed, 01 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Object allocation sinking is broken for escaping sites in loops
https://bugs.webkit.org/show_bug.cgi?id=137310
Reviewed by Michael Saboff.
I tried to do this clever forward-flow based materialization point placement, and I messed up loops. Disabling
the phase for now and landing a test to demonstrate what it going on.
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
* runtime/Options.h:
* tests/stress/object-escapes-in-loop.js: Added.
(foo):
(bar):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGPlancpp">trunk/Source/JavaScriptCore/dfg/DFGPlan.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeOptionsh">trunk/Source/JavaScriptCore/runtime/Options.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoretestsstressobjectescapesinloopjs">trunk/Source/JavaScriptCore/tests/stress/object-escapes-in-loop.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (174172 => 174173)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-10-01 21:27:43 UTC (rev 174172)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-10-01 21:34:12 UTC (rev 174173)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-10-01 Filip Pizlo <fpizlo@apple.com>
+
+ Object allocation sinking is broken for escaping sites in loops
+ https://bugs.webkit.org/show_bug.cgi?id=137310
+
+ Reviewed by Michael Saboff.
+
+ I tried to do this clever forward-flow based materialization point placement, and I messed up loops. Disabling
+ the phase for now and landing a test to demonstrate what it going on.
+
+ * dfg/DFGPlan.cpp:
+ (JSC::DFG::Plan::compileInThreadImpl):
+ * runtime/Options.h:
+ * tests/stress/object-escapes-in-loop.js: Added.
+ (foo):
+ (bar):
+
</ins><span class="cx"> 2014-10-01 Saam Barati <saambarati1@gmail.com>
</span><span class="cx">
</span><span class="cx"> Support the type profiler in the DFG
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGPlancpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGPlan.cpp (174172 => 174173)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGPlan.cpp 2014-10-01 21:27:43 UTC (rev 174172)
+++ trunk/Source/JavaScriptCore/dfg/DFGPlan.cpp 2014-10-01 21:34:12 UTC (rev 174173)
</span><span class="lines">@@ -329,8 +329,10 @@
</span><span class="cx"> performPhantomCanonicalization(dfg); // Reduce the graph size a lot.
</span><span class="cx"> changed = false;
</span><span class="cx"> changed |= performStrengthReduction(dfg);
</span><del>- changed |= performCriticalEdgeBreaking(dfg);
- changed |= performObjectAllocationSinking(dfg);
</del><ins>+ if (Options::enableObjectAllocationSinking()) {
+ changed |= performCriticalEdgeBreaking(dfg);
+ changed |= performObjectAllocationSinking(dfg);
+ }
</ins><span class="cx"> if (changed) {
</span><span class="cx"> // State-at-tail and state-at-head will be invalid if we did strength reduction since
</span><span class="cx"> // it might increase live ranges.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeOptionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Options.h (174172 => 174173)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Options.h 2014-10-01 21:27:43 UTC (rev 174172)
+++ trunk/Source/JavaScriptCore/runtime/Options.h 2014-10-01 21:34:12 UTC (rev 174173)
</span><span class="lines">@@ -178,6 +178,7 @@
</span><span class="cx"> v(bool, enableCallEdgeProfiling, true) \
</span><span class="cx"> v(unsigned, frequentCallThreshold, 2) \
</span><span class="cx"> v(bool, optimizeNativeCalls, false) \
</span><ins>+ v(bool, enableObjectAllocationSinking, false) \
</ins><span class="cx"> \
</span><span class="cx"> v(bool, enableConcurrentJIT, true) \
</span><span class="cx"> v(unsigned, numberOfDFGCompilerThreads, computeNumberOfWorkerThreads(2, 2) - 1) \
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstressobjectescapesinloopjs"></a>
<div class="addfile"><h4>Added: trunk/Source/JavaScriptCore/tests/stress/object-escapes-in-loop.js (0 => 174173)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/object-escapes-in-loop.js (rev 0)
+++ trunk/Source/JavaScriptCore/tests/stress/object-escapes-in-loop.js 2014-10-01 21:34:12 UTC (rev 174173)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+function foo(p) {
+ var o = {};
+ if (p) {
+ for (var i = 0; i < 100; ++i)
+ bar(o);
+ }
+ return 42;
+}
+
+function bar() {
+}
+
+noInline(foo);
+noInline(bar);
+
+for (var i = 0; i < 100000; ++i)
+ foo(true);
</ins></span></pre>
</div>
</div>
</body>
</html>