<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[174089] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/174089">174089</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2014-09-29 15:23:20 -0700 (Mon, 29 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use is<>() / downcast<>() for Document
https://bugs.webkit.org/show_bug.cgi?id=137221
Reviewed by Andreas Kling.
Use is<>() / downcast<>() for Document instead of isDocumentNode() /
toDocument().
Source/WebCore:
No new tests, no behavior change.
* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::document):
(WebCore::Geolocation::frame):
(WebCore::Geolocation::page):
* Modules/indexeddb/IDBFactory.cpp:
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::document):
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
* Modules/notifications/Notification.cpp:
(WebCore::Notification::Notification):
(WebCore::Notification::show):
(WebCore::Notification::permission):
(WebCore::Notification::requestPermission):
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::document):
* Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::create):
* Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::allowDatabaseAccess):
(WebCore::DatabaseContext::databaseExceededQuota):
* Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::create):
* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):
* Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
* bindings/gobject/WebKitDOMPrivate.cpp:
(WebKit::wrap):
* bindings/js/DOMConstructorWithDocument.h:
(WebCore::DOMConstructorWithDocument::document):
* bindings/js/DOMRequestState.h:
(WebCore::DOMRequestState::DOMRequestState):
(WebCore::DOMRequestState::clear):
* bindings/js/JSAudioContextCustom.cpp:
(WebCore::constructJSAudioContext):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::toJSDOMGlobalObject):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
* bindings/js/ScriptState.cpp:
(WebCore::frameFromExecState):
* crypto/SubtleCrypto.cpp:
(WebCore::SubtleCrypto::document):
* dom/Comment.cpp:
(WebCore::Comment::create):
* dom/ContainerNode.cpp:
(WebCore::checkAcceptChild):
* dom/ContainerNodeAlgorithms.cpp:
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
* dom/Document.h:
(WebCore::isDocument):
* dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::create):
* dom/Element.cpp:
(WebCore::Element::computeInheritedLanguage):
* dom/EventDispatcher.cpp:
(WebCore::WindowEventContext::WindowEventContext):
* dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
* dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::document):
* dom/Node.cpp:
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::Node::removedLastRef):
* dom/Range.cpp:
(WebCore::Range::create):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::dispatchErrorEvent):
* dom/Text.cpp:
(WebCore::Text::create):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup):
* html/HTMLDocument.h:
(WebCore::isHTMLDocument):
* html/HTMLNameCollection.h:
(WebCore::HTMLNameCollection::document):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::insertedInto):
* html/ImageDocument.h:
(WebCore::isImageDocument):
* html/MediaDocument.h:
(WebCore::isMediaDocument):
* html/PluginDocument.h:
(WebCore::isPluginDocument):
* html/track/TextTrackCue.h:
(WebCore::TextTrackCue::ownerDocument):
* html/track/VTTCue.cpp:
(WebCore::VTTCue::initialize):
* html/track/VTTRegion.h:
(WebCore::VTTRegion::ownerDocument):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::assertDocument):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::innerParentNode):
* inspector/InspectorInstrumentation.cpp:
(WebCore::frameForScriptExecutionContext):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::instrumentingAgentsForContext):
* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::corsPolicyPreventedLoad):
(WebCore::TextTrackLoader::notifyFinished):
(WebCore::TextTrackLoader::load):
* loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
* page/Crypto.cpp:
(WebCore::Crypto::document):
* page/DOMTimer.cpp:
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::focus):
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::document):
(WebCore::DOMWindow::styleMedia):
(WebCore::DOMWindow::getComputedStyle):
* page/DragController.cpp:
(WebCore::DragController::dragExited):
(WebCore::DragController::dragEnteredOrUpdated):
* page/EventSource.cpp:
(WebCore::EventSource::create):
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
* page/History.cpp:
(WebCore::History::go):
* page/SpatialNavigation.cpp:
(WebCore::scrollInDirection):
(WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDirection):
(WebCore::canScrollInDirection):
(WebCore::nodeRectInAbsoluteCoordinates):
* svg/SVGDocument.h:
(WebCore::isSVGDocument):
* testing/Internals.cpp:
(WebCore::Internals::contextDocument):
(WebCore::Internals::frame):
(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::injectInternalsObject):
(WebCoreTestSupport::resetInternalsObject):
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::addToWorkerDocuments):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::document):
(WebCore::XMLHttpRequest::open):
Source/WebKit2:
* WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:
(-[WKDOMDocument createElement:]):
(-[WKDOMDocument createTextNode:]):
(-[WKDOMDocument body]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesgeolocationGeolocationcpp">trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBFactorycpp">trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediasourceSourceBuffercpp">trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCPeerConnectioncpp">trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesnotificationsNotificationcpp">trunk/Source/WebCore/Modules/notifications/Notification.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioAudioContextcpp">trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioOfflineAudioContextcpp">trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseContextcpp">trunk/Source/WebCore/Modules/webdatabase/DatabaseContext.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsThreadableWebSocketChannelcpp">trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsWebSocketcpp">trunk/Source/WebCore/Modules/websockets/WebSocket.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsWebSocketHandshakecpp">trunk/Source/WebCore/Modules/websockets/WebSocketHandshake.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsWorkerThreadableWebSocketChannelcpp">trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsgobjectWebKitDOMPrivatecpp">trunk/Source/WebCore/bindings/gobject/WebKitDOMPrivate.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsDOMConstructorWithDocumenth">trunk/Source/WebCore/bindings/js/DOMConstructorWithDocument.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsDOMRequestStateh">trunk/Source/WebCore/bindings/js/DOMRequestState.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSAudioContextCustomcpp">trunk/Source/WebCore/bindings/js/JSAudioContextCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMGlobalObjectcpp">trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSLazyEventListenercpp">trunk/Source/WebCore/bindings/js/JSLazyEventListener.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSNodeCustomcpp">trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsScheduledActioncpp">trunk/Source/WebCore/bindings/js/ScheduledAction.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsScriptStatecpp">trunk/Source/WebCore/bindings/js/ScriptState.cpp</a></li>
<li><a href="#trunkSourceWebCorecryptoSubtleCryptocpp">trunk/Source/WebCore/crypto/SubtleCrypto.cpp</a></li>
<li><a href="#trunkSourceWebCoredomCommentcpp">trunk/Source/WebCore/dom/Comment.cpp</a></li>
<li><a href="#trunkSourceWebCoredomContainerNodecpp">trunk/Source/WebCore/dom/ContainerNode.cpp</a></li>
<li><a href="#trunkSourceWebCoredomContainerNodeAlgorithmscpp">trunk/Source/WebCore/dom/ContainerNodeAlgorithms.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
<li><a href="#trunkSourceWebCoredomDocumentFragmentcpp">trunk/Source/WebCore/dom/DocumentFragment.cpp</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoredomEventDispatchercpp">trunk/Source/WebCore/dom/EventDispatcher.cpp</a></li>
<li><a href="#trunkSourceWebCoredomEventTargetcpp">trunk/Source/WebCore/dom/EventTarget.cpp</a></li>
<li><a href="#trunkSourceWebCoredomNamedFlowCollectioncpp">trunk/Source/WebCore/dom/NamedFlowCollection.cpp</a></li>
<li><a href="#trunkSourceWebCoredomNodecpp">trunk/Source/WebCore/dom/Node.cpp</a></li>
<li><a href="#trunkSourceWebCoredomRangecpp">trunk/Source/WebCore/dom/Range.cpp</a></li>
<li><a href="#trunkSourceWebCoredomScriptExecutionContextcpp">trunk/Source/WebCore/dom/ScriptExecutionContext.cpp</a></li>
<li><a href="#trunkSourceWebCoredomTextcpp">trunk/Source/WebCore/dom/Text.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingMarkupAccumulatorcpp">trunk/Source/WebCore/editing/MarkupAccumulator.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLDocumenth">trunk/Source/WebCore/html/HTMLDocument.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLNameCollectionh">trunk/Source/WebCore/html/HTMLNameCollection.h</a></li>
<li><a href="#trunkSourceWebCorehtmlImageDocumenth">trunk/Source/WebCore/html/ImageDocument.h</a></li>
<li><a href="#trunkSourceWebCorehtmlMediaDocumenth">trunk/Source/WebCore/html/MediaDocument.h</a></li>
<li><a href="#trunkSourceWebCorehtmlPluginDocumenth">trunk/Source/WebCore/html/PluginDocument.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackTextTrackCueh">trunk/Source/WebCore/html/track/TextTrackCue.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackVTTCuecpp">trunk/Source/WebCore/html/track/VTTCue.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackVTTRegionh">trunk/Source/WebCore/html/track/VTTRegion.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorDOMAgentcpp">trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorInstrumentationcpp">trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorInstrumentationh">trunk/Source/WebCore/inspector/InspectorInstrumentation.h</a></li>
<li><a href="#trunkSourceWebCoreloaderTextTrackLoadercpp">trunk/Source/WebCore/loader/TextTrackLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderThreadableLoadercpp">trunk/Source/WebCore/loader/ThreadableLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderWorkerThreadableLoadercpp">trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp</a></li>
<li><a href="#trunkSourceWebCorepageContentSecurityPolicycpp">trunk/Source/WebCore/page/ContentSecurityPolicy.cpp</a></li>
<li><a href="#trunkSourceWebCorepageCryptocpp">trunk/Source/WebCore/page/Crypto.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDOMTimercpp">trunk/Source/WebCore/page/DOMTimer.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDOMWindowcpp">trunk/Source/WebCore/page/DOMWindow.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDragControllercpp">trunk/Source/WebCore/page/DragController.cpp</a></li>
<li><a href="#trunkSourceWebCorepageEventSourcecpp">trunk/Source/WebCore/page/EventSource.cpp</a></li>
<li><a href="#trunkSourceWebCorepageFocusControllercpp">trunk/Source/WebCore/page/FocusController.cpp</a></li>
<li><a href="#trunkSourceWebCorepageHistorycpp">trunk/Source/WebCore/page/History.cpp</a></li>
<li><a href="#trunkSourceWebCorepageSpatialNavigationcpp">trunk/Source/WebCore/page/SpatialNavigation.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGDocumenth">trunk/Source/WebCore/svg/SVGDocument.h</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
<li><a href="#trunkSourceWebCoretestingjsWebCoreTestSupportcpp">trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp</a></li>
<li><a href="#trunkSourceWebCoreworkersDefaultSharedWorkerRepositorycpp">trunk/Source/WebCore/workers/DefaultSharedWorkerRepository.cpp</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerMessagingProxycpp">trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlXMLHttpRequestcpp">trunk/Source/WebCore/xml/XMLHttpRequest.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessInjectedBundleAPImacWKDOMDocumentmm">trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/ChangeLog 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -1,3 +1,176 @@
</span><ins>+2014-09-29 Christophe Dumez <cdumez@apple.com>
+
+ Use is<>() / downcast<>() for Document
+ https://bugs.webkit.org/show_bug.cgi?id=137221
+
+ Reviewed by Andreas Kling.
+
+ Use is<>() / downcast<>() for Document instead of isDocumentNode() /
+ toDocument().
+
+ No new tests, no behavior change.
+
+ * Modules/geolocation/Geolocation.cpp:
+ (WebCore::Geolocation::document):
+ (WebCore::Geolocation::frame):
+ (WebCore::Geolocation::page):
+ * Modules/indexeddb/IDBFactory.cpp:
+ * Modules/mediasource/SourceBuffer.cpp:
+ (WebCore::SourceBuffer::document):
+ * Modules/mediastream/RTCPeerConnection.cpp:
+ (WebCore::RTCPeerConnection::RTCPeerConnection):
+ * Modules/notifications/Notification.cpp:
+ (WebCore::Notification::Notification):
+ (WebCore::Notification::show):
+ (WebCore::Notification::permission):
+ (WebCore::Notification::requestPermission):
+ * Modules/webaudio/AudioContext.cpp:
+ (WebCore::AudioContext::document):
+ * Modules/webaudio/OfflineAudioContext.cpp:
+ (WebCore::OfflineAudioContext::create):
+ * Modules/webdatabase/DatabaseContext.cpp:
+ (WebCore::DatabaseContext::allowDatabaseAccess):
+ (WebCore::DatabaseContext::databaseExceededQuota):
+ * Modules/websockets/ThreadableWebSocketChannel.cpp:
+ (WebCore::ThreadableWebSocketChannel::create):
+ * Modules/websockets/WebSocket.cpp:
+ (WebCore::WebSocket::connect):
+ * Modules/websockets/WebSocketHandshake.cpp:
+ (WebCore::WebSocketHandshake::clientHandshakeMessage):
+ (WebCore::WebSocketHandshake::clientHandshakeRequest):
+ * Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
+ (WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
+ * bindings/gobject/WebKitDOMPrivate.cpp:
+ (WebKit::wrap):
+ * bindings/js/DOMConstructorWithDocument.h:
+ (WebCore::DOMConstructorWithDocument::document):
+ * bindings/js/DOMRequestState.h:
+ (WebCore::DOMRequestState::DOMRequestState):
+ (WebCore::DOMRequestState::clear):
+ * bindings/js/JSAudioContextCustom.cpp:
+ (WebCore::constructJSAudioContext):
+ * bindings/js/JSDOMGlobalObject.cpp:
+ (WebCore::toJSDOMGlobalObject):
+ * bindings/js/JSLazyEventListener.cpp:
+ (WebCore::JSLazyEventListener::initializeJSFunction):
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::createWrapperInline):
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::execute):
+ * bindings/js/ScriptState.cpp:
+ (WebCore::frameFromExecState):
+ * crypto/SubtleCrypto.cpp:
+ (WebCore::SubtleCrypto::document):
+ * dom/Comment.cpp:
+ (WebCore::Comment::create):
+ * dom/ContainerNode.cpp:
+ (WebCore::checkAcceptChild):
+ * dom/ContainerNodeAlgorithms.cpp:
+ (WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
+ * dom/Document.h:
+ (WebCore::isDocument):
+ * dom/DocumentFragment.cpp:
+ (WebCore::DocumentFragment::create):
+ * dom/Element.cpp:
+ (WebCore::Element::computeInheritedLanguage):
+ * dom/EventDispatcher.cpp:
+ (WebCore::WindowEventContext::WindowEventContext):
+ * dom/EventTarget.cpp:
+ (WebCore::EventTarget::fireEventListeners):
+ * dom/NamedFlowCollection.cpp:
+ (WebCore::NamedFlowCollection::document):
+ * dom/Node.cpp:
+ (WebCore::Node::isDefaultNamespace):
+ (WebCore::Node::lookupPrefix):
+ (WebCore::Node::lookupNamespaceURI):
+ (WebCore::Node::removedLastRef):
+ * dom/Range.cpp:
+ (WebCore::Range::create):
+ * dom/ScriptExecutionContext.cpp:
+ (WebCore::ScriptExecutionContext::dispatchErrorEvent):
+ * dom/Text.cpp:
+ (WebCore::Text::create):
+ * editing/MarkupAccumulator.cpp:
+ (WebCore::MarkupAccumulator::appendStartMarkup):
+ * html/HTMLDocument.h:
+ (WebCore::isHTMLDocument):
+ * html/HTMLNameCollection.h:
+ (WebCore::HTMLNameCollection::document):
+ * html/HTMLStyleElement.cpp:
+ (WebCore::HTMLStyleElement::insertedInto):
+ * html/ImageDocument.h:
+ (WebCore::isImageDocument):
+ * html/MediaDocument.h:
+ (WebCore::isMediaDocument):
+ * html/PluginDocument.h:
+ (WebCore::isPluginDocument):
+ * html/track/TextTrackCue.h:
+ (WebCore::TextTrackCue::ownerDocument):
+ * html/track/VTTCue.cpp:
+ (WebCore::VTTCue::initialize):
+ * html/track/VTTRegion.h:
+ (WebCore::VTTRegion::ownerDocument):
+ * inspector/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::assertDocument):
+ (WebCore::InspectorDOMAgent::buildObjectForNode):
+ (WebCore::InspectorDOMAgent::innerParentNode):
+ * inspector/InspectorInstrumentation.cpp:
+ (WebCore::frameForScriptExecutionContext):
+ * inspector/InspectorInstrumentation.h:
+ (WebCore::InspectorInstrumentation::instrumentingAgentsForContext):
+ * loader/TextTrackLoader.cpp:
+ (WebCore::TextTrackLoader::corsPolicyPreventedLoad):
+ (WebCore::TextTrackLoader::notifyFinished):
+ (WebCore::TextTrackLoader::load):
+ * loader/ThreadableLoader.cpp:
+ (WebCore::ThreadableLoader::create):
+ (WebCore::ThreadableLoader::loadResourceSynchronously):
+ * loader/WorkerThreadableLoader.cpp:
+ (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
+ * page/ContentSecurityPolicy.cpp:
+ (WebCore::ContentSecurityPolicy::reportViolation):
+ * page/Crypto.cpp:
+ (WebCore::Crypto::document):
+ * page/DOMTimer.cpp:
+ (WebCore::DOMTimer::install):
+ (WebCore::DOMTimer::fired):
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::focus):
+ (WebCore::DOMWindow::close):
+ (WebCore::DOMWindow::document):
+ (WebCore::DOMWindow::styleMedia):
+ (WebCore::DOMWindow::getComputedStyle):
+ * page/DragController.cpp:
+ (WebCore::DragController::dragExited):
+ (WebCore::DragController::dragEnteredOrUpdated):
+ * page/EventSource.cpp:
+ (WebCore::EventSource::create):
+ * page/FocusController.cpp:
+ (WebCore::FocusController::advanceFocusDirectionally):
+ * page/History.cpp:
+ (WebCore::History::go):
+ * page/SpatialNavigation.cpp:
+ (WebCore::scrollInDirection):
+ (WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDirection):
+ (WebCore::canScrollInDirection):
+ (WebCore::nodeRectInAbsoluteCoordinates):
+ * svg/SVGDocument.h:
+ (WebCore::isSVGDocument):
+ * testing/Internals.cpp:
+ (WebCore::Internals::contextDocument):
+ (WebCore::Internals::frame):
+ (WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):
+ * testing/js/WebCoreTestSupport.cpp:
+ (WebCoreTestSupport::injectInternalsObject):
+ (WebCoreTestSupport::resetInternalsObject):
+ * workers/DefaultSharedWorkerRepository.cpp:
+ (WebCore::SharedWorkerProxy::addToWorkerDocuments):
+ * workers/WorkerMessagingProxy.cpp:
+ (WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::document):
+ (WebCore::XMLHttpRequest::open):
+
</ins><span class="cx"> 2014-09-29 David Hyatt <hyatt@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r168046): Confused column spans when combined with dynamic animations
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesgeolocationGeolocationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -250,17 +250,17 @@
</span><span class="cx">
</span><span class="cx"> Document* Geolocation::document() const
</span><span class="cx"> {
</span><del>- return toDocument(scriptExecutionContext());
</del><ins>+ return downcast<Document>(scriptExecutionContext());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Frame* Geolocation::frame() const
</span><span class="cx"> {
</span><del>- return document() ? document()->frame() : 0;
</del><ins>+ return document() ? document()->frame() : nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Page* Geolocation::page() const
</span><span class="cx"> {
</span><del>- return document() ? document()->page() : 0;
</del><ins>+ return document() ? document()->page() : nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBFactorycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -68,10 +68,10 @@
</span><span class="cx"> namespace {
</span><span class="cx"> static bool isContextValid(ScriptExecutionContext* context)
</span><span class="cx"> {
</span><del>- ASSERT(context->isDocument() || context->isWorkerGlobalScope());
- if (context->isDocument()) {
- Document* document = toDocument(context);
- return document->frame() && document->page() && (!document->page()->usesEphemeralSession() || SchemeRegistry::allowsDatabaseAccessInPrivateBrowsing(document->securityOrigin()->protocol()));
</del><ins>+ ASSERT(is<Document>(context) || context->isWorkerGlobalScope());
+ if (is<Document>(context)) {
+ Document& document = downcast<Document>(*context);
+ return document.frame() && document.page() && (!document.page()->usesEphemeralSession() || SchemeRegistry::allowsDatabaseAccessInPrivateBrowsing(document.securityOrigin()->protocol()));
</ins><span class="cx"> }
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -79,9 +79,9 @@
</span><span class="cx"> static String getIndexedDBDatabasePath(ScriptExecutionContext* context)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(isContextValid(context));
</span><del>- if (context->isDocument()) {
- Document* document = toDocument(context);
- return document->page()->group().groupSettings().indexedDBDatabasePath();
</del><ins>+ if (is<Document>(context)) {
+ Document& document = downcast<Document>(*context);
+ return document.page()->group().groupSettings().indexedDBDatabasePath();
</ins><span class="cx"> }
</span><span class="cx"> const GroupSettings* groupSettings = toWorkerGlobalScope(context)->groupSettings();
</span><span class="cx"> if (groupSettings)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediasourceSourceBuffercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -1796,7 +1796,7 @@
</span><span class="cx"> Document& SourceBuffer::document() const
</span><span class="cx"> {
</span><span class="cx"> ASSERT(scriptExecutionContext());
</span><del>- return *toDocument(scriptExecutionContext());
</del><ins>+ return downcast<Document>(*scriptExecutionContext());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCPeerConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -178,7 +178,7 @@
</span><span class="cx"> , m_configuration(configuration)
</span><span class="cx"> , m_stopped(false)
</span><span class="cx"> {
</span><del>- Document& document = toDocument(context);
</del><ins>+ Document& document = downcast<Document>(context);
</ins><span class="cx">
</span><span class="cx"> if (!document.frame()) {
</span><span class="cx"> ec = NOT_SUPPORTED_ERR;
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesnotificationsNotificationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/notifications/Notification.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/notifications/Notification.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/Modules/notifications/Notification.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx"> , m_state(Idle)
</span><span class="cx"> , m_taskTimer(std::make_unique<Timer<Notification>>(this, &Notification::taskTimerFired))
</span><span class="cx"> {
</span><del>- m_notificationCenter = DOMWindowNotifications::webkitNotifications(toDocument(context).domWindow());
</del><ins>+ m_notificationCenter = DOMWindowNotifications::webkitNotifications(downcast<Document>(context).domWindow());
</ins><span class="cx">
</span><span class="cx"> ASSERT(m_notificationCenter->client());
</span><span class="cx"> m_taskTimer->startOneShot(0);
</span><span class="lines">@@ -135,9 +135,9 @@
</span><span class="cx"> // prevent double-showing
</span><span class="cx"> if (m_state == Idle && m_notificationCenter->client()) {
</span><span class="cx"> #if ENABLE(NOTIFICATIONS)
</span><del>- if (!toDocument(scriptExecutionContext())->page())
</del><ins>+ if (!downcast<Document>(*scriptExecutionContext()).page())
</ins><span class="cx"> return;
</span><del>- if (NotificationController::from(toDocument(scriptExecutionContext())->page())->client()->checkPermission(scriptExecutionContext()) != NotificationClient::PermissionAllowed) {
</del><ins>+ if (NotificationController::from(downcast<Document>(*scriptExecutionContext()).page())->client()->checkPermission(scriptExecutionContext()) != NotificationClient::PermissionAllowed) {
</ins><span class="cx"> dispatchErrorEvent();
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -213,8 +213,8 @@
</span><span class="cx"> #if ENABLE(NOTIFICATIONS)
</span><span class="cx"> const String Notification::permission(ScriptExecutionContext* context)
</span><span class="cx"> {
</span><del>- ASSERT(toDocument(context)->page());
- return permissionString(NotificationController::from(toDocument(context)->page())->client()->checkPermission(context));
</del><ins>+ ASSERT(downcast<Document>(*context).page());
+ return permissionString(NotificationController::from(downcast<Document>(*context).page())->client()->checkPermission(context));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> const String Notification::permissionString(NotificationClient::Permission permission)
</span><span class="lines">@@ -234,8 +234,8 @@
</span><span class="cx">
</span><span class="cx"> void Notification::requestPermission(ScriptExecutionContext* context, PassRefPtr<NotificationPermissionCallback> callback)
</span><span class="cx"> {
</span><del>- ASSERT(toDocument(context)->page());
- NotificationController::from(toDocument(context)->page())->client()->requestPermission(context, callback);
</del><ins>+ ASSERT(downcast<Document>(*context).page());
+ NotificationController::from(downcast<Document>(*context).page())->client()->requestPermission(context, callback);
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioAudioContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -325,7 +325,7 @@
</span><span class="cx"> Document* AudioContext::document() const
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_scriptExecutionContext);
</span><del>- return toDocument(m_scriptExecutionContext);
</del><ins>+ return downcast<Document>(m_scriptExecutionContext);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<AudioBuffer> AudioContext::createBuffer(unsigned numberOfChannels, size_t numberOfFrames, float sampleRate, ExceptionCode& ec)
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioOfflineAudioContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -37,12 +37,12 @@
</span><span class="cx"> PassRefPtr<OfflineAudioContext> OfflineAudioContext::create(ScriptExecutionContext& context, unsigned numberOfChannels, size_t numberOfFrames, float sampleRate, ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> // FIXME: add support for workers.
</span><del>- if (!context.isDocument()) {
</del><ins>+ if (!is<Document>(context)) {
</ins><span class="cx"> ec = NOT_SUPPORTED_ERR;
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- Document& document = toDocument(context);
</del><ins>+ Document& document = downcast<Document>(context);
</ins><span class="cx">
</span><span class="cx"> if (numberOfChannels > 10 || !isSampleRateRangeGood(sampleRate)) {
</span><span class="cx"> ec = SYNTAX_ERR;
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseContext.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseContext.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseContext.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -218,9 +218,9 @@
</span><span class="cx">
</span><span class="cx"> bool DatabaseContext::allowDatabaseAccess() const
</span><span class="cx"> {
</span><del>- if (m_scriptExecutionContext->isDocument()) {
- Document* document = toDocument(m_scriptExecutionContext);
- if (!document->page() || (document->page()->usesEphemeralSession() && !SchemeRegistry::allowsDatabaseAccessInPrivateBrowsing(document->securityOrigin()->protocol())))
</del><ins>+ if (is<Document>(*m_scriptExecutionContext)) {
+ Document& document = downcast<Document>(*m_scriptExecutionContext);
+ if (!document.page() || (document.page()->usesEphemeralSession() && !SchemeRegistry::allowsDatabaseAccessInPrivateBrowsing(document.securityOrigin()->protocol())))
</ins><span class="cx"> return false;
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -231,10 +231,10 @@
</span><span class="cx">
</span><span class="cx"> void DatabaseContext::databaseExceededQuota(const String& name, DatabaseDetails details)
</span><span class="cx"> {
</span><del>- if (m_scriptExecutionContext->isDocument()) {
- Document* document = toDocument(m_scriptExecutionContext);
- if (Page* page = document->page())
- page->chrome().client().exceededDatabaseQuota(document->frame(), name, details);
</del><ins>+ if (is<Document>(*m_scriptExecutionContext)) {
+ Document& document = downcast<Document>(*m_scriptExecutionContext);
+ if (Page* page = document.page())
+ page->chrome().client().exceededDatabaseQuota(document.frame(), name, details);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> ASSERT(m_scriptExecutionContext->isWorkerGlobalScope());
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsThreadableWebSocketChannelcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -64,7 +64,7 @@
</span><span class="cx"> return WorkerThreadableWebSocketChannel::create(workerGlobalScope, client, mode.toString());
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return WebSocketChannel::create(toDocument(context), client);
</del><ins>+ return WebSocketChannel::create(downcast<Document>(context), client);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsWebSocketcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -239,9 +239,9 @@
</span><span class="cx">
</span><span class="cx"> // FIXME: Convert this to check the isolated world's Content Security Policy once webkit.org/b/104520 is solved.
</span><span class="cx"> bool shouldBypassMainWorldContentSecurityPolicy = false;
</span><del>- if (scriptExecutionContext()->isDocument()) {
- Document* document = toDocument(scriptExecutionContext());
- shouldBypassMainWorldContentSecurityPolicy = document->frame()->script().shouldBypassMainWorldContentSecurityPolicy();
</del><ins>+ if (is<Document>(scriptExecutionContext())) {
+ Document& document = downcast<Document>(*scriptExecutionContext());
+ shouldBypassMainWorldContentSecurityPolicy = document.frame()->script().shouldBypassMainWorldContentSecurityPolicy();
</ins><span class="cx"> }
</span><span class="cx"> if (!shouldBypassMainWorldContentSecurityPolicy && !scriptExecutionContext()->contentSecurityPolicy()->allowConnectToSource(m_url)) {
</span><span class="cx"> m_state = CLOSED;
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsWebSocketHandshakecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/WebSocketHandshake.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/WebSocketHandshake.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/Modules/websockets/WebSocketHandshake.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -196,9 +196,9 @@
</span><span class="cx"> fields.append("Sec-WebSocket-Protocol: " + m_clientProtocol);
</span><span class="cx">
</span><span class="cx"> URL url = httpURLForAuthenticationAndCookies();
</span><del>- if (m_context->isDocument()) {
- Document* document = toDocument(m_context);
- String cookie = cookieRequestHeaderFieldValue(document, url);
</del><ins>+ if (is<Document>(m_context)) {
+ Document& document = downcast<Document>(*m_context);
+ String cookie = cookieRequestHeaderFieldValue(&document, url);
</ins><span class="cx"> if (!cookie.isEmpty())
</span><span class="cx"> fields.append("Cookie: " + cookie);
</span><span class="cx"> // Set "Cookie2: <cookie>" if cookies 2 exists for url?
</span><span class="lines">@@ -247,9 +247,9 @@
</span><span class="cx"> request.setHTTPHeaderField(HTTPHeaderName::SecWebSocketProtocol, m_clientProtocol);
</span><span class="cx">
</span><span class="cx"> URL url = httpURLForAuthenticationAndCookies();
</span><del>- if (m_context->isDocument()) {
- Document* document = toDocument(m_context);
- String cookie = cookieRequestHeaderFieldValue(document, url);
</del><ins>+ if (is<Document>(*m_context)) {
+ Document& document = downcast<Document>(*m_context);
+ String cookie = cookieRequestHeaderFieldValue(&document, url);
</ins><span class="cx"> if (!cookie.isEmpty())
</span><span class="cx"> request.setHTTPHeaderField(HTTPHeaderName::Cookie, cookie);
</span><span class="cx"> // Set "Cookie2: <cookie>" if cookies 2 exists for url?
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsWorkerThreadableWebSocketChannelcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -147,7 +147,7 @@
</span><span class="cx"> WorkerThreadableWebSocketChannel::Peer::Peer(PassRefPtr<ThreadableWebSocketChannelClientWrapper> clientWrapper, WorkerLoaderProxy& loaderProxy, ScriptExecutionContext* context, const String& taskMode)
</span><span class="cx"> : m_workerClientWrapper(clientWrapper)
</span><span class="cx"> , m_loaderProxy(loaderProxy)
</span><del>- , m_mainWebSocketChannel(WebSocketChannel::create(toDocument(context), this))
</del><ins>+ , m_mainWebSocketChannel(WebSocketChannel::create(downcast<Document>(context), this))
</ins><span class="cx"> , m_taskMode(taskMode)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(isMainThread());
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgobjectWebKitDOMPrivatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMPrivate.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/gobject/WebKitDOMPrivate.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMPrivate.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -100,9 +100,9 @@
</span><span class="cx"> case Node::COMMENT_NODE:
</span><span class="cx"> return WEBKIT_DOM_NODE(wrapComment(static_cast<Comment*>(node)));
</span><span class="cx"> case Node::DOCUMENT_NODE:
</span><del>- if (toDocument(node)->isHTMLDocument())
- return WEBKIT_DOM_NODE(wrapHTMLDocument(static_cast<HTMLDocument*>(node)));
- return WEBKIT_DOM_NODE(wrapDocument(toDocument(node)));
</del><ins>+ if (is<HTMLDocument>(node))
+ return WEBKIT_DOM_NODE(wrapHTMLDocument(downcast<HTMLDocument>(node)));
+ return WEBKIT_DOM_NODE(wrapDocument(downcast<Document>(node)));
</ins><span class="cx"> case Node::DOCUMENT_TYPE_NODE:
</span><span class="cx"> return WEBKIT_DOM_NODE(wrapDocumentType(static_cast<DocumentType*>(node)));
</span><span class="cx"> case Node::DOCUMENT_FRAGMENT_NODE:
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsDOMConstructorWithDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/DOMConstructorWithDocument.h (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/DOMConstructorWithDocument.h 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/bindings/js/DOMConstructorWithDocument.h 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -32,7 +32,7 @@
</span><span class="cx"> public:
</span><span class="cx"> Document* document() const
</span><span class="cx"> {
</span><del>- return toDocument(scriptExecutionContext());
</del><ins>+ return downcast<Document>(scriptExecutionContext());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> protected:
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsDOMRequestStateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/DOMRequestState.h (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/DOMRequestState.h 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/bindings/js/DOMRequestState.h 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -41,11 +41,11 @@
</span><span class="cx"> public:
</span><span class="cx"> explicit DOMRequestState(ScriptExecutionContext* scriptExecutionContext)
</span><span class="cx"> : m_scriptExecutionContext(scriptExecutionContext)
</span><del>- , m_exec(0)
</del><ins>+ , m_exec(nullptr)
</ins><span class="cx"> {
</span><del>- if (m_scriptExecutionContext->isDocument()) {
- Document* document = toDocument(m_scriptExecutionContext);
- m_exec = execStateFromPage(mainThreadNormalWorld(), document->page());
</del><ins>+ if (is<Document>(*m_scriptExecutionContext)) {
+ Document& document = downcast<Document>(*m_scriptExecutionContext);
+ m_exec = execStateFromPage(mainThreadNormalWorld(), document.page());
</ins><span class="cx"> } else {
</span><span class="cx"> WorkerGlobalScope* workerGlobalScope = static_cast<WorkerGlobalScope*>(m_scriptExecutionContext);
</span><span class="cx"> m_exec = execStateFromWorkerGlobalScope(workerGlobalScope);
</span><span class="lines">@@ -54,8 +54,8 @@
</span><span class="cx">
</span><span class="cx"> void clear()
</span><span class="cx"> {
</span><del>- m_scriptExecutionContext = 0;
- m_exec = 0;
</del><ins>+ m_scriptExecutionContext = nullptr;
+ m_exec = nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> class Scope {
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSAudioContextCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSAudioContextCustom.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSAudioContextCustom.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/bindings/js/JSAudioContextCustom.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -53,10 +53,10 @@
</span><span class="cx"> if (!scriptExecutionContext)
</span><span class="cx"> return throwVMError(exec, createReferenceError(exec, "AudioContext constructor script execution context is unavailable"));
</span><span class="cx">
</span><del>- if (!scriptExecutionContext->isDocument())
</del><ins>+ if (!is<Document>(scriptExecutionContext))
</ins><span class="cx"> return throwVMError(exec, createReferenceError(exec, "AudioContext constructor called in a script execution context which is not a document"));
</span><span class="cx">
</span><del>- Document& document = toDocument(*scriptExecutionContext);
</del><ins>+ Document& document = downcast<Document>(*scriptExecutionContext);
</ins><span class="cx">
</span><span class="cx"> RefPtr<AudioContext> audioContext;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMGlobalObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -105,14 +105,14 @@
</span><span class="cx">
</span><span class="cx"> JSDOMGlobalObject* toJSDOMGlobalObject(ScriptExecutionContext* scriptExecutionContext, JSC::ExecState* exec)
</span><span class="cx"> {
</span><del>- if (scriptExecutionContext->isDocument())
- return toJSDOMGlobalObject(toDocument(scriptExecutionContext), exec);
</del><ins>+ if (is<Document>(scriptExecutionContext))
+ return toJSDOMGlobalObject(downcast<Document>(scriptExecutionContext), exec);
</ins><span class="cx">
</span><span class="cx"> if (scriptExecutionContext->isWorkerGlobalScope())
</span><span class="cx"> return toWorkerGlobalScope(scriptExecutionContext)->script()->workerGlobalScopeWrapper();
</span><span class="cx">
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> JSDOMGlobalObject* toJSDOMGlobalObject(Document* document, DOMWrapperWorld& world)
</span><span class="lines">@@ -122,14 +122,14 @@
</span><span class="cx">
</span><span class="cx"> JSDOMGlobalObject* toJSDOMGlobalObject(ScriptExecutionContext* scriptExecutionContext, DOMWrapperWorld& world)
</span><span class="cx"> {
</span><del>- if (scriptExecutionContext->isDocument())
- return toJSDOMGlobalObject(toDocument(scriptExecutionContext), world);
</del><ins>+ if (is<Document>(scriptExecutionContext))
+ return toJSDOMGlobalObject(downcast<Document>(scriptExecutionContext), world);
</ins><span class="cx">
</span><span class="cx"> if (scriptExecutionContext->isWorkerGlobalScope())
</span><span class="cx"> return toWorkerGlobalScope(scriptExecutionContext)->script()->workerGlobalScopeWrapper();
</span><span class="cx">
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSLazyEventListenercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSLazyEventListener.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSLazyEventListener.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/bindings/js/JSLazyEventListener.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -73,30 +73,30 @@
</span><span class="cx"> JSObject* JSLazyEventListener::initializeJSFunction(ScriptExecutionContext* executionContext) const
</span><span class="cx"> {
</span><span class="cx"> ASSERT(executionContext);
</span><del>- ASSERT(executionContext->isDocument());
</del><ins>+ ASSERT(is<Document>(executionContext));
</ins><span class="cx"> if (!executionContext)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> ASSERT(!m_code.isNull());
</span><span class="cx"> ASSERT(!m_eventParameterName.isNull());
</span><span class="cx"> if (m_code.isNull() || m_eventParameterName.isNull())
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- Document* document = toDocument(executionContext);
</del><ins>+ Document& document = downcast<Document>(*executionContext);
</ins><span class="cx">
</span><del>- if (!document->frame())
- return 0;
</del><ins>+ if (!document.frame())
+ return nullptr;
</ins><span class="cx">
</span><del>- if (!document->contentSecurityPolicy()->allowInlineEventHandlers(m_sourceURL, m_position.m_line))
- return 0;
</del><ins>+ if (!document.contentSecurityPolicy()->allowInlineEventHandlers(m_sourceURL, m_position.m_line))
+ return nullptr;
</ins><span class="cx">
</span><del>- ScriptController& script = document->frame()->script();
</del><ins>+ ScriptController& script = document.frame()->script();
</ins><span class="cx"> if (!script.canExecuteScripts(AboutToExecuteScript) || script.isPaused())
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> JSDOMGlobalObject* globalObject = toJSDOMGlobalObject(executionContext, isolatedWorld());
</span><span class="cx"> if (!globalObject)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> ExecState* exec = globalObject->globalExec();
</span><span class="cx">
</span><span class="lines">@@ -108,7 +108,7 @@
</span><span class="cx"> if (exec->hadException()) {
</span><span class="cx"> reportCurrentException(exec);
</span><span class="cx"> exec->clearException();
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> JSFunction* listenerAsFunction = jsCast<JSFunction*>(jsFunction);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSNodeCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -219,7 +219,7 @@
</span><span class="cx"> break;
</span><span class="cx"> case Node::DOCUMENT_NODE:
</span><span class="cx"> // we don't want to cache the document itself in the per-document dictionary
</span><del>- return toJS(exec, globalObject, toDocument(node));
</del><ins>+ return toJS(exec, globalObject, downcast<Document>(node));
</ins><span class="cx"> case Node::DOCUMENT_TYPE_NODE:
</span><span class="cx"> wrapper = CREATE_DOM_WRAPPER(globalObject, DocumentType, node);
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsScheduledActioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/ScheduledAction.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/ScheduledAction.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/bindings/js/ScheduledAction.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -74,8 +74,8 @@
</span><span class="cx">
</span><span class="cx"> void ScheduledAction::execute(ScriptExecutionContext* context)
</span><span class="cx"> {
</span><del>- if (context->isDocument())
- execute(toDocument(context));
</del><ins>+ if (is<Document>(context))
+ execute(downcast<Document>(context));
</ins><span class="cx"> else
</span><span class="cx"> execute(toWorkerGlobalScope(context));
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsScriptStatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/ScriptState.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/ScriptState.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/bindings/js/ScriptState.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx"> Frame* frameFromExecState(JSC::ExecState* scriptState)
</span><span class="cx"> {
</span><span class="cx"> ScriptExecutionContext* context = scriptExecutionContextFromExecState(scriptState);
</span><del>- Document* document = context && context->isDocument() ? toDocument(context) : nullptr;
</del><ins>+ Document* document = context && is<Document>(context) ? downcast<Document>(context) : nullptr;
</ins><span class="cx"> return document ? document->frame() : nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecryptoSubtleCryptocpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/crypto/SubtleCrypto.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/SubtleCrypto.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/crypto/SubtleCrypto.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx">
</span><span class="cx"> Document* SubtleCrypto::document() const
</span><span class="cx"> {
</span><del>- return toDocument(scriptExecutionContext());
</del><ins>+ return downcast<Document>(scriptExecutionContext());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomCommentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Comment.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Comment.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/dom/Comment.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx">
</span><span class="cx"> PassRefPtr<Comment> Comment::create(ScriptExecutionContext& context, const String& text)
</span><span class="cx"> {
</span><del>- return adoptRef(new Comment(toDocument(context), text));
</del><ins>+ return adoptRef(new Comment(downcast<Document>(context), text));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String Comment::nodeName() const
</span></span></pre></div>
<a id="trunkSourceWebCoredomContainerNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ContainerNode.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -202,8 +202,8 @@
</span><span class="cx"> if (containsConsideringHostElements(newChild, newParent))
</span><span class="cx"> return HIERARCHY_REQUEST_ERR;
</span><span class="cx">
</span><del>- if (oldChild && newParent->isDocumentNode()) {
- if (!toDocument(newParent)->canReplaceChild(newChild, oldChild))
</del><ins>+ if (oldChild && is<Document>(newParent)) {
+ if (!downcast<Document>(*newParent).canReplaceChild(newChild, oldChild))
</ins><span class="cx"> return HIERARCHY_REQUEST_ERR;
</span><span class="cx"> } else if (!isChildTypeAllowed(newParent, newChild))
</span><span class="cx"> return HIERARCHY_REQUEST_ERR;
</span></span></pre></div>
<a id="trunkSourceWebCoredomContainerNodeAlgorithmscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ContainerNodeAlgorithms.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ContainerNodeAlgorithms.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/dom/ContainerNodeAlgorithms.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -37,7 +37,7 @@
</span><span class="cx"> // we don't want to tell the rest of our children that they've been
</span><span class="cx"> // inserted into the document because they haven't.
</span><span class="cx"> if (node.inDocument() && child->parentNode() == &node)
</span><del>- notifyNodeInsertedIntoDocument(*child.get());
</del><ins>+ notifyNodeInsertedIntoDocument(*child);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!node.isElementNode())
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx">
</span><span class="cx"> if (RefPtr<ShadowRoot> root = toElement(node).shadowRoot()) {
</span><span class="cx"> if (node.inDocument() && root->hostElement() == &node)
</span><del>- notifyNodeInsertedIntoDocument(*root.get());
</del><ins>+ notifyNodeInsertedIntoDocument(*root);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/dom/Document.h 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -1740,13 +1740,11 @@
</span><span class="cx">
</span><span class="cx"> Element* eventTargetElementForDocument(Document*);
</span><span class="cx">
</span><del>-SCRIPT_EXECUTION_CONTEXT_TYPE_CASTS(Document)
</del><ins>+SPECIALIZE_TYPE_TRAITS_BEGIN(Document)
+ static bool isDocument(const ScriptExecutionContext& context) { return context.isDocument(); }
+ static bool isDocument(const Node& node) { return node.isDocumentNode(); }
+SPECIALIZE_TYPE_TRAITS_END()
</ins><span class="cx">
</span><del>-inline bool isDocument(const Node& node) { return node.isDocumentNode(); }
-void isDocument(const Document&); // Catch unnecessary runtime check of type known at compile time.
-
-NODE_TYPE_CASTS(Document)
-
</del><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> namespace WTF {
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentFragmentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DocumentFragment.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DocumentFragment.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/dom/DocumentFragment.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx">
</span><span class="cx"> PassRefPtr<DocumentFragment> DocumentFragment::create(ScriptExecutionContext& context)
</span><span class="cx"> {
</span><del>- return adoptRef(new DocumentFragment(toDocument(context), Node::CreateDocumentFragment));
</del><ins>+ return adoptRef(new DocumentFragment(downcast<Document>(context), Node::CreateDocumentFragment));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String DocumentFragment::nodeName() const
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/dom/Element.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -2200,9 +2200,9 @@
</span><span class="cx"> if (const Attribute* attribute = elementData->findLanguageAttribute())
</span><span class="cx"> return attribute->value();
</span><span class="cx"> }
</span><del>- } else if (currentNode->isDocumentNode()) {
</del><ins>+ } else if (is<Document>(currentNode)) {
</ins><span class="cx"> // checking the MIME content-language
</span><del>- return toDocument(currentNode)->contentLanguage();
</del><ins>+ return downcast<Document>(*currentNode).contentLanguage();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventDispatchercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EventDispatcher.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/dom/EventDispatcher.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -60,10 +60,10 @@
</span><span class="cx"> WindowEventContext::WindowEventContext(PassRefPtr<Node> node, const EventContext* topEventContext)
</span><span class="cx"> {
</span><span class="cx"> Node* topLevelContainer = topEventContext ? topEventContext->node() : node.get();
</span><del>- if (!topLevelContainer->isDocumentNode())
</del><ins>+ if (!is<Document>(topLevelContainer))
</ins><span class="cx"> return;
</span><span class="cx">
</span><del>- m_window = toDocument(topLevelContainer)->domWindow();
</del><ins>+ m_window = downcast<Document>(*topLevelContainer).domWindow();
</ins><span class="cx"> m_target = topEventContext ? topEventContext->target() : node.get();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventTargetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EventTarget.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EventTarget.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/dom/EventTarget.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -223,8 +223,8 @@
</span><span class="cx"> ScriptExecutionContext* context = scriptExecutionContext();
</span><span class="cx"> Document* document = nullptr;
</span><span class="cx"> InspectorInstrumentationCookie willDispatchEventCookie;
</span><del>- if (context && context->isDocument()) {
- document = toDocument(context);
</del><ins>+ if (context && is<Document>(context)) {
+ document = downcast<Document>(context);
</ins><span class="cx"> willDispatchEventCookie = InspectorInstrumentation::willDispatchEvent(document, *event, size > 0);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomNamedFlowCollectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/NamedFlowCollection.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/NamedFlowCollection.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/dom/NamedFlowCollection.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -101,7 +101,7 @@
</span><span class="cx"> Document* NamedFlowCollection::document() const
</span><span class="cx"> {
</span><span class="cx"> ScriptExecutionContext* context = ContextDestructionObserver::scriptExecutionContext();
</span><del>- return toDocument(context);
</del><ins>+ return downcast<Document>(context);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<DOMNamedFlowCollection> NamedFlowCollection::createCSSOMSnapshot()
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/dom/Node.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -1162,8 +1162,8 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx"> case DOCUMENT_NODE:
</span><del>- if (Element* de = toDocument(this)->documentElement())
- return de->isDefaultNamespace(namespaceURI);
</del><ins>+ if (Element* documentElement = downcast<Document>(*this).documentElement())
+ return documentElement->isDefaultNamespace(namespaceURI);
</ins><span class="cx"> return false;
</span><span class="cx"> case ENTITY_NODE:
</span><span class="cx"> case NOTATION_NODE:
</span><span class="lines">@@ -1195,8 +1195,8 @@
</span><span class="cx"> case ELEMENT_NODE:
</span><span class="cx"> return lookupNamespacePrefix(namespaceURI, static_cast<const Element *>(this));
</span><span class="cx"> case DOCUMENT_NODE:
</span><del>- if (Element* de = toDocument(this)->documentElement())
- return de->lookupPrefix(namespaceURI);
</del><ins>+ if (Element* documentElement = downcast<Document>(*this).documentElement())
+ return documentElement->lookupPrefix(namespaceURI);
</ins><span class="cx"> return String();
</span><span class="cx"> case ENTITY_NODE:
</span><span class="cx"> case NOTATION_NODE:
</span><span class="lines">@@ -1253,8 +1253,8 @@
</span><span class="cx"> return String();
</span><span class="cx"> }
</span><span class="cx"> case DOCUMENT_NODE:
</span><del>- if (Element* de = toDocument(this)->documentElement())
- return de->lookupNamespaceURI(prefix);
</del><ins>+ if (Element* documentElement = downcast<Document>(*this).documentElement())
+ return documentElement->lookupNamespaceURI(prefix);
</ins><span class="cx"> return String();
</span><span class="cx"> case ENTITY_NODE:
</span><span class="cx"> case NOTATION_NODE:
</span><span class="lines">@@ -2198,8 +2198,8 @@
</span><span class="cx"> // An explicit check for Document here is better than a virtual function since it is
</span><span class="cx"> // faster for non-Document nodes, and because the call to removedLastRef that is inlined
</span><span class="cx"> // at all deref call sites is smaller if it's a non-virtual function.
</span><del>- if (isDocumentNode()) {
- toDocument(*this).removedLastRef();
</del><ins>+ if (is<Document>(*this)) {
+ downcast<Document>(*this).removedLastRef();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomRangecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Range.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Range.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/dom/Range.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -106,7 +106,7 @@
</span><span class="cx">
</span><span class="cx"> PassRefPtr<Range> Range::create(ScriptExecutionContext& context)
</span><span class="cx"> {
</span><del>- return adoptRef(new Range(toDocument(context)));
</del><ins>+ return adoptRef(new Range(downcast<Document>(context)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<Range> Range::create(Document& ownerDocument, const VisiblePosition& visibleStart, const VisiblePosition& visibleEnd)
</span></span></pre></div>
<a id="trunkSourceWebCoredomScriptExecutionContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ScriptExecutionContext.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ScriptExecutionContext.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/dom/ScriptExecutionContext.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -378,8 +378,8 @@
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><del>- if (target == target->toDOMWindow() && isDocument()) {
- Settings* settings = toDocument(this)->settings();
</del><ins>+ if (target == target->toDOMWindow() && is<Document>(*this)) {
+ Settings* settings = downcast<Document>(*this).settings();
</ins><span class="cx"> if (settings && !settings->shouldDispatchJavaScriptWindowOnErrorEvents())
</span><span class="cx"> return false;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomTextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Text.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Text.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/dom/Text.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx">
</span><span class="cx"> PassRefPtr<Text> Text::create(ScriptExecutionContext& context, const String& data)
</span><span class="cx"> {
</span><del>- return adoptRef(new Text(toDocument(context), data, CreateText));
</del><ins>+ return adoptRef(new Text(downcast<Document>(context), data, CreateText));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<Text> Text::createEditingText(Document& document, const String& data)
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingMarkupAccumulatorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/MarkupAccumulator.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/MarkupAccumulator.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/editing/MarkupAccumulator.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -559,7 +559,7 @@
</span><span class="cx"> appendComment(result, downcast<Comment>(node).data());
</span><span class="cx"> break;
</span><span class="cx"> case Node::DOCUMENT_NODE:
</span><del>- appendXMLDeclaration(result, toDocument(node));
</del><ins>+ appendXMLDeclaration(result, downcast<Document>(node));
</ins><span class="cx"> break;
</span><span class="cx"> case Node::DOCUMENT_FRAGMENT_NODE:
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLDocument.h (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLDocument.h 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/html/HTMLDocument.h 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx">
</span><span class="cx"> SPECIALIZE_TYPE_TRAITS_BEGIN(HTMLDocument)
</span><span class="cx"> static bool isHTMLDocument(const Document& document) { return document.isHTMLDocument(); }
</span><del>- static bool isHTMLDocument(const Node& node) { return node.isDocumentNode() && isHTMLDocument(toDocument(node)); }
</del><ins>+ static bool isHTMLDocument(const Node& node) { return is<Document>(node) && isHTMLDocument(downcast<Document>(node)); }
</ins><span class="cx"> SPECIALIZE_TYPE_TRAITS_END()
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLNameCollectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLNameCollection.h (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLNameCollection.h 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/html/HTMLNameCollection.h 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> public:
</span><span class="cx"> ~HTMLNameCollection();
</span><span class="cx">
</span><del>- Document& document() { return toDocument(ownerNode()); }
</del><ins>+ Document& document() { return downcast<Document>(ownerNode()); }
</ins><span class="cx">
</span><span class="cx"> protected:
</span><span class="cx"> HTMLNameCollection(Document&, CollectionType, const AtomicString& name);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlImageDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ImageDocument.h (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ImageDocument.h 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/html/ImageDocument.h 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx">
</span><span class="cx"> SPECIALIZE_TYPE_TRAITS_BEGIN(ImageDocument)
</span><span class="cx"> static bool isImageDocument(const Document& document) { return document.isImageDocument(); }
</span><del>- static bool isImageDocument(const Node& node) { return node.isDocumentNode() && isImageDocument(toDocument(node)); }
</del><ins>+ static bool isImageDocument(const Node& node) { return is<Document>(node) && isImageDocument(downcast<Document>(node)); }
</ins><span class="cx"> SPECIALIZE_TYPE_TRAITS_END()
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlMediaDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/MediaDocument.h (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/MediaDocument.h 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/html/MediaDocument.h 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx">
</span><span class="cx"> SPECIALIZE_TYPE_TRAITS_BEGIN(MediaDocument)
</span><span class="cx"> static bool isMediaDocument(const Document& document) { return document.isMediaDocument(); }
</span><del>- static bool isMediaDocument(const Node& node) { return node.isDocumentNode() && isMediaDocument(toDocument(node)); }
</del><ins>+ static bool isMediaDocument(const Node& node) { return is<Document>(node) && isMediaDocument(downcast<Document>(node)); }
</ins><span class="cx"> SPECIALIZE_TYPE_TRAITS_END()
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlPluginDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/PluginDocument.h (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/PluginDocument.h 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/html/PluginDocument.h 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx">
</span><span class="cx"> SPECIALIZE_TYPE_TRAITS_BEGIN(PluginDocument)
</span><span class="cx"> static bool isPluginDocument(const Document& document) { return document.isPluginDocument(); }
</span><del>- static bool isPluginDocument(const Node& node) { return node.isDocumentNode() && isPluginDocument(toDocument(node)); }
</del><ins>+ static bool isPluginDocument(const Node& node) { return is<Document>(node) && isPluginDocument(downcast<Document>(node)); }
</ins><span class="cx"> SPECIALIZE_TYPE_TRAITS_END()
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackTextTrackCueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/TextTrackCue.h (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/TextTrackCue.h 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/html/track/TextTrackCue.h 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -120,7 +120,7 @@
</span><span class="cx"> protected:
</span><span class="cx"> TextTrackCue(ScriptExecutionContext&, const MediaTime& start, const MediaTime& end);
</span><span class="cx">
</span><del>- Document& ownerDocument() { return toDocument(m_scriptExecutionContext); }
</del><ins>+ Document& ownerDocument() { return downcast<Document>(m_scriptExecutionContext); }
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackVTTCuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/VTTCue.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/VTTCue.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/html/track/VTTCue.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -288,8 +288,8 @@
</span><span class="cx"> m_writingDirection = Horizontal;
</span><span class="cx"> m_cueAlignment = Middle;
</span><span class="cx"> m_webVTTNodeTree = nullptr;
</span><del>- m_cueBackdropBox = HTMLDivElement::create(toDocument(context));
- m_cueHighlightBox = HTMLSpanElement::create(spanTag, toDocument(context));
</del><ins>+ m_cueBackdropBox = HTMLDivElement::create(downcast<Document>(context));
+ m_cueHighlightBox = HTMLSpanElement::create(spanTag, downcast<Document>(context));
</ins><span class="cx"> m_displayDirection = CSSValueLtr;
</span><span class="cx"> m_displaySize = 0;
</span><span class="cx"> m_snapToLines = true;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackVTTRegionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/VTTRegion.h (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/VTTRegion.h 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/html/track/VTTRegion.h 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx"> private:
</span><span class="cx"> VTTRegion(ScriptExecutionContext&);
</span><span class="cx">
</span><del>- Document* ownerDocument() { return toDocument(m_scriptExecutionContext); }
</del><ins>+ Document* ownerDocument() { return downcast<Document>(m_scriptExecutionContext); }
</ins><span class="cx">
</span><span class="cx"> void prepareRegionDisplayTree();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorDOMAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -379,11 +379,11 @@
</span><span class="cx"> Node* node = assertNode(errorString, nodeId);
</span><span class="cx"> if (!node)
</span><span class="cx"> return nullptr;
</span><del>- if (!node->isDocumentNode()) {
</del><ins>+ if (!is<Document>(node)) {
</ins><span class="cx"> *errorString = "Document is not available";
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><del>- return toDocument(node);
</del><ins>+ return downcast<Document>(node);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Element* InspectorDOMAgent::assertElement(ErrorString* errorString, int nodeId)
</span><span class="lines">@@ -1301,11 +1301,11 @@
</span><span class="cx"> value->setTemplateContent(buildObjectForNode(downcast<HTMLTemplateElement>(*element).content(), 0, nodesMap));
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- } else if (node->isDocumentNode()) {
- Document* document = toDocument(node);
- value->setDocumentURL(documentURLString(document));
- value->setBaseURL(documentBaseURLString(document));
- value->setXmlVersion(document->xmlVersion());
</del><ins>+ } else if (is<Document>(node)) {
+ Document& document = downcast<Document>(*node);
+ value->setDocumentURL(documentURLString(&document));
+ value->setBaseURL(documentBaseURLString(&document));
+ value->setXmlVersion(document.xmlVersion());
</ins><span class="cx"> } else if (is<DocumentType>(node)) {
</span><span class="cx"> DocumentType& docType = downcast<DocumentType>(*node);
</span><span class="cx"> value->setPublicId(docType.publicId());
</span><span class="lines">@@ -1728,10 +1728,8 @@
</span><span class="cx">
</span><span class="cx"> Node* InspectorDOMAgent::innerParentNode(Node* node)
</span><span class="cx"> {
</span><del>- if (node->isDocumentNode()) {
- Document* document = toDocument(node);
- return document->ownerElement();
- }
</del><ins>+ if (is<Document>(node))
+ return downcast<Document>(*node).ownerElement();
</ins><span class="cx"> return node->parentNode();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorInstrumentationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -100,8 +100,8 @@
</span><span class="cx"> static Frame* frameForScriptExecutionContext(ScriptExecutionContext* context)
</span><span class="cx"> {
</span><span class="cx"> Frame* frame = nullptr;
</span><del>- if (context->isDocument())
- frame = toDocument(context)->frame();
</del><ins>+ if (is<Document>(context))
+ frame = downcast<Document>(context)->frame();
</ins><span class="cx"> return frame;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorInstrumentationh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.h (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -2062,8 +2062,8 @@
</span><span class="cx"> {
</span><span class="cx"> if (!context)
</span><span class="cx"> return nullptr;
</span><del>- if (context->isDocument())
- return instrumentingAgentsForPage(toDocument(context)->page());
</del><ins>+ if (is<Document>(context))
+ return instrumentingAgentsForPage(downcast<Document>(context)->page());
</ins><span class="cx"> return instrumentingAgentsForNonDocumentContext(context);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderTextTrackLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/TextTrackLoader.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/TextTrackLoader.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/loader/TextTrackLoader.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -117,7 +117,7 @@
</span><span class="cx"> void TextTrackLoader::corsPolicyPreventedLoad()
</span><span class="cx"> {
</span><span class="cx"> DEPRECATED_DEFINE_STATIC_LOCAL(String, consoleMessage, (ASCIILiteral("Cross-origin text track load denied by Cross-Origin Resource Sharing policy.")));
</span><del>- Document* document = toDocument(m_scriptExecutionContext);
</del><ins>+ Document* document = downcast<Document>(m_scriptExecutionContext);
</ins><span class="cx"> document->addConsoleMessage(MessageSource::Security, MessageLevel::Error, consoleMessage);
</span><span class="cx"> m_state = Failed;
</span><span class="cx"> }
</span><span class="lines">@@ -126,7 +126,7 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_resource == resource);
</span><span class="cx">
</span><del>- Document* document = toDocument(m_scriptExecutionContext);
</del><ins>+ Document* document = downcast<Document>(m_scriptExecutionContext);
</ins><span class="cx"> if (!m_crossOriginMode.isNull()
</span><span class="cx"> && !document->securityOrigin()->canRequest(resource->response().url())
</span><span class="cx"> && !resource->passesAccessControlCheck(document->securityOrigin())) {
</span><span class="lines">@@ -155,8 +155,8 @@
</span><span class="cx"> {
</span><span class="cx"> cancelLoad();
</span><span class="cx">
</span><del>- ASSERT(m_scriptExecutionContext->isDocument());
- Document* document = toDocument(m_scriptExecutionContext);
</del><ins>+ ASSERT(is<Document>(m_scriptExecutionContext));
+ Document* document = downcast<Document>(m_scriptExecutionContext);
</ins><span class="cx"> CachedResourceRequest cueRequest(ResourceRequest(document->completeURL(url)));
</span><span class="cx">
</span><span class="cx"> if (!crossOriginMode.isNull()) {
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderThreadableLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/ThreadableLoader.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/ThreadableLoader.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/loader/ThreadableLoader.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -59,7 +59,7 @@
</span><span class="cx"> if (context->isWorkerGlobalScope())
</span><span class="cx"> return WorkerThreadableLoader::create(toWorkerGlobalScope(context), client, WorkerRunLoop::defaultMode(), request, options);
</span><span class="cx">
</span><del>- return DocumentThreadableLoader::create(toDocument(*context), *client, request, options);
</del><ins>+ return DocumentThreadableLoader::create(downcast<Document>(*context), *client, request, options);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ThreadableLoader::loadResourceSynchronously(ScriptExecutionContext* context, const ResourceRequest& request, ThreadableLoaderClient& client, const ThreadableLoaderOptions& options)
</span><span class="lines">@@ -71,7 +71,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- DocumentThreadableLoader::loadResourceSynchronously(*toDocument(context), request, client, options);
</del><ins>+ DocumentThreadableLoader::loadResourceSynchronously(*downcast<Document>(context), request, client, options);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderWorkerThreadableLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -101,14 +101,14 @@
</span><span class="cx"> void WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader(ScriptExecutionContext& context, MainThreadBridge* thisPtr, PassOwnPtr<CrossThreadResourceRequestData> requestData, ThreadableLoaderOptions options, const String& outgoingReferrer)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(isMainThread());
</span><del>- Document* document = toDocument(&context);
</del><ins>+ Document& document = downcast<Document>(context);
</ins><span class="cx">
</span><span class="cx"> OwnPtr<ResourceRequest> request(ResourceRequest::adopt(requestData));
</span><span class="cx"> request->setHTTPReferrer(outgoingReferrer);
</span><span class="cx"> // FIXME: If the a site requests a local resource, then this will return a non-zero value but the sync path
</span><span class="cx"> // will return a 0 value. Either this should return 0 or the other code path should do a callback with
</span><span class="cx"> // a failure.
</span><del>- thisPtr->m_mainThreadLoader = DocumentThreadableLoader::create(*document, *thisPtr, *request, options);
</del><ins>+ thisPtr->m_mainThreadLoader = DocumentThreadableLoader::create(document, *thisPtr, *request, options);
</ins><span class="cx"> ASSERT(thisPtr->m_mainThreadLoader);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageContentSecurityPolicycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/ContentSecurityPolicy.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/ContentSecurityPolicy.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/page/ContentSecurityPolicy.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -1577,20 +1577,20 @@
</span><span class="cx"> m_scriptExecutionContext->enforceSandboxFlags(mask);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static String stripURLForUseInReport(Document* document, const URL& url)
</del><ins>+static String stripURLForUseInReport(Document& document, const URL& url)
</ins><span class="cx"> {
</span><span class="cx"> if (!url.isValid())
</span><span class="cx"> return String();
</span><span class="cx"> if (!url.isHierarchical() || url.protocolIs("file"))
</span><span class="cx"> return url.protocol();
</span><del>- return document->securityOrigin()->canRequest(url) ? url.strippedForUseAsReferrer() : SecurityOrigin::create(url)->toString();
</del><ins>+ return document.securityOrigin()->canRequest(url) ? url.strippedForUseAsReferrer() : SecurityOrigin::create(url)->toString();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CSP_NEXT)
</span><del>-static void gatherSecurityPolicyViolationEventData(SecurityPolicyViolationEventInit& init, Document* document, const String& directiveText, const String& effectiveDirective, const URL& blockedURL, const String& header)
</del><ins>+static void gatherSecurityPolicyViolationEventData(SecurityPolicyViolationEventInit& init, Document& document, const String& directiveText, const String& effectiveDirective, const URL& blockedURL, const String& header)
</ins><span class="cx"> {
</span><del>- init.documentURI = document->url().string();
- init.referrer = document->referrer();
</del><ins>+ init.documentURI = document.url().string();
+ init.referrer = document.referrer();
</ins><span class="cx"> init.blockedURI = stripURLForUseInReport(document, blockedURL);
</span><span class="cx"> init.violatedDirective = directiveText;
</span><span class="cx"> init.effectiveDirective = effectiveDirective;
</span><span class="lines">@@ -1613,11 +1613,11 @@
</span><span class="cx"> logToConsole(consoleMessage, contextURL, contextLine, state);
</span><span class="cx">
</span><span class="cx"> // FIXME: Support sending reports from worker.
</span><del>- if (!m_scriptExecutionContext->isDocument())
</del><ins>+ if (!is<Document>(*m_scriptExecutionContext))
</ins><span class="cx"> return;
</span><span class="cx">
</span><del>- Document* document = toDocument(m_scriptExecutionContext);
- Frame* frame = document->frame();
</del><ins>+ Document& document = downcast<Document>(*m_scriptExecutionContext);
+ Frame* frame = document.frame();
</ins><span class="cx"> if (!frame)
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="lines">@@ -1626,7 +1626,7 @@
</span><span class="cx"> // FIXME: This code means that we're gathering information like line numbers twice. Once we can bring this out from behind the flag, we should reuse the data gathered here when generating the JSON report below.
</span><span class="cx"> SecurityPolicyViolationEventInit init;
</span><span class="cx"> gatherSecurityPolicyViolationEventData(init, document, directiveText, effectiveDirective, blockedURL, header);
</span><del>- document->enqueueDocumentEvent(SecurityPolicyViolationEvent::create(eventNames().securitypolicyviolationEvent, init));
</del><ins>+ document.enqueueDocumentEvent(SecurityPolicyViolationEvent::create(eventNames().securitypolicyviolationEvent, init));
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -1644,8 +1644,8 @@
</span><span class="cx"> // harmless information.
</span><span class="cx">
</span><span class="cx"> RefPtr<InspectorObject> cspReport = InspectorObject::create();
</span><del>- cspReport->setString(ASCIILiteral("document-uri"), document->url().strippedForUseAsReferrer());
- cspReport->setString(ASCIILiteral("referrer"), document->referrer());
</del><ins>+ cspReport->setString(ASCIILiteral("document-uri"), document.url().strippedForUseAsReferrer());
+ cspReport->setString(ASCIILiteral("referrer"), document.referrer());
</ins><span class="cx"> cspReport->setString(ASCIILiteral("violated-directive"), directiveText);
</span><span class="cx"> #if ENABLE(CSP_NEXT)
</span><span class="cx"> if (experimentalFeaturesEnabled())
</span></span></pre></div>
<a id="trunkSourceWebCorepageCryptocpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Crypto.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Crypto.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/page/Crypto.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -59,7 +59,7 @@
</span><span class="cx">
</span><span class="cx"> Document* Crypto::document() const
</span><span class="cx"> {
</span><del>- return toDocument(scriptExecutionContext());
</del><ins>+ return downcast<Document>(scriptExecutionContext());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Crypto::getRandomValues(ArrayBufferView* array, ExceptionCode& ec)
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMTimercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMTimer.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMTimer.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/page/DOMTimer.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -120,8 +120,8 @@
</span><span class="cx"> // is destroyed, or if explicitly cancelled by removeById.
</span><span class="cx"> DOMTimer* timer = new DOMTimer(context, WTF::move(action), timeout, singleShot);
</span><span class="cx"> #if PLATFORM(IOS)
</span><del>- if (context->isDocument()) {
- Document& document = toDocument(*context);
</del><ins>+ if (is<Document>(context)) {
+ Document& document = downcast<Document>(*context);
</ins><span class="cx"> bool didDeferTimeout = document.frame() && document.frame()->timersPaused();
</span><span class="cx"> if (!didDeferTimeout && timeout <= 100 && singleShot) {
</span><span class="cx"> WKSetObservedContentChange(WKContentIndeterminateChange);
</span><span class="lines">@@ -173,8 +173,8 @@
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> Document* document = nullptr;
</span><del>- if (context->isDocument()) {
- document = toDocument(context);
</del><ins>+ if (is<Document>(context)) {
+ document = downcast<Document>(context);
</ins><span class="cx"> ASSERT(!document->frame()->timersPaused());
</span><span class="cx"> }
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMWindowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMWindow.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMWindow.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/page/DOMWindow.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -973,8 +973,8 @@
</span><span class="cx"> bool allowFocus = WindowFocusAllowedIndicator::windowFocusAllowed() || !m_frame->settings().windowFocusRestricted();
</span><span class="cx"> if (context) {
</span><span class="cx"> ASSERT(isMainThread());
</span><del>- Document* activeDocument = toDocument(context);
- if (opener() && opener() != this && activeDocument->domWindow() == opener())
</del><ins>+ Document& activeDocument = downcast<Document>(*context);
+ if (opener() && opener() != this && activeDocument.domWindow() == opener())
</ins><span class="cx"> allowFocus = true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1025,12 +1025,8 @@
</span><span class="cx">
</span><span class="cx"> if (context) {
</span><span class="cx"> ASSERT(isMainThread());
</span><del>- Document* activeDocument = toDocument(context);
- if (!activeDocument)
</del><ins>+ if (!downcast<Document>(*context).canNavigate(m_frame))
</ins><span class="cx"> return;
</span><del>-
- if (!activeDocument->canNavigate(m_frame))
- return;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool allowScriptsToCloseWindows = m_frame->settings().allowScriptsToCloseWindows();
</span><span class="lines">@@ -1413,24 +1409,24 @@
</span><span class="cx"> Document* DOMWindow::document() const
</span><span class="cx"> {
</span><span class="cx"> ScriptExecutionContext* context = ContextDestructionObserver::scriptExecutionContext();
</span><del>- return toDocument(context);
</del><ins>+ return downcast<Document>(context);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<StyleMedia> DOMWindow::styleMedia() const
</span><span class="cx"> {
</span><span class="cx"> if (!isCurrentlyDisplayedInFrame())
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> if (!m_media)
</span><span class="cx"> m_media = StyleMedia::create(m_frame);
</span><span class="cx"> return m_media.get();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CSSStyleDeclaration> DOMWindow::getComputedStyle(Element* elt, const String& pseudoElt) const
</del><ins>+PassRefPtr<CSSStyleDeclaration> DOMWindow::getComputedStyle(Element* element, const String& pseudoElt) const
</ins><span class="cx"> {
</span><del>- if (!elt)
- return 0;
</del><ins>+ if (!element)
+ return nullptr;
</ins><span class="cx">
</span><del>- return CSSComputedStyleDeclaration::create(elt, false, pseudoElt);
</del><ins>+ return CSSComputedStyleDeclaration::create(element, false, pseudoElt);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<CSSRuleList> DOMWindow::getMatchedCSSRules(Element* element, const String& pseudoElement, bool authorOnly) const
</span></span></pre></div>
<a id="trunkSourceWebCorepageDragControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DragController.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DragController.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/page/DragController.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -192,10 +192,10 @@
</span><span class="cx"> m_page.mainFrame().eventHandler().cancelDragAndDrop(createMouseEvent(dragData), dataTransfer.get());
</span><span class="cx"> dataTransfer->setAccessPolicy(DataTransferAccessPolicy::Numb); // Invalidate dataTransfer here for security.
</span><span class="cx"> }
</span><del>- mouseMovedIntoDocument(0);
</del><ins>+ mouseMovedIntoDocument(nullptr);
</ins><span class="cx"> if (m_fileInputElementUnderMouse)
</span><span class="cx"> m_fileInputElementUnderMouse->setCanReceiveDroppedFiles(false);
</span><del>- m_fileInputElementUnderMouse = 0;
</del><ins>+ m_fileInputElementUnderMouse = nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> DragOperation DragController::dragUpdated(DragData& dragData)
</span><span class="lines">@@ -255,7 +255,7 @@
</span><span class="cx">
</span><span class="cx"> m_dragDestinationAction = m_client.actionMaskForDrag(dragData);
</span><span class="cx"> if (m_dragDestinationAction == DragDestinationActionNone) {
</span><del>- cancelDrag(); // FIXME: Why not call mouseMovedIntoDocument(0)?
</del><ins>+ cancelDrag(); // FIXME: Why not call mouseMovedIntoDocument(nullptr)?
</ins><span class="cx"> return DragOperationNone;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageEventSourcecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/EventSource.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/EventSource.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/page/EventSource.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -77,25 +77,25 @@
</span><span class="cx"> {
</span><span class="cx"> if (url.isEmpty()) {
</span><span class="cx"> ec = SYNTAX_ERR;
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> URL fullURL = context.completeURL(url);
</span><span class="cx"> if (!fullURL.isValid()) {
</span><span class="cx"> ec = SYNTAX_ERR;
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // FIXME: Convert this to check the isolated world's Content Security Policy once webkit.org/b/104520 is solved.
</span><span class="cx"> bool shouldBypassMainWorldContentSecurityPolicy = false;
</span><del>- if (context.isDocument()) {
- Document& document = toDocument(context);
</del><ins>+ if (is<Document>(context)) {
+ Document& document = downcast<Document>(context);
</ins><span class="cx"> shouldBypassMainWorldContentSecurityPolicy = document.frame()->script().shouldBypassMainWorldContentSecurityPolicy();
</span><span class="cx"> }
</span><span class="cx"> if (!shouldBypassMainWorldContentSecurityPolicy && !context.contentSecurityPolicy()->allowConnectToSource(fullURL)) {
</span><span class="cx"> // FIXME: Should this be throwing an exception?
</span><span class="cx"> ec = SECURITY_ERR;
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RefPtr<EventSource> source = adoptRef(new EventSource(context, fullURL, eventSourceInit));
</span></span></pre></div>
<a id="trunkSourceWebCorepageFocusControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FocusController.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FocusController.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/page/FocusController.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -876,8 +876,8 @@
</span><span class="cx"> Element* focusedElement = focusedDocument->focusedElement();
</span><span class="cx"> Node* container = focusedDocument;
</span><span class="cx">
</span><del>- if (container->isDocumentNode())
- toDocument(container)->updateLayoutIgnorePendingStylesheets();
</del><ins>+ if (is<Document>(container))
+ downcast<Document>(*container).updateLayoutIgnorePendingStylesheets();
</ins><span class="cx">
</span><span class="cx"> // Figure out the starting rect.
</span><span class="cx"> LayoutRect startingRect;
</span><span class="lines">@@ -900,8 +900,8 @@
</span><span class="cx"> consumed = advanceFocusDirectionallyInContainer(container, startingRect, direction, event);
</span><span class="cx"> startingRect = nodeRectInAbsoluteCoordinates(container, true /* ignore border */);
</span><span class="cx"> container = scrollableEnclosingBoxOrParentFrameForNodeInDirection(direction, container);
</span><del>- if (container && container->isDocumentNode())
- toDocument(container)->updateLayoutIgnorePendingStylesheets();
</del><ins>+ if (container && is<Document>(container))
+ downcast<Document>(*container).updateLayoutIgnorePendingStylesheets();
</ins><span class="cx"> } while (!consumed && container);
</span><span class="cx">
</span><span class="cx"> return consumed;
</span></span></pre></div>
<a id="trunkSourceWebCorepageHistorycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/History.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/History.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/page/History.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -117,7 +117,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> ASSERT(isMainThread());
</span><del>- Document* activeDocument = toDocument(context);
</del><ins>+ Document* activeDocument = downcast<Document>(context);
</ins><span class="cx"> if (!activeDocument)
</span><span class="cx"> return;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageSpatialNavigationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/SpatialNavigation.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/SpatialNavigation.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/page/SpatialNavigation.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -366,8 +366,8 @@
</span><span class="cx"> bool scrollInDirection(Node* container, FocusDirection direction)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(container);
</span><del>- if (container->isDocumentNode())
- return scrollInDirection(toDocument(container)->frame(), direction);
</del><ins>+ if (is<Document>(container))
+ return scrollInDirection(downcast<Document>(*container).frame(), direction);
</ins><span class="cx">
</span><span class="cx"> if (!container->renderBox())
</span><span class="cx"> return false;
</span><span class="lines">@@ -435,11 +435,11 @@
</span><span class="cx"> ASSERT(node);
</span><span class="cx"> Node* parent = node;
</span><span class="cx"> do {
</span><del>- if (parent->isDocumentNode())
- parent = toDocument(parent)->document().frame()->ownerElement();
</del><ins>+ if (is<Document>(parent))
+ parent = downcast<Document>(*parent).document().frame()->ownerElement();
</ins><span class="cx"> else
</span><span class="cx"> parent = parent->parentNode();
</span><del>- } while (parent && !canScrollInDirection(parent, direction) && !parent->isDocumentNode());
</del><ins>+ } while (parent && !canScrollInDirection(parent, direction) && !is<Document>(parent));
</ins><span class="cx">
</span><span class="cx"> return parent;
</span><span class="cx"> }
</span><span class="lines">@@ -451,8 +451,8 @@
</span><span class="cx"> if (is<HTMLSelectElement>(container))
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- if (container->isDocumentNode())
- return canScrollInDirection(toDocument(container)->frame(), direction);
</del><ins>+ if (is<Document>(container))
+ return canScrollInDirection(downcast<Document>(*container).frame(), direction);
</ins><span class="cx">
</span><span class="cx"> if (!isScrollableNode(container))
</span><span class="cx"> return false;
</span><span class="lines">@@ -520,8 +520,8 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(node && node->renderer() && !node->document().view()->needsLayout());
</span><span class="cx">
</span><del>- if (node->isDocumentNode())
- return frameRectInAbsoluteCoordinates(toDocument(node)->frame());
</del><ins>+ if (is<Document>(node))
+ return frameRectInAbsoluteCoordinates(downcast<Document>(*node).frame());
</ins><span class="cx"> LayoutRect rect = rectToAbsoluteCoordinates(node->document().frame(), node->boundingBox());
</span><span class="cx">
</span><span class="cx"> // For authors that use border instead of outline in their CSS, we compensate by ignoring the border when calculating
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGDocument.h (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGDocument.h 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/svg/SVGDocument.h 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx">
</span><span class="cx"> SPECIALIZE_TYPE_TRAITS_BEGIN(SVGDocument)
</span><span class="cx"> static bool isSVGDocument(const Document& document) { return document.isSVGDocument(); }
</span><del>- static bool isSVGDocument(const Node& node) { return node.isDocumentNode() && isSVGDocument(toDocument(node)); }
</del><ins>+ static bool isSVGDocument(const Node& node) { return is<Document>(node) && isSVGDocument(downcast<Document>(node)); }
</ins><span class="cx"> SPECIALIZE_TYPE_TRAITS_END()
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/testing/Internals.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -319,13 +319,13 @@
</span><span class="cx">
</span><span class="cx"> Document* Internals::contextDocument() const
</span><span class="cx"> {
</span><del>- return toDocument(scriptExecutionContext());
</del><ins>+ return downcast<Document>(scriptExecutionContext());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Frame* Internals::frame() const
</span><span class="cx"> {
</span><span class="cx"> if (!contextDocument())
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> return contextDocument()->frame();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1916,8 +1916,8 @@
</span><span class="cx"> Document* document;
</span><span class="cx"> if (!node)
</span><span class="cx"> document = contextDocument();
</span><del>- else if (node->isDocumentNode())
- document = toDocument(node);
</del><ins>+ else if (is<Document>(node))
+ document = downcast<Document>(node);
</ins><span class="cx"> else if (is<HTMLIFrameElement>(node))
</span><span class="cx"> document = downcast<HTMLIFrameElement>(*node).contentDocument();
</span><span class="cx"> else {
</span></span></pre></div>
<a id="trunkSourceWebCoretestingjsWebCoreTestSupportcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -46,8 +46,8 @@
</span><span class="cx"> JSLockHolder lock(exec);
</span><span class="cx"> JSDOMGlobalObject* globalObject = jsCast<JSDOMGlobalObject*>(exec->lexicalGlobalObject());
</span><span class="cx"> ScriptExecutionContext* scriptContext = globalObject->scriptExecutionContext();
</span><del>- if (scriptContext->isDocument())
- globalObject->putDirect(exec->vm(), Identifier(exec, Internals::internalsId), toJS(exec, globalObject, Internals::create(toDocument(scriptContext))));
</del><ins>+ if (is<Document>(scriptContext))
+ globalObject->putDirect(exec->vm(), Identifier(exec, Internals::internalsId), toJS(exec, globalObject, Internals::create(downcast<Document>(scriptContext))));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void resetInternalsObject(JSContextRef context)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx"> JSLockHolder lock(exec);
</span><span class="cx"> JSDOMGlobalObject* globalObject = jsCast<JSDOMGlobalObject*>(exec->lexicalGlobalObject());
</span><span class="cx"> ScriptExecutionContext* scriptContext = globalObject->scriptExecutionContext();
</span><del>- Page* page = toDocument(scriptContext)->frame()->page();
</del><ins>+ Page* page = downcast<Document>(scriptContext)->frame()->page();
</ins><span class="cx"> Internals::resetToConsistentState(page);
</span><span class="cx"> InternalSettings::from(page)->resetToConsistentState();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersDefaultSharedWorkerRepositorycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/DefaultSharedWorkerRepository.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/DefaultSharedWorkerRepository.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/workers/DefaultSharedWorkerRepository.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -228,7 +228,7 @@
</span><span class="cx"> ASSERT(context);
</span><span class="cx"> ASSERT(!isClosing());
</span><span class="cx"> MutexLocker lock(m_workerDocumentsLock);
</span><del>- m_workerDocuments.add(toDocument(context));
</del><ins>+ m_workerDocuments.add(downcast<Document>(context));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void SharedWorkerProxy::documentDetached(Document* document)
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerMessagingProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -83,11 +83,11 @@
</span><span class="cx"> {
</span><span class="cx"> // FIXME: This need to be revisited when we support nested worker one day
</span><span class="cx"> ASSERT(m_scriptExecutionContext);
</span><del>- Document* document = toDocument(m_scriptExecutionContext);
- GroupSettings* settings = 0;
- if (document->page())
- settings = &document->page()->group().groupSettings();
- RefPtr<DedicatedWorkerThread> thread = DedicatedWorkerThread::create(scriptURL, userAgent, settings, sourceCode, *this, *this, startMode, document->contentSecurityPolicy()->deprecatedHeader(), document->contentSecurityPolicy()->deprecatedHeaderType(), document->topOrigin());
</del><ins>+ Document& document = downcast<Document>(*m_scriptExecutionContext);
+ GroupSettings* settings = nullptr;
+ if (document.page())
+ settings = &document.page()->group().groupSettings();
+ RefPtr<DedicatedWorkerThread> thread = DedicatedWorkerThread::create(scriptURL, userAgent, settings, sourceCode, *this, *this, startMode, document.contentSecurityPolicy()->deprecatedHeader(), document.contentSecurityPolicy()->deprecatedHeaderType(), document.topOrigin());
</ins><span class="cx"> workerThreadCreated(thread);
</span><span class="cx"> thread->start();
</span><span class="cx"> InspectorInstrumentation::didStartWorkerGlobalScope(m_scriptExecutionContext.get(), this, scriptURL);
</span></span></pre></div>
<a id="trunkSourceWebCorexmlXMLHttpRequestcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -155,7 +155,7 @@
</span><span class="cx"> Document* XMLHttpRequest::document() const
</span><span class="cx"> {
</span><span class="cx"> ASSERT(scriptExecutionContext());
</span><del>- return toDocument(scriptExecutionContext());
</del><ins>+ return downcast<Document>(scriptExecutionContext());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> SecurityOrigin* XMLHttpRequest::securityOrigin() const
</span><span class="lines">@@ -487,10 +487,10 @@
</span><span class="cx">
</span><span class="cx"> // FIXME: Convert this to check the isolated world's Content Security Policy once webkit.org/b/104520 is solved.
</span><span class="cx"> bool shouldBypassMainWorldContentSecurityPolicy = false;
</span><del>- if (scriptExecutionContext()->isDocument()) {
- Document* document = toDocument(scriptExecutionContext());
- if (document->frame())
- shouldBypassMainWorldContentSecurityPolicy = document->frame()->script().shouldBypassMainWorldContentSecurityPolicy();
</del><ins>+ if (is<Document>(scriptExecutionContext())) {
+ Document& document = downcast<Document>(*scriptExecutionContext());
+ if (document.frame())
+ shouldBypassMainWorldContentSecurityPolicy = document.frame()->script().shouldBypassMainWorldContentSecurityPolicy();
</ins><span class="cx"> }
</span><span class="cx"> if (!shouldBypassMainWorldContentSecurityPolicy && !scriptExecutionContext()->contentSecurityPolicy()->allowConnectToSource(url)) {
</span><span class="cx"> // FIXME: Should this be throwing an exception?
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebKit2/ChangeLog 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-09-29 Christophe Dumez <cdumez@apple.com>
+
+ Use is<>() / downcast<>() for Document
+ https://bugs.webkit.org/show_bug.cgi?id=137221
+
+ Reviewed by Andreas Kling.
+
+ Use is<>() / downcast<>() for Document instead of isDocumentNode() /
+ toDocument().
+
+ * WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:
+ (-[WKDOMDocument createElement:]):
+ (-[WKDOMDocument createTextNode:]):
+ (-[WKDOMDocument body]):
+
</ins><span class="cx"> 2014-09-29 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r174045.
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessInjectedBundleAPImacWKDOMDocumentmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm (174088 => 174089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm 2014-09-29 22:14:13 UTC (rev 174088)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm 2014-09-29 22:23:20 UTC (rev 174089)
</span><span class="lines">@@ -39,17 +39,17 @@
</span><span class="cx"> {
</span><span class="cx"> // FIXME: Do something about the exception.
</span><span class="cx"> WebCore::ExceptionCode ec = 0;
</span><del>- return WebKit::toWKDOMElement(toDocument(_impl.get())->createElement(tagName, ec).get());
</del><ins>+ return WebKit::toWKDOMElement(WebCore::downcast<WebCore::Document>(*_impl).createElement(tagName, ec).get());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (WKDOMText *)createTextNode:(NSString *)data
</span><span class="cx"> {
</span><del>- return WebKit::toWKDOMText(toDocument(_impl.get())->createTextNode(data).get());
</del><ins>+ return WebKit::toWKDOMText(WebCore::downcast<WebCore::Document>(*_impl).createTextNode(data).get());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (WKDOMElement *)body
</span><span class="cx"> {
</span><del>- return WebKit::toWKDOMElement(toDocument(_impl.get())->body());
</del><ins>+ return WebKit::toWKDOMElement(WebCore::downcast<WebCore::Document>(*_impl).body());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> @end
</span></span></pre>
</div>
</div>
</body>
</html>