<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[174043] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/174043">174043</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2014-09-28 01:18:07 -0700 (Sun, 28 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[ATK] WebKitAccessibleWrapperAtk should not depend on GTK
https://bugs.webkit.org/show_bug.cgi?id=137177
Reviewed by Martin Robinson.
It's used to get the web view widget, but there's no GtkWidget in
the web process and platformPageClient is always NULL.
* PlatformGTK.cmake: Move accessibility sources to the WebCore
sources list.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkParentOfRootObject): Remove code to get view GtkWidget.
* editing/atk/FrameSelectionAtk.cpp: Remove unneeded header include.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorePlatformGTKcmake">trunk/Source/WebCore/PlatformGTK.cmake</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp">trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingatkFrameSelectionAtkcpp">trunk/Source/WebCore/editing/atk/FrameSelectionAtk.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (174042 => 174043)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-09-28 08:14:51 UTC (rev 174042)
+++ trunk/Source/WebCore/ChangeLog 2014-09-28 08:18:07 UTC (rev 174043)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2014-09-28 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><ins>+ [ATK] WebKitAccessibleWrapperAtk should not depend on GTK
+ https://bugs.webkit.org/show_bug.cgi?id=137177
+
+ Reviewed by Martin Robinson.
+
+ It's used to get the web view widget, but there's no GtkWidget in
+ the web process and platformPageClient is always NULL.
+
+ * PlatformGTK.cmake: Move accessibility sources to the WebCore
+ sources list.
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (atkParentOfRootObject): Remove code to get view GtkWidget.
+ * editing/atk/FrameSelectionAtk.cpp: Remove unneeded header include.
+
+2014-09-28 Carlos Garcia Campos <cgarcia@igalia.com>
+
</ins><span class="cx"> [GTK] Remove unused GtkPluginWidget
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=137176
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorePlatformGTKcmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/PlatformGTK.cmake (174042 => 174043)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/PlatformGTK.cmake 2014-09-28 08:14:51 UTC (rev 174042)
+++ trunk/Source/WebCore/PlatformGTK.cmake 2014-09-28 08:18:07 UTC (rev 174043)
</span><span class="lines">@@ -25,6 +25,25 @@
</span><span class="cx"> )
</span><span class="cx">
</span><span class="cx"> list(APPEND WebCore_SOURCES
</span><ins>+ accessibility/atk/AXObjectCacheAtk.cpp
+ accessibility/atk/AccessibilityObjectAtk.cpp
+ accessibility/atk/WebKitAccessibleHyperlink.cpp
+ accessibility/atk/WebKitAccessibleInterfaceAction.cpp
+ accessibility/atk/WebKitAccessibleInterfaceComponent.cpp
+ accessibility/atk/WebKitAccessibleInterfaceDocument.cpp
+ accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp
+ accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.cpp
+ accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp
+ accessibility/atk/WebKitAccessibleInterfaceImage.cpp
+ accessibility/atk/WebKitAccessibleInterfaceSelection.cpp
+ accessibility/atk/WebKitAccessibleInterfaceTable.cpp
+ accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp
+ accessibility/atk/WebKitAccessibleInterfaceText.cpp
+ accessibility/atk/WebKitAccessibleInterfaceValue.cpp
+ accessibility/atk/WebKitAccessibleUtil.cpp
+ accessibility/atk/WebKitAccessibleWrapperAtk.cpp
+
+ editing/atk/FrameSelectionAtk.cpp
</ins><span class="cx"> editing/SmartReplace.cpp
</span><span class="cx">
</span><span class="cx"> loader/soup/CachedRawResourceSoup.cpp
</span><span class="lines">@@ -162,25 +181,6 @@
</span><span class="cx"> )
</span><span class="cx">
</span><span class="cx"> list(APPEND WebCorePlatformGTK_SOURCES
</span><del>- accessibility/atk/AXObjectCacheAtk.cpp
- accessibility/atk/AccessibilityObjectAtk.cpp
- accessibility/atk/WebKitAccessibleHyperlink.cpp
- accessibility/atk/WebKitAccessibleInterfaceAction.cpp
- accessibility/atk/WebKitAccessibleInterfaceComponent.cpp
- accessibility/atk/WebKitAccessibleInterfaceDocument.cpp
- accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp
- accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.cpp
- accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp
- accessibility/atk/WebKitAccessibleInterfaceImage.cpp
- accessibility/atk/WebKitAccessibleInterfaceSelection.cpp
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp
- accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp
- accessibility/atk/WebKitAccessibleInterfaceText.cpp
- accessibility/atk/WebKitAccessibleInterfaceValue.cpp
- accessibility/atk/WebKitAccessibleUtil.cpp
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp
-
- editing/atk/FrameSelectionAtk.cpp
</del><span class="cx"> editing/gtk/EditorGtk.cpp
</span><span class="cx">
</span><span class="cx"> page/gtk/DragControllerGtk.cpp
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityatkWebKitAccessibleWrapperAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (174042 => 174043)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2014-09-28 08:14:51 UTC (rev 174042)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2014-09-28 08:18:07 UTC (rev 174043)
</span><span class="lines">@@ -65,10 +65,6 @@
</span><span class="cx"> #include <glib/gprintf.h>
</span><span class="cx"> #include <wtf/text/CString.h>
</span><span class="cx">
</span><del>-#if PLATFORM(GTK)
-#include <gtk/gtk.h>
-#endif
-
</del><span class="cx"> using namespace WebCore;
</span><span class="cx">
</span><span class="cx"> struct _WebKitAccessiblePrivate {
</span><span class="lines">@@ -294,18 +290,6 @@
</span><span class="cx"> Document* document = coreObject->document();
</span><span class="cx"> if (!document)
</span><span class="cx"> return 0;
</span><del>-
-#if PLATFORM(GTK)
- HostWindow* hostWindow = document->view()->hostWindow();
- if (hostWindow) {
- PlatformPageClient scrollView = hostWindow->platformPageClient();
- if (scrollView) {
- GtkWidget* scrollViewParent = gtk_widget_get_parent(scrollView);
- if (scrollViewParent)
- return gtk_widget_get_accessible(scrollViewParent);
- }
- }
-#endif // PLATFORM(GTK)
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!coreParent)
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingatkFrameSelectionAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/atk/FrameSelectionAtk.cpp (174042 => 174043)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/atk/FrameSelectionAtk.cpp 2014-09-28 08:14:51 UTC (rev 174042)
+++ trunk/Source/WebCore/editing/atk/FrameSelectionAtk.cpp 2014-09-28 08:18:07 UTC (rev 174043)
</span><span class="lines">@@ -26,13 +26,7 @@
</span><span class="cx"> #include "Document.h"
</span><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "WebKitAccessibleWrapperAtk.h"
</span><del>-
-#if PLATFORM(EFL)
</del><span class="cx"> #include <glib.h>
</span><del>-#else
-#include <gtk/gtk.h>
-#endif
-
</del><span class="cx"> #include <wtf/NeverDestroyed.h>
</span><span class="cx"> #include <wtf/RefPtr.h>
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>