<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173921] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173921">173921</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2014-09-24 08:56:26 -0700 (Wed, 24 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use is<SVG*Element>() instead of isSVG*Element()
https://bugs.webkit.org/show_bug.cgi?id=137058
Reviewed by Dirk Schulze.
Use is<SVG*Element>() instead of isSVG*Element() and drop support for
generated isSVG*Element().
No new tests, no behavior change.
* css/CSSCursorImageValue.cpp:
(WebCore::resourceReferencedByCursorElement):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::useSVGZoomRulesForLength):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
* dom/ScriptElement.cpp:
(WebCore::toScriptElementIfPossible):
* dom/make_names.pl:
(printTypeHelpers):
* editing/gtk/EditorGtk.cpp:
(WebCore::elementURL):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::isLiveLink):
* rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):
* rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
* rendering/svg/SVGPathData.cpp:
(WebCore::updatePathFromCircleElement):
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):
* rendering/svg/SVGResources.cpp:
(WebCore::targetReferenceFromResource):
* svg/SVGAltGlyphDefElement.cpp:
(WebCore::SVGAltGlyphDefElement::hasValidGlyphElements):
* svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::hasValidGlyphElements):
* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
* svg/SVGDocument.cpp:
(WebCore::SVGDocument::rootElement):
* svg/SVGElement.cpp:
(WebCore::SVGElement::isOutermostSVGSVGElement):
(WebCore::SVGElement::ownerSVGElement):
(WebCore::SVGElement::viewportElement):
* svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::build):
* svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::findLightElement):
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
* svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::ensureGlyphCache):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::associatedFontElement):
(WebCore::SVGFontFaceElement::rebuildFontFace):
* svg/SVGFontFaceSrcElement.cpp:
(WebCore::SVGFontFaceSrcElement::srcValue):
(WebCore::SVGFontFaceSrcElement::childrenChanged):
* svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::invalidateGlyphCache):
* svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):
* svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::determineViewport):
* svg/SVGLocatable.cpp:
(WebCore::isViewportElement):
* svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::pathElement):
(WebCore::SVGMPathElement::notifyParentOfPathChange):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::invalidateMPathDependencies):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPatternAttributes):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setupInitialView):
* svg/SVGUseElement.cpp:
(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
* svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSCursorImageValuecpp">trunk/Source/WebCore/css/CSSCursorImageValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssStyleResolvercpp">trunk/Source/WebCore/css/StyleResolver.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumentStyleSheetCollectioncpp">trunk/Source/WebCore/dom/DocumentStyleSheetCollection.cpp</a></li>
<li><a href="#trunkSourceWebCoredomScriptElementcpp">trunk/Source/WebCore/dom/ScriptElement.cpp</a></li>
<li><a href="#trunkSourceWebCoredommake_namespl">trunk/Source/WebCore/dom/make_names.pl</a></li>
<li><a href="#trunkSourceWebCoreeditinggtkEditorGtkcpp">trunk/Source/WebCore/editing/gtk/EditorGtk.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingHitTestResultcpp">trunk/Source/WebCore/rendering/HitTestResult.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGEllipsecpp">trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGTransformableContainercpp">trunk/Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgSVGPathDatacpp">trunk/Source/WebCore/rendering/svg/SVGPathData.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgSVGRenderTreeAsTextcpp">trunk/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgSVGResourcescpp">trunk/Source/WebCore/rendering/svg/SVGResources.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGAltGlyphDefElementcpp">trunk/Source/WebCore/svg/SVGAltGlyphDefElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGAltGlyphElementcpp">trunk/Source/WebCore/svg/SVGAltGlyphElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGAnimateMotionElementcpp">trunk/Source/WebCore/svg/SVGAnimateMotionElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGDocumentcpp">trunk/Source/WebCore/svg/SVGDocument.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGElementcpp">trunk/Source/WebCore/svg/SVGElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGFEComponentTransferElementcpp">trunk/Source/WebCore/svg/SVGFEComponentTransferElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGFELightElementcpp">trunk/Source/WebCore/svg/SVGFELightElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGFontDatacpp">trunk/Source/WebCore/svg/SVGFontData.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGFontElementcpp">trunk/Source/WebCore/svg/SVGFontElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGFontFaceElementcpp">trunk/Source/WebCore/svg/SVGFontFaceElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGFontFaceSrcElementcpp">trunk/Source/WebCore/svg/SVGFontFaceSrcElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGGlyphElementcpp">trunk/Source/WebCore/svg/SVGGlyphElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGHKernElementcpp">trunk/Source/WebCore/svg/SVGHKernElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGLengthContextcpp">trunk/Source/WebCore/svg/SVGLengthContext.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGLocatablecpp">trunk/Source/WebCore/svg/SVGLocatable.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGMPathElementcpp">trunk/Source/WebCore/svg/SVGMPathElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGPathElementcpp">trunk/Source/WebCore/svg/SVGPathElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGPatternElementcpp">trunk/Source/WebCore/svg/SVGPatternElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGSVGElementcpp">trunk/Source/WebCore/svg/SVGSVGElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGUseElementcpp">trunk/Source/WebCore/svg/SVGUseElement.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGVKernElementcpp">trunk/Source/WebCore/svg/SVGVKernElement.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/ChangeLog        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -1,3 +1,91 @@
</span><ins>+2014-09-24 Christophe Dumez <cdumez@apple.com>
+
+ Use is<SVG*Element>() instead of isSVG*Element()
+ https://bugs.webkit.org/show_bug.cgi?id=137058
+
+ Reviewed by Dirk Schulze.
+
+ Use is<SVG*Element>() instead of isSVG*Element() and drop support for
+ generated isSVG*Element().
+
+ No new tests, no behavior change.
+
+ * css/CSSCursorImageValue.cpp:
+ (WebCore::resourceReferencedByCursorElement):
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::useSVGZoomRulesForLength):
+ * dom/DocumentStyleSheetCollection.cpp:
+ (WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
+ * dom/ScriptElement.cpp:
+ (WebCore::toScriptElementIfPossible):
+ * dom/make_names.pl:
+ (printTypeHelpers):
+ * editing/gtk/EditorGtk.cpp:
+ (WebCore::elementURL):
+ * rendering/HitTestResult.cpp:
+ (WebCore::HitTestResult::absoluteImageURL):
+ (WebCore::HitTestResult::isLiveLink):
+ * rendering/svg/RenderSVGEllipse.cpp:
+ (WebCore::RenderSVGEllipse::calculateRadiiAndCenter):
+ * rendering/svg/RenderSVGTransformableContainer.cpp:
+ (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
+ * rendering/svg/SVGPathData.cpp:
+ (WebCore::updatePathFromCircleElement):
+ * rendering/svg/SVGRenderTreeAsText.cpp:
+ (WebCore::operator<<):
+ * rendering/svg/SVGResources.cpp:
+ (WebCore::targetReferenceFromResource):
+ * svg/SVGAltGlyphDefElement.cpp:
+ (WebCore::SVGAltGlyphDefElement::hasValidGlyphElements):
+ * svg/SVGAltGlyphElement.cpp:
+ (WebCore::SVGAltGlyphElement::hasValidGlyphElements):
+ * svg/SVGAnimateMotionElement.cpp:
+ (WebCore::SVGAnimateMotionElement::hasValidAttributeType):
+ * svg/SVGDocument.cpp:
+ (WebCore::SVGDocument::rootElement):
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::isOutermostSVGSVGElement):
+ (WebCore::SVGElement::ownerSVGElement):
+ (WebCore::SVGElement::viewportElement):
+ * svg/SVGFEComponentTransferElement.cpp:
+ (WebCore::SVGFEComponentTransferElement::build):
+ * svg/SVGFELightElement.cpp:
+ (WebCore::SVGFELightElement::findLightElement):
+ * svg/SVGFontData.cpp:
+ (WebCore::SVGFontData::applySVGGlyphSelection):
+ * svg/SVGFontElement.cpp:
+ (WebCore::SVGFontElement::ensureGlyphCache):
+ * svg/SVGFontFaceElement.cpp:
+ (WebCore::SVGFontFaceElement::associatedFontElement):
+ (WebCore::SVGFontFaceElement::rebuildFontFace):
+ * svg/SVGFontFaceSrcElement.cpp:
+ (WebCore::SVGFontFaceSrcElement::srcValue):
+ (WebCore::SVGFontFaceSrcElement::childrenChanged):
+ * svg/SVGGlyphElement.cpp:
+ (WebCore::SVGGlyphElement::invalidateGlyphCache):
+ * svg/SVGHKernElement.cpp:
+ (WebCore::SVGHKernElement::insertedInto):
+ (WebCore::SVGHKernElement::removedFrom):
+ * svg/SVGLengthContext.cpp:
+ (WebCore::SVGLengthContext::determineViewport):
+ * svg/SVGLocatable.cpp:
+ (WebCore::isViewportElement):
+ * svg/SVGMPathElement.cpp:
+ (WebCore::SVGMPathElement::pathElement):
+ (WebCore::SVGMPathElement::notifyParentOfPathChange):
+ * svg/SVGPathElement.cpp:
+ (WebCore::SVGPathElement::invalidateMPathDependencies):
+ * svg/SVGPatternElement.cpp:
+ (WebCore::SVGPatternElement::collectPatternAttributes):
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::setupInitialView):
+ * svg/SVGUseElement.cpp:
+ (WebCore::dumpInstanceTree):
+ (WebCore::SVGUseElement::expandUseElementsInShadowTree):
+ * svg/SVGVKernElement.cpp:
+ (WebCore::SVGVKernElement::insertedInto):
+ (WebCore::SVGVKernElement::removedFrom):
+
</ins><span class="cx"> 2014-09-24 Benjamin Poulain <bpoulain@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove the style marking from :nth-child()
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSCursorImageValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSCursorImageValue.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSCursorImageValue.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/css/CSSCursorImageValue.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> static inline SVGCursorElement* resourceReferencedByCursorElement(const String& url, Document& document)
</span><span class="cx"> {
</span><span class="cx"> Element* element = SVGURIReference::targetElementFromIRIString(url, document);
</span><del>- if (element && isSVGCursorElement(element))
</del><ins>+ if (element && is<SVGCursorElement>(element))
</ins><span class="cx"> return downcast<SVGCursorElement>(element);
</span><span class="cx">
</span><span class="cx"> return nullptr;
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleResolvercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleResolver.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleResolver.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/css/StyleResolver.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -1883,7 +1883,7 @@
</span><span class="cx"> // Scale with/height properties on inline SVG root.
</span><span class="cx"> bool StyleResolver::useSVGZoomRulesForLength()
</span><span class="cx"> {
</span><del>- return m_state.element() && m_state.element()->isSVGElement() && !(isSVGSVGElement(m_state.element()) && m_state.element()->parentNode());
</del><ins>+ return m_state.element() && m_state.element()->isSVGElement() && !(is<SVGSVGElement>(m_state.element()) && m_state.element()->parentNode());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentStyleSheetCollectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/DocumentStyleSheetCollection.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/DocumentStyleSheetCollection.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/dom/DocumentStyleSheetCollection.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -305,7 +305,7 @@
</span><span class="cx"> }
</span><span class="cx"> // Get the current preferred styleset. This is the
</span><span class="cx"> // set of sheets that will be enabled.
</span><del>- if (isSVGStyleElement(element))
</del><ins>+ if (is<SVGStyleElement>(element))
</ins><span class="cx"> sheet = downcast<SVGStyleElement>(element).sheet();
</span><span class="cx"> else if (isHTMLLinkElement(element))
</span><span class="cx"> sheet = downcast<HTMLLinkElement>(element).sheet();
</span></span></pre></div>
<a id="trunkSourceWebCoredomScriptElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ScriptElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ScriptElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/dom/ScriptElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -385,7 +385,7 @@
</span><span class="cx"> if (isHTMLScriptElement(element))
</span><span class="cx"> return downcast<HTMLScriptElement>(element);
</span><span class="cx">
</span><del>- if (isSVGScriptElement(element))
</del><ins>+ if (is<SVGScriptElement>(element))
</ins><span class="cx"> return downcast<SVGScriptElement>(element);
</span><span class="cx">
</span><span class="cx"> return nullptr;
</span></span></pre></div>
<a id="trunkSourceWebCoredommake_namespl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/make_names.pl (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/make_names.pl        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/dom/make_names.pl        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -657,12 +657,16 @@
</span><span class="cx"> }
</span><span class="cx"> print F <<END
</span><span class="cx"> };
</span><del>-
</del><ins>+END
+ ;
+ if ($parameters{namespace} eq "HTML") {
+ print F <<END
</ins><span class="cx"> // FIXME: Remove these macros once the code has been ported to using
</span><span class="cx"> // is<*Element>().
</span><span class="cx"> #define is$class(x) WebCore::is<WebCore::$class>(x)
</span><span class="cx"> END
</span><del>- ;
</del><ins>+ ;
+ }
</ins><span class="cx"> print F "\n";
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditinggtkEditorGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/gtk/EditorGtk.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/gtk/EditorGtk.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/editing/gtk/EditorGtk.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (isHTMLImageElement(element) || isHTMLInputElement(element))
</span><span class="cx"> return element.fastGetAttribute(HTMLNames::srcAttr);
</span><del>- if (isSVGImageElement(element))
</del><ins>+ if (is<SVGImageElement>(element))
</ins><span class="cx"> return element.fastGetAttribute(XLinkNames::hrefAttr);
</span><span class="cx"> if (isHTMLEmbedElement(element) || isHTMLObjectElement(element))
</span><span class="cx"> return element.imageSourceURL();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingHitTestResultcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/HitTestResult.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/HitTestResult.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/rendering/HitTestResult.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -321,7 +321,7 @@
</span><span class="cx"> || isHTMLImageElement(m_innerNonSharedNode.get())
</span><span class="cx"> || isHTMLInputElement(m_innerNonSharedNode.get())
</span><span class="cx"> || m_innerNonSharedNode->hasTagName(objectTag)
</span><del>- || isSVGImageElement(m_innerNonSharedNode.get()))
</del><ins>+ || is<SVGImageElement>(m_innerNonSharedNode.get()))
</ins><span class="cx"> {
</span><span class="cx"> Element* element = toElement(m_innerNonSharedNode.get());
</span><span class="cx"> urlString = element->imageSourceURL();
</span><span class="lines">@@ -521,7 +521,7 @@
</span><span class="cx"> if (isHTMLAnchorElement(*m_innerURLElement))
</span><span class="cx"> return downcast<HTMLAnchorElement>(*m_innerURLElement).isLiveLink();
</span><span class="cx">
</span><del>- if (isSVGAElement(*m_innerURLElement))
</del><ins>+ if (is<SVGAElement>(*m_innerURLElement))
</ins><span class="cx"> return m_innerURLElement->isLink();
</span><span class="cx">
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGEllipsecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -81,13 +81,13 @@
</span><span class="cx"> m_center = FloatPoint(
</span><span class="cx"> lengthContext.valueForLength(style().svgStyle().cx(), LengthModeWidth),
</span><span class="cx"> lengthContext.valueForLength(style().svgStyle().cy(), LengthModeHeight));
</span><del>- if (isSVGCircleElement(graphicsElement())) {
</del><ins>+ if (is<SVGCircleElement>(graphicsElement())) {
</ins><span class="cx"> float radius = lengthContext.valueForLength(style().svgStyle().r());
</span><span class="cx"> m_radii = FloatSize(radius, radius);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- ASSERT(isSVGEllipseElement(graphicsElement()));
</del><ins>+ ASSERT(is<SVGEllipseElement>(graphicsElement()));
</ins><span class="cx"> m_radii = FloatSize(
</span><span class="cx"> lengthContext.valueForLength(style().svgStyle().rx(), LengthModeWidth),
</span><span class="cx"> lengthContext.valueForLength(style().svgStyle().ry(), LengthModeHeight));
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGTransformableContainercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -42,11 +42,11 @@
</span><span class="cx"> // tree, that was created during the use/symbol/svg expansion in SVGUseElement. These containers
</span><span class="cx"> // need to respect the translations induced by their corresponding use elements x/y attributes.
</span><span class="cx"> SVGUseElement* useElement = nullptr;
</span><del>- if (isSVGUseElement(element))
</del><ins>+ if (is<SVGUseElement>(element))
</ins><span class="cx"> useElement = &downcast<SVGUseElement>(element);
</span><del>- else if (element.isInShadowTree() && isSVGGElement(element)) {
</del><ins>+ else if (element.isInShadowTree() && is<SVGGElement>(element)) {
</ins><span class="cx"> SVGElement* correspondingElement = element.correspondingElement();
</span><del>- if (correspondingElement && isSVGUseElement(correspondingElement))
</del><ins>+ if (correspondingElement && is<SVGUseElement>(correspondingElement))
</ins><span class="cx"> useElement = downcast<SVGUseElement>(correspondingElement);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgSVGPathDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/SVGPathData.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/SVGPathData.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/rendering/svg/SVGPathData.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx">
</span><span class="cx"> static void updatePathFromCircleElement(SVGElement* element, Path& path)
</span><span class="cx"> {
</span><del>- ASSERT(isSVGCircleElement(element));
</del><ins>+ ASSERT(is<SVGCircleElement>(element));
</ins><span class="cx">
</span><span class="cx"> SVGLengthContext lengthContext(element);
</span><span class="cx"> RenderElement* renderer = element->renderer();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgSVGRenderTreeAsTextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -320,25 +320,25 @@
</span><span class="cx"> SVGGraphicsElement& svgElement = shape.graphicsElement();
</span><span class="cx"> SVGLengthContext lengthContext(&svgElement);
</span><span class="cx">
</span><del>- if (isSVGRectElement(svgElement)) {
</del><ins>+ if (is<SVGRectElement>(svgElement)) {
</ins><span class="cx"> const SVGRectElement& element = downcast<SVGRectElement>(svgElement);
</span><span class="cx"> writeNameValuePair(ts, "x", element.x().value(lengthContext));
</span><span class="cx"> writeNameValuePair(ts, "y", element.y().value(lengthContext));
</span><span class="cx"> writeNameValuePair(ts, "width", element.width().value(lengthContext));
</span><span class="cx"> writeNameValuePair(ts, "height", element.height().value(lengthContext));
</span><del>- } else if (isSVGLineElement(svgElement)) {
</del><ins>+ } else if (is<SVGLineElement>(svgElement)) {
</ins><span class="cx"> const SVGLineElement& element = downcast<SVGLineElement>(svgElement);
</span><span class="cx"> writeNameValuePair(ts, "x1", element.x1().value(lengthContext));
</span><span class="cx"> writeNameValuePair(ts, "y1", element.y1().value(lengthContext));
</span><span class="cx"> writeNameValuePair(ts, "x2", element.x2().value(lengthContext));
</span><span class="cx"> writeNameValuePair(ts, "y2", element.y2().value(lengthContext));
</span><del>- } else if (isSVGEllipseElement(svgElement)) {
</del><ins>+ } else if (is<SVGEllipseElement>(svgElement)) {
</ins><span class="cx"> const SVGEllipseElement& element = downcast<SVGEllipseElement>(svgElement);
</span><span class="cx"> writeNameValuePair(ts, "cx", element.cx().value(lengthContext));
</span><span class="cx"> writeNameValuePair(ts, "cy", element.cy().value(lengthContext));
</span><span class="cx"> writeNameValuePair(ts, "rx", element.rx().value(lengthContext));
</span><span class="cx"> writeNameValuePair(ts, "ry", element.ry().value(lengthContext));
</span><del>- } else if (isSVGCircleElement(svgElement)) {
</del><ins>+ } else if (is<SVGCircleElement>(svgElement)) {
</ins><span class="cx"> const SVGCircleElement& element = downcast<SVGCircleElement>(svgElement);
</span><span class="cx"> writeNameValuePair(ts, "cx", element.cx().value(lengthContext));
</span><span class="cx"> writeNameValuePair(ts, "cy", element.cy().value(lengthContext));
</span><span class="lines">@@ -346,7 +346,7 @@
</span><span class="cx"> } else if (svgElement.hasTagName(SVGNames::polygonTag) || svgElement.hasTagName(SVGNames::polylineTag)) {
</span><span class="cx"> const SVGPolyElement& element = toSVGPolyElement(svgElement);
</span><span class="cx"> writeNameAndQuotedValue(ts, "points", element.pointList().valueAsString());
</span><del>- } else if (isSVGPathElement(svgElement)) {
</del><ins>+ } else if (is<SVGPathElement>(svgElement)) {
</ins><span class="cx"> const SVGPathElement& element = downcast<SVGPathElement>(svgElement);
</span><span class="cx"> String pathString;
</span><span class="cx"> // FIXME: We should switch to UnalteredParsing here - this will affect the path dumping output of dozens of tests.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgSVGResourcescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/SVGResources.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/SVGResources.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/rendering/svg/SVGResources.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -141,11 +141,11 @@
</span><span class="cx"> static inline String targetReferenceFromResource(SVGElement& element)
</span><span class="cx"> {
</span><span class="cx"> String target;
</span><del>- if (isSVGPatternElement(element))
</del><ins>+ if (is<SVGPatternElement>(element))
</ins><span class="cx"> target = downcast<SVGPatternElement>(element).href();
</span><span class="cx"> else if (isSVGGradientElement(element))
</span><span class="cx"> target = toSVGGradientElement(element).href();
</span><del>- else if (isSVGFilterElement(element))
</del><ins>+ else if (is<SVGFilterElement>(element))
</ins><span class="cx"> target = downcast<SVGFilterElement>(element).href();
</span><span class="cx"> else
</span><span class="cx"> ASSERT_NOT_REACHED();
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGAltGlyphDefElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGAltGlyphDefElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGAltGlyphDefElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGAltGlyphDefElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -90,7 +90,7 @@
</span><span class="cx"> bool foundFirstAltGlyphItem = false;
</span><span class="cx">
</span><span class="cx"> for (auto& child : childrenOfType<SVGElement>(*this)) {
</span><del>- if (!foundFirstAltGlyphItem && isSVGGlyphRefElement(child)) {
</del><ins>+ if (!foundFirstAltGlyphItem && is<SVGGlyphRefElement>(child)) {
</ins><span class="cx"> fountFirstGlyphRef = true;
</span><span class="cx"> String referredGlyphName;
</span><span class="cx">
</span><span class="lines">@@ -104,7 +104,7 @@
</span><span class="cx"> glyphNames.clear();
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><del>- } else if (!fountFirstGlyphRef && isSVGAltGlyphItemElement(child)) {
</del><ins>+ } else if (!fountFirstGlyphRef && is<SVGAltGlyphItemElement>(child)) {
</ins><span class="cx"> foundFirstAltGlyphItem = true;
</span><span class="cx">
</span><span class="cx"> // As the spec says "The first 'altGlyphItem' in which all referenced glyphs
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGAltGlyphElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGAltGlyphElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGAltGlyphElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGAltGlyphElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -94,12 +94,12 @@
</span><span class="cx"> if (!element)
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- if (isSVGGlyphElement(element)) {
</del><ins>+ if (is<SVGGlyphElement>(element)) {
</ins><span class="cx"> glyphNames.append(target);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (isSVGAltGlyphDefElement(element)
</del><ins>+ if (is<SVGAltGlyphDefElement>(element)
</ins><span class="cx"> && downcast<SVGAltGlyphDefElement>(*element).hasValidGlyphElements(glyphNames))
</span><span class="cx"> return true;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGAnimateMotionElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGAnimateMotionElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGAnimateMotionElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGAnimateMotionElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx"> if (targetElement->hasTagName(gTag)
</span><span class="cx"> || targetElement->hasTagName(defsTag)
</span><span class="cx"> || targetElement->hasTagName(useTag)
</span><del>- || isSVGImageElement(targetElement)
</del><ins>+ || is<SVGImageElement>(targetElement)
</ins><span class="cx"> || targetElement->hasTagName(switchTag)
</span><span class="cx"> || targetElement->hasTagName(pathTag)
</span><span class="cx"> || targetElement->hasTagName(rectTag)
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGDocument.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGDocument.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGDocument.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> SVGSVGElement* SVGDocument::rootElement() const
</span><span class="cx"> {
</span><span class="cx"> Element* element = documentElement();
</span><del>- if (element && isSVGSVGElement(element))
</del><ins>+ if (element && is<SVGSVGElement>(element))
</ins><span class="cx"> return downcast<SVGSVGElement>(element);
</span><span class="cx">
</span><span class="cx"> return nullptr;
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -320,7 +320,7 @@
</span><span class="cx">
</span><span class="cx"> bool SVGElement::isOutermostSVGSVGElement() const
</span><span class="cx"> {
</span><del>- if (!isSVGSVGElement(this))
</del><ins>+ if (!is<SVGSVGElement>(this))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> // If we're living in a shadow tree, we're a <svg> element that got created as replacement
</span><span class="lines">@@ -396,7 +396,7 @@
</span><span class="cx"> {
</span><span class="cx"> ContainerNode* node = parentOrShadowHostNode();
</span><span class="cx"> while (node) {
</span><del>- if (isSVGSVGElement(node))
</del><ins>+ if (is<SVGSVGElement>(node))
</ins><span class="cx"> return downcast<SVGSVGElement>(node);
</span><span class="cx">
</span><span class="cx"> node = node->parentOrShadowHostNode();
</span><span class="lines">@@ -411,7 +411,7 @@
</span><span class="cx"> // to determine the "overflow" property. <use> on <symbol> wouldn't work otherwhise.
</span><span class="cx"> ContainerNode* node = parentOrShadowHostNode();
</span><span class="cx"> while (node) {
</span><del>- if (isSVGSVGElement(node) || isSVGImageElement(node) || node->hasTagName(SVGNames::symbolTag))
</del><ins>+ if (is<SVGSVGElement>(node) || is<SVGImageElement>(node) || node->hasTagName(SVGNames::symbolTag))
</ins><span class="cx"> return downcast<SVGElement>(node);
</span><span class="cx">
</span><span class="cx"> node = node->parentOrShadowHostNode();
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGFEComponentTransferElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGFEComponentTransferElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGFEComponentTransferElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGFEComponentTransferElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -90,13 +90,13 @@
</span><span class="cx"> ComponentTransferFunction alpha;
</span><span class="cx">
</span><span class="cx"> for (auto& child : childrenOfType<SVGElement>(*this)) {
</span><del>- if (isSVGFEFuncRElement(child))
</del><ins>+ if (is<SVGFEFuncRElement>(child))
</ins><span class="cx"> red = downcast<SVGFEFuncRElement>(child).transferFunction();
</span><del>- else if (isSVGFEFuncGElement(child))
</del><ins>+ else if (is<SVGFEFuncGElement>(child))
</ins><span class="cx"> green = downcast<SVGFEFuncGElement>(child).transferFunction();
</span><del>- else if (isSVGFEFuncBElement(child))
</del><ins>+ else if (is<SVGFEFuncBElement>(child))
</ins><span class="cx"> blue = downcast<SVGFEFuncBElement>(child).transferFunction();
</span><del>- else if (isSVGFEFuncAElement(child))
</del><ins>+ else if (is<SVGFEFuncAElement>(child))
</ins><span class="cx"> alpha = downcast<SVGFEFuncAElement>(child).transferFunction();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGFELightElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGFELightElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGFELightElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGFELightElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -71,7 +71,7 @@
</span><span class="cx"> SVGFELightElement* SVGFELightElement::findLightElement(const SVGElement* svgElement)
</span><span class="cx"> {
</span><span class="cx"> for (auto& child : childrenOfType<SVGElement>(*svgElement)) {
</span><del>- if (isSVGFEDistantLightElement(child) || isSVGFEPointLightElement(child) || isSVGFESpotLightElement(child))
</del><ins>+ if (is<SVGFEDistantLightElement>(child) || is<SVGFEPointLightElement>(child) || is<SVGFESpotLightElement>(child))
</ins><span class="cx"> return static_cast<SVGFELightElement*>(const_cast<SVGElement*>(&child));
</span><span class="cx"> }
</span><span class="cx"> return nullptr;
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGFontDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGFontData.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGFontData.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGFontData.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -159,7 +159,7 @@
</span><span class="cx"> if (Element* parentRendererElement = parentRenderer->element()) {
</span><span class="cx"> language = parentRendererElement->getAttribute(XMLNames::langAttr);
</span><span class="cx">
</span><del>- if (isSVGAltGlyphElement(parentRendererElement)) {
</del><ins>+ if (is<SVGAltGlyphElement>(parentRendererElement)) {
</ins><span class="cx"> SVGAltGlyphElement& altGlyph = downcast<SVGAltGlyphElement>(*parentRendererElement);
</span><span class="cx"> if (!altGlyph.hasValidGlyphElements(altGlyphNames))
</span><span class="cx"> altGlyphNames.clear();
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGFontElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGFontElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGFontElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGFontElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -119,7 +119,7 @@
</span><span class="cx"> const SVGMissingGlyphElement* firstMissingGlyphElement = nullptr;
</span><span class="cx"> Vector<String> ligatures;
</span><span class="cx"> for (auto& child : childrenOfType<SVGElement>(*this)) {
</span><del>- if (isSVGGlyphElement(child)) {
</del><ins>+ if (is<SVGGlyphElement>(child)) {
</ins><span class="cx"> SVGGlyphElement& glyph = downcast<SVGGlyphElement>(child);
</span><span class="cx"> AtomicString unicode = glyph.fastGetAttribute(SVGNames::unicodeAttr);
</span><span class="cx"> AtomicString glyphId = glyph.getIdAttribute();
</span><span class="lines">@@ -131,17 +131,17 @@
</span><span class="cx"> // Register ligatures, if needed, don't mix up with surrogate pairs though!
</span><span class="cx"> if (unicode.length() > 1 && !U16_IS_SURROGATE(unicode[0]))
</span><span class="cx"> ligatures.append(unicode.string());
</span><del>- } else if (isSVGHKernElement(child)) {
</del><ins>+ } else if (is<SVGHKernElement>(child)) {
</ins><span class="cx"> SVGHKernElement& hkern = downcast<SVGHKernElement>(child);
</span><span class="cx"> SVGKerningPair kerningPair;
</span><span class="cx"> if (hkern.buildHorizontalKerningPair(kerningPair))
</span><span class="cx"> m_horizontalKerningMap.insert(kerningPair);
</span><del>- } else if (isSVGVKernElement(child)) {
</del><ins>+ } else if (is<SVGVKernElement>(child)) {
</ins><span class="cx"> SVGVKernElement& vkern = downcast<SVGVKernElement>(child);
</span><span class="cx"> SVGKerningPair kerningPair;
</span><span class="cx"> if (vkern.buildVerticalKerningPair(kerningPair))
</span><span class="cx"> m_verticalKerningMap.insert(kerningPair);
</span><del>- } else if (isSVGMissingGlyphElement(child) && !firstMissingGlyphElement)
</del><ins>+ } else if (is<SVGMissingGlyphElement>(child) && !firstMissingGlyphElement)
</ins><span class="cx"> firstMissingGlyphElement = &downcast<SVGMissingGlyphElement>(child);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGFontFaceElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGFontFaceElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGFontFaceElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGFontFaceElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -216,7 +216,7 @@
</span><span class="cx"> SVGFontElement* SVGFontFaceElement::associatedFontElement() const
</span><span class="cx"> {
</span><span class="cx"> ASSERT(parentNode() == m_fontElement);
</span><del>- ASSERT(!parentNode() || isSVGFontElement(parentNode()));
</del><ins>+ ASSERT(!parentNode() || is<SVGFontElement>(parentNode()));
</ins><span class="cx"> return m_fontElement;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -230,7 +230,7 @@
</span><span class="cx"> // we currently ignore all but the first src element, alternatively we could concat them
</span><span class="cx"> auto srcElement = childrenOfType<SVGFontFaceSrcElement>(*this).first();
</span><span class="cx">
</span><del>- bool describesParentFont = isSVGFontElement(parentNode());
</del><ins>+ bool describesParentFont = is<SVGFontElement>(parentNode());
</ins><span class="cx"> RefPtr<CSSValueList> list;
</span><span class="cx">
</span><span class="cx"> if (describesParentFont) {
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGFontFaceSrcElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGFontFaceSrcElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGFontFaceSrcElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGFontFaceSrcElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -50,9 +50,9 @@
</span><span class="cx"> RefPtr<CSSValueList> list = CSSValueList::createCommaSeparated();
</span><span class="cx"> for (auto& child : childrenOfType<SVGElement>(*this)) {
</span><span class="cx"> RefPtr<CSSFontFaceSrcValue> srcValue;
</span><del>- if (isSVGFontFaceUriElement(child))
</del><ins>+ if (is<SVGFontFaceUriElement>(child))
</ins><span class="cx"> srcValue = downcast<SVGFontFaceUriElement>(child).srcValue();
</span><del>- else if (isSVGFontFaceNameElement(child))
</del><ins>+ else if (is<SVGFontFaceNameElement>(child))
</ins><span class="cx"> srcValue = downcast<SVGFontFaceNameElement>(child).srcValue();
</span><span class="cx"> if (srcValue && srcValue->resource().length())
</span><span class="cx"> list->append(srcValue.releaseNonNull());
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx"> void SVGFontFaceSrcElement::childrenChanged(const ChildChange& change)
</span><span class="cx"> {
</span><span class="cx"> SVGElement::childrenChanged(change);
</span><del>- if (parentNode() && isSVGFontFaceElement(parentNode()))
</del><ins>+ if (parentNode() && is<SVGFontFaceElement>(parentNode()))
</ins><span class="cx"> downcast<SVGFontFaceElement>(*parentNode()).rebuildFontFace();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGGlyphElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGGlyphElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGGlyphElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGGlyphElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> void SVGGlyphElement::invalidateGlyphCache()
</span><span class="cx"> {
</span><span class="cx"> ContainerNode* fontNode = parentNode();
</span><del>- if (fontNode && isSVGFontElement(fontNode))
</del><ins>+ if (fontNode && is<SVGFontElement>(fontNode))
</ins><span class="cx"> downcast<SVGFontElement>(*fontNode).invalidateGlyphCache();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGHKernElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGHKernElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGHKernElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGHKernElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> Node::InsertionNotificationRequest SVGHKernElement::insertedInto(ContainerNode& rootParent)
</span><span class="cx"> {
</span><span class="cx"> ContainerNode* fontNode = parentNode();
</span><del>- if (fontNode && isSVGFontElement(fontNode))
</del><ins>+ if (fontNode && is<SVGFontElement>(fontNode))
</ins><span class="cx"> downcast<SVGFontElement>(*fontNode).invalidateGlyphCache();
</span><span class="cx">
</span><span class="cx"> return SVGElement::insertedInto(rootParent);
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> void SVGHKernElement::removedFrom(ContainerNode& rootParent)
</span><span class="cx"> {
</span><span class="cx"> ContainerNode* fontNode = parentNode();
</span><del>- if (fontNode && isSVGFontElement(fontNode))
</del><ins>+ if (fontNode && is<SVGFontElement>(fontNode))
</ins><span class="cx"> downcast<SVGFontElement>(*fontNode).invalidateGlyphCache();
</span><span class="cx">
</span><span class="cx"> SVGElement::removedFrom(rootParent);
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGLengthContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGLengthContext.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGLengthContext.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGLengthContext.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -318,7 +318,7 @@
</span><span class="cx">
</span><span class="cx"> // Take size from nearest viewport element.
</span><span class="cx"> SVGElement* viewportElement = m_context->viewportElement();
</span><del>- if (!viewportElement || !isSVGSVGElement(viewportElement))
</del><ins>+ if (!viewportElement || !is<SVGSVGElement>(viewportElement))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> const SVGSVGElement& svg = downcast<SVGSVGElement>(*viewportElement);
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGLocatablecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGLocatable.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGLocatable.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGLocatable.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx"> return (node->hasTagName(SVGNames::svgTag)
</span><span class="cx"> || node->hasTagName(SVGNames::symbolTag)
</span><span class="cx"> || node->hasTagName(SVGNames::foreignObjectTag)
</span><del>- || isSVGImageElement(node));
</del><ins>+ || is<SVGImageElement>(node));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> SVGElement* SVGLocatable::nearestViewportElement(const SVGElement* element)
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGMPathElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGMPathElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGMPathElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGMPathElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -156,7 +156,7 @@
</span><span class="cx"> SVGPathElement* SVGMPathElement::pathElement()
</span><span class="cx"> {
</span><span class="cx"> Element* target = targetElementFromIRIString(href(), document());
</span><del>- if (target && isSVGPathElement(target))
</del><ins>+ if (target && is<SVGPathElement>(target))
</ins><span class="cx"> return downcast<SVGPathElement>(target);
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="lines">@@ -168,7 +168,7 @@
</span><span class="cx">
</span><span class="cx"> void SVGMPathElement::notifyParentOfPathChange(ContainerNode* parent)
</span><span class="cx"> {
</span><del>- if (parent && isSVGAnimateMotionElement(parent))
</del><ins>+ if (parent && is<SVGAnimateMotionElement>(parent))
</ins><span class="cx"> downcast<SVGAnimateMotionElement>(*parent).updateAnimationPath();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGPathElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGPathElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGPathElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGPathElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -286,7 +286,7 @@
</span><span class="cx"> // markForLayoutAndParentResourceInvalidation so we update any mpath dependencies manually.
</span><span class="cx"> if (HashSet<SVGElement*>* dependencies = document().accessSVGExtensions().setOfElementsReferencingTarget(this)) {
</span><span class="cx"> for (auto* element : *dependencies) {
</span><del>- if (isSVGMPathElement(element))
</del><ins>+ if (is<SVGMPathElement>(element))
</ins><span class="cx"> downcast<SVGMPathElement>(*element).targetPathChanged();
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGPatternElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGPatternElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGPatternElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGPatternElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -236,7 +236,7 @@
</span><span class="cx">
</span><span class="cx"> // Respect xlink:href, take attributes from referenced element
</span><span class="cx"> Element* refElement = SVGURIReference::targetElementFromIRIString(current->href(), document());
</span><del>- if (refElement && isSVGPatternElement(refElement)) {
</del><ins>+ if (refElement && is<SVGPatternElement>(refElement)) {
</ins><span class="cx"> current = downcast<SVGPatternElement>(refElement);
</span><span class="cx">
</span><span class="cx"> // Cycle detection
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGSVGElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGSVGElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGSVGElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGSVGElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -661,10 +661,10 @@
</span><span class="cx"> // or MyDrawing.svg#xpointer(id('MyView'))) then the closest ancestor ‘svg’ element is displayed in the viewport.
</span><span class="cx"> // Any view specification attributes included on the given ‘view’ element override the corresponding view specification
</span><span class="cx"> // attributes on the closest ancestor ‘svg’ element.
</span><del>- if (anchorNode && isSVGViewElement(anchorNode)) {
</del><ins>+ if (anchorNode && is<SVGViewElement>(anchorNode)) {
</ins><span class="cx"> SVGViewElement& viewElement = downcast<SVGViewElement>(*anchorNode);
</span><span class="cx"> SVGElement* element = SVGLocatable::nearestViewportElement(&viewElement);
</span><del>- if (isSVGSVGElement(element)) {
</del><ins>+ if (is<SVGSVGElement>(element)) {
</ins><span class="cx"> SVGSVGElement& svg = downcast<SVGSVGElement>(*element);
</span><span class="cx"> svg.inheritViewAttributes(&viewElement);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGUseElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGUseElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGUseElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGUseElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -282,7 +282,7 @@
</span><span class="cx"> SVGElement* element = targetInstance->correspondingElement();
</span><span class="cx"> ASSERT(element);
</span><span class="cx">
</span><del>- if (isSVGUseElement(element)) {
</del><ins>+ if (is<SVGUseElement>(element)) {
</ins><span class="cx"> if (downcast<SVGUseElement>(*element).cachedDocumentIsStillLoading())
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="lines">@@ -710,7 +710,7 @@
</span><span class="cx"> // contains <use> tags, we'd miss them. So once we're done with settin' up the
</span><span class="cx"> // actual shadow tree (after the special case modification for svg/symbol) we have
</span><span class="cx"> // to walk it completely and expand all <use> elements.
</span><del>- if (isSVGUseElement(element)) {
</del><ins>+ if (is<SVGUseElement>(element)) {
</ins><span class="cx"> SVGUseElement& use = downcast<SVGUseElement>(*element);
</span><span class="cx"> ASSERT(!use.cachedDocumentIsStillLoading());
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGVKernElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGVKernElement.cpp (173920 => 173921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGVKernElement.cpp        2014-09-24 15:11:45 UTC (rev 173920)
+++ trunk/Source/WebCore/svg/SVGVKernElement.cpp        2014-09-24 15:56:26 UTC (rev 173921)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (rootParent.inDocument()) {
</span><span class="cx"> ContainerNode* fontNode = parentNode();
</span><del>- if (fontNode && isSVGFontElement(fontNode))
</del><ins>+ if (fontNode && is<SVGFontElement>(fontNode))
</ins><span class="cx"> downcast<SVGFontElement>(*fontNode).invalidateGlyphCache();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx"> void SVGVKernElement::removedFrom(ContainerNode& rootParent)
</span><span class="cx"> {
</span><span class="cx"> ContainerNode* fontNode = parentNode();
</span><del>- if (fontNode && isSVGFontElement(fontNode))
</del><ins>+ if (fontNode && is<SVGFontElement>(fontNode))
</ins><span class="cx"> downcast<SVGFontElement>(*fontNode).invalidateGlyphCache();
</span><span class="cx">
</span><span class="cx"> SVGElement::removedFrom(rootParent);
</span></span></pre>
</div>
</div>
</body>
</html>