<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173932] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173932">173932</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2014-09-24 14:25:22 -0700 (Wed, 24 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use is<HTML*Element>() instead of isHTML*Element() - Part 1
https://bugs.webkit.org/show_bug.cgi?id=137068
Reviewed by Ryosuke Niwa.
Start using is<HTML*Element>() instead of isHTML*Element().
Remaining usages will be updated in a follow-up patch to
reduce the size of the change.
Source/WebCore:
No new tests, no behavior change.
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaTimeline::valueDescription):
* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::setElement):
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::isNodeActionElement):
(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore::accessibleNameForNode):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isFileUploadButton):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
* accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::notifyChildrenSelectionChange):
* css/SelectorCheckerTestFunctions.h:
(WebCore::isDisabled):
(WebCore::isEnabled):
(WebCore::isChecked):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::isInPasswordField):
* editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_processElement):
* editing/gtk/EditorGtk.cpp:
(WebCore::elementURL):
* editing/ios/EditorIOS.mm:
(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendText):
(WebCore::isPlainTextMarkup):
(WebCore::collectElementsToRemoveFromFragment):
* html/HTMLCollection.cpp:
(WebCore::isMatchingElement):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::rendererIsNeeded):
* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::getTextFieldValues):
(WebCore::HTMLFormElement::formElementIndex):
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::dispatchLoadEvent):
(WebCore::HTMLImageLoader::notifyFinished):
* html/HTMLNameCollection.cpp:
(WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatches):
* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::recalcSelectOptions):
(WebCore::HTMLOptGroupElement::ownerSelectElement):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::index):
(WebCore::HTMLOptionElement::ownerSelectElement):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::add):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::setLength):
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):
* html/HTMLTagNames.in:
* html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::hasImpliedEndTag):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isSelectScopeMarker):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
* html/shadow/MediaControlElementTypes.cpp:
(WebCore::mediaControlElementType):
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::handleFallbackContent):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestObject):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* page/Chrome.cpp:
(WebCore::Chrome::setToolTip):
* page/EventHandler.cpp:
(WebCore::isSubmitImage):
(WebCore::EventHandler::handleMousePressEvent):
* page/FocusController.cpp:
(WebCore::clearSelectionIfNeeded):
* page/FrameView.cpp:
(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):
* page/PageSerializer.cpp:
(WebCore::frameOwnerURLAttributeName):
* page/SpatialNavigation.cpp:
(WebCore::canScrollInDirection):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absolutePDFURL):
(WebCore::HitTestResult::isContentEditable):
* rendering/RenderBlockFlow.cpp:
(WebCore::resizeTextPermitted):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::updateFromElement):
(WebCore::RenderButton::canHaveGeneratedChildren):
* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::isOpen):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::uploadButton):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::updateAltText):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
* rendering/RenderMenuList.cpp:
(WebCore::selectedOptionCount):
(RenderMenuList::updateOptionsWidth):
(RenderMenuList::setTextFromOption):
(RenderMenuList::itemText):
(RenderMenuList::itemIsEnabled):
(RenderMenuList::itemIsSelected):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):
* testing/Internals.cpp:
(WebCore::Internals::selectColorInColorChooser):
(WebCore::Internals::wasLastChangeUserEdit):
(WebCore::Internals::isSelectPopupVisible):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
Source/WebKit/ios:
* WebCoreSupport/WebChromeClientIOS.mm:
(WebChromeClientIOS::focusedElementChanged):
Source/WebKit/mac:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::focusedElementChanged):
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
(WebEditorClient::textDidChangeInTextArea):
* WebView/WebHTMLRepresentation.mm:
(inputElementFromDOMElement):
Source/WebKit/win:
* DOMCoreClasses.cpp:
(DOMElement::createInstance):
* DOMHTMLClasses.cpp:
(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):
(DOMHTMLInputElement::form):
(DOMHTMLInputElement::disabled):
(DOMHTMLInputElement::readOnly):
(DOMHTMLInputElement::setType):
(DOMHTMLInputElement::value):
(DOMHTMLInputElement::setValue):
(DOMHTMLInputElement::setValueForUser):
(DOMHTMLInputElement::select):
(DOMHTMLInputElement::setSelectionStart):
(DOMHTMLInputElement::selectionStart):
(DOMHTMLInputElement::setSelectionEnd):
(DOMHTMLInputElement::selectionEnd):
(DOMHTMLInputElement::isTextField):
(DOMHTMLInputElement::rectOnScreen):
(DOMHTMLInputElement::replaceCharactersInRange):
(DOMHTMLInputElement::selectedRange):
(DOMHTMLInputElement::setAutofilled):
(DOMHTMLInputElement::isAutofilled):
(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):
* WebFrame.cpp:
(inputElementFromDOMElement):
Source/WebKit2:
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::isTextField):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedElementChanged):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::textDidChangeInTextArea):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormControls):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::setAssistedNodeValue):
(WebKit::WebPage::setAssistedNodeValueAsNumber):
(WebKit::WebPage::setAssistedNodeSelectedIndex):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityListBoxOptioncpp">trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityMediaControlscpp">trunk/Source/WebCore/accessibility/AccessibilityMediaControls.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityMenuListOptioncpp">trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityMenuListPopupcpp">trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityatkAXObjectCacheAtkcpp">trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp</a></li>
<li><a href="#trunkSourceWebCorecssSelectorCheckerTestFunctionsh">trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h</a></li>
<li><a href="#trunkSourceWebCorecssStyleResolvercpp">trunk/Source/WebCore/css/StyleResolver.cpp</a></li>
<li><a href="#trunkSourceWebCoredomEventDispatchercpp">trunk/Source/WebCore/dom/EventDispatcher.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingFrameSelectioncpp">trunk/Source/WebCore/editing/FrameSelection.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingReplaceSelectionCommandcpp">trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingVisibleSelectioncpp">trunk/Source/WebCore/editing/VisibleSelection.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingcocoaHTMLConvertermm">trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm</a></li>
<li><a href="#trunkSourceWebCoreeditinggtkEditorGtkcpp">trunk/Source/WebCore/editing/gtk/EditorGtk.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingiosEditorIOSmm">trunk/Source/WebCore/editing/ios/EditorIOS.mm</a></li>
<li><a href="#trunkSourceWebCoreeditingmarkupcpp">trunk/Source/WebCore/editing/markup.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLCollectioncpp">trunk/Source/WebCore/html/HTMLCollection.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLEmbedElementcpp">trunk/Source/WebCore/html/HTMLEmbedElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormControlElementcpp">trunk/Source/WebCore/html/HTMLFormControlElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormElementcpp">trunk/Source/WebCore/html/HTMLFormElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLImageLoadercpp">trunk/Source/WebCore/html/HTMLImageLoader.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLNameCollectioncpp">trunk/Source/WebCore/html/HTMLNameCollection.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptGroupElementcpp">trunk/Source/WebCore/html/HTMLOptGroupElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptionElementcpp">trunk/Source/WebCore/html/HTMLOptionElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLSelectElementcpp">trunk/Source/WebCore/html/HTMLSelectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTagNamesin">trunk/Source/WebCore/html/HTMLTagNames.in</a></li>
<li><a href="#trunkSourceWebCorehtmlRadioInputTypecpp">trunk/Source/WebCore/html/RadioInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlparserHTMLConstructionSitecpp">trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlparserHTMLElementStackcpp">trunk/Source/WebCore/html/parser/HTMLElementStack.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlparserHTMLTreeBuildercpp">trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowMediaControlElementTypescpp">trunk/Source/WebCore/html/shadow/MediaControlElementTypes.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderFormSubmissioncpp">trunk/Source/WebCore/loader/FormSubmission.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderFrameLoadercpp">trunk/Source/WebCore/loader/FrameLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderImageLoadercpp">trunk/Source/WebCore/loader/ImageLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderSubframeLoadercpp">trunk/Source/WebCore/loader/SubframeLoader.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderarchivecfLegacyWebArchivecpp">trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp</a></li>
<li><a href="#trunkSourceWebCorepageChromecpp">trunk/Source/WebCore/page/Chrome.cpp</a></li>
<li><a href="#trunkSourceWebCorepageEventHandlercpp">trunk/Source/WebCore/page/EventHandler.cpp</a></li>
<li><a href="#trunkSourceWebCorepageFocusControllercpp">trunk/Source/WebCore/page/FocusController.cpp</a></li>
<li><a href="#trunkSourceWebCorepageFrameViewcpp">trunk/Source/WebCore/page/FrameView.cpp</a></li>
<li><a href="#trunkSourceWebCorepagePageSerializercpp">trunk/Source/WebCore/page/PageSerializer.cpp</a></li>
<li><a href="#trunkSourceWebCorepageSpatialNavigationcpp">trunk/Source/WebCore/page/SpatialNavigation.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingHitTestResultcpp">trunk/Source/WebCore/rendering/HitTestResult.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockFlowcpp">trunk/Source/WebCore/rendering/RenderBlockFlow.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderButtoncpp">trunk/Source/WebCore/rendering/RenderButton.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderDetailsMarkercpp">trunk/Source/WebCore/rendering/RenderDetailsMarker.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderFileUploadControlcpp">trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderImagecpp">trunk/Source/WebCore/rendering/RenderImage.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderListBoxcpp">trunk/Source/WebCore/rendering/RenderListBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderMenuListcpp">trunk/Source/WebCore/rendering/RenderMenuList.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemecpp">trunk/Source/WebCore/rendering/RenderTheme.cpp</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
<li><a href="#trunkSourceWebCorexmlparserXMLDocumentParserLibxml2cpp">trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp</a></li>
<li><a href="#trunkSourceWebKitiosChangeLog">trunk/Source/WebKit/ios/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitiosWebCoreSupportWebChromeClientIOSmm">trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebChromeClientmm">trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebCoreSupportWebEditorClientmm">trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebHTMLRepresentationmm">trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinDOMCoreClassescpp">trunk/Source/WebKit/win/DOMCoreClasses.cpp</a></li>
<li><a href="#trunkSourceWebKitwinDOMHTMLClassescpp">trunk/Source/WebKit/win/DOMHTMLClasses.cpp</a></li>
<li><a href="#trunkSourceWebKitwinWebFramecpp">trunk/Source/WebKit/win/WebFrame.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessInjectedBundleDOMInjectedBundleNodeHandlecpp">trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClientcpp">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebCoreSupportWebEditorClientcpp">trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebFramecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageiosWebPageIOSmm">trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/ChangeLog 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -1,3 +1,202 @@
</span><ins>+2014-09-24 Christophe Dumez <cdumez@apple.com>
+
+ Use is<HTML*Element>() instead of isHTML*Element() - Part 1
+ https://bugs.webkit.org/show_bug.cgi?id=137068
+
+ Reviewed by Ryosuke Niwa.
+
+ Start using is<HTML*Element>() instead of isHTML*Element().
+ Remaining usages will be updated in a follow-up patch to
+ reduce the size of the change.
+
+ No new tests, no behavior change.
+
+ * accessibility/AccessibilityListBoxOption.cpp:
+ (WebCore::AccessibilityListBoxOption::isSelected):
+ (WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
+ (WebCore::AccessibilityListBoxOption::stringValue):
+ (WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
+ * accessibility/AccessibilityMediaControls.cpp:
+ (WebCore::AccessibilityMediaTimeline::valueDescription):
+ * accessibility/AccessibilityMenuListOption.cpp:
+ (WebCore::AccessibilityMenuListOption::setElement):
+ * accessibility/AccessibilityMenuListPopup.cpp:
+ (WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::determineAccessibilityRole):
+ (WebCore::AccessibilityNodeObject::isNativeTextControl):
+ (WebCore::AccessibilityNodeObject::isNativeImage):
+ (WebCore::AccessibilityNodeObject::isInputImage):
+ (WebCore::AccessibilityNodeObject::isReadOnly):
+ (WebCore::AccessibilityNodeObject::valueForRange):
+ (WebCore::AccessibilityNodeObject::maxValueForRange):
+ (WebCore::AccessibilityNodeObject::minValueForRange):
+ (WebCore::isNodeActionElement):
+ (WebCore::AccessibilityNodeObject::titleElementText):
+ (WebCore::AccessibilityNodeObject::visibleText):
+ (WebCore::AccessibilityNodeObject::title):
+ (WebCore::AccessibilityNodeObject::colorValue):
+ (WebCore::accessibleNameForNode):
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::isFileUploadButton):
+ (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
+ (WebCore::AccessibilityRenderObject::setValue):
+ (WebCore::AccessibilityRenderObject::accessibilityHitTest):
+ (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
+ (WebCore::AccessibilityRenderObject::addTextFieldChildren):
+ * accessibility/atk/AXObjectCacheAtk.cpp:
+ (WebCore::notifyChildrenSelectionChange):
+ * css/SelectorCheckerTestFunctions.h:
+ (WebCore::isDisabled):
+ (WebCore::isEnabled):
+ (WebCore::isChecked):
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::adjustRenderStyle):
+ * dom/EventDispatcher.cpp:
+ (WebCore::EventDispatcher::dispatchEvent):
+ * editing/FrameSelection.cpp:
+ (WebCore::FrameSelection::selectAll):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
+ * editing/VisibleSelection.cpp:
+ (WebCore::VisibleSelection::isInPasswordField):
+ * editing/cocoa/HTMLConverter.mm:
+ (HTMLConverter::_processElement):
+ * editing/gtk/EditorGtk.cpp:
+ (WebCore::elementURL):
+ * editing/ios/EditorIOS.mm:
+ (WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
+ * editing/markup.cpp:
+ (WebCore::StyledMarkupAccumulator::appendText):
+ (WebCore::isPlainTextMarkup):
+ (WebCore::collectElementsToRemoveFromFragment):
+ * html/HTMLCollection.cpp:
+ (WebCore::isMatchingElement):
+ * html/HTMLEmbedElement.cpp:
+ (WebCore::HTMLEmbedElement::rendererIsNeeded):
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::shouldAutofocus):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::getTextFieldValues):
+ (WebCore::HTMLFormElement::formElementIndex):
+ * html/HTMLImageLoader.cpp:
+ (WebCore::HTMLImageLoader::dispatchLoadEvent):
+ (WebCore::HTMLImageLoader::notifyFinished):
+ * html/HTMLNameCollection.cpp:
+ (WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
+ (WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
+ (WebCore::DocumentNameCollection::elementMatches):
+ * html/HTMLOptGroupElement.cpp:
+ (WebCore::HTMLOptGroupElement::recalcSelectOptions):
+ (WebCore::HTMLOptGroupElement::ownerSelectElement):
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::index):
+ (WebCore::HTMLOptionElement::ownerSelectElement):
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::add):
+ (WebCore::HTMLSelectElement::value):
+ (WebCore::HTMLSelectElement::setValue):
+ (WebCore::HTMLSelectElement::childShouldCreateRenderer):
+ (WebCore::HTMLSelectElement::setLength):
+ (WebCore::HTMLSelectElement::nextValidIndex):
+ (WebCore::HTMLSelectElement::saveLastSelection):
+ (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
+ (WebCore::HTMLSelectElement::updateListBoxSelection):
+ (WebCore::HTMLSelectElement::listBoxOnChange):
+ (WebCore::HTMLSelectElement::recalcListItems):
+ (WebCore::HTMLSelectElement::selectedIndex):
+ (WebCore::HTMLSelectElement::selectOption):
+ (WebCore::HTMLSelectElement::optionToListIndex):
+ (WebCore::HTMLSelectElement::listToOptionIndex):
+ (WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
+ (WebCore::HTMLSelectElement::saveFormControlState):
+ (WebCore::HTMLSelectElement::searchOptionsForValue):
+ (WebCore::HTMLSelectElement::restoreFormControlState):
+ (WebCore::HTMLSelectElement::appendFormData):
+ (WebCore::HTMLSelectElement::reset):
+ (WebCore::HTMLSelectElement::updateSelectedState):
+ (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
+ (WebCore::HTMLSelectElement::lastSelectedListIndex):
+ (WebCore::HTMLSelectElement::optionAtIndex):
+ (WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
+ (WebCore::HTMLSelectElement::length):
+ * html/HTMLTagNames.in:
+ * html/RadioInputType.cpp:
+ (WebCore::RadioInputType::handleKeydownEvent):
+ (WebCore::RadioInputType::isKeyboardFocusable):
+ * html/parser/HTMLConstructionSite.cpp:
+ (WebCore::hasImpliedEndTag):
+ * html/parser/HTMLElementStack.cpp:
+ (WebCore::HTMLNames::isSelectScopeMarker):
+ * html/parser/HTMLTreeBuilder.cpp:
+ (WebCore::HTMLTreeBuilder::processStartTagForInBody):
+ (WebCore::HTMLTreeBuilder::processStartTag):
+ (WebCore::HTMLTreeBuilder::processEndTag):
+ * html/shadow/MediaControlElementTypes.cpp:
+ (WebCore::mediaControlElementType):
+ * loader/FormSubmission.cpp:
+ (WebCore::FormSubmission::create):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::handleFallbackContent):
+ * loader/ImageLoader.cpp:
+ (WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
+ * loader/SubframeLoader.cpp:
+ (WebCore::SubframeLoader::requestObject):
+ * loader/archive/cf/LegacyWebArchive.cpp:
+ (WebCore::LegacyWebArchive::create):
+ * page/Chrome.cpp:
+ (WebCore::Chrome::setToolTip):
+ * page/EventHandler.cpp:
+ (WebCore::isSubmitImage):
+ (WebCore::EventHandler::handleMousePressEvent):
+ * page/FocusController.cpp:
+ (WebCore::clearSelectionIfNeeded):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::addEmbeddedObjectToUpdate):
+ (WebCore::FrameView::updateEmbeddedObject):
+ * page/PageSerializer.cpp:
+ (WebCore::frameOwnerURLAttributeName):
+ * page/SpatialNavigation.cpp:
+ (WebCore::canScrollInDirection):
+ * rendering/HitTestResult.cpp:
+ (WebCore::HitTestResult::altDisplayString):
+ (WebCore::HitTestResult::absoluteImageURL):
+ (WebCore::HitTestResult::absolutePDFURL):
+ (WebCore::HitTestResult::isContentEditable):
+ * rendering/RenderBlockFlow.cpp:
+ (WebCore::resizeTextPermitted):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::sizesLogicalWidthToFitContent):
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::updateFromElement):
+ (WebCore::RenderButton::canHaveGeneratedChildren):
+ * rendering/RenderDetailsMarker.cpp:
+ (WebCore::RenderDetailsMarker::isOpen):
+ * rendering/RenderFileUploadControl.cpp:
+ (WebCore::RenderFileUploadControl::uploadButton):
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::updateAltText):
+ * rendering/RenderListBox.cpp:
+ (WebCore::RenderListBox::updateFromElement):
+ (WebCore::RenderListBox::addFocusRingRects):
+ (WebCore::RenderListBox::paintItemForeground):
+ (WebCore::RenderListBox::paintItemBackground):
+ * rendering/RenderMenuList.cpp:
+ (WebCore::selectedOptionCount):
+ (RenderMenuList::updateOptionsWidth):
+ (RenderMenuList::setTextFromOption):
+ (RenderMenuList::itemText):
+ (RenderMenuList::itemIsEnabled):
+ (RenderMenuList::itemIsSelected):
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::paintSliderTicks):
+ * testing/Internals.cpp:
+ (WebCore::Internals::selectColorInColorChooser):
+ (WebCore::Internals::wasLastChangeUserEdit):
+ (WebCore::Internals::isSelectPopupVisible):
+ * xml/parser/XMLDocumentParserLibxml2.cpp:
+ (WebCore::XMLDocumentParser::startElementNs):
+
</ins><span class="cx"> 2014-09-24 Eric Carlson <eric.carlson@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] Remove MediaPlayer::setHasPlaybackTargetAvailabilityListeners
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityListBoxOptioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/accessibility/AccessibilityListBoxOption.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -81,7 +81,7 @@
</span><span class="cx"> if (!m_optionElement)
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- if (!isHTMLOptionElement(m_optionElement))
</del><ins>+ if (!is<HTMLOptionElement>(m_optionElement))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> return downcast<HTMLOptionElement>(*m_optionElement).selected();
</span><span class="lines">@@ -134,7 +134,7 @@
</span><span class="cx"> if (!m_optionElement)
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- if (!isHTMLOptionElement(m_optionElement))
</del><ins>+ if (!is<HTMLOptionElement>(m_optionElement))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> if (m_optionElement->isDisabledFormControl())
</span><span class="lines">@@ -156,7 +156,7 @@
</span><span class="cx"> if (!ariaLabel.isNull())
</span><span class="cx"> return ariaLabel;
</span><span class="cx">
</span><del>- if (isHTMLOptionElement(m_optionElement))
</del><ins>+ if (is<HTMLOptionElement>(m_optionElement))
</ins><span class="cx"> return downcast<HTMLOptionElement>(*m_optionElement).text();
</span><span class="cx">
</span><span class="cx"> if (isHTMLOptGroupElement(m_optionElement))
</span><span class="lines">@@ -202,7 +202,7 @@
</span><span class="cx"> if (!m_optionElement)
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><del>- if (isHTMLOptionElement(m_optionElement))
</del><ins>+ if (is<HTMLOptionElement>(m_optionElement))
</ins><span class="cx"> return downcast<HTMLOptionElement>(*m_optionElement).ownerSelectElement();
</span><span class="cx">
</span><span class="cx"> if (isHTMLOptGroupElement(m_optionElement))
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityMediaControlscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityMediaControls.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityMediaControls.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/accessibility/AccessibilityMediaControls.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -274,7 +274,7 @@
</span><span class="cx"> String AccessibilityMediaTimeline::valueDescription() const
</span><span class="cx"> {
</span><span class="cx"> Node* node = m_renderer->node();
</span><del>- if (!isHTMLInputElement(node))
</del><ins>+ if (!is<HTMLInputElement>(node))
</ins><span class="cx"> return String();
</span><span class="cx">
</span><span class="cx"> float time = downcast<HTMLInputElement>(*node).value().toFloat();
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityMenuListOptioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/accessibility/AccessibilityMenuListOption.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx">
</span><span class="cx"> void AccessibilityMenuListOption::setElement(HTMLElement* element)
</span><span class="cx"> {
</span><del>- ASSERT_ARG(element, isHTMLOptionElement(element));
</del><ins>+ ASSERT_ARG(element, is<HTMLOptionElement>(element));
</ins><span class="cx"> m_element = element;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityMenuListPopupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -70,7 +70,7 @@
</span><span class="cx">
</span><span class="cx"> AccessibilityMenuListOption* AccessibilityMenuListPopup::menuListOptionAccessibilityObject(HTMLElement* element) const
</span><span class="cx"> {
</span><del>- if (!element || !isHTMLOptionElement(element) || !element->inRenderedDocument())
</del><ins>+ if (!element || !is<HTMLOptionElement>(element) || !element->inRenderedDocument())
</ins><span class="cx"> return nullptr;
</span><span class="cx">
</span><span class="cx"> AccessibilityObject* object = document()->axObjectCache()->getOrCreate(MenuListOptionRole);
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -290,7 +290,7 @@
</span><span class="cx"> return StaticTextRole;
</span><span class="cx"> if (node()->hasTagName(buttonTag))
</span><span class="cx"> return buttonRoleType();
</span><del>- if (isHTMLInputElement(node())) {
</del><ins>+ if (is<HTMLInputElement>(node())) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node());
</span><span class="cx"> if (input.isCheckbox())
</span><span class="cx"> return CheckBoxRole;
</span><span class="lines">@@ -313,7 +313,7 @@
</span><span class="cx"> HTMLSelectElement& selectElement = downcast<HTMLSelectElement>(*node());
</span><span class="cx"> return selectElement.multiple() ? ListBoxRole : PopUpButtonRole;
</span><span class="cx"> }
</span><del>- if (isHTMLTextAreaElement(node()))
</del><ins>+ if (is<HTMLTextAreaElement>(node()))
</ins><span class="cx"> return TextAreaRole;
</span><span class="cx"> if (headingLevel())
</span><span class="cx"> return HeadingRole;
</span><span class="lines">@@ -465,10 +465,10 @@
</span><span class="cx"> if (!node)
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- if (isHTMLTextAreaElement(node))
</del><ins>+ if (is<HTMLTextAreaElement>(node))
</ins><span class="cx"> return true;
</span><span class="cx">
</span><del>- if (isHTMLInputElement(node)) {
</del><ins>+ if (is<HTMLInputElement>(node)) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node);
</span><span class="cx"> return input.isText() || input.isNumberField();
</span><span class="cx"> }
</span><span class="lines">@@ -518,7 +518,7 @@
</span><span class="cx"> if (node->hasTagName(appletTag) || node->hasTagName(embedTag) || node->hasTagName(objectTag))
</span><span class="cx"> return true;
</span><span class="cx">
</span><del>- if (isHTMLInputElement(node)) {
</del><ins>+ if (is<HTMLInputElement>(node)) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node);
</span><span class="cx"> return input.isImageButton();
</span><span class="cx"> }
</span><span class="lines">@@ -553,7 +553,7 @@
</span><span class="cx"> if (!node)
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- if (roleValue() == ButtonRole && isHTMLInputElement(node)) {
</del><ins>+ if (roleValue() == ButtonRole && is<HTMLInputElement>(node)) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node);
</span><span class="cx"> return input.isImageButton();
</span><span class="cx"> }
</span><span class="lines">@@ -738,10 +738,10 @@
</span><span class="cx"> if (!node)
</span><span class="cx"> return true;
</span><span class="cx">
</span><del>- if (isHTMLTextAreaElement(node))
</del><ins>+ if (is<HTMLTextAreaElement>(node))
</ins><span class="cx"> return toHTMLFormControlElement(node)->isReadOnly();
</span><span class="cx">
</span><del>- if (isHTMLInputElement(node)) {
</del><ins>+ if (is<HTMLInputElement>(node)) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node);
</span><span class="cx"> if (input.isTextField())
</span><span class="cx"> return input.isReadOnly();
</span><span class="lines">@@ -837,7 +837,7 @@
</span><span class="cx">
</span><span class="cx"> float AccessibilityNodeObject::valueForRange() const
</span><span class="cx"> {
</span><del>- if (node() && isHTMLInputElement(node())) {
</del><ins>+ if (node() && is<HTMLInputElement>(node())) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node());
</span><span class="cx"> if (input.isRangeControl())
</span><span class="cx"> return input.valueAsNumber();
</span><span class="lines">@@ -851,7 +851,7 @@
</span><span class="cx">
</span><span class="cx"> float AccessibilityNodeObject::maxValueForRange() const
</span><span class="cx"> {
</span><del>- if (node() && isHTMLInputElement(node())) {
</del><ins>+ if (node() && is<HTMLInputElement>(node())) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node());
</span><span class="cx"> if (input.isRangeControl())
</span><span class="cx"> return input.maximum();
</span><span class="lines">@@ -865,7 +865,7 @@
</span><span class="cx">
</span><span class="cx"> float AccessibilityNodeObject::minValueForRange() const
</span><span class="cx"> {
</span><del>- if (node() && isHTMLInputElement(node())) {
</del><ins>+ if (node() && is<HTMLInputElement>(node())) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node());
</span><span class="cx"> if (input.isRangeControl())
</span><span class="cx"> return input.minimum();
</span><span class="lines">@@ -973,7 +973,7 @@
</span><span class="cx">
</span><span class="cx"> static bool isNodeActionElement(Node* node)
</span><span class="cx"> {
</span><del>- if (isHTMLInputElement(node)) {
</del><ins>+ if (is<HTMLInputElement>(node)) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node);
</span><span class="cx"> if (!input.isDisabledFormControl() && (input.isRadioButton() || input.isCheckbox() || input.isTextButton() || input.isFileUpload() || input.isImageButton()))
</span><span class="cx"> return true;
</span><span class="lines">@@ -1251,7 +1251,7 @@
</span><span class="cx"> if (!node)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- bool isInputTag = isHTMLInputElement(node);
</del><ins>+ bool isInputTag = is<HTMLInputElement>(node);
</ins><span class="cx"> if (isInputTag || AccessibilityObject::isARIAInput(ariaRoleAttribute()) || isControl()) {
</span><span class="cx"> HTMLLabelElement* label = labelForElement(toElement(node));
</span><span class="cx"> if (label) {
</span><span class="lines">@@ -1328,7 +1328,7 @@
</span><span class="cx"> if (!node)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- bool isInputTag = isHTMLInputElement(node);
</del><ins>+ bool isInputTag = is<HTMLInputElement>(node);
</ins><span class="cx"> if (isInputTag) {
</span><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node);
</span><span class="cx"> if (input.isTextButton()) {
</span><span class="lines">@@ -1683,7 +1683,7 @@
</span><span class="cx"> if (!node)
</span><span class="cx"> return String();
</span><span class="cx">
</span><del>- bool isInputTag = isHTMLInputElement(node);
</del><ins>+ bool isInputTag = is<HTMLInputElement>(node);
</ins><span class="cx"> if (isInputTag) {
</span><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node);
</span><span class="cx"> if (input.isTextButton())
</span><span class="lines">@@ -1809,7 +1809,7 @@
</span><span class="cx"> if (!isColorWell())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (!node() || !isHTMLInputElement(node()))
</del><ins>+ if (!node() || !is<HTMLInputElement>(node()))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node());
</span><span class="lines">@@ -1841,7 +1841,7 @@
</span><span class="cx"> if (!alt.isEmpty())
</span><span class="cx"> return alt;
</span><span class="cx">
</span><del>- if (isHTMLInputElement(node))
</del><ins>+ if (is<HTMLInputElement>(node))
</ins><span class="cx"> return downcast<HTMLInputElement>(*node).value();
</span><span class="cx">
</span><span class="cx"> // If the node can be turned into an AX object, we can use standard name computation rules.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -523,7 +523,7 @@
</span><span class="cx">
</span><span class="cx"> bool AccessibilityRenderObject::isFileUploadButton() const
</span><span class="cx"> {
</span><del>- if (m_renderer && m_renderer->node() && isHTMLInputElement(m_renderer->node())) {
</del><ins>+ if (m_renderer && m_renderer->node() && is<HTMLInputElement>(m_renderer->node())) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*m_renderer->node());
</span><span class="cx"> return input.isFileUpload();
</span><span class="cx"> }
</span><span class="lines">@@ -950,7 +950,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> Node* node = m_renderer->node();
</span><del>- if (!node || !isHTMLInputElement(node))
</del><ins>+ if (!node || !is<HTMLInputElement>(node))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node);
</span><span class="lines">@@ -968,7 +968,7 @@
</span><span class="cx"> unsigned length = list->length();
</span><span class="cx"> for (unsigned i = 0; i < length; ++i) {
</span><span class="cx"> Node* item = list->item(i);
</span><del>- if (isHTMLInputElement(item)) {
</del><ins>+ if (is<HTMLInputElement>(item)) {
</ins><span class="cx"> HTMLInputElement& associateElement = downcast<HTMLInputElement>(*item);
</span><span class="cx"> if (associateElement.isRadioButton() && associateElement.name() == input.name()) {
</span><span class="cx"> if (AccessibilityObject* object = axObjectCache()->getOrCreate(&associateElement))
</span><span class="lines">@@ -1687,9 +1687,9 @@
</span><span class="cx"> RenderBoxModelObject* renderer = toRenderBoxModelObject(m_renderer);
</span><span class="cx">
</span><span class="cx"> // FIXME: Do we want to do anything here for ARIA textboxes?
</span><del>- if (renderer->isTextField() && isHTMLInputElement(element))
</del><ins>+ if (renderer->isTextField() && is<HTMLInputElement>(element))
</ins><span class="cx"> downcast<HTMLInputElement>(element).setValue(string);
</span><del>- else if (renderer->isTextArea() && isHTMLTextAreaElement(element))
</del><ins>+ else if (renderer->isTextArea() && is<HTMLTextAreaElement>(element))
</ins><span class="cx"> downcast<HTMLTextAreaElement>(element).setValue(string);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2211,7 +2211,7 @@
</span><span class="cx"> if (isHTMLAreaElement(node))
</span><span class="cx"> return accessibilityImageMapHitTest(downcast<HTMLAreaElement>(node), point);
</span><span class="cx">
</span><del>- if (isHTMLOptionElement(node))
</del><ins>+ if (is<HTMLOptionElement>(node))
</ins><span class="cx"> node = downcast<HTMLOptionElement>(*node).ownerSelectElement();
</span><span class="cx">
</span><span class="cx"> RenderObject* obj = node->renderer();
</span><span class="lines">@@ -2483,7 +2483,7 @@
</span><span class="cx"> if (m_renderer->isText())
</span><span class="cx"> return StaticTextRole;
</span><span class="cx"> if (cssBox && cssBox->isImage()) {
</span><del>- if (node && isHTMLInputElement(node))
</del><ins>+ if (node && is<HTMLInputElement>(node))
</ins><span class="cx"> return ariaHasPopup() ? PopUpButtonRole : ButtonRole;
</span><span class="cx"> if (isSVGImage())
</span><span class="cx"> return SVGRootRole;
</span><span class="lines">@@ -2502,7 +2502,7 @@
</span><span class="cx"> if (cssBox && cssBox->isTextArea())
</span><span class="cx"> return TextAreaRole;
</span><span class="cx">
</span><del>- if (node && isHTMLInputElement(node)) {
</del><ins>+ if (node && is<HTMLInputElement>(node)) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node);
</span><span class="cx"> if (input.isCheckbox())
</span><span class="cx"> return CheckBoxRole;
</span><span class="lines">@@ -2836,7 +2836,7 @@
</span><span class="cx"> void AccessibilityRenderObject::addTextFieldChildren()
</span><span class="cx"> {
</span><span class="cx"> Node* node = this->node();
</span><del>- if (!node || !isHTMLInputElement(node))
</del><ins>+ if (!node || !is<HTMLInputElement>(node))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*node);
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityatkAXObjectCacheAtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -133,7 +133,7 @@
</span><span class="cx">
</span><span class="cx"> // Only support HTML select elements so far (ARIA selectors not supported).
</span><span class="cx"> Node* node = object->node();
</span><del>- if (!node || !isHTMLSelectElement(node))
</del><ins>+ if (!node || !is<HTMLSelectElement>(node))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> // Emit signal from the listbox's point of view first.
</span></span></pre></div>
<a id="trunkSourceWebCorecssSelectorCheckerTestFunctionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx">
</span><span class="cx"> ALWAYS_INLINE bool isDisabled(const Element* element)
</span><span class="cx"> {
</span><del>- if (element->isFormControlElement() || isHTMLOptionElement(element) || isHTMLOptGroupElement(element))
</del><ins>+ if (element->isFormControlElement() || is<HTMLOptionElement>(element) || is<HTMLOptGroupElement>(element))
</ins><span class="cx"> return element->isDisabledFormControl();
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="lines">@@ -66,10 +66,10 @@
</span><span class="cx"> ALWAYS_INLINE bool isEnabled(const Element* element)
</span><span class="cx"> {
</span><span class="cx"> bool isEnabled = false;
</span><del>- if (element->isFormControlElement() || isHTMLOptionElement(element) || isHTMLOptGroupElement(element))
</del><ins>+ if (element->isFormControlElement() || is<HTMLOptionElement>(element) || is<HTMLOptGroupElement>(element))
</ins><span class="cx"> isEnabled = !element->isDisabledFormControl();
</span><span class="cx"> else if (element->isLink())
</span><del>- isEnabled = isHTMLAnchorElement(element) || isHTMLAreaElement(element);
</del><ins>+ isEnabled = is<HTMLAnchorElement>(element) || is<HTMLAreaElement>(element);
</ins><span class="cx"> return isEnabled;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx"> const HTMLInputElement* inputElement = element->toInputElement();
</span><span class="cx"> if (inputElement && inputElement->shouldAppearChecked() && !inputElement->shouldAppearIndeterminate())
</span><span class="cx"> return true;
</span><del>- if (isHTMLOptionElement(element) && downcast<HTMLOptionElement>(*element).selected())
</del><ins>+ if (is<HTMLOptionElement>(element) && downcast<HTMLOptionElement>(*element).selected())
</ins><span class="cx"> return true;
</span><span class="cx"> return false;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleResolvercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleResolver.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleResolver.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -1270,7 +1270,7 @@
</span><span class="cx"> style.setZIndex(0);
</span><span class="cx">
</span><span class="cx"> // Textarea considers overflow visible as auto.
</span><del>- if (e && isHTMLTextAreaElement(e)) {
</del><ins>+ if (e && is<HTMLTextAreaElement>(e)) {
</ins><span class="cx"> style.setOverflowX(style.overflowX() == OVISIBLE ? OAUTO : style.overflowX());
</span><span class="cx"> style.setOverflowY(style.overflowY() == OVISIBLE ? OAUTO : style.overflowY());
</span><span class="cx"> }
</span><span class="lines">@@ -1338,7 +1338,7 @@
</span><span class="cx"> if (e && e->isFormControlElement() && style.fontSize() >= 11) {
</span><span class="cx"> // Don't apply intrinsic margins to image buttons. The designer knows how big the images are,
</span><span class="cx"> // so we have to treat all image buttons as though they were explicitly sized.
</span><del>- if (!isHTMLInputElement(e) || !downcast<HTMLInputElement>(*e).isImageButton())
</del><ins>+ if (!is<HTMLInputElement>(e) || !downcast<HTMLInputElement>(*e).isImageButton())
</ins><span class="cx"> addIntrinsicMargins(style);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomEventDispatchercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/EventDispatcher.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/dom/EventDispatcher.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -356,7 +356,7 @@
</span><span class="cx"> WindowEventContext windowEventContext(node.get(), eventPath.lastContextIfExists());
</span><span class="cx">
</span><span class="cx"> InputElementClickState clickHandlingState;
</span><del>- if (isHTMLInputElement(node.get()))
</del><ins>+ if (is<HTMLInputElement>(node.get()))
</ins><span class="cx"> downcast<HTMLInputElement>(*node).willDispatchEvent(*event, clickHandlingState);
</span><span class="cx">
</span><span class="cx"> if (!event->propagationStopped() && !eventPath.isEmpty())
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingFrameSelectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/FrameSelection.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -1670,7 +1670,7 @@
</span><span class="cx"> Document* document = m_frame->document();
</span><span class="cx">
</span><span class="cx"> Element* focusedElement = document->focusedElement();
</span><del>- if (focusedElement && isHTMLSelectElement(focusedElement)) {
</del><ins>+ if (focusedElement && is<HTMLSelectElement>(focusedElement)) {
</ins><span class="cx"> HTMLSelectElement& selectElement = downcast<HTMLSelectElement>(*focusedElement);
</span><span class="cx"> if (selectElement.canSelectAll()) {
</span><span class="cx"> selectElement.selectAll();
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingReplaceSelectionCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -1273,7 +1273,7 @@
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> Element* textControl = enclosingTextFormControl(positionAtStartOfInsertedContent().deepEquivalent());
</span><del>- if (textControl && isHTMLInputElement(textControl) && downcast<HTMLInputElement>(*textControl).isPasswordField())
</del><ins>+ if (textControl && is<HTMLInputElement>(textControl) && downcast<HTMLInputElement>(*textControl).isPasswordField())
</ins><span class="cx"> return false; // Disable smart replace for password fields.
</span><span class="cx">
</span><span class="cx"> return true;
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingVisibleSelectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/VisibleSelection.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/VisibleSelection.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/editing/VisibleSelection.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -664,7 +664,7 @@
</span><span class="cx"> bool VisibleSelection::isInPasswordField() const
</span><span class="cx"> {
</span><span class="cx"> HTMLTextFormControlElement* textControl = enclosingTextFormControl(start());
</span><del>- return textControl && isHTMLInputElement(textControl) && downcast<HTMLInputElement>(*textControl).isPasswordField();
</del><ins>+ return textControl && is<HTMLInputElement>(textControl) && downcast<HTMLInputElement>(*textControl).isPasswordField();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingcocoaHTMLConvertermm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -2042,7 +2042,7 @@
</span><span class="cx"> } else if (element.hasTagName(qTag)) {
</span><span class="cx"> _addQuoteForElement(element, YES, _quoteLevel++);
</span><span class="cx"> } else if (element.hasTagName(inputTag)) {
</span><del>- if (isHTMLInputElement(element)) {
</del><ins>+ if (is<HTMLInputElement>(element)) {
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(element);
</span><span class="cx"> if (inputElement.type() == "text") {
</span><span class="cx"> NSString *value = inputElement.value();
</span><span class="lines">@@ -2051,7 +2051,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> } else if (element.hasTagName(textareaTag)) {
</span><del>- if (isHTMLTextAreaElement(element)) {
</del><ins>+ if (is<HTMLTextAreaElement>(element)) {
</ins><span class="cx"> HTMLTextAreaElement& textAreaElement = downcast<HTMLTextAreaElement>(element);
</span><span class="cx"> NSString *value = textAreaElement.value();
</span><span class="cx"> if (value && [value length] > 0)
</span></span></pre></div>
<a id="trunkSourceWebCoreeditinggtkEditorGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/gtk/EditorGtk.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/gtk/EditorGtk.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/editing/gtk/EditorGtk.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -82,11 +82,11 @@
</span><span class="cx">
</span><span class="cx"> static const AtomicString& elementURL(Element& element)
</span><span class="cx"> {
</span><del>- if (isHTMLImageElement(element) || isHTMLInputElement(element))
</del><ins>+ if (is<HTMLImageElement>(element) || is<HTMLInputElement>(element))
</ins><span class="cx"> return element.fastGetAttribute(HTMLNames::srcAttr);
</span><span class="cx"> if (is<SVGImageElement>(element))
</span><span class="cx"> return element.fastGetAttribute(XLinkNames::hrefAttr);
</span><del>- if (isHTMLEmbedElement(element) || isHTMLObjectElement(element))
</del><ins>+ if (is<HTMLEmbedElement>(element) || is<HTMLObjectElement>(element))
</ins><span class="cx"> return element.imageSourceURL();
</span><span class="cx"> return nullAtom;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingiosEditorIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ios/EditorIOS.mm (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ios/EditorIOS.mm 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/editing/ios/EditorIOS.mm 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -181,7 +181,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> Element* focusedElement = m_frame.document()->focusedElement();
</span><del>- if (focusedElement && (isHTMLTextAreaElement(focusedElement) || (isHTMLInputElement(focusedElement)
</del><ins>+ if (focusedElement && (is<HTMLTextAreaElement>(focusedElement) || (is<HTMLInputElement>(focusedElement)
</ins><span class="cx"> && (downcast<HTMLInputElement>(*focusedElement).isTextField()
</span><span class="cx"> || downcast<HTMLInputElement>(*focusedElement).isSearchField())))) {
</span><span class="cx"> if (direction == NaturalWritingDirection)
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingmarkupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/markup.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/markup.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/editing/markup.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -234,7 +234,7 @@
</span><span class="cx">
</span><span class="cx"> void StyledMarkupAccumulator::appendText(StringBuilder& out, const Text& text)
</span><span class="cx"> {
</span><del>- const bool parentIsTextarea = text.parentElement() && isHTMLTextAreaElement(text.parentElement());
</del><ins>+ const bool parentIsTextarea = text.parentElement() && is<HTMLTextAreaElement>(text.parentElement());
</ins><span class="cx"> const bool wrappingSpan = shouldApplyWrappingStyle(text) && !parentIsTextarea;
</span><span class="cx"> if (wrappingSpan) {
</span><span class="cx"> RefPtr<EditingStyle> wrappingStyle = m_wrappingStyle->copy();
</span><span class="lines">@@ -743,7 +743,7 @@
</span><span class="cx">
</span><span class="cx"> bool isPlainTextMarkup(Node* node)
</span><span class="cx"> {
</span><del>- if (!isHTMLDivElement(node))
</del><ins>+ if (!is<HTMLDivElement>(node))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> HTMLDivElement& element = downcast<HTMLDivElement>(*node);
</span><span class="lines">@@ -929,7 +929,7 @@
</span><span class="cx"> {
</span><span class="cx"> Vector<Ref<HTMLElement>> toRemove;
</span><span class="cx"> for (auto& element : childrenOfType<HTMLElement>(container)) {
</span><del>- if (isHTMLHtmlElement(element)) {
</del><ins>+ if (is<HTMLHtmlElement>(element)) {
</ins><span class="cx"> toRemove.append(element);
</span><span class="cx"> collectElementsToRemoveFromFragment(element);
</span><span class="cx"> continue;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLCollectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLCollection.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLCollection.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/HTMLCollection.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -191,9 +191,9 @@
</span><span class="cx"> case SelectOptions:
</span><span class="cx"> return element.hasTagName(optionTag);
</span><span class="cx"> case SelectedOptions:
</span><del>- return isHTMLOptionElement(element) && downcast<HTMLOptionElement>(element).selected();
</del><ins>+ return is<HTMLOptionElement>(element) && downcast<HTMLOptionElement>(element).selected();
</ins><span class="cx"> case DataListOptions:
</span><del>- if (isHTMLOptionElement(element)) {
</del><ins>+ if (is<HTMLOptionElement>(element)) {
</ins><span class="cx"> HTMLOptionElement& option = downcast<HTMLOptionElement>(element);
</span><span class="cx"> if (!option.isDisabledFormControl() && !option.value().isEmpty())
</span><span class="cx"> return true;
</span><span class="lines">@@ -202,7 +202,7 @@
</span><span class="cx"> case MapAreas:
</span><span class="cx"> return element.hasTagName(areaTag);
</span><span class="cx"> case DocApplets:
</span><del>- return element.hasTagName(appletTag) || (isHTMLObjectElement(element) && downcast<HTMLObjectElement>(element).containsJavaApplet());
</del><ins>+ return is<HTMLAppletElement>(element) || (is<HTMLObjectElement>(element) && downcast<HTMLObjectElement>(element).containsJavaApplet());
</ins><span class="cx"> case DocEmbeds:
</span><span class="cx"> return element.hasTagName(embedTag);
</span><span class="cx"> case DocLinks:
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLEmbedElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLEmbedElement.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLEmbedElement.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/HTMLEmbedElement.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -189,7 +189,7 @@
</span><span class="cx"> // If my parent is an <object> and is not set to use fallback content, I
</span><span class="cx"> // should be ignored and not get a renderer.
</span><span class="cx"> ContainerNode* parent = parentNode();
</span><del>- if (parent && isHTMLObjectElement(parent)) {
</del><ins>+ if (parent && is<HTMLObjectElement>(parent)) {
</ins><span class="cx"> if (!parent->renderer())
</span><span class="cx"> return false;
</span><span class="cx"> if (!downcast<HTMLObjectElement>(*parent).useFallbackContent()) {
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormControlElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -192,7 +192,7 @@
</span><span class="cx">
</span><span class="cx"> // FIXME: Should this set of hasTagName checks be replaced by a
</span><span class="cx"> // virtual member function?
</span><del>- if (isHTMLInputElement(element))
</del><ins>+ if (is<HTMLInputElement>(element))
</ins><span class="cx"> return !downcast<HTMLInputElement>(*element).isInputTypeHidden();
</span><span class="cx"> if (element->hasTagName(selectTag))
</span><span class="cx"> return true;
</span><span class="lines">@@ -200,7 +200,7 @@
</span><span class="cx"> return true;
</span><span class="cx"> if (element->hasTagName(buttonTag))
</span><span class="cx"> return true;
</span><del>- if (isHTMLTextAreaElement(element))
</del><ins>+ if (is<HTMLTextAreaElement>(element))
</ins><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormElement.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -316,7 +316,7 @@
</span><span class="cx"> for (unsigned i = 0; i < m_associatedElements.size(); ++i) {
</span><span class="cx"> FormAssociatedElement& control = *m_associatedElements[i];
</span><span class="cx"> HTMLElement& element = control.asHTMLElement();
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> continue;
</span><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(element);
</span><span class="cx"> if (!input.isTextField())
</span><span class="lines">@@ -592,7 +592,7 @@
</span><span class="cx"> for (auto& element : descendants) {
</span><span class="cx"> if (&element == &associatedHTMLElement)
</span><span class="cx"> return i;
</span><del>- if (!isHTMLFormControlElement(element) && !isHTMLObjectElement(element))
</del><ins>+ if (!isHTMLFormControlElement(element) && !is<HTMLObjectElement>(element))
</ins><span class="cx"> continue;
</span><span class="cx"> if (element.form() != this)
</span><span class="cx"> continue;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLImageLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLImageLoader.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLImageLoader.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/HTMLImageLoader.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx">
</span><span class="cx"> bool errorOccurred = image()->errorOccurred();
</span><span class="cx"> if (!errorOccurred && image()->response().httpStatusCode() >= 400)
</span><del>- errorOccurred = isHTMLObjectElement(element()); // An <object> considers a 404 to be an error and should fire onerror.
</del><ins>+ errorOccurred = is<HTMLObjectElement>(element()); // An <object> considers a 404 to be an error and should fire onerror.
</ins><span class="cx"> element().dispatchEvent(Event::create(errorOccurred ? eventNames().errorEvent : eventNames().loadEvent, false, false));
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (loadError && isHTMLObjectElement(element()))
</del><ins>+ if (loadError && is<HTMLObjectElement>(element()))
</ins><span class="cx"> downcast<HTMLObjectElement>(element()).renderFallbackContent();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLNameCollectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLNameCollection.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLNameCollection.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/HTMLNameCollection.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -66,15 +66,15 @@
</span><span class="cx"> bool DocumentNameCollection::elementMatchesIfIdAttributeMatch(const Element& element)
</span><span class="cx"> {
</span><span class="cx"> // FIXME: we need to fix HTMLImageElement to update the hash map for us when name attribute has been removed.
</span><del>- return element.hasTagName(appletTag) || (isHTMLObjectElement(element) && downcast<HTMLObjectElement>(element).isDocNamedItem())
- || (isHTMLImageElement(element) && element.hasName());
</del><ins>+ return is<HTMLAppletElement>(element) || (is<HTMLObjectElement>(element) && downcast<HTMLObjectElement>(element).isDocNamedItem())
+ || (is<HTMLImageElement>(element) && element.hasName());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool DocumentNameCollection::elementMatchesIfNameAttributeMatch(const Element& element)
</span><span class="cx"> {
</span><del>- return isHTMLFormElement(element) || element.hasTagName(embedTag) || element.hasTagName(iframeTag)
- || element.hasTagName(appletTag) || (isHTMLObjectElement(element) && downcast<HTMLObjectElement>(element).isDocNamedItem())
- || isHTMLImageElement(element);
</del><ins>+ return is<HTMLFormElement>(element) || is<HTMLEmbedElement>(element) || is<HTMLIFrameElement>(element)
+ || is<HTMLAppletElement>(element) || (is<HTMLObjectElement>(element) && downcast<HTMLObjectElement>(element).isDocNamedItem())
+ || is<HTMLImageElement>(element);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool DocumentNameCollection::elementMatches(const Element& element, const AtomicStringImpl* name)
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx"> return element.getNameAttribute().impl() == name;
</span><span class="cx"> if (element.hasTagName(appletTag))
</span><span class="cx"> return element.getNameAttribute().impl() == name || element.getIdAttribute().impl() == name;
</span><del>- if (isHTMLObjectElement(element))
</del><ins>+ if (is<HTMLObjectElement>(element))
</ins><span class="cx"> return (element.getNameAttribute().impl() == name || element.getIdAttribute().impl() == name) && downcast<HTMLObjectElement>(element).isDocNamedItem();
</span><span class="cx"> if (isHTMLImageElement(element))
</span><span class="cx"> return element.getNameAttribute().impl() == name || (element.getIdAttribute().impl() == name && element.hasName());
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptGroupElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptGroupElement.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptGroupElement.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/HTMLOptGroupElement.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx"> void HTMLOptGroupElement::recalcSelectOptions()
</span><span class="cx"> {
</span><span class="cx"> ContainerNode* select = parentNode();
</span><del>- while (select && !isHTMLSelectElement(select))
</del><ins>+ while (select && !is<HTMLSelectElement>(select))
</ins><span class="cx"> select = select->parentNode();
</span><span class="cx"> if (select)
</span><span class="cx"> downcast<HTMLSelectElement>(*select).setRecalcListItems();
</span><span class="lines">@@ -107,7 +107,7 @@
</span><span class="cx"> HTMLSelectElement* HTMLOptGroupElement::ownerSelectElement() const
</span><span class="cx"> {
</span><span class="cx"> ContainerNode* select = parentNode();
</span><del>- while (select && !isHTMLSelectElement(select))
</del><ins>+ while (select && !is<HTMLSelectElement>(select))
</ins><span class="cx"> select = select->parentNode();
</span><span class="cx">
</span><span class="cx"> if (!select)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptionElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptionElement.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptionElement.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/HTMLOptionElement.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -160,7 +160,7 @@
</span><span class="cx"> const Vector<HTMLElement*>& items = selectElement->listItems();
</span><span class="cx"> size_t length = items.size();
</span><span class="cx"> for (size_t i = 0; i < length; ++i) {
</span><del>- if (!isHTMLOptionElement(items[i]))
</del><ins>+ if (!is<HTMLOptionElement>(items[i]))
</ins><span class="cx"> continue;
</span><span class="cx"> if (items[i] == this)
</span><span class="cx"> return optionIndex;
</span><span class="lines">@@ -267,7 +267,7 @@
</span><span class="cx"> HTMLSelectElement* HTMLOptionElement::ownerSelectElement() const
</span><span class="cx"> {
</span><span class="cx"> ContainerNode* select = parentNode();
</span><del>- while (select && !isHTMLSelectElement(select))
</del><ins>+ while (select && !is<HTMLSelectElement>(select))
</ins><span class="cx"> select = select->parentNode();
</span><span class="cx">
</span><span class="cx"> if (!select)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -220,7 +220,7 @@
</span><span class="cx">
</span><span class="cx"> void HTMLSelectElement::add(HTMLElement* element, HTMLElement* before, ExceptionCode& ec)
</span><span class="cx"> {
</span><del>- if (!element || !(isHTMLOptionElement(*element) || element->hasTagName(hrTag)))
</del><ins>+ if (!element || !(is<HTMLOptionElement>(*element) || element->hasTagName(hrTag)))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> // Make sure the element is ref'd and deref'd so we don't leak it.
</span><span class="lines">@@ -250,7 +250,7 @@
</span><span class="cx"> String HTMLSelectElement::value() const
</span><span class="cx"> {
</span><span class="cx"> for (auto* item : listItems()) {
</span><del>- if (isHTMLOptionElement(*item)) {
</del><ins>+ if (is<HTMLOptionElement>(*item)) {
</ins><span class="cx"> HTMLOptionElement& option = downcast<HTMLOptionElement>(*item);
</span><span class="cx"> if (option.selected())
</span><span class="cx"> return option.value();
</span><span class="lines">@@ -270,7 +270,7 @@
</span><span class="cx"> // Find the option with value() matching the given parameter and make it the current selection.
</span><span class="cx"> unsigned optionIndex = 0;
</span><span class="cx"> for (auto* item : listItems()) {
</span><del>- if (isHTMLOptionElement(*item)) {
</del><ins>+ if (is<HTMLOptionElement>(*item)) {
</ins><span class="cx"> if (downcast<HTMLOptionElement>(*item).value() == value) {
</span><span class="cx"> setSelectedIndex(optionIndex);
</span><span class="cx"> return;
</span><span class="lines">@@ -363,7 +363,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="cx"> if (!usesMenuList())
</span><del>- return isHTMLOptionElement(child) || isHTMLOptGroupElement(child) || validationMessageShadowTreeContains(child);
</del><ins>+ return is<HTMLOptionElement>(child) || is<HTMLOptGroupElement>(child) || validationMessageShadowTreeContains(child);
</ins><span class="cx"> #endif
</span><span class="cx"> return validationMessageShadowTreeContains(child);
</span><span class="cx"> }
</span><span class="lines">@@ -483,7 +483,7 @@
</span><span class="cx"> Vector<RefPtr<Element>> itemsToRemove;
</span><span class="cx"> size_t optionIndex = 0;
</span><span class="cx"> for (auto& item : items) {
</span><del>- if (isHTMLOptionElement(*item) && optionIndex++ >= newLen) {
</del><ins>+ if (is<HTMLOptionElement>(*item) && optionIndex++ >= newLen) {
</ins><span class="cx"> ASSERT(item->parentNode());
</span><span class="cx"> itemsToRemove.append(item);
</span><span class="cx"> }
</span><span class="lines">@@ -521,7 +521,7 @@
</span><span class="cx"> int size = listItems.size();
</span><span class="cx"> for (listIndex += direction; listIndex >= 0 && listIndex < size; listIndex += direction) {
</span><span class="cx"> --skip;
</span><del>- if (!listItems[listIndex]->isDisabledFormControl() && isHTMLOptionElement(listItems[listIndex])) {
</del><ins>+ if (!listItems[listIndex]->isDisabledFormControl() && is<HTMLOptionElement>(listItems[listIndex])) {
</ins><span class="cx"> lastGoodIndex = listIndex;
</span><span class="cx"> if (skip <= 0)
</span><span class="cx"> break;
</span><span class="lines">@@ -605,7 +605,7 @@
</span><span class="cx"> const Vector<HTMLElement*>& items = listItems();
</span><span class="cx"> for (unsigned i = 0; i < items.size(); ++i) {
</span><span class="cx"> HTMLElement* element = items[i];
</span><del>- m_lastOnChangeSelection.append(isHTMLOptionElement(element) && downcast<HTMLOptionElement>(element)->selected());
</del><ins>+ m_lastOnChangeSelection.append(is<HTMLOptionElement>(element) && downcast<HTMLOptionElement>(element)->selected());
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -620,7 +620,7 @@
</span><span class="cx"> const Vector<HTMLElement*>& items = listItems();
</span><span class="cx"> for (unsigned i = 0; i < items.size(); ++i) {
</span><span class="cx"> HTMLElement* element = items[i];
</span><del>- m_cachedStateForActiveSelection.append(isHTMLOptionElement(element) && downcast<HTMLOptionElement>(element)->selected());
</del><ins>+ m_cachedStateForActiveSelection.append(is<HTMLOptionElement>(element) && downcast<HTMLOptionElement>(element)->selected());
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -644,7 +644,7 @@
</span><span class="cx"> const Vector<HTMLElement*>& items = listItems();
</span><span class="cx"> for (unsigned i = 0; i < items.size(); ++i) {
</span><span class="cx"> HTMLElement* element = items[i];
</span><del>- if (!isHTMLOptionElement(element) || downcast<HTMLOptionElement>(*element).isDisabledFormControl())
</del><ins>+ if (!is<HTMLOptionElement>(element) || downcast<HTMLOptionElement>(*element).isDisabledFormControl())
</ins><span class="cx"> continue;
</span><span class="cx">
</span><span class="cx"> if (i >= start && i <= end)
</span><span class="lines">@@ -676,7 +676,7 @@
</span><span class="cx"> bool fireOnChange = false;
</span><span class="cx"> for (unsigned i = 0; i < items.size(); ++i) {
</span><span class="cx"> HTMLElement* element = items[i];
</span><del>- bool selected = isHTMLOptionElement(element) && downcast<HTMLOptionElement>(*element).selected();
</del><ins>+ bool selected = is<HTMLOptionElement>(element) && downcast<HTMLOptionElement>(*element).selected();
</ins><span class="cx"> if (selected != m_lastOnChangeSelection[i])
</span><span class="cx"> fireOnChange = true;
</span><span class="cx"> m_lastOnChangeSelection[i] = selected;
</span><span class="lines">@@ -798,7 +798,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (isHTMLOptionElement(current)) {
</del><ins>+ if (is<HTMLOptionElement>(current)) {
</ins><span class="cx"> m_listItems.append(current);
</span><span class="cx">
</span><span class="cx"> if (updateSelectedStates && !m_multiple) {
</span><span class="lines">@@ -840,7 +840,7 @@
</span><span class="cx"> const Vector<HTMLElement*>& items = listItems();
</span><span class="cx"> for (size_t i = 0; i < items.size(); ++i) {
</span><span class="cx"> HTMLElement* element = items[i];
</span><del>- if (isHTMLOptionElement(element)) {
</del><ins>+ if (is<HTMLOptionElement>(element)) {
</ins><span class="cx"> if (downcast<HTMLOptionElement>(*element).selected())
</span><span class="cx"> return index;
</span><span class="cx"> ++index;
</span><span class="lines">@@ -876,7 +876,7 @@
</span><span class="cx"> HTMLElement* element = nullptr;
</span><span class="cx"> if (listIndex >= 0) {
</span><span class="cx"> element = items[listIndex];
</span><del>- if (isHTMLOptionElement(element)) {
</del><ins>+ if (is<HTMLOptionElement>(element)) {
</ins><span class="cx"> if (m_activeSelectionAnchorIndex < 0 || shouldDeselect)
</span><span class="cx"> setActiveSelectionAnchorIndex(listIndex);
</span><span class="cx"> if (m_activeSelectionEndIndex < 0 || shouldDeselect)
</span><span class="lines">@@ -918,7 +918,7 @@
</span><span class="cx">
</span><span class="cx"> int optionIndex2 = -1;
</span><span class="cx"> for (int listIndex = 0; listIndex < listSize; ++listIndex) {
</span><del>- if (isHTMLOptionElement(items[listIndex])) {
</del><ins>+ if (is<HTMLOptionElement>(items[listIndex])) {
</ins><span class="cx"> ++optionIndex2;
</span><span class="cx"> if (optionIndex2 == optionIndex)
</span><span class="cx"> return listIndex;
</span><span class="lines">@@ -931,13 +931,13 @@
</span><span class="cx"> int HTMLSelectElement::listToOptionIndex(int listIndex) const
</span><span class="cx"> {
</span><span class="cx"> const Vector<HTMLElement*>& items = listItems();
</span><del>- if (listIndex < 0 || listIndex >= static_cast<int>(items.size()) || !isHTMLOptionElement(items[listIndex]))
</del><ins>+ if (listIndex < 0 || listIndex >= static_cast<int>(items.size()) || !is<HTMLOptionElement>(items[listIndex]))
</ins><span class="cx"> return -1;
</span><span class="cx">
</span><span class="cx"> // Actual index of option not counting OPTGROUP entries that may be in list.
</span><span class="cx"> int optionIndex = 0;
</span><span class="cx"> for (int i = 0; i < listIndex; ++i) {
</span><del>- if (isHTMLOptionElement(items[i]))
</del><ins>+ if (is<HTMLOptionElement>(items[i]))
</ins><span class="cx"> ++optionIndex;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -968,7 +968,7 @@
</span><span class="cx"> const Vector<HTMLElement*>& items = listItems();
</span><span class="cx"> for (unsigned i = 0; i < items.size(); ++i) {
</span><span class="cx"> HTMLElement* element = items[i];
</span><del>- if (element != excludeElement && isHTMLOptionElement(element))
</del><ins>+ if (element != excludeElement && is<HTMLOptionElement>(element))
</ins><span class="cx"> downcast<HTMLOptionElement>(*element).setSelectedState(false);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -979,7 +979,7 @@
</span><span class="cx"> size_t length = items.size();
</span><span class="cx"> FormControlState state;
</span><span class="cx"> for (unsigned i = 0; i < length; ++i) {
</span><del>- if (!isHTMLOptionElement(items[i]))
</del><ins>+ if (!is<HTMLOptionElement>(items[i]))
</ins><span class="cx"> continue;
</span><span class="cx"> HTMLOptionElement& option = downcast<HTMLOptionElement>(*items[i]);
</span><span class="cx"> if (!option.selected())
</span><span class="lines">@@ -996,7 +996,7 @@
</span><span class="cx"> const Vector<HTMLElement*>& items = listItems();
</span><span class="cx"> size_t loopEndIndex = std::min(items.size(), listIndexEnd);
</span><span class="cx"> for (size_t i = listIndexStart; i < loopEndIndex; ++i) {
</span><del>- if (!isHTMLOptionElement(items[i]))
</del><ins>+ if (!is<HTMLOptionElement>(items[i]))
</ins><span class="cx"> continue;
</span><span class="cx"> if (downcast<HTMLOptionElement>(*items[i]).value() == value)
</span><span class="cx"> return i;
</span><span class="lines">@@ -1014,7 +1014,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> for (size_t i = 0; i < itemsSize; ++i) {
</span><del>- if (!isHTMLOptionElement(items[i]))
</del><ins>+ if (!is<HTMLOptionElement>(items[i]))
</ins><span class="cx"> continue;
</span><span class="cx"> downcast<HTMLOptionElement>(*items[i]).setSelectedState(false);
</span><span class="cx"> }
</span><span class="lines">@@ -1061,7 +1061,7 @@
</span><span class="cx">
</span><span class="cx"> for (unsigned i = 0; i < items.size(); ++i) {
</span><span class="cx"> HTMLElement* element = items[i];
</span><del>- if (isHTMLOptionElement(element) && downcast<HTMLOptionElement>(*element).selected() && !downcast<HTMLOptionElement>(*element).isDisabledFormControl()) {
</del><ins>+ if (is<HTMLOptionElement>(element) && downcast<HTMLOptionElement>(*element).selected() && !downcast<HTMLOptionElement>(*element).isDisabledFormControl()) {
</ins><span class="cx"> list.appendData(name, downcast<HTMLOptionElement>(*element).value());
</span><span class="cx"> successful = true;
</span><span class="cx"> }
</span><span class="lines">@@ -1081,7 +1081,7 @@
</span><span class="cx"> const Vector<HTMLElement*>& items = listItems();
</span><span class="cx"> for (unsigned i = 0; i < items.size(); ++i) {
</span><span class="cx"> HTMLElement* element = items[i];
</span><del>- if (!isHTMLOptionElement(element))
</del><ins>+ if (!is<HTMLOptionElement>(element))
</ins><span class="cx"> continue;
</span><span class="cx">
</span><span class="cx"> HTMLOptionElement& option = downcast<HTMLOptionElement>(*element);
</span><span class="lines">@@ -1297,7 +1297,7 @@
</span><span class="cx"> bool multiSelect = m_multiple && multi && !shift;
</span><span class="cx">
</span><span class="cx"> HTMLElement* clickedElement = listItems()[listIndex];
</span><del>- if (isHTMLOptionElement(clickedElement)) {
</del><ins>+ if (is<HTMLOptionElement>(clickedElement)) {
</ins><span class="cx"> // Keep track of whether an active selection (like during drag
</span><span class="cx"> // selection), should select or deselect.
</span><span class="cx"> if (downcast<HTMLOptionElement>(*clickedElement).selected() && multiSelect)
</span><span class="lines">@@ -1318,7 +1318,7 @@
</span><span class="cx"> setActiveSelectionAnchorIndex(selectedIndex());
</span><span class="cx">
</span><span class="cx"> // Set the selection state of the clicked option.
</span><del>- if (isHTMLOptionElement(clickedElement) && !downcast<HTMLOptionElement>(*clickedElement).isDisabledFormControl())
</del><ins>+ if (is<HTMLOptionElement>(clickedElement) && !downcast<HTMLOptionElement>(*clickedElement).isDisabledFormControl())
</ins><span class="cx"> downcast<HTMLOptionElement>(*clickedElement).setSelectedState(true);
</span><span class="cx">
</span><span class="cx"> // If there was no selectedIndex() for the previous initialization, or If
</span><span class="lines">@@ -1494,7 +1494,7 @@
</span><span class="cx"> m_activeSelectionState = !m_activeSelectionState;
</span><span class="cx"> ASSERT(m_activeSelectionEndIndex >= 0);
</span><span class="cx"> ASSERT(m_activeSelectionEndIndex < static_cast<int>(listItems.size()));
</span><del>- ASSERT(isHTMLOptionElement(*listItems[m_activeSelectionEndIndex]));
</del><ins>+ ASSERT(is<HTMLOptionElement>(*listItems[m_activeSelectionEndIndex]));
</ins><span class="cx"> updateSelectedState(m_activeSelectionEndIndex, true /*multi*/, false /*shift*/);
</span><span class="cx"> listBoxOnChange();
</span><span class="cx"> event->setDefaultHandled();
</span><span class="lines">@@ -1539,7 +1539,7 @@
</span><span class="cx"> const Vector<HTMLElement*>& items = listItems();
</span><span class="cx"> for (size_t i = items.size(); i;) {
</span><span class="cx"> HTMLElement* element = items[--i];
</span><del>- if (isHTMLOptionElement(element) && downcast<HTMLOptionElement>(*element).selected())
</del><ins>+ if (is<HTMLOptionElement>(element) && downcast<HTMLOptionElement>(*element).selected())
</ins><span class="cx"> return i;
</span><span class="cx"> }
</span><span class="cx"> return -1;
</span><span class="lines">@@ -1560,7 +1560,7 @@
</span><span class="cx"> const Vector<HTMLElement*>& items = listItems();
</span><span class="cx">
</span><span class="cx"> HTMLElement* element = items[index];
</span><del>- if (!isHTMLOptionElement(element) || downcast<HTMLOptionElement>(*element).isDisabledFormControl())
</del><ins>+ if (!is<HTMLOptionElement>(element) || downcast<HTMLOptionElement>(*element).isDisabledFormControl())
</ins><span class="cx"> return String();
</span><span class="cx"> return downcast<HTMLOptionElement>(*element).textIndentedToRespectGroupLabel();
</span><span class="cx"> }
</span><span class="lines">@@ -1596,7 +1596,7 @@
</span><span class="cx"> int listIndex = optionToListIndex(index);
</span><span class="cx"> if (listIndex >= 0) {
</span><span class="cx"> HTMLElement* element = items[listIndex];
</span><del>- if (isHTMLOptionElement(element)) {
</del><ins>+ if (is<HTMLOptionElement>(element)) {
</ins><span class="cx"> if (downcast<HTMLOptionElement>(*element).selected())
</span><span class="cx"> downcast<HTMLOptionElement>(*element).setSelectedState(false);
</span><span class="cx"> else
</span><span class="lines">@@ -1618,7 +1618,7 @@
</span><span class="cx">
</span><span class="cx"> const Vector<HTMLElement*>& items = listItems();
</span><span class="cx"> for (unsigned i = 0; i < items.size(); ++i) {
</span><del>- if (isHTMLOptionElement(items[i]))
</del><ins>+ if (is<HTMLOptionElement>(items[i]))
</ins><span class="cx"> ++options;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTagNamesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTagNames.in (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTagNames.in 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/HTMLTagNames.in 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -22,7 +22,7 @@
</span><span class="cx"> blockquote interfaceName=HTMLQuoteElement
</span><span class="cx"> body generateTypeHelpers
</span><span class="cx"> br interfaceName=HTMLBRElement
</span><del>-button constructorNeedsFormElement
</del><ins>+button constructorNeedsFormElement, generateTypeHelpers
</ins><span class="cx"> canvas generateTypeHelpers
</span><span class="cx"> caption interfaceName=HTMLTableCaptionElement, generateTypeHelpers
</span><span class="cx"> center interfaceName=HTMLElement
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlRadioInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/RadioInputType.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/RadioInputType.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/RadioInputType.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> if (isHTMLFormElement(node))
</span><span class="cx"> break;
</span><span class="cx"> // Look for more radio buttons.
</span><del>- if (!isHTMLInputElement(node))
</del><ins>+ if (!is<HTMLInputElement>(node))
</ins><span class="cx"> continue;
</span><span class="cx"> RefPtr<HTMLInputElement> inputElement = downcast<HTMLInputElement>(node);
</span><span class="cx"> if (inputElement->form() != element().form())
</span><span class="lines">@@ -122,7 +122,7 @@
</span><span class="cx"> // Never allow keyboard tabbing to leave you in the same radio group. Always
</span><span class="cx"> // skip any other elements in the group.
</span><span class="cx"> Element* currentFocusedNode = element().document().focusedElement();
</span><del>- if (currentFocusedNode && isHTMLInputElement(currentFocusedNode)) {
</del><ins>+ if (currentFocusedNode && is<HTMLInputElement>(currentFocusedNode)) {
</ins><span class="cx"> HTMLInputElement& focusedInput = downcast<HTMLInputElement>(*currentFocusedNode);
</span><span class="cx"> if (focusedInput.isRadioButton() && focusedInput.form() == element().form() && focusedInput.name() == element().name())
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlparserHTMLConstructionSitecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -61,7 +61,7 @@
</span><span class="cx"> return item->hasTagName(ddTag)
</span><span class="cx"> || item->hasTagName(dtTag)
</span><span class="cx"> || item->hasTagName(liTag)
</span><del>- || isHTMLOptionElement(item->node())
</del><ins>+ || is<HTMLOptionElement>(item->node())
</ins><span class="cx"> || isHTMLOptGroupElement(item->node())
</span><span class="cx"> || item->hasTagName(pTag)
</span><span class="cx"> || item->hasTagName(rbTag)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlparserHTMLElementStackcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/parser/HTMLElementStack.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/parser/HTMLElementStack.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/parser/HTMLElementStack.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -120,7 +120,7 @@
</span><span class="cx">
</span><span class="cx"> inline bool isSelectScopeMarker(HTMLStackItem* item)
</span><span class="cx"> {
</span><del>- return !isHTMLOptGroupElement(item->node()) && !isHTMLOptionElement(item->node());
</del><ins>+ return !is<HTMLOptGroupElement>(item->node()) && !is<HTMLOptionElement>(item->node());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlparserHTMLTreeBuildercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -868,7 +868,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> if (token->name() == optgroupTag || token->name() == optionTag) {
</span><del>- if (isHTMLOptionElement(m_tree.currentStackItem()->node())) {
</del><ins>+ if (is<HTMLOptionElement>(m_tree.currentStackItem()->node())) {
</ins><span class="cx"> AtomicHTMLToken endOption(HTMLToken::EndTag, optionTag.localName());
</span><span class="cx"> processEndTag(&endOption);
</span><span class="cx"> }
</span><span class="lines">@@ -1359,7 +1359,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> if (token->name() == optionTag) {
</span><del>- if (isHTMLOptionElement(m_tree.currentStackItem()->node())) {
</del><ins>+ if (is<HTMLOptionElement>(m_tree.currentStackItem()->node())) {
</ins><span class="cx"> AtomicHTMLToken endOption(HTMLToken::EndTag, optionTag.localName());
</span><span class="cx"> processEndTag(&endOption);
</span><span class="cx"> }
</span><span class="lines">@@ -1367,7 +1367,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> if (token->name() == optgroupTag) {
</span><del>- if (isHTMLOptionElement(m_tree.currentStackItem()->node())) {
</del><ins>+ if (is<HTMLOptionElement>(m_tree.currentStackItem()->node())) {
</ins><span class="cx"> AtomicHTMLToken endOption(HTMLToken::EndTag, optionTag.localName());
</span><span class="cx"> processEndTag(&endOption);
</span><span class="cx"> }
</span><span class="lines">@@ -2233,7 +2233,7 @@
</span><span class="cx"> case InsertionMode::InSelect:
</span><span class="cx"> ASSERT(insertionMode() == InsertionMode::InSelect || insertionMode() == InsertionMode::InSelectInTable);
</span><span class="cx"> if (token->name() == optgroupTag) {
</span><del>- if (isHTMLOptionElement(m_tree.currentStackItem()->node()) && m_tree.oneBelowTop() && isHTMLOptGroupElement(m_tree.oneBelowTop()->node()))
</del><ins>+ if (is<HTMLOptionElement>(m_tree.currentStackItem()->node()) && m_tree.oneBelowTop() && isHTMLOptGroupElement(m_tree.oneBelowTop()->node()))
</ins><span class="cx"> processFakeEndTag(optionTag);
</span><span class="cx"> if (isHTMLOptGroupElement(m_tree.currentStackItem()->node())) {
</span><span class="cx"> m_tree.openElements()->pop();
</span><span class="lines">@@ -2243,7 +2243,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> if (token->name() == optionTag) {
</span><del>- if (isHTMLOptionElement(m_tree.currentStackItem()->node())) {
</del><ins>+ if (is<HTMLOptionElement>(m_tree.currentStackItem()->node())) {
</ins><span class="cx"> m_tree.openElements()->pop();
</span><span class="cx"> return;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowMediaControlElementTypescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/MediaControlElementTypes.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/MediaControlElementTypes.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/html/shadow/MediaControlElementTypes.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT_WITH_SECURITY_IMPLICATION(node->isMediaControlElement());
</span><span class="cx"> HTMLElement* element = toHTMLElement(node);
</span><del>- if (isHTMLInputElement(element))
</del><ins>+ if (is<HTMLInputElement>(element))
</ins><span class="cx"> return static_cast<MediaControlInputElement*>(element)->displayType();
</span><span class="cx"> return static_cast<MediaControlDivElement*>(element)->displayType();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderFormSubmissioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/FormSubmission.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/FormSubmission.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/loader/FormSubmission.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -189,7 +189,7 @@
</span><span class="cx"> HTMLElement& element = control.asHTMLElement();
</span><span class="cx"> if (!element.isDisabledFormControl())
</span><span class="cx"> control.appendFormData(*domFormData, isMultiPartForm);
</span><del>- if (isHTMLInputElement(element)) {
</del><ins>+ if (is<HTMLInputElement>(element)) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(element);
</span><span class="cx"> if (input.isTextField()) {
</span><span class="cx"> formValues.append(std::pair<String, String>(input.name().string(), input.value()));
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderFrameLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/FrameLoader.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -1033,7 +1033,7 @@
</span><span class="cx"> void FrameLoader::handleFallbackContent()
</span><span class="cx"> {
</span><span class="cx"> HTMLFrameOwnerElement* owner = m_frame.ownerElement();
</span><del>- if (!owner || !isHTMLObjectElement(owner))
</del><ins>+ if (!owner || !is<HTMLObjectElement>(owner))
</ins><span class="cx"> return;
</span><span class="cx"> downcast<HTMLObjectElement>(*owner).renderFallbackContent();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderImageLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/ImageLoader.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/ImageLoader.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/loader/ImageLoader.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -412,7 +412,7 @@
</span><span class="cx"> loadEventSender().cancelEvent(*this);
</span><span class="cx"> m_hasPendingLoadEvent = false;
</span><span class="cx">
</span><del>- if (isHTMLObjectElement(element()))
</del><ins>+ if (is<HTMLObjectElement>(element()))
</ins><span class="cx"> downcast<HTMLObjectElement>(element()).renderFallbackContent();
</span><span class="cx">
</span><span class="cx"> // Only consider updating the protection ref-count of the Element immediately before returning
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderSubframeLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/SubframeLoader.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/SubframeLoader.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/loader/SubframeLoader.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -213,7 +213,7 @@
</span><span class="cx"> if (!url.isEmpty())
</span><span class="cx"> completedURL = completeURL(url);
</span><span class="cx">
</span><del>- bool hasFallbackContent = isHTMLObjectElement(ownerElement) && downcast<HTMLObjectElement>(ownerElement).hasFallbackContent();
</del><ins>+ bool hasFallbackContent = is<HTMLObjectElement>(ownerElement) && downcast<HTMLObjectElement>(ownerElement).hasFallbackContent();
</ins><span class="cx">
</span><span class="cx"> bool useFallback;
</span><span class="cx"> if (shouldUsePlugin(completedURL, mimeType, ownerElement.shouldPreferPlugInsForImages(), hasFallbackContent, useFallback)) {
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderarchivecfLegacyWebArchivecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -516,7 +516,7 @@
</span><span class="cx"> for (size_t i = 0; i < nodesSize; ++i) {
</span><span class="cx"> Node& node = *nodes[i];
</span><span class="cx"> Frame* childFrame;
</span><del>- if ((isHTMLFrameElement(node) || isHTMLIFrameElement(node) || isHTMLObjectElement(node))
</del><ins>+ if ((is<HTMLFrameElement>(node) || is<HTMLIFrameElement>(node) || is<HTMLObjectElement>(node))
</ins><span class="cx"> && (childFrame = toHTMLFrameOwnerElement(node).contentFrame())) {
</span><span class="cx"> if (frameFilter && !frameFilter(*childFrame))
</span><span class="cx"> continue;
</span></span></pre></div>
<a id="trunkSourceWebCorepageChromecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Chrome.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Chrome.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/page/Chrome.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -408,7 +408,7 @@
</span><span class="cx"> if (toolTip.isEmpty() && m_page.settings().showsURLsInToolTips()) {
</span><span class="cx"> if (Element* element = result.innerNonSharedElement()) {
</span><span class="cx"> // Get tooltip representing form action, if relevant
</span><del>- if (isHTMLInputElement(element)) {
</del><ins>+ if (is<HTMLInputElement>(element)) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*element);
</span><span class="cx"> if (input.isSubmitButton()) {
</span><span class="cx"> if (HTMLFormElement* form = input.form()) {
</span><span class="lines">@@ -441,7 +441,7 @@
</span><span class="cx"> // Lastly, for <input type="file"> that allow multiple files, we'll consider a tooltip for the selected filenames
</span><span class="cx"> if (toolTip.isEmpty()) {
</span><span class="cx"> if (Element* element = result.innerNonSharedElement()) {
</span><del>- if (isHTMLInputElement(element)) {
</del><ins>+ if (is<HTMLInputElement>(element)) {
</ins><span class="cx"> toolTip = downcast<HTMLInputElement>(*element).defaultToolTip();
</span><span class="cx">
</span><span class="cx"> // FIXME: We should obtain text direction of tooltip from
</span></span></pre></div>
<a id="trunkSourceWebCorepageEventHandlercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/EventHandler.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/EventHandler.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -1267,7 +1267,7 @@
</span><span class="cx"> #if ENABLE(CURSOR_SUPPORT)
</span><span class="cx"> static bool isSubmitImage(Node* node)
</span><span class="cx"> {
</span><del>- return node && isHTMLInputElement(node) && downcast<HTMLInputElement>(*node).isImageButton();
</del><ins>+ return node && is<HTMLInputElement>(node) && downcast<HTMLInputElement>(*node).isImageButton();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Returns true if the node's editable block is not current focused for editing
</span><span class="lines">@@ -1761,7 +1761,7 @@
</span><span class="cx"> // If a mouse event handler changes the input element type to one that has a widget associated,
</span><span class="cx"> // we'd like to EventHandler::handleMousePressEvent to pass the event to the widget and thus the
</span><span class="cx"> // event target node can't still be the shadow node.
</span><del>- if (mouseEvent.targetNode()->isShadowRoot() && isHTMLInputElement(toShadowRoot(mouseEvent.targetNode())->hostElement()))
</del><ins>+ if (mouseEvent.targetNode()->isShadowRoot() && is<HTMLInputElement>(toShadowRoot(mouseEvent.targetNode())->hostElement()))
</ins><span class="cx"> mouseEvent = m_frame.document()->prepareMouseEvent(HitTestRequest(), documentPoint, platformMouseEvent);
</span><span class="cx">
</span><span class="cx"> FrameView* view = m_frame.view();
</span></span></pre></div>
<a id="trunkSourceWebCorepageFocusControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FocusController.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FocusController.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/page/FocusController.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -574,7 +574,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (Node* shadowAncestorNode = root->deprecatedShadowAncestorNode()) {
</span><del>- if (!isHTMLInputElement(shadowAncestorNode) && !isHTMLTextAreaElement(shadowAncestorNode))
</del><ins>+ if (!is<HTMLInputElement>(shadowAncestorNode) && !is<HTMLTextAreaElement>(shadowAncestorNode))
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorepageFrameViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FrameView.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FrameView.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/page/FrameView.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -1414,7 +1414,7 @@
</span><span class="cx"> m_embeddedObjectsToUpdate = std::make_unique<ListHashSet<RenderEmbeddedObject*>>();
</span><span class="cx">
</span><span class="cx"> HTMLFrameOwnerElement& element = embeddedObject.frameOwnerElement();
</span><del>- if (isHTMLObjectElement(element) || isHTMLEmbedElement(element)) {
</del><ins>+ if (is<HTMLObjectElement>(element) || is<HTMLEmbedElement>(element)) {
</ins><span class="cx"> // Tell the DOM element that it needs a widget update.
</span><span class="cx"> HTMLPlugInImageElement& pluginElement = toHTMLPlugInImageElement(element);
</span><span class="cx"> if (!pluginElement.needsCheckForSizeChange())
</span><span class="lines">@@ -2788,7 +2788,7 @@
</span><span class="cx"> HTMLFrameOwnerElement& element = embeddedObject.frameOwnerElement();
</span><span class="cx">
</span><span class="cx"> if (embeddedObject.isSnapshottedPlugIn()) {
</span><del>- if (isHTMLObjectElement(element) || isHTMLEmbedElement(element)) {
</del><ins>+ if (is<HTMLObjectElement>(element) || is<HTMLEmbedElement>(element)) {
</ins><span class="cx"> HTMLPlugInImageElement& pluginElement = toHTMLPlugInImageElement(element);
</span><span class="cx"> pluginElement.checkSnapshotStatus();
</span><span class="cx"> }
</span><span class="lines">@@ -2799,7 +2799,7 @@
</span><span class="cx">
</span><span class="cx"> // FIXME: This could turn into a real virtual dispatch if we defined
</span><span class="cx"> // updateWidget(PluginCreationOption) on HTMLElement.
</span><del>- if (isHTMLObjectElement(element) || isHTMLEmbedElement(element) || isHTMLAppletElement(element)) {
</del><ins>+ if (is<HTMLObjectElement>(element) || is<HTMLEmbedElement>(element) || is<HTMLAppletElement>(element)) {
</ins><span class="cx"> HTMLPlugInImageElement& pluginElement = toHTMLPlugInImageElement(element);
</span><span class="cx"> if (pluginElement.needsCheckForSizeChange()) {
</span><span class="cx"> pluginElement.checkSnapshotStatus();
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageSerializercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/PageSerializer.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/PageSerializer.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/page/PageSerializer.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -91,7 +91,7 @@
</span><span class="cx"> static const QualifiedName& frameOwnerURLAttributeName(const HTMLFrameOwnerElement& frameOwner)
</span><span class="cx"> {
</span><span class="cx"> // FIXME: We should support all frame owners including applets.
</span><del>- return isHTMLObjectElement(frameOwner) ? HTMLNames::dataAttr : HTMLNames::srcAttr;
</del><ins>+ return is<HTMLObjectElement>(frameOwner) ? HTMLNames::dataAttr : HTMLNames::srcAttr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> class SerializerMarkupAccumulator final : public WebCore::MarkupAccumulator {
</span></span></pre></div>
<a id="trunkSourceWebCorepageSpatialNavigationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/SpatialNavigation.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/SpatialNavigation.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/page/SpatialNavigation.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -448,7 +448,7 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(container);
</span><span class="cx">
</span><del>- if (isHTMLSelectElement(container))
</del><ins>+ if (is<HTMLSelectElement>(container))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> if (container->isDocumentNode())
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingHitTestResultcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/HitTestResult.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/HitTestResult.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/rendering/HitTestResult.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -278,7 +278,7 @@
</span><span class="cx"> return displayString(image.fastGetAttribute(altAttr), m_innerNonSharedNode.get());
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (isHTMLInputElement(*m_innerNonSharedNode)) {
</del><ins>+ if (is<HTMLInputElement>(*m_innerNonSharedNode)) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(*m_innerNonSharedNode);
</span><span class="cx"> return displayString(input.alt(), m_innerNonSharedNode.get());
</span><span class="cx"> }
</span><span class="lines">@@ -317,14 +317,12 @@
</span><span class="cx"> return URL();
</span><span class="cx">
</span><span class="cx"> AtomicString urlString;
</span><del>- if (m_innerNonSharedNode->hasTagName(embedTag)
- || isHTMLImageElement(m_innerNonSharedNode.get())
- || isHTMLInputElement(m_innerNonSharedNode.get())
- || m_innerNonSharedNode->hasTagName(objectTag)
- || is<SVGImageElement>(m_innerNonSharedNode.get()))
- {
- Element* element = toElement(m_innerNonSharedNode.get());
- urlString = element->imageSourceURL();
</del><ins>+ if (is<HTMLEmbedElement>(*m_innerNonSharedNode)
+ || is<HTMLImageElement>(*m_innerNonSharedNode)
+ || is<HTMLInputElement>(*m_innerNonSharedNode)
+ || is<HTMLObjectElement>(*m_innerNonSharedNode)
+ || is<SVGImageElement>(*m_innerNonSharedNode)) {
+ urlString = toElement(*m_innerNonSharedNode).imageSourceURL();
</ins><span class="cx"> } else
</span><span class="cx"> return URL();
</span><span class="cx">
</span><span class="lines">@@ -336,7 +334,7 @@
</span><span class="cx"> if (!m_innerNonSharedNode)
</span><span class="cx"> return URL();
</span><span class="cx">
</span><del>- if (!isHTMLEmbedElement(*m_innerNonSharedNode) && !isHTMLObjectElement(*m_innerNonSharedNode))
</del><ins>+ if (!is<HTMLEmbedElement>(*m_innerNonSharedNode) && !is<HTMLObjectElement>(*m_innerNonSharedNode))
</ins><span class="cx"> return URL();
</span><span class="cx">
</span><span class="cx"> HTMLPlugInImageElement& element = toHTMLPlugInImageElement(*m_innerNonSharedNode);
</span><span class="lines">@@ -556,10 +554,10 @@
</span><span class="cx"> if (!m_innerNonSharedNode)
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- if (isHTMLTextAreaElement(*m_innerNonSharedNode))
</del><ins>+ if (is<HTMLTextAreaElement>(*m_innerNonSharedNode))
</ins><span class="cx"> return true;
</span><span class="cx">
</span><del>- if (isHTMLInputElement(*m_innerNonSharedNode))
</del><ins>+ if (is<HTMLInputElement>(*m_innerNonSharedNode))
</ins><span class="cx"> return downcast<HTMLInputElement>(*m_innerNonSharedNode).isTextField();
</span><span class="cx">
</span><span class="cx"> return m_innerNonSharedNode->hasEditableStyle();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockFlowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -3569,7 +3569,7 @@
</span><span class="cx"> // Get the first non-shadow HTMLElement and see if it's an input.
</span><span class="cx"> if (renderer->element() && renderer->element()->isHTMLElement() && !renderer->element()->isInShadowTree()) {
</span><span class="cx"> const HTMLElement& element = toHTMLElement(*renderer->element());
</span><del>- return !isHTMLInputElement(element) && !isHTMLTextAreaElement(element);
</del><ins>+ return !is<HTMLInputElement>(element) && !is<HTMLTextAreaElement>(element);
</ins><span class="cx"> }
</span><span class="cx"> renderer = renderer->parent();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -34,6 +34,7 @@
</span><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "FrameView.h"
</span><span class="cx"> #include "GraphicsContext.h"
</span><ins>+#include "HTMLButtonElement.h"
</ins><span class="cx"> #include "HTMLElement.h"
</span><span class="cx"> #include "HTMLFrameOwnerElement.h"
</span><span class="cx"> #include "HTMLInputElement.h"
</span><span class="lines">@@ -2477,7 +2478,7 @@
</span><span class="cx"> // stretching column flexbox.
</span><span class="cx"> // FIXME: Think about block-flow here.
</span><span class="cx"> // https://bugs.webkit.org/show_bug.cgi?id=46473
</span><del>- if (logicalWidth.type() == Auto && !isStretchingColumnFlexItem(*this) && element() && (isHTMLInputElement(element()) || element()->hasTagName(selectTag) || element()->hasTagName(buttonTag) || isHTMLTextAreaElement(element()) || element()->hasTagName(legendTag)))
</del><ins>+ if (logicalWidth.type() == Auto && !isStretchingColumnFlexItem(*this) && element() && (is<HTMLInputElement>(element()) || is<HTMLSelectElement>(element()) || is<HTMLButtonElement>(element()) || is<HTMLTextAreaElement>(element()) || is<HTMLLegendElement>(element())))
</ins><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> if (isHorizontalWritingMode() != containingBlock()->isHorizontalWritingMode())
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderButtoncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderButton.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderButton.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/rendering/RenderButton.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -144,7 +144,7 @@
</span><span class="cx"> void RenderButton::updateFromElement()
</span><span class="cx"> {
</span><span class="cx"> // If we're an input element, we may need to change our button text.
</span><del>- if (isHTMLInputElement(formControlElement())) {
</del><ins>+ if (is<HTMLInputElement>(formControlElement())) {
</ins><span class="cx"> HTMLInputElement& input = downcast<HTMLInputElement>(formControlElement());
</span><span class="cx"> String value = input.valueWithDefault();
</span><span class="cx"> setText(value);
</span><span class="lines">@@ -178,7 +178,7 @@
</span><span class="cx"> // Input elements can't have generated children, but button elements can. We'll
</span><span class="cx"> // write the code assuming any other button types that might emerge in the future
</span><span class="cx"> // can also have children.
</span><del>- return !isHTMLInputElement(formControlElement());
</del><ins>+ return !is<HTMLInputElement>(formControlElement());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> LayoutRect RenderButton::controlClipRect(const LayoutPoint& additionalOffset) const
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderDetailsMarkercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderDetailsMarker.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderDetailsMarker.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/rendering/RenderDetailsMarker.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -145,7 +145,7 @@
</span><span class="cx"> continue;
</span><span class="cx"> if (renderer->node()->hasTagName(detailsTag))
</span><span class="cx"> return !toElement(renderer->node())->getAttribute(openAttr).isNull();
</span><del>- if (isHTMLInputElement(renderer->node()))
</del><ins>+ if (is<HTMLInputElement>(renderer->node()))
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderFileUploadControlcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -255,7 +255,7 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(inputElement().shadowRoot());
</span><span class="cx"> Node* buttonNode = inputElement().shadowRoot()->firstChild();
</span><del>- return buttonNode && buttonNode->isHTMLElement() && isHTMLInputElement(buttonNode) ? downcast<HTMLInputElement>(buttonNode) : nullptr;
</del><ins>+ return buttonNode && is<HTMLInputElement>(buttonNode) ? downcast<HTMLInputElement>(buttonNode) : nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String RenderFileUploadControl::buttonValue()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderImagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderImage.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderImage.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/rendering/RenderImage.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -655,7 +655,7 @@
</span><span class="cx"> if (!element())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (isHTMLInputElement(*element()))
</del><ins>+ if (is<HTMLInputElement>(*element()))
</ins><span class="cx"> m_altText = downcast<HTMLInputElement>(*element()).altText();
</span><span class="cx"> else if (isHTMLImageElement(*element()))
</span><span class="cx"> m_altText = downcast<HTMLImageElement>(*element()).altText();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderListBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderListBox.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderListBox.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/rendering/RenderListBox.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -116,7 +116,7 @@
</span><span class="cx"> HTMLElement* element = listItems[i];
</span><span class="cx"> String text;
</span><span class="cx"> Font itemFont = style().font();
</span><del>- if (isHTMLOptionElement(element))
</del><ins>+ if (is<HTMLOptionElement>(element))
</ins><span class="cx"> text = downcast<HTMLOptionElement>(*element).textIndentedToRespectGroupLabel();
</span><span class="cx"> else if (isHTMLOptGroupElement(element)) {
</span><span class="cx"> text = downcast<HTMLOptGroupElement>(*element).groupLabelText();
</span><span class="lines">@@ -330,7 +330,7 @@
</span><span class="cx"> const Vector<HTMLElement*>& listItems = selectElement().listItems();
</span><span class="cx"> for (int i = 0; i < size; ++i) {
</span><span class="cx"> HTMLElement* element = listItems[i];
</span><del>- if (isHTMLOptionElement(element) && !element->isDisabledFormControl()) {
</del><ins>+ if (is<HTMLOptionElement>(element) && !element->isDisabledFormControl()) {
</ins><span class="cx"> selectElement().setActiveSelectionEndIndex(i);
</span><span class="cx"> rects.append(snappedIntRect(itemBoundingBoxRect(additionalOffset, i)));
</span><span class="cx"> return;
</span><span class="lines">@@ -385,7 +385,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> String itemText;
</span><del>- bool isOptionElement = isHTMLOptionElement(listItemElement);
</del><ins>+ bool isOptionElement = is<HTMLOptionElement>(listItemElement);
</ins><span class="cx"> if (isOptionElement)
</span><span class="cx"> itemText = downcast<HTMLOptionElement>(*listItemElement).textIndentedToRespectGroupLabel();
</span><span class="cx"> else if (isHTMLOptGroupElement(listItemElement))
</span><span class="lines">@@ -426,7 +426,7 @@
</span><span class="cx"> HTMLElement* listItemElement = listItems[listIndex];
</span><span class="cx">
</span><span class="cx"> Color backColor;
</span><del>- if (isHTMLOptionElement(listItemElement) && downcast<HTMLOptionElement>(*listItemElement).selected()) {
</del><ins>+ if (is<HTMLOptionElement>(listItemElement) && downcast<HTMLOptionElement>(*listItemElement).selected()) {
</ins><span class="cx"> if (frame().selection().isFocusedAndActive() && document().focusedElement() == &selectElement())
</span><span class="cx"> backColor = theme().activeListBoxSelectionBackgroundColor();
</span><span class="cx"> else
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderMenuListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderMenuList.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderMenuList.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/rendering/RenderMenuList.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -64,7 +64,7 @@
</span><span class="cx">
</span><span class="cx"> size_t count = 0;
</span><span class="cx"> for (size_t i = 0; i < numberOfItems; ++i) {
</span><del>- if (isHTMLOptionElement(listItems[i]) && downcast<HTMLOptionElement>(*listItems[i]).selected())
</del><ins>+ if (is<HTMLOptionElement>(listItems[i]) && downcast<HTMLOptionElement>(*listItems[i]).selected())
</ins><span class="cx"> ++count;
</span><span class="cx"> }
</span><span class="cx"> return count;
</span><span class="lines">@@ -214,7 +214,7 @@
</span><span class="cx">
</span><span class="cx"> for (int i = 0; i < size; ++i) {
</span><span class="cx"> HTMLElement* element = listItems[i];
</span><del>- if (!isHTMLOptionElement(element))
</del><ins>+ if (!is<HTMLOptionElement>(element))
</ins><span class="cx"> continue;
</span><span class="cx">
</span><span class="cx"> String text = downcast<HTMLOptionElement>(*element).textIndentedToRespectGroupLabel();
</span><span class="lines">@@ -270,7 +270,7 @@
</span><span class="cx"> String text = emptyString();
</span><span class="cx"> if (i >= 0 && i < size) {
</span><span class="cx"> Element* element = listItems[i];
</span><del>- if (isHTMLOptionElement(element)) {
</del><ins>+ if (is<HTMLOptionElement>(element)) {
</ins><span class="cx"> text = downcast<HTMLOptionElement>(*element).textIndentedToRespectGroupLabel();
</span><span class="cx"> m_optionStyle = element->computedStyle();
</span><span class="cx"> }
</span><span class="lines">@@ -452,7 +452,7 @@
</span><span class="cx"> Element* element = listItems[listIndex];
</span><span class="cx"> if (isHTMLOptGroupElement(element))
</span><span class="cx"> itemString = downcast<HTMLOptGroupElement>(*element).groupLabelText();
</span><del>- else if (isHTMLOptionElement(element))
</del><ins>+ else if (is<HTMLOptionElement>(element))
</ins><span class="cx"> itemString = downcast<HTMLOptionElement>(*element).textIndentedToRespectGroupLabel();
</span><span class="cx">
</span><span class="cx"> applyTextTransform(style(), itemString, ' ');
</span><span class="lines">@@ -492,7 +492,7 @@
</span><span class="cx"> if (listIndex >= listItems.size())
</span><span class="cx"> return false;
</span><span class="cx"> HTMLElement* element = listItems[listIndex];
</span><del>- if (!isHTMLOptionElement(element))
</del><ins>+ if (!is<HTMLOptionElement>(element))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> bool groupEnabled = true;
</span><span class="lines">@@ -654,7 +654,7 @@
</span><span class="cx"> if (listIndex >= listItems.size())
</span><span class="cx"> return false;
</span><span class="cx"> HTMLElement* element = listItems[listIndex];
</span><del>- return isHTMLOptionElement(element) && downcast<HTMLOptionElement>(*element).selected();
</del><ins>+ return is<HTMLOptionElement>(element) && downcast<HTMLOptionElement>(*element).selected();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderMenuList::setTextFromItem(unsigned listIndex)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTheme.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -1035,7 +1035,7 @@
</span><span class="cx"> GraphicsContextStateSaver stateSaver(*paintInfo.context);
</span><span class="cx"> paintInfo.context->setFillColor(o.style().visitedDependentColor(CSSPropertyColor), ColorSpaceDeviceRGB);
</span><span class="cx"> for (unsigned i = 0; Node* node = options->item(i); i++) {
</span><del>- ASSERT(isHTMLOptionElement(node));
</del><ins>+ ASSERT(is<HTMLOptionElement>(node));
</ins><span class="cx"> HTMLOptionElement& optionElement = downcast<HTMLOptionElement>(*node);
</span><span class="cx"> String value = optionElement.value();
</span><span class="cx"> if (!input->isValidValue(value))
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/testing/Internals.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -637,7 +637,7 @@
</span><span class="cx"> #if ENABLE(INPUT_TYPE_COLOR)
</span><span class="cx"> void Internals::selectColorInColorChooser(Element* element, const String& colorValue)
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return;
</span><span class="cx"> HTMLInputElement* inputElement = element->toInputElement();
</span><span class="cx"> if (!inputElement)
</span><span class="lines">@@ -912,7 +912,7 @@
</span><span class="cx"> if (HTMLInputElement* inputElement = textField->toInputElement())
</span><span class="cx"> return inputElement->lastChangeWasUserEdit();
</span><span class="cx">
</span><del>- if (isHTMLTextAreaElement(textField))
</del><ins>+ if (is<HTMLTextAreaElement>(textField))
</ins><span class="cx"> return downcast<HTMLTextAreaElement>(*textField).lastChangeWasUserEdit();
</span><span class="cx">
</span><span class="cx"> ec = INVALID_NODE_TYPE_ERR;
</span><span class="lines">@@ -2083,7 +2083,7 @@
</span><span class="cx">
</span><span class="cx"> bool Internals::isSelectPopupVisible(Node* node)
</span><span class="cx"> {
</span><del>- if (!isHTMLSelectElement(node))
</del><ins>+ if (!is<HTMLSelectElement>(node))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> HTMLSelectElement& select = downcast<HTMLSelectElement>(*node);
</span></span></pre></div>
<a id="trunkSourceWebCorexmlparserXMLDocumentParserLibxml2cpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -858,7 +858,7 @@
</span><span class="cx"> pushCurrentNode(newElement.get());
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- if (isHTMLHtmlElement(*newElement))
</del><ins>+ if (is<HTMLHtmlElement>(*newElement))
</ins><span class="cx"> downcast<HTMLHtmlElement>(*newElement).insertedByParser();
</span><span class="cx">
</span><span class="cx"> if (!m_parsingFragment && isFirstElement && document()->frame())
</span></span></pre></div>
<a id="trunkSourceWebKitiosChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ios/ChangeLog (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ios/ChangeLog 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit/ios/ChangeLog 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-09-24 Christophe Dumez <cdumez@apple.com>
+
+ Use is<HTML*Element>() instead of isHTML*Element() - Part 1
+ https://bugs.webkit.org/show_bug.cgi?id=137068
+
+ Reviewed by Ryosuke Niwa.
+
+ Start using is<HTML*Element>() instead of isHTML*Element().
+ Remaining usages will be updated in a follow-up patch to
+ reduce the size of the change.
+
+ * WebCoreSupport/WebChromeClientIOS.mm:
+ (WebChromeClientIOS::focusedElementChanged):
+
</ins><span class="cx"> 2014-09-21 Timothy Hatcher <timothy@apple.com>
</span><span class="cx">
</span><span class="cx"> Make the Web Inspector use a separate web process.
</span></span></pre></div>
<a id="trunkSourceWebKitiosWebCoreSupportWebChromeClientIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -311,7 +311,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (!element)
</span><span class="cx"> return;
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*element);
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2014-09-24 Christophe Dumez <cdumez@apple.com>
+
+ Use is<HTML*Element>() instead of isHTML*Element() - Part 1
+ https://bugs.webkit.org/show_bug.cgi?id=137068
+
+ Reviewed by Ryosuke Niwa.
+
+ Start using is<HTML*Element>() instead of isHTML*Element().
+ Remaining usages will be updated in a follow-up patch to
+ reduce the size of the change.
+
+ * WebCoreSupport/WebChromeClient.mm:
+ (WebChromeClient::focusedElementChanged):
+ * WebCoreSupport/WebEditorClient.mm:
+ (WebEditorClient::textFieldDidBeginEditing):
+ (WebEditorClient::textFieldDidEndEditing):
+ (WebEditorClient::textDidChangeInTextField):
+ (WebEditorClient::doTextFieldCommandFromEvent):
+ (WebEditorClient::textWillBeDeletedInTextField):
+ (WebEditorClient::textDidChangeInTextArea):
+ * WebView/WebHTMLRepresentation.mm:
+ (inputElementFromDOMElement):
+
</ins><span class="cx"> 2014-09-21 Timothy Hatcher <timothy@apple.com>
</span><span class="cx">
</span><span class="cx"> Make the Web Inspector use a separate web process.
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebChromeClientmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -220,7 +220,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (!element)
</span><span class="cx"> return;
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*element);
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebCoreSupportWebEditorClientmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -705,7 +705,7 @@
</span><span class="cx">
</span><span class="cx"> void WebEditorClient::textFieldDidBeginEditing(Element* element)
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> DOMHTMLInputElement* inputElement = kit(downcast<HTMLInputElement>(element));
</span><span class="lines">@@ -715,7 +715,7 @@
</span><span class="cx">
</span><span class="cx"> void WebEditorClient::textFieldDidEndEditing(Element* element)
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> DOMHTMLInputElement* inputElement = kit(downcast<HTMLInputElement>(element));
</span><span class="lines">@@ -725,7 +725,7 @@
</span><span class="cx">
</span><span class="cx"> void WebEditorClient::textDidChangeInTextField(Element* element)
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> #if !PLATFORM(IOS)
</span><span class="lines">@@ -763,7 +763,7 @@
</span><span class="cx">
</span><span class="cx"> bool WebEditorClient::doTextFieldCommandFromEvent(Element* element, KeyboardEvent* event)
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return NO;
</span><span class="cx">
</span><span class="cx"> DOMHTMLInputElement* inputElement = kit(downcast<HTMLInputElement>(element));
</span><span class="lines">@@ -775,7 +775,7 @@
</span><span class="cx">
</span><span class="cx"> void WebEditorClient::textWillBeDeletedInTextField(Element* element)
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> DOMHTMLInputElement* inputElement = kit(downcast<HTMLInputElement>(element));
</span><span class="lines">@@ -786,7 +786,7 @@
</span><span class="cx">
</span><span class="cx"> void WebEditorClient::textDidChangeInTextArea(Element* element)
</span><span class="cx"> {
</span><del>- if (!isHTMLTextAreaElement(element))
</del><ins>+ if (!is<HTMLTextAreaElement>(element))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> DOMHTMLTextAreaElement* textAreaElement = kit(downcast<HTMLTextAreaElement>(element));
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebHTMLRepresentationmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -305,7 +305,7 @@
</span><span class="cx"> static HTMLInputElement* inputElementFromDOMElement(DOMElement* element)
</span><span class="cx"> {
</span><span class="cx"> Element* node = core(element);
</span><del>- return node && isHTMLInputElement(node) ? downcast<HTMLInputElement>(node) : nullptr;
</del><ins>+ return node && is<HTMLInputElement>(node) ? downcast<HTMLInputElement>(node) : nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> - (BOOL)elementDoesAutoComplete:(DOMElement *)element
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit/win/ChangeLog 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -1,3 +1,46 @@
</span><ins>+2014-09-24 Christophe Dumez <cdumez@apple.com>
+
+ Use is<HTML*Element>() instead of isHTML*Element() - Part 1
+ https://bugs.webkit.org/show_bug.cgi?id=137068
+
+ Reviewed by Ryosuke Niwa.
+
+ Start using is<HTML*Element>() instead of isHTML*Element().
+ Remaining usages will be updated in a follow-up patch to
+ reduce the size of the change.
+
+ * DOMCoreClasses.cpp:
+ (DOMElement::createInstance):
+ * DOMHTMLClasses.cpp:
+ (DOMHTMLOptionElement::text):
+ (DOMHTMLOptionElement::label):
+ (DOMHTMLInputElement::form):
+ (DOMHTMLInputElement::disabled):
+ (DOMHTMLInputElement::readOnly):
+ (DOMHTMLInputElement::setType):
+ (DOMHTMLInputElement::value):
+ (DOMHTMLInputElement::setValue):
+ (DOMHTMLInputElement::setValueForUser):
+ (DOMHTMLInputElement::select):
+ (DOMHTMLInputElement::setSelectionStart):
+ (DOMHTMLInputElement::selectionStart):
+ (DOMHTMLInputElement::setSelectionEnd):
+ (DOMHTMLInputElement::selectionEnd):
+ (DOMHTMLInputElement::isTextField):
+ (DOMHTMLInputElement::rectOnScreen):
+ (DOMHTMLInputElement::replaceCharactersInRange):
+ (DOMHTMLInputElement::selectedRange):
+ (DOMHTMLInputElement::setAutofilled):
+ (DOMHTMLInputElement::isAutofilled):
+ (DOMHTMLInputElement::isUserEdited):
+ (DOMHTMLTextAreaElement::form):
+ (DOMHTMLTextAreaElement::value):
+ (DOMHTMLTextAreaElement::setValue):
+ (DOMHTMLTextAreaElement::select):
+ (DOMHTMLTextAreaElement::isUserEdited):
+ * WebFrame.cpp:
+ (inputElementFromDOMElement):
+
</ins><span class="cx"> 2014-09-21 Timothy Hatcher <timothy@apple.com>
</span><span class="cx">
</span><span class="cx"> Make the Web Inspector use a separate web process.
</span></span></pre></div>
<a id="trunkSourceWebKitwinDOMCoreClassescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/DOMCoreClasses.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/DOMCoreClasses.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit/win/DOMCoreClasses.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -1506,16 +1506,16 @@
</span><span class="cx"> } else if (e->hasTagName(iframeTag)) {
</span><span class="cx"> DOMHTMLIFrameElement* newElement = new DOMHTMLIFrameElement(e);
</span><span class="cx"> hr = newElement->QueryInterface(IID_IDOMElement, (void**)&domElement);
</span><del>- } else if (isHTMLInputElement(e)) {
</del><ins>+ } else if (is<HTMLInputElement>(e)) {
</ins><span class="cx"> DOMHTMLInputElement* newElement = new DOMHTMLInputElement(e);
</span><span class="cx"> hr = newElement->QueryInterface(IID_IDOMElement, (void**)&domElement);
</span><del>- } else if (isHTMLOptionElement(e)) {
</del><ins>+ } else if (is<HTMLOptionElement>(e)) {
</ins><span class="cx"> DOMHTMLOptionElement* newElement = new DOMHTMLOptionElement(e);
</span><span class="cx"> hr = newElement->QueryInterface(IID_IDOMElement, (void**)&domElement);
</span><span class="cx"> } else if (e->hasTagName(selectTag)) {
</span><span class="cx"> DOMHTMLSelectElement* newElement = new DOMHTMLSelectElement(e);
</span><span class="cx"> hr = newElement->QueryInterface(IID_IDOMElement, (void**)&domElement);
</span><del>- } else if (isHTMLTextAreaElement(e)) {
</del><ins>+ } else if (is<HTMLTextAreaElement>(e)) {
</ins><span class="cx"> DOMHTMLTextAreaElement* newElement = new DOMHTMLTextAreaElement(e);
</span><span class="cx"> hr = newElement->QueryInterface(IID_IDOMElement, (void**)&domElement);
</span><span class="cx"> } else if (e->isHTMLElement()) {
</span></span></pre></div>
<a id="trunkSourceWebKitwinDOMHTMLClassescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/DOMHTMLClasses.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -859,7 +859,7 @@
</span><span class="cx"> *result = 0;
</span><span class="cx">
</span><span class="cx"> ASSERT(m_element);
</span><del>- ASSERT(isHTMLOptionElement(m_element));
</del><ins>+ ASSERT(is<HTMLOptionElement>(m_element));
</ins><span class="cx"> HTMLOptionElement& optionElement = downcast<HTMLOptionElement>(*m_element);
</span><span class="cx">
</span><span class="cx"> *result = BString(optionElement.text()).release();
</span><span class="lines">@@ -896,7 +896,7 @@
</span><span class="cx"> *result = 0;
</span><span class="cx">
</span><span class="cx"> ASSERT(m_element);
</span><del>- ASSERT(isHTMLOptionElement(m_element));
</del><ins>+ ASSERT(is<HTMLOptionElement>(m_element));
</ins><span class="cx"> HTMLOptionElement& optionElement = downcast<HTMLOptionElement>(*m_element);
</span><span class="cx">
</span><span class="cx"> *result = BString(optionElement.label()).release();
</span><span class="lines">@@ -992,7 +992,7 @@
</span><span class="cx"> if (!result)
</span><span class="cx"> return E_POINTER;
</span><span class="cx"> *result = nullptr;
</span><del>- ASSERT(m_element && isHTMLInputElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> COMPtr<IDOMElement> domElement;
</span><span class="cx"> domElement.adoptRef(DOMHTMLElement::createInstance(inputElement.form()));
</span><span class="lines">@@ -1074,7 +1074,7 @@
</span><span class="cx"> HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::disabled(
</span><span class="cx"> /* [retval][out] */ BOOL* result)
</span><span class="cx"> {
</span><del>- ASSERT(m_element && isHTMLInputElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> *result = inputElement.isDisabledFormControl() ? TRUE : FALSE;
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1118,7 +1118,7 @@
</span><span class="cx"> HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::readOnly(
</span><span class="cx"> /* [retval][out] */ BOOL* result)
</span><span class="cx"> {
</span><del>- ASSERT(m_element && isHTMLInputElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> *result = inputElement.isReadOnly() ? TRUE : FALSE;
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1183,7 +1183,7 @@
</span><span class="cx"> HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::setType(
</span><span class="cx"> /* [in] */ BSTR type)
</span><span class="cx"> {
</span><del>- ASSERT(m_element && isHTMLInputElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> WTF::String typeString(type, SysStringLen(type));
</span><span class="cx"> inputElement.setType(typeString);
</span><span class="lines">@@ -1207,7 +1207,7 @@
</span><span class="cx"> HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::value(
</span><span class="cx"> /* [retval][out] */ BSTR* result)
</span><span class="cx"> {
</span><del>- ASSERT(m_element && isHTMLInputElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> WTF::String valueString = inputElement.value();
</span><span class="cx"> *result = BString(valueString).release();
</span><span class="lines">@@ -1219,7 +1219,7 @@
</span><span class="cx"> HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::setValue(
</span><span class="cx"> /* [in] */ BSTR value)
</span><span class="cx"> {
</span><del>- ASSERT(m_element && isHTMLInputElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> inputElement.setValue(String((UChar*) value, SysStringLen(value)));
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1229,7 +1229,7 @@
</span><span class="cx"> /* [in] */ BSTR value)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_element);
</span><del>- ASSERT(isHTMLInputElement(m_element));
</del><ins>+ ASSERT(is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> inputElement.setValueForUser(String(static_cast<UChar*>(value), SysStringLen(value)));
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1237,7 +1237,7 @@
</span><span class="cx">
</span><span class="cx"> HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::select( void)
</span><span class="cx"> {
</span><del>- ASSERT(m_element && isHTMLInputElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> inputElement.select();
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1252,7 +1252,7 @@
</span><span class="cx"> HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::setSelectionStart(
</span><span class="cx"> /* [in] */ long start)
</span><span class="cx"> {
</span><del>- ASSERT(m_element && isHTMLInputElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> inputElement.setSelectionStart(start);
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1261,7 +1261,7 @@
</span><span class="cx"> HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::selectionStart(
</span><span class="cx"> /* [retval][out] */ long *start)
</span><span class="cx"> {
</span><del>- ASSERT(m_element && isHTMLInputElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> *start = inputElement.selectionStart();
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1270,7 +1270,7 @@
</span><span class="cx"> HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::setSelectionEnd(
</span><span class="cx"> /* [in] */ long end)
</span><span class="cx"> {
</span><del>- ASSERT(m_element && isHTMLInputElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> inputElement.setSelectionEnd(end);
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1279,7 +1279,7 @@
</span><span class="cx"> HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::selectionEnd(
</span><span class="cx"> /* [retval][out] */ long *end)
</span><span class="cx"> {
</span><del>- ASSERT(m_element && isHTMLInputElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> *end = inputElement.selectionEnd();
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1291,7 +1291,7 @@
</span><span class="cx"> /* [retval][out] */ BOOL* result)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_element);
</span><del>- ASSERT(isHTMLInputElement(m_element));
</del><ins>+ ASSERT(is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> *result = inputElement.isTextField() ? TRUE : FALSE;
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1301,7 +1301,7 @@
</span><span class="cx"> /* [retval][out] */ LPRECT rect)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_element);
</span><del>- ASSERT(isHTMLInputElement(m_element));
</del><ins>+ ASSERT(is<HTMLInputElement>(m_element));
</ins><span class="cx"> rect->left = rect->top = rect->right = rect->bottom = 0;
</span><span class="cx"> RenderObject* renderer = m_element->renderer();
</span><span class="cx"> FrameView* view = m_element->document().view();
</span><span class="lines">@@ -1327,7 +1327,7 @@
</span><span class="cx"> return E_POINTER;
</span><span class="cx">
</span><span class="cx"> ASSERT(m_element);
</span><del>- ASSERT(isHTMLInputElement(m_element));
</del><ins>+ ASSERT(is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx">
</span><span class="cx"> String newValue = inputElement.value();
</span><span class="lines">@@ -1344,7 +1344,7 @@
</span><span class="cx"> /* [out] */ int* end)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_element);
</span><del>- ASSERT(isHTMLInputElement(m_element));
</del><ins>+ ASSERT(is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> *start = inputElement.selectionStart();
</span><span class="cx"> *end = inputElement.selectionEnd();
</span><span class="lines">@@ -1355,7 +1355,7 @@
</span><span class="cx"> /* [in] */ BOOL filled)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_element);
</span><del>- ASSERT(isHTMLInputElement(m_element));
</del><ins>+ ASSERT(is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> inputElement.setAutofilled(!!filled);
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1365,7 +1365,7 @@
</span><span class="cx"> /* [retval][out] */ BOOL* result)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_element);
</span><del>- ASSERT(isHTMLInputElement(m_element));
</del><ins>+ ASSERT(is<HTMLInputElement>(m_element));
</ins><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*m_element);
</span><span class="cx"> *result = inputElement.isAutofilled() ? TRUE : FALSE;
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1380,7 +1380,7 @@
</span><span class="cx"> return E_POINTER;
</span><span class="cx">
</span><span class="cx"> *result = FALSE;
</span><del>- ASSERT(m_element && isHTMLInputElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLInputElement>(m_element));
</ins><span class="cx"> BOOL textField = FALSE;
</span><span class="cx"> if (FAILED(isTextField(&textField)) || !textField)
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1427,7 +1427,7 @@
</span><span class="cx"> if (!result)
</span><span class="cx"> return E_POINTER;
</span><span class="cx"> *result = 0;
</span><del>- ASSERT(m_element && isHTMLTextAreaElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLTextAreaElement>(m_element));
</ins><span class="cx"> HTMLTextAreaElement& textareaElement = downcast<HTMLTextAreaElement>(*m_element);
</span><span class="cx"> COMPtr<IDOMElement> domElement;
</span><span class="cx"> domElement.adoptRef(DOMHTMLElement::createInstance(textareaElement.form()));
</span><span class="lines">@@ -1544,7 +1544,7 @@
</span><span class="cx"> HRESULT STDMETHODCALLTYPE DOMHTMLTextAreaElement::value(
</span><span class="cx"> /* [retval][out] */ BSTR* result)
</span><span class="cx"> {
</span><del>- ASSERT(m_element && isHTMLTextAreaElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLTextAreaElement>(m_element));
</ins><span class="cx"> HTMLTextAreaElement& textareaElement = downcast<HTMLTextAreaElement>(*m_element);
</span><span class="cx"> WTF::String valueString = textareaElement.value();
</span><span class="cx"> *result = BString(valueString).release();
</span><span class="lines">@@ -1556,7 +1556,7 @@
</span><span class="cx"> HRESULT STDMETHODCALLTYPE DOMHTMLTextAreaElement::setValue(
</span><span class="cx"> /* [in] */ BSTR value)
</span><span class="cx"> {
</span><del>- ASSERT(m_element && isHTMLTextAreaElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLTextAreaElement>(m_element));
</ins><span class="cx"> HTMLTextAreaElement& textareaElement = downcast<HTMLTextAreaElement>(*m_element);
</span><span class="cx"> textareaElement.setValue(String((UChar*) value, SysStringLen(value)));
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1564,7 +1564,7 @@
</span><span class="cx">
</span><span class="cx"> HRESULT STDMETHODCALLTYPE DOMHTMLTextAreaElement::select( void)
</span><span class="cx"> {
</span><del>- ASSERT(m_element && isHTMLTextAreaElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLTextAreaElement>(m_element));
</ins><span class="cx"> HTMLTextAreaElement& textareaElement = downcast<HTMLTextAreaElement>(*m_element);
</span><span class="cx"> textareaElement.select();
</span><span class="cx"> return S_OK;
</span><span class="lines">@@ -1579,7 +1579,7 @@
</span><span class="cx"> return E_POINTER;
</span><span class="cx">
</span><span class="cx"> *result = FALSE;
</span><del>- ASSERT(m_element && isHTMLTextAreaElement(m_element));
</del><ins>+ ASSERT(m_element && is<HTMLTextAreaElement>(m_element));
</ins><span class="cx"> if (downcast<HTMLTextAreaElement>(*m_element).lastChangeWasUserEdit())
</span><span class="cx"> *result = TRUE;
</span><span class="cx"> return S_OK;
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebFramecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebFrame.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebFrame.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit/win/WebFrame.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -219,7 +219,7 @@
</span><span class="cx"> Element* ele;
</span><span class="cx"> hr = elePriv->coreElement((void**)&ele);
</span><span class="cx"> elePriv->Release();
</span><del>- if (SUCCEEDED(hr) && ele && isHTMLInputElement(ele))
</del><ins>+ if (SUCCEEDED(hr) && ele && is<HTMLInputElement>(ele))
</ins><span class="cx"> return downcast<HTMLInputElement>(ele);
</span><span class="cx"> }
</span><span class="cx"> return nullptr;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit2/ChangeLog 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -1,3 +1,37 @@
</span><ins>+2014-09-24 Christophe Dumez <cdumez@apple.com>
+
+ Use is<HTML*Element>() instead of isHTML*Element() - Part 1
+ https://bugs.webkit.org/show_bug.cgi?id=137068
+
+ Reviewed by Ryosuke Niwa.
+
+ Start using is<HTML*Element>() instead of isHTML*Element().
+ Remaining usages will be updated in a follow-up patch to
+ reduce the size of the change.
+
+ * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
+ (WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
+ (WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
+ (WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):
+ (WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
+ (WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
+ (WebKit::InjectedBundleNodeHandle::isTextField):
+ * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+ (WebKit::WebChromeClient::focusedElementChanged):
+ * WebProcess/WebCoreSupport/WebEditorClient.cpp:
+ (WebKit::WebEditorClient::textFieldDidBeginEditing):
+ (WebKit::WebEditorClient::textFieldDidEndEditing):
+ (WebKit::WebEditorClient::textDidChangeInTextField):
+ (WebKit::WebEditorClient::textDidChangeInTextArea):
+ (WebKit::WebEditorClient::doTextFieldCommandFromEvent):
+ (WebKit::WebEditorClient::textWillBeDeletedInTextField):
+ * WebProcess/WebPage/WebFrame.cpp:
+ (WebKit::WebFrame::containsAnyFormControls):
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::setAssistedNodeValue):
+ (WebKit::WebPage::setAssistedNodeValueAsNumber):
+ (WebKit::WebPage::setAssistedNodeSelectedIndex):
+
</ins><span class="cx"> 2014-09-23 Ada Chan <adachan@apple.com>
</span><span class="cx">
</span><span class="cx"> Add stub implementation of WKPageIsPlayingAudio().
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessInjectedBundleDOMInjectedBundleNodeHandlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -199,7 +199,7 @@
</span><span class="cx">
</span><span class="cx"> void InjectedBundleNodeHandle::setHTMLInputElementValueForUser(const String& value)
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(*m_node))
</del><ins>+ if (!is<HTMLInputElement>(*m_node))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> downcast<HTMLInputElement>(*m_node).setValueForUser(value);
</span><span class="lines">@@ -207,7 +207,7 @@
</span><span class="cx">
</span><span class="cx"> bool InjectedBundleNodeHandle::isHTMLInputElementAutofilled() const
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(*m_node))
</del><ins>+ if (!is<HTMLInputElement>(*m_node))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> return downcast<HTMLInputElement>(*m_node).isAutofilled();
</span><span class="lines">@@ -215,7 +215,7 @@
</span><span class="cx">
</span><span class="cx"> void InjectedBundleNodeHandle::setHTMLInputElementAutofilled(bool filled)
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(*m_node))
</del><ins>+ if (!is<HTMLInputElement>(*m_node))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> downcast<HTMLInputElement>(*m_node).setAutofilled(filled);
</span><span class="lines">@@ -223,7 +223,7 @@
</span><span class="cx">
</span><span class="cx"> bool InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit()
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(*m_node))
</del><ins>+ if (!is<HTMLInputElement>(*m_node))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> return downcast<HTMLInputElement>(*m_node).lastChangeWasUserEdit();
</span><span class="lines">@@ -231,7 +231,7 @@
</span><span class="cx">
</span><span class="cx"> bool InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit()
</span><span class="cx"> {
</span><del>- if (!isHTMLTextAreaElement(*m_node))
</del><ins>+ if (!is<HTMLTextAreaElement>(*m_node))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> return downcast<HTMLTextAreaElement>(*m_node).lastChangeWasUserEdit();
</span><span class="lines">@@ -239,7 +239,7 @@
</span><span class="cx">
</span><span class="cx"> bool InjectedBundleNodeHandle::isTextField() const
</span><span class="cx"> {
</span><del>- return isHTMLInputElement(*m_node) && downcast<HTMLInputElement>(*m_node).isText();
</del><ins>+ return is<HTMLInputElement>(*m_node) && downcast<HTMLInputElement>(*m_node).isText();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<InjectedBundleNodeHandle> InjectedBundleNodeHandle::htmlTableCellElementCellAbove()
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebChromeClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -178,7 +178,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (!element)
</span><span class="cx"> return;
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> HTMLInputElement& inputElement = downcast<HTMLInputElement>(*element);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebCoreSupportWebEditorClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -295,7 +295,7 @@
</span><span class="cx">
</span><span class="cx"> void WebEditorClient::textFieldDidBeginEditing(Element* element)
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> WebFrame* webFrame = WebFrame::fromCoreFrame(*element->document().frame());
</span><span class="lines">@@ -306,7 +306,7 @@
</span><span class="cx">
</span><span class="cx"> void WebEditorClient::textFieldDidEndEditing(Element* element)
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> WebFrame* webFrame = WebFrame::fromCoreFrame(*element->document().frame());
</span><span class="lines">@@ -317,7 +317,7 @@
</span><span class="cx">
</span><span class="cx"> void WebEditorClient::textDidChangeInTextField(Element* element)
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> bool initiatedByUserTyping = UserTypingGestureIndicator::processingUserTypingGesture() && UserTypingGestureIndicator::focusedElementAtGestureStart() == element;
</span><span class="lines">@@ -330,7 +330,7 @@
</span><span class="cx">
</span><span class="cx"> void WebEditorClient::textDidChangeInTextArea(Element* element)
</span><span class="cx"> {
</span><del>- if (!isHTMLTextAreaElement(element))
</del><ins>+ if (!is<HTMLTextAreaElement>(element))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> WebFrame* webFrame = WebFrame::fromCoreFrame(*element->document().frame());
</span><span class="lines">@@ -393,7 +393,7 @@
</span><span class="cx">
</span><span class="cx"> bool WebEditorClient::doTextFieldCommandFromEvent(Element* element, KeyboardEvent* event)
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> WKInputFieldActionType actionType = static_cast<WKInputFieldActionType>(0);
</span><span class="lines">@@ -408,7 +408,7 @@
</span><span class="cx">
</span><span class="cx"> void WebEditorClient::textWillBeDeletedInTextField(Element* element)
</span><span class="cx"> {
</span><del>- if (!isHTMLInputElement(element))
</del><ins>+ if (!is<HTMLInputElement>(element))
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> WebFrame* webFrame = WebFrame::fromCoreFrame(*element->document().frame());
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebFramecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -633,7 +633,7 @@
</span><span class="cx"> for (Node* node = document->documentElement(); node; node = NodeTraversal::next(node)) {
</span><span class="cx"> if (!node->isElementNode())
</span><span class="cx"> continue;
</span><del>- if (isHTMLInputElement(node) || isHTMLSelectElement(node) || isHTMLTextAreaElement(node))
</del><ins>+ if (is<HTMLInputElement>(node) || is<HTMLSelectElement>(node) || is<HTMLTextAreaElement>(node))
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageiosWebPageIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (173931 => 173932)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-09-24 21:22:41 UTC (rev 173931)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-09-24 21:25:22 UTC (rev 173932)
</span><span class="lines">@@ -612,7 +612,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (!m_assistedNode)
</span><span class="cx"> return;
</span><del>- if (isHTMLInputElement(*m_assistedNode)) {
</del><ins>+ if (is<HTMLInputElement>(*m_assistedNode)) {
</ins><span class="cx"> HTMLInputElement& element = downcast<HTMLInputElement>(*m_assistedNode);
</span><span class="cx"> element.setValue(value, DispatchInputAndChangeEvent);
</span><span class="cx"> }
</span><span class="lines">@@ -623,7 +623,7 @@
</span><span class="cx"> {
</span><span class="cx"> if (!m_assistedNode)
</span><span class="cx"> return;
</span><del>- if (isHTMLInputElement(*m_assistedNode)) {
</del><ins>+ if (is<HTMLInputElement>(*m_assistedNode)) {
</ins><span class="cx"> HTMLInputElement& element = downcast<HTMLInputElement>(*m_assistedNode);
</span><span class="cx"> element.setValueAsNumber(value, ASSERT_NO_EXCEPTION, DispatchInputAndChangeEvent);
</span><span class="cx"> }
</span><span class="lines">@@ -631,7 +631,7 @@
</span><span class="cx">
</span><span class="cx"> void WebPage::setAssistedNodeSelectedIndex(uint32_t index, bool allowMultipleSelection)
</span><span class="cx"> {
</span><del>- if (!m_assistedNode || !isHTMLSelectElement(*m_assistedNode))
</del><ins>+ if (!m_assistedNode || !is<HTMLSelectElement>(*m_assistedNode))
</ins><span class="cx"> return;
</span><span class="cx"> HTMLSelectElement& select = downcast<HTMLSelectElement>(*m_assistedNode);
</span><span class="cx"> select.optionSelectedByUser(index, true, allowMultipleSelection);
</span><span class="lines">@@ -1990,11 +1990,11 @@
</span><span class="cx">
</span><span class="cx"> static inline bool isAssistableNode(Node* node)
</span><span class="cx"> {
</span><del>- if (isHTMLSelectElement(node))
</del><ins>+ if (is<HTMLSelectElement>(node))
</ins><span class="cx"> return true;
</span><del>- if (isHTMLTextAreaElement(node))
</del><ins>+ if (is<HTMLTextAreaElement>(node))
</ins><span class="cx"> return !downcast<HTMLTextAreaElement>(*node).isReadOnlyNode();
</span><del>- if (isHTMLInputElement(node)) {
</del><ins>+ if (is<HTMLInputElement>(node)) {
</ins><span class="cx"> HTMLInputElement& element = downcast<HTMLInputElement>(*node);
</span><span class="cx"> return !element.isReadOnlyNode() && (element.isTextField() || element.isDateField() || element.isDateTimeLocalField() || element.isMonthField() || element.isTimeField());
</span><span class="cx"> }
</span><span class="lines">@@ -2066,7 +2066,7 @@
</span><span class="cx"> information.hasNextNode = hasFocusableElement(m_assistedNode.get(), m_page.get(), true);
</span><span class="cx"> information.hasPreviousNode = hasFocusableElement(m_assistedNode.get(), m_page.get(), false);
</span><span class="cx">
</span><del>- if (isHTMLSelectElement(*m_assistedNode)) {
</del><ins>+ if (is<HTMLSelectElement>(*m_assistedNode)) {
</ins><span class="cx"> HTMLSelectElement& element = downcast<HTMLSelectElement>(*m_assistedNode);
</span><span class="cx"> information.elementType = InputType::Select;
</span><span class="cx"> const Vector<HTMLElement*>& items = element.listItems();
</span><span class="lines">@@ -2077,7 +2077,7 @@
</span><span class="cx"> // If a select does not have groups, all the option elements have group ID 0.
</span><span class="cx"> for (size_t i = 0; i < count; ++i) {
</span><span class="cx"> HTMLElement* item = items[i];
</span><del>- if (isHTMLOptionElement(item)) {
</del><ins>+ if (is<HTMLOptionElement>(item)) {
</ins><span class="cx"> HTMLOptionElement& option = downcast<HTMLOptionElement>(*item);
</span><span class="cx"> information.selectOptions.append(OptionItem(option.text(), false, parentGroupID, option.selected(), option.fastHasAttribute(WebCore::HTMLNames::disabledAttr)));
</span><span class="cx"> } else if (isHTMLOptGroupElement(item)) {
</span><span class="lines">@@ -2088,14 +2088,14 @@
</span><span class="cx"> }
</span><span class="cx"> information.selectedIndex = element.selectedIndex();
</span><span class="cx"> information.isMultiSelect = element.multiple();
</span><del>- } else if (isHTMLTextAreaElement(*m_assistedNode)) {
</del><ins>+ } else if (is<HTMLTextAreaElement>(*m_assistedNode)) {
</ins><span class="cx"> HTMLTextAreaElement& element = downcast<HTMLTextAreaElement>(*m_assistedNode);
</span><span class="cx"> information.autocapitalizeType = static_cast<WebAutocapitalizeType>(element.autocapitalizeType());
</span><span class="cx"> information.isAutocorrect = element.autocorrect();
</span><span class="cx"> information.elementType = InputType::TextArea;
</span><span class="cx"> information.isReadOnly = element.isReadOnly();
</span><span class="cx"> information.value = element.value();
</span><del>- } else if (isHTMLInputElement(*m_assistedNode)) {
</del><ins>+ } else if (is<HTMLInputElement>(*m_assistedNode)) {
</ins><span class="cx"> HTMLInputElement& element = downcast<HTMLInputElement>(*m_assistedNode);
</span><span class="cx"> HTMLFormElement* form = element.form();
</span><span class="cx"> if (form)
</span></span></pre>
</div>
</div>
</body>
</html>