<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173895] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173895">173895</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2014-09-23 15:27:38 -0700 (Tue, 23 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed build fix after <a href="http://trac.webkit.org/projects/webkit/changeset/173893">r173893</a>.
Partial revert of <a href="http://trac.webkit.org/projects/webkit/changeset/173893">r173893</a> to fix debug builds.
Source/WebCore:
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::text):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::makeContextStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::makeElementStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::isPlaceholderShown):
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
* dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::updateName):
(WebCore::Element::updateId):
* editing/Editor.cpp:
(WebCore::Editor::selectionForCommand):
(WebCore::findFirstMarkable):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::matchesReadWritePseudoClass):
(WebCore::HTMLElement::directionality):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateDocNamedItem):
* html/HTMLPlugInImageElement.cpp:
(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin):
* html/HTMLTextFormControlElement.cpp:
(WebCore::enclosingTextFormControl):
* page/FrameView.cpp:
(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absolutePDFURL):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintContents):
(WebCore::RenderEmbeddedObject::layout):
* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::plugInImageElement):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::textFormControlElement):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
* testing/Internals.cpp:
(WebCore::Internals::visiblePlaceholder):
Source/WebKit/win:
* DOMHTMLClasses.cpp:
(DOMHTMLDocument::URL):
(DOMHTMLDocument::body):
(DOMHTMLDocument::forms):
Source/WebKit2:
* WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::value):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::pluginSnapshotTimerFired):
(WebKit::PluginView::pluginDidReceiveUserInteraction):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMWindowCustomcpp">trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorecssSelectorCheckercpp">trunk/Source/WebCore/css/SelectorChecker.cpp</a></li>
<li><a href="#trunkSourceWebCorecssjitSelectorCompilercpp">trunk/Source/WebCore/cssjit/SelectorCompiler.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingEditorcpp">trunk/Source/WebCore/editing/Editor.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingFrameSelectioncpp">trunk/Source/WebCore/editing/FrameSelection.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLElementcpp">trunk/Source/WebCore/html/HTMLElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLImageElementcpp">trunk/Source/WebCore/html/HTMLImageElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLObjectElementcpp">trunk/Source/WebCore/html/HTMLObjectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLPlugInImageElementcpp">trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTextFormControlElementcpp">trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp</a></li>
<li><a href="#trunkSourceWebCorepageFrameViewcpp">trunk/Source/WebCore/page/FrameView.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingHitTestResultcpp">trunk/Source/WebCore/rendering/HitTestResult.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderEmbeddedObjectcpp">trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderSnapshottedPlugIncpp">trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTextControlcpp">trunk/Source/WebCore/rendering/RenderTextControl.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemeMacmm">trunk/Source/WebCore/rendering/RenderThemeMac.mm</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitwinDOMHTMLClassescpp">trunk/Source/WebKit/win/DOMHTMLClasses.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessPluginsPDFPDFPluginTextAnnotationmm">trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm</a></li>
<li><a href="#trunkSourceWebKit2WebProcessPluginsPluginViewcpp">trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/ChangeLog 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -1,3 +1,62 @@
</span><ins>+2014-09-23 Christophe Dumez <cdumez@apple.com>
+
+ Unreviewed build fix after r173893.
+
+ Partial revert of r173893 to fix debug builds.
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::text):
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::namedItemGetter):
+ (WebCore::JSDOMWindow::getOwnPropertySlot):
+ (WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
+ * css/SelectorChecker.cpp:
+ (WebCore::SelectorChecker::checkOne):
+ * cssjit/SelectorCompiler.cpp:
+ (WebCore::SelectorCompiler::makeContextStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
+ (WebCore::SelectorCompiler::makeElementStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
+ (WebCore::SelectorCompiler::isPlaceholderShown):
+ * dom/Document.cpp:
+ (WebCore::Document::processHttpEquiv):
+ * dom/Element.cpp:
+ (WebCore::Element::insertedInto):
+ (WebCore::Element::removedFrom):
+ (WebCore::Element::updateName):
+ (WebCore::Element::updateId):
+ * editing/Editor.cpp:
+ (WebCore::Editor::selectionForCommand):
+ (WebCore::findFirstMarkable):
+ * editing/FrameSelection.cpp:
+ (WebCore::FrameSelection::selectAll):
+ * html/HTMLElement.cpp:
+ (WebCore::HTMLElement::matchesReadWritePseudoClass):
+ (WebCore::HTMLElement::directionality):
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::parseAttribute):
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::updateDocNamedItem):
+ * html/HTMLPlugInImageElement.cpp:
+ (WebCore::addPlugInsFromNodeListMatchingPlugInOrigin):
+ * html/HTMLTextFormControlElement.cpp:
+ (WebCore::enclosingTextFormControl):
+ * page/FrameView.cpp:
+ (WebCore::FrameView::addEmbeddedObjectToUpdate):
+ (WebCore::FrameView::updateEmbeddedObject):
+ * rendering/HitTestResult.cpp:
+ (WebCore::HitTestResult::absolutePDFURL):
+ * rendering/RenderEmbeddedObject.cpp:
+ (WebCore::RenderEmbeddedObject::paintContents):
+ (WebCore::RenderEmbeddedObject::layout):
+ * rendering/RenderSnapshottedPlugIn.cpp:
+ (WebCore::RenderSnapshottedPlugIn::plugInImageElement):
+ * rendering/RenderTextControl.cpp:
+ (WebCore::RenderTextControl::textFormControlElement):
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
+ (WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
+ * testing/Internals.cpp:
+ (WebCore::Internals::visiblePlaceholder):
+
</ins><span class="cx"> 2014-09-22 Wenson Hsieh <wenson_hsieh@apple.com>
</span><span class="cx">
</span><span class="cx"> Implement snapping behavior for Mac overflow scrolling
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -1752,7 +1752,7 @@
</span><span class="cx"> return String();
</span><span class="cx">
</span><span class="cx"> if (isNativeTextControl() && isHTMLTextFormControlElement(*node))
</span><del>- return downcast<HTMLTextFormControlElement>(*node).value();
</del><ins>+ return toHTMLTextFormControlElement(*node).value();
</ins><span class="cx">
</span><span class="cx"> if (!node->isElementNode())
</span><span class="cx"> return String();
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMWindowCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -83,16 +83,16 @@
</span><span class="cx"> ASSERT(document->isHTMLDocument());
</span><span class="cx">
</span><span class="cx"> AtomicStringImpl* atomicPropertyName = propertyName.publicName();
</span><del>- if (!atomicPropertyName || !downcast<HTMLDocument>(*document).hasWindowNamedItem(*atomicPropertyName))
</del><ins>+ if (!atomicPropertyName || !toHTMLDocument(*document).hasWindowNamedItem(*atomicPropertyName))
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx">
</span><del>- if (UNLIKELY(downcast<HTMLDocument>(*document).windowNamedItemContainsMultipleElements(*atomicPropertyName))) {
</del><ins>+ if (UNLIKELY(toHTMLDocument(*document).windowNamedItemContainsMultipleElements(*atomicPropertyName))) {
</ins><span class="cx"> RefPtr<HTMLCollection> collection = document->windowNamedItems(atomicPropertyName);
</span><span class="cx"> ASSERT(collection->length() > 1);
</span><span class="cx"> return JSValue::encode(toJS(exec, thisObj->globalObject(), WTF::getPtr(collection)));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return JSValue::encode(toJS(exec, thisObj->globalObject(), downcast<HTMLDocument>(*document).windowNamedItem(*atomicPropertyName)));
</del><ins>+ return JSValue::encode(toJS(exec, thisObj->globalObject(), toHTMLDocument(*document).windowNamedItem(*atomicPropertyName)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(USER_MESSAGE_HANDLERS)
</span><span class="lines">@@ -246,7 +246,7 @@
</span><span class="cx"> Document* document = thisObject->impl().frame()->document();
</span><span class="cx"> if (document->isHTMLDocument()) {
</span><span class="cx"> AtomicStringImpl* atomicPropertyName = propertyName.publicName();
</span><del>- if (atomicPropertyName && downcast<HTMLDocument>(*document).hasWindowNamedItem(*atomicPropertyName)) {
</del><ins>+ if (atomicPropertyName && toHTMLDocument(*document).hasWindowNamedItem(*atomicPropertyName)) {
</ins><span class="cx"> slot.setCustom(thisObject, ReadOnly | DontDelete | DontEnum, namedItemGetter);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -323,7 +323,7 @@
</span><span class="cx"> Document* document = thisObject->impl().frame()->document();
</span><span class="cx"> if (document->isHTMLDocument()) {
</span><span class="cx"> AtomicStringImpl* atomicPropertyName = propertyName.publicName();
</span><del>- if (atomicPropertyName && downcast<HTMLDocument>(*document).hasWindowNamedItem(*atomicPropertyName)) {
</del><ins>+ if (atomicPropertyName && toHTMLDocument(*document).hasWindowNamedItem(*atomicPropertyName)) {
</ins><span class="cx"> slot.setCustom(thisObject, ReadOnly | DontDelete | DontEnum, namedItemGetter);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorecssSelectorCheckercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/SelectorChecker.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/SelectorChecker.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/css/SelectorChecker.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -655,7 +655,7 @@
</span><span class="cx"> if (RenderStyle* style = context.elementStyle ? context.elementStyle : element->renderStyle())
</span><span class="cx"> style->setUnique();
</span><span class="cx"> }
</span><del>- return downcast<HTMLTextFormControlElement>(*element).isPlaceholderVisible();
</del><ins>+ return toHTMLTextFormControlElement(*element).isPlaceholderVisible();
</ins><span class="cx"> }
</span><span class="cx"> return false;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorecssjitSelectorCompilercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/cssjit/SelectorCompiler.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/cssjit/SelectorCompiler.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/cssjit/SelectorCompiler.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -2785,7 +2785,7 @@
</span><span class="cx"> if (isHTMLTextFormControlElement(*element)) {
</span><span class="cx"> if (checkingContext->resolvingMode == SelectorChecker::Mode::ResolvingStyle)
</span><span class="cx"> checkingContext->elementStyle->setUnique();
</span><del>- return downcast<HTMLTextFormControlElement>(*element).isPlaceholderVisible();
</del><ins>+ return toHTMLTextFormControlElement(*element).isPlaceholderVisible();
</ins><span class="cx"> }
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="lines">@@ -2797,14 +2797,14 @@
</span><span class="cx"> if (RenderStyle* style = element->renderStyle())
</span><span class="cx"> style->setUnique();
</span><span class="cx"> }
</span><del>- return downcast<HTMLTextFormControlElement>(*element).isPlaceholderVisible();
</del><ins>+ return toHTMLTextFormControlElement(*element).isPlaceholderVisible();
</ins><span class="cx"> }
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static bool isPlaceholderShown(Element* element)
</span><span class="cx"> {
</span><del>- return isHTMLTextFormControlElement(*element) && downcast<HTMLTextFormControlElement>(*element).isPlaceholderVisible();
</del><ins>+ return isHTMLTextFormControlElement(*element) && toHTMLTextFormControlElement(*element).isPlaceholderVisible();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void SelectorCodeGenerator::generateElementHasPlaceholderShown(Assembler::JumpList& failureCases, const SelectorFragment& fragment)
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -2881,7 +2881,7 @@
</span><span class="cx"> // FIXME: make setCookie work on XML documents too; e.g. in case of <html:meta .....>
</span><span class="cx"> if (isHTMLDocument()) {
</span><span class="cx"> // Exception (for sandboxed documents) ignored.
</span><del>- downcast<HTMLDocument>(*this).setCookie(content, IGNORE_EXCEPTION);
</del><ins>+ toHTMLDocument(*this).setCookie(content, IGNORE_EXCEPTION);
</ins><span class="cx"> }
</span><span class="cx"> break;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/dom/Element.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -1338,7 +1338,7 @@
</span><span class="cx"> elementRareData()->clearClassListValueForQuirksMode();
</span><span class="cx">
</span><span class="cx"> TreeScope* newScope = &insertionPoint.treeScope();
</span><del>- HTMLDocument* newDocument = !wasInDocument && inDocument() && newScope->documentScope().isHTMLDocument() ? downcast<HTMLDocument>(&newScope->documentScope()) : nullptr;
</del><ins>+ HTMLDocument* newDocument = !wasInDocument && inDocument() && newScope->documentScope().isHTMLDocument() ? toHTMLDocument(&newScope->documentScope()) : nullptr;
</ins><span class="cx"> if (newScope != &treeScope())
</span><span class="cx"> newScope = nullptr;
</span><span class="cx">
</span><span class="lines">@@ -1381,7 +1381,7 @@
</span><span class="cx">
</span><span class="cx"> if (insertionPoint.isInTreeScope()) {
</span><span class="cx"> TreeScope* oldScope = &insertionPoint.treeScope();
</span><del>- HTMLDocument* oldDocument = inDocument() && oldScope->documentScope().isHTMLDocument() ? downcast<HTMLDocument>(&oldScope->documentScope()) : nullptr;
</del><ins>+ HTMLDocument* oldDocument = inDocument() && oldScope->documentScope().isHTMLDocument() ? toHTMLDocument(&oldScope->documentScope()) : nullptr;
</ins><span class="cx"> if (oldScope != &treeScope() || !isInTreeScope())
</span><span class="cx"> oldScope = nullptr;
</span><span class="cx">
</span><span class="lines">@@ -2590,7 +2590,7 @@
</span><span class="cx"> return;
</span><span class="cx"> if (!document().isHTMLDocument())
</span><span class="cx"> return;
</span><del>- updateNameForDocument(downcast<HTMLDocument>(document()), oldName, newName);
</del><ins>+ updateNameForDocument(toHTMLDocument(document()), oldName, newName);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Element::updateNameForTreeScope(TreeScope& scope, const AtomicString& oldName, const AtomicString& newName)
</span><span class="lines">@@ -2638,7 +2638,7 @@
</span><span class="cx"> return;
</span><span class="cx"> if (!document().isHTMLDocument())
</span><span class="cx"> return;
</span><del>- updateIdForDocument(downcast<HTMLDocument>(document()), oldId, newId, UpdateHTMLDocumentNamedItemMapsOnlyIfDiffersFromNameAttribute);
</del><ins>+ updateIdForDocument(toHTMLDocument(document()), oldId, newId, UpdateHTMLDocumentNamedItemMapsOnlyIfDiffersFromNameAttribute);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Element::updateIdForTreeScope(TreeScope& scope, const AtomicString& oldId, const AtomicString& newId)
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingEditorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/Editor.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/Editor.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/editing/Editor.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -209,7 +209,7 @@
</span><span class="cx"> // If the target is a text control, and the current selection is outside of its shadow tree,
</span><span class="cx"> // then use the saved selection for that text control.
</span><span class="cx"> HTMLTextFormControlElement* textFormControlOfSelectionStart = enclosingTextFormControl(selection.start());
</span><del>- HTMLTextFormControlElement* textFromControlOfTarget = isHTMLTextFormControlElement(*event->target()->toNode()) ? downcast<HTMLTextFormControlElement>(event->target()->toNode()) : nullptr;
</del><ins>+ HTMLTextFormControlElement* textFromControlOfTarget = isHTMLTextFormControlElement(*event->target()->toNode()) ? toHTMLTextFormControlElement(event->target()->toNode()) : nullptr;
</ins><span class="cx"> if (textFromControlOfTarget && (selection.start().isNull() || textFromControlOfTarget != textFormControlOfSelectionStart)) {
</span><span class="cx"> if (RefPtr<Range> range = textFromControlOfTarget->selection())
</span><span class="cx"> return VisibleSelection(range.get(), DOWNSTREAM, selection.isDirectional());
</span><span class="lines">@@ -3537,7 +3537,7 @@
</span><span class="cx"> if (node->renderer()->isTextOrLineBreak())
</span><span class="cx"> return node;
</span><span class="cx"> if (isHTMLTextFormControlElement(*node))
</span><del>- node = downcast<HTMLTextFormControlElement>(*node).visiblePositionForIndex(1).deepEquivalent().deprecatedNode();
</del><ins>+ node = toHTMLTextFormControlElement(*node).visiblePositionForIndex(1).deepEquivalent().deprecatedNode();
</ins><span class="cx"> else if (node->firstChild())
</span><span class="cx"> node = node->firstChild();
</span><span class="cx"> else
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingFrameSelectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/FrameSelection.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -1689,7 +1689,7 @@
</span><span class="cx"> } else {
</span><span class="cx"> if (m_selection.isNone() && focusedElement) {
</span><span class="cx"> if (focusedElement->isTextFormControl()) {
</span><del>- downcast<HTMLTextFormControlElement>(*focusedElement).select();
</del><ins>+ toHTMLTextFormControlElement(*focusedElement).select();
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> root = focusedElement->nonBoundaryShadowTreeRootNode();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLElement.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLElement.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/html/HTMLElement.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -379,7 +379,7 @@
</span><span class="cx">
</span><span class="cx"> const Document& document = this->document();
</span><span class="cx"> if (document.isHTMLDocument()) {
</span><del>- const HTMLDocument& htmlDocument = downcast<HTMLDocument>(document);
</del><ins>+ const HTMLDocument& htmlDocument = toHTMLDocument(document);
</ins><span class="cx"> return htmlDocument.inDesignMode();
</span><span class="cx"> }
</span><span class="cx"> return false;
</span><span class="lines">@@ -920,7 +920,7 @@
</span><span class="cx"> TextDirection HTMLElement::directionality(Node** strongDirectionalityTextNode) const
</span><span class="cx"> {
</span><span class="cx"> if (isHTMLTextFormControlElement(*this)) {
</span><del>- HTMLTextFormControlElement& textElement = downcast<HTMLTextFormControlElement>(const_cast<HTMLElement&>(*this));
</del><ins>+ HTMLTextFormControlElement& textElement = toHTMLTextFormControlElement(const_cast<HTMLElement&>(*this));
</ins><span class="cx"> bool hasStrongDirectionality;
</span><span class="cx"> UCharDirection textDirection = textElement.value().defaultWritingDirection(&hasStrongDirectionality);
</span><span class="cx"> if (strongDirectionalityTextNode)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLImageElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLImageElement.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLImageElement.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/html/HTMLImageElement.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -183,7 +183,7 @@
</span><span class="cx"> if (name == nameAttr) {
</span><span class="cx"> bool willHaveName = !value.isNull();
</span><span class="cx"> if (hasName() != willHaveName && inDocument() && document().isHTMLDocument()) {
</span><del>- HTMLDocument& document = downcast<HTMLDocument>(this->document());
</del><ins>+ HTMLDocument& document = toHTMLDocument(this->document());
</ins><span class="cx"> const AtomicString& id = getIdAttribute();
</span><span class="cx"> if (!id.isEmpty() && id != getNameAttribute()) {
</span><span class="cx"> if (willHaveName)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLObjectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLObjectElement.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLObjectElement.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/html/HTMLObjectElement.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -436,7 +436,7 @@
</span><span class="cx"> child = child->nextSibling();
</span><span class="cx"> }
</span><span class="cx"> if (isNamedItem != wasNamedItem && inDocument() && document().isHTMLDocument()) {
</span><del>- HTMLDocument& document = downcast<HTMLDocument>(this->document());
</del><ins>+ HTMLDocument& document = toHTMLDocument(this->document());
</ins><span class="cx">
</span><span class="cx"> const AtomicString& id = getIdAttribute();
</span><span class="cx"> if (!id.isEmpty()) {
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLPlugInImageElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -417,7 +417,7 @@
</span><span class="cx"> if (node->isPluginElement()) {
</span><span class="cx"> HTMLPlugInElement* plugInElement = toHTMLPlugInElement(node);
</span><span class="cx"> if (plugInElement->isPlugInImageElement()) {
</span><del>- HTMLPlugInImageElement& plugInImageElement = downcast<HTMLPlugInImageElement>(*node);
</del><ins>+ HTMLPlugInImageElement& plugInImageElement = toHTMLPlugInImageElement(*node);
</ins><span class="cx"> const URL& loadedURL = plugInImageElement.loadedUrl();
</span><span class="cx"> String otherMimeType = plugInImageElement.loadedMimeType();
</span><span class="cx"> if (plugInOrigin == loadedURL.host() && mimeType == otherMimeType)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTextFormControlElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -717,7 +717,7 @@
</span><span class="cx"> if (!container)
</span><span class="cx"> return nullptr;
</span><span class="cx"> Element* ancestor = container->shadowHost();
</span><del>- return ancestor && isHTMLTextFormControlElement(*ancestor) ? downcast<HTMLTextFormControlElement>(ancestor) : nullptr;
</del><ins>+ return ancestor && isHTMLTextFormControlElement(*ancestor) ? toHTMLTextFormControlElement(ancestor) : nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static const Element* parentHTMLElement(const Element* element)
</span></span></pre></div>
<a id="trunkSourceWebCorepageFrameViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/FrameView.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/FrameView.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/page/FrameView.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -1416,7 +1416,7 @@
</span><span class="cx"> HTMLFrameOwnerElement& element = embeddedObject.frameOwnerElement();
</span><span class="cx"> if (isHTMLObjectElement(element) || isHTMLEmbedElement(element)) {
</span><span class="cx"> // Tell the DOM element that it needs a widget update.
</span><del>- HTMLPlugInImageElement& pluginElement = downcast<HTMLPlugInImageElement>(element);
</del><ins>+ HTMLPlugInImageElement& pluginElement = toHTMLPlugInImageElement(element);
</ins><span class="cx"> if (!pluginElement.needsCheckForSizeChange())
</span><span class="cx"> pluginElement.setNeedsWidgetUpdate(true);
</span><span class="cx"> }
</span><span class="lines">@@ -2789,7 +2789,7 @@
</span><span class="cx">
</span><span class="cx"> if (embeddedObject.isSnapshottedPlugIn()) {
</span><span class="cx"> if (isHTMLObjectElement(element) || isHTMLEmbedElement(element)) {
</span><del>- HTMLPlugInImageElement& pluginElement = downcast<HTMLPlugInImageElement>(element);
</del><ins>+ HTMLPlugInImageElement& pluginElement = toHTMLPlugInImageElement(element);
</ins><span class="cx"> pluginElement.checkSnapshotStatus();
</span><span class="cx"> }
</span><span class="cx"> return;
</span><span class="lines">@@ -2800,7 +2800,7 @@
</span><span class="cx"> // FIXME: This could turn into a real virtual dispatch if we defined
</span><span class="cx"> // updateWidget(PluginCreationOption) on HTMLElement.
</span><span class="cx"> if (isHTMLObjectElement(element) || isHTMLEmbedElement(element) || isHTMLAppletElement(element)) {
</span><del>- HTMLPlugInImageElement& pluginElement = downcast<HTMLPlugInImageElement>(element);
</del><ins>+ HTMLPlugInImageElement& pluginElement = toHTMLPlugInImageElement(element);
</ins><span class="cx"> if (pluginElement.needsCheckForSizeChange()) {
</span><span class="cx"> pluginElement.checkSnapshotStatus();
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingHitTestResultcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/HitTestResult.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/HitTestResult.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/rendering/HitTestResult.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -339,7 +339,7 @@
</span><span class="cx"> if (!isHTMLEmbedElement(*m_innerNonSharedNode) && !isHTMLObjectElement(*m_innerNonSharedNode))
</span><span class="cx"> return URL();
</span><span class="cx">
</span><del>- HTMLPlugInImageElement& element = downcast<HTMLPlugInImageElement>(*m_innerNonSharedNode);
</del><ins>+ HTMLPlugInImageElement& element = toHTMLPlugInImageElement(*m_innerNonSharedNode);
</ins><span class="cx"> URL url = m_innerNonSharedNode->document().completeURL(stripLeadingAndTrailingHTMLSpaces(element.url()));
</span><span class="cx"> if (!url.isValid())
</span><span class="cx"> return URL();
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderEmbeddedObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -238,7 +238,7 @@
</span><span class="cx"> if (!plugInElement.isPlugInImageElement())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (Image* snapshot = downcast<HTMLPlugInImageElement>(plugInElement).snapshotImage())
</del><ins>+ if (Image* snapshot = toHTMLPlugInImageElement(plugInElement).snapshotImage())
</ins><span class="cx"> paintSnapshotImage(paintInfo, paintOffset, snapshot);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -494,7 +494,7 @@
</span><span class="cx"> if (!wasMissingWidget && newSize.width() >= oldSize.width() && newSize.height() >= oldSize.height()) {
</span><span class="cx"> HTMLFrameOwnerElement& element = frameOwnerElement();
</span><span class="cx"> if (element.isPluginElement() && toHTMLPlugInElement(element).isPlugInImageElement()) {
</span><del>- HTMLPlugInImageElement& plugInImageElement = downcast<HTMLPlugInImageElement>(element);
</del><ins>+ HTMLPlugInImageElement& plugInImageElement = toHTMLPlugInImageElement(element);
</ins><span class="cx"> if (plugInImageElement.displayState() > HTMLPlugInElement::DisplayingSnapshot && plugInImageElement.snapshotDecision() == HTMLPlugInImageElement::MaySnapshotWhenResized) {
</span><span class="cx"> plugInImageElement.setNeedsCheckForSizeChange();
</span><span class="cx"> view().frameView().addEmbeddedObjectToUpdate(*this);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderSnapshottedPlugIncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -64,7 +64,7 @@
</span><span class="cx">
</span><span class="cx"> HTMLPlugInImageElement& RenderSnapshottedPlugIn::plugInImageElement() const
</span><span class="cx"> {
</span><del>- return downcast<HTMLPlugInImageElement>(RenderEmbeddedObject::frameOwnerElement());
</del><ins>+ return toHTMLPlugInImageElement(RenderEmbeddedObject::frameOwnerElement());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderSnapshottedPlugIn::layout()
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTextControlcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTextControl.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTextControl.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/rendering/RenderTextControl.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx">
</span><span class="cx"> HTMLTextFormControlElement& RenderTextControl::textFormControlElement() const
</span><span class="cx"> {
</span><del>- return downcast<HTMLTextFormControlElement>(nodeForNonAnonymous());
</del><ins>+ return toHTMLTextFormControlElement(nodeForNonAnonymous());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> TextControlInnerTextElement* RenderTextControl::innerTextElement() const
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemeMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -1678,7 +1678,7 @@
</span><span class="cx">
</span><span class="cx"> NSSearchFieldCell* search = this->search();
</span><span class="cx">
</span><del>- if (!input->isDisabledFormControl() && (input->isTextFormControl() && !downcast<HTMLTextFormControlElement>(*input).isReadOnly()))
</del><ins>+ if (!input->isDisabledFormControl() && (input->isTextFormControl() && !toHTMLTextFormControlElement(*input).isReadOnly()))
</ins><span class="cx"> updatePressedState([search cancelButtonCell], o);
</span><span class="cx"> else if ([[search cancelButtonCell] isHighlighted])
</span><span class="cx"> [[search cancelButtonCell] setHighlighted:NO];
</span><span class="lines">@@ -1861,7 +1861,7 @@
</span><span class="cx"> if (!plugInElement->isPlugInImageElement())
</span><span class="cx"> return true;
</span><span class="cx">
</span><del>- HTMLPlugInImageElement& plugInImageElement = downcast<HTMLPlugInImageElement>(*plugInElement);
</del><ins>+ HTMLPlugInImageElement& plugInImageElement = toHTMLPlugInImageElement(*plugInElement);
</ins><span class="cx">
</span><span class="cx"> Image* snapshot = plugInImageElement.snapshotImage();
</span><span class="cx"> if (!snapshot)
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebCore/testing/Internals.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -624,7 +624,7 @@
</span><span class="cx"> String Internals::visiblePlaceholder(Element* element)
</span><span class="cx"> {
</span><span class="cx"> if (element && isHTMLTextFormControlElement(*element)) {
</span><del>- const HTMLTextFormControlElement& textFormControlElement = downcast<HTMLTextFormControlElement>(*element);
</del><ins>+ const HTMLTextFormControlElement& textFormControlElement = toHTMLTextFormControlElement(*element);
</ins><span class="cx"> if (!textFormControlElement.isPlaceholderVisible())
</span><span class="cx"> return String();
</span><span class="cx"> if (HTMLElement* placeholderElement = textFormControlElement.placeholderElement())
</span></span></pre></div>
<a id="trunkSourceWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/ChangeLog 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebKit/win/ChangeLog 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-09-23 Christophe Dumez <cdumez@apple.com>
+
+ Unreviewed build fix after r173893.
+
+ Partial revert of r173893 to fix debug builds.
+
+ * DOMHTMLClasses.cpp:
+ (DOMHTMLDocument::URL):
+ (DOMHTMLDocument::body):
+ (DOMHTMLDocument::forms):
+
</ins><span class="cx"> 2014-09-23 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Use downcast<HTML*Element>() instead of toHTML*Element()
</span></span></pre></div>
<a id="trunkSourceWebKitwinDOMHTMLClassescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/DOMHTMLClasses.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -250,7 +250,7 @@
</span><span class="cx"> if (!result)
</span><span class="cx"> return E_POINTER;
</span><span class="cx">
</span><del>- *result = BString(downcast<HTMLDocument>(m_document)->url()).release();
</del><ins>+ *result = BString(toHTMLDocument(m_document)->url()).release();
</ins><span class="cx"> return S_OK;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -261,7 +261,7 @@
</span><span class="cx"> if (!m_document || !m_document->isHTMLDocument())
</span><span class="cx"> return E_FAIL;
</span><span class="cx">
</span><del>- HTMLDocument& htmlDoc = downcast<HTMLDocument>(*m_document);
</del><ins>+ HTMLDocument& htmlDoc = toHTMLDocument(*m_document);
</ins><span class="cx"> COMPtr<IDOMElement> domElement;
</span><span class="cx"> domElement.adoptRef(DOMHTMLElement::createInstance(htmlDoc.body()));
</span><span class="cx"> if (domElement)
</span><span class="lines">@@ -304,7 +304,7 @@
</span><span class="cx"> if (!m_document || !m_document->isHTMLDocument())
</span><span class="cx"> return E_FAIL;
</span><span class="cx">
</span><del>- HTMLDocument& htmlDoc = downcast<HTMLDocument>(*m_document);
</del><ins>+ HTMLDocument& htmlDoc = toHTMLDocument(*m_document);
</ins><span class="cx"> RefPtr<HTMLCollection> forms = htmlDoc.forms();
</span><span class="cx"> *collection = DOMHTMLCollection::createInstance(forms.get());
</span><span class="cx"> return S_OK;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebKit2/ChangeLog 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-09-23 Christophe Dumez <cdumez@apple.com>
+
+ Unreviewed build fix after r173893.
+
+ Partial revert of r173893 to fix debug builds.
+
+ * WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
+ (WebKit::PDFPluginTextAnnotation::value):
+ * WebProcess/Plugins/PluginView.cpp:
+ (WebKit::PluginView::initializePlugin):
+ (WebKit::PluginView::pluginSnapshotTimerFired):
+ (WebKit::PluginView::pluginDidReceiveUserInteraction):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::createPlugin):
+
</ins><span class="cx"> 2014-09-23 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Use downcast<HTML*Element>() instead of toHTML*Element()
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessPluginsPDFPDFPluginTextAnnotationmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -128,7 +128,7 @@
</span><span class="cx">
</span><span class="cx"> String PDFPluginTextAnnotation::value() const
</span><span class="cx"> {
</span><del>- return downcast<HTMLTextFormControlElement>(element())->value();
</del><ins>+ return toHTMLTextFormControlElement(element())->value();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool PDFPluginTextAnnotation::handleEvent(Event* event)
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessPluginsPluginViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -590,7 +590,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC)
</span><del>- HTMLPlugInImageElement* plugInImageElement = downcast<HTMLPlugInImageElement>(m_pluginElement.get());
</del><ins>+ HTMLPlugInImageElement* plugInImageElement = toHTMLPlugInImageElement(m_pluginElement.get());
</ins><span class="cx"> m_didPlugInStartOffScreen = !m_webPage->plugInIntersectsSearchRect(*plugInImageElement);
</span><span class="cx"> #endif
</span><span class="cx"> m_plugin->initialize(this, m_parameters);
</span><span class="lines">@@ -1713,7 +1713,7 @@
</span><span class="cx"> ASSERT(m_plugin);
</span><span class="cx">
</span><span class="cx"> #if ENABLE(PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC)
</span><del>- HTMLPlugInImageElement* plugInImageElement = downcast<HTMLPlugInImageElement>(m_pluginElement.get());
</del><ins>+ HTMLPlugInImageElement* plugInImageElement = toHTMLPlugInImageElement(m_pluginElement.get());
</ins><span class="cx"> bool isPlugInOnScreen = m_webPage->plugInIntersectsSearchRect(*plugInImageElement);
</span><span class="cx"> bool plugInCameOnScreen = isPlugInOnScreen && m_didPlugInStartOffScreen;
</span><span class="cx"> bool snapshotFound = false;
</span><span class="lines">@@ -1781,7 +1781,7 @@
</span><span class="cx">
</span><span class="cx"> m_didReceiveUserInteraction = true;
</span><span class="cx">
</span><del>- WebCore::HTMLPlugInImageElement* plugInImageElement = downcast<HTMLPlugInImageElement>(m_pluginElement.get());
</del><ins>+ WebCore::HTMLPlugInImageElement* plugInImageElement = toHTMLPlugInImageElement(m_pluginElement.get());
</ins><span class="cx"> String pageOrigin = plugInImageElement->document().page()->mainFrame().document()->baseURL().host();
</span><span class="cx"> String pluginOrigin = plugInImageElement->loadedUrl().host();
</span><span class="cx"> String mimeType = plugInImageElement->loadedMimeType();
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (173894 => 173895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-09-23 22:16:25 UTC (rev 173894)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-09-23 22:27:38 UTC (rev 173895)
</span><span class="lines">@@ -624,7 +624,7 @@
</span><span class="cx"> String pageURLString = m_page->mainFrame().loader().documentLoader()->responseURL().string();
</span><span class="cx">
</span><span class="cx"> #if ENABLE(PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC)
</span><del>- HTMLPlugInImageElement& pluginImageElement = downcast<HTMLPlugInImageElement>(*pluginElement);
</del><ins>+ HTMLPlugInImageElement& pluginImageElement = toHTMLPlugInImageElement(*pluginElement);
</ins><span class="cx"> unsigned pluginArea = 0;
</span><span class="cx"> PluginProcessType processType = pluginElement->displayState() == HTMLPlugInElement::WaitingForSnapshot && !(plugInIsPrimarySize(pluginImageElement, pluginArea) && !plugInIntersectsSearchRect(pluginImageElement)) ? PluginProcessTypeSnapshot : PluginProcessTypeNormal;
</span><span class="cx"> #else
</span></span></pre>
</div>
</div>
</body>
</html>