<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173871] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173871">173871</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-09-23 07:47:21 -0700 (Tue, 23 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
https://bugs.webkit.org/show_bug.cgi?id=137026
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-09-23
Reviewed by Csaba Osztrogonác.
* BuildSlaveSupport/wait-for-SVN-server.py:
(getLatestSVNRevision):
(waitForSVNRevision):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportwaitforSVNserverpy">trunk/Tools/BuildSlaveSupport/wait-for-SVN-server.py</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportwaitforSVNserverpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/wait-for-SVN-server.py (173870 => 173871)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/wait-for-SVN-server.py 2014-09-23 09:57:53 UTC (rev 173870)
+++ trunk/Tools/BuildSlaveSupport/wait-for-SVN-server.py 2014-09-23 14:47:21 UTC (rev 173871)
</span><span class="lines">@@ -28,9 +28,14 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> def getLatestSVNRevision(SVNServer):
</span><ins>+ p = subprocess.Popen(["svn", "log", "--non-interactive", "--verbose", "--xml", "--limit=1", SVNServer], stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
+ response = p.communicate()[0]
+ if p.returncode != 0:
+ print "Can't connect to host: %s, return code %s " % (SVNServer, p.returncode)
+ print "OUTPUT:"
+ print response
+ return -1
</ins><span class="cx"> try:
</span><del>- p = subprocess.Popen(["svn", "log", "--non-interactive", "--verbose", "--xml", "--limit=1", SVNServer], stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
- response = p.communicate()[0]
</del><span class="cx"> doc = xml.dom.minidom.parseString(response)
</span><span class="cx"> el = doc.getElementsByTagName("logentry")[0]
</span><span class="cx"> return el.getAttribute("revision")
</span><span class="lines">@@ -52,7 +57,10 @@
</span><span class="cx"> revision = int(revision)
</span><span class="cx"> while True:
</span><span class="cx"> latestRevision = int(getLatestSVNRevision(SVNServer))
</span><del>- if latestRevision < revision:
</del><ins>+ if latestRevision == -1:
+ print "%s SVN server is unreachable. Sleeping for 60 seconds." % (SVNServer)
+ time.sleep(60)
+ elif latestRevision < revision:
</ins><span class="cx"> print "Latest SVN revision on %s is r%d, but we are waiting for r%d. Sleeping for 5 seconds." % (SVNServer, latestRevision, revision)
</span><span class="cx"> time.sleep(5)
</span><span class="cx"> else:
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (173870 => 173871)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-09-23 09:57:53 UTC (rev 173870)
+++ trunk/Tools/ChangeLog 2014-09-23 14:47:21 UTC (rev 173871)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2014-09-23 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><ins>+ Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
+ https://bugs.webkit.org/show_bug.cgi?id=137026
+
+ Reviewed by Csaba Osztrogonác.
+
+ * BuildSlaveSupport/wait-for-SVN-server.py:
+ (getLatestSVNRevision):
+ (waitForSVNRevision):
+
+2014-09-23 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
+
</ins><span class="cx"> Remove unlinkZeroFiles from build-webkit
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=137018
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>