<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173892] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173892">173892</a></dd>
<dt>Author</dt> <dd>mark.lam@apple.com</dd>
<dt>Date</dt> <dd>2014-09-23 14:24:01 -0700 (Tue, 23 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Renamed DebuggerCallFrameScope to DebuggerPausedScope.
<https://webkit.org/b/137042>
Reviewed by Michael Saboff.
DebuggerPausedScope is a better name for this data structure because it
is meant for tracking the period within which the debugger is paused,
and doing clean ups after the pause ends.
* debugger/Debugger.cpp:
(JSC::DebuggerPausedScope::DebuggerPausedScope):
(JSC::DebuggerPausedScope::~DebuggerPausedScope):
(JSC::Debugger::pauseIfNeeded):
(JSC::DebuggerCallFrameScope::DebuggerCallFrameScope): Deleted.
(JSC::DebuggerCallFrameScope::~DebuggerCallFrameScope): Deleted.
* debugger/Debugger.h:
* debugger/DebuggerCallFrame.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredebuggerDebuggercpp">trunk/Source/JavaScriptCore/debugger/Debugger.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredebuggerDebuggerh">trunk/Source/JavaScriptCore/debugger/Debugger.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredebuggerDebuggerCallFrameh">trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (173891 => 173892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-09-23 21:21:17 UTC (rev 173891)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-09-23 21:24:01 UTC (rev 173892)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2014-09-23 Mark Lam <mark.lam@apple.com>
+
+ Renamed DebuggerCallFrameScope to DebuggerPausedScope.
+ <https://webkit.org/b/137042>
+
+ Reviewed by Michael Saboff.
+
+ DebuggerPausedScope is a better name for this data structure because it
+ is meant for tracking the period within which the debugger is paused,
+ and doing clean ups after the pause ends.
+
+ * debugger/Debugger.cpp:
+ (JSC::DebuggerPausedScope::DebuggerPausedScope):
+ (JSC::DebuggerPausedScope::~DebuggerPausedScope):
+ (JSC::Debugger::pauseIfNeeded):
+ (JSC::DebuggerCallFrameScope::DebuggerCallFrameScope): Deleted.
+ (JSC::DebuggerCallFrameScope::~DebuggerCallFrameScope): Deleted.
+ * debugger/Debugger.h:
+ * debugger/DebuggerCallFrame.h:
+
</ins><span class="cx"> 2014-09-23 Tomas Popela <tpopela@redhat.com>
</span><span class="cx">
</span><span class="cx"> [CLoop] - Fix CLoop on the 32-bit Big-Endians
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredebuggerDebuggercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/debugger/Debugger.cpp (173891 => 173892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/debugger/Debugger.cpp 2014-09-23 21:21:17 UTC (rev 173891)
+++ trunk/Source/JavaScriptCore/debugger/Debugger.cpp 2014-09-23 21:24:01 UTC (rev 173892)
</span><span class="lines">@@ -96,9 +96,9 @@
</span><span class="cx">
</span><span class="cx"> namespace JSC {
</span><span class="cx">
</span><del>-class DebuggerCallFrameScope {
</del><ins>+class DebuggerPausedScope {
</ins><span class="cx"> public:
</span><del>- DebuggerCallFrameScope(Debugger& debugger)
</del><ins>+ DebuggerPausedScope(Debugger& debugger)
</ins><span class="cx"> : m_debugger(debugger)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(!m_debugger.m_currentDebuggerCallFrame);
</span><span class="lines">@@ -106,7 +106,7 @@
</span><span class="cx"> m_debugger.m_currentDebuggerCallFrame = DebuggerCallFrame::create(debugger.m_currentCallFrame);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- ~DebuggerCallFrameScope()
</del><ins>+ ~DebuggerPausedScope()
</ins><span class="cx"> {
</span><span class="cx"> if (m_debugger.m_currentDebuggerCallFrame) {
</span><span class="cx"> m_debugger.m_currentDebuggerCallFrame->invalidate();
</span><span class="lines">@@ -644,7 +644,7 @@
</span><span class="cx"> bool pauseNow = m_pauseOnNextStatement;
</span><span class="cx"> pauseNow |= (m_pauseOnCallFrame == m_currentCallFrame);
</span><span class="cx">
</span><del>- DebuggerCallFrameScope debuggerCallFrameScope(*this);
</del><ins>+ DebuggerPausedScope debuggerPausedScope(*this);
</ins><span class="cx">
</span><span class="cx"> intptr_t sourceID = DebuggerCallFrame::sourceIDForCallFrame(m_currentCallFrame);
</span><span class="cx"> TextPosition position = DebuggerCallFrame::positionForCallFrame(m_currentCallFrame);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredebuggerDebuggerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/debugger/Debugger.h (173891 => 173892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/debugger/Debugger.h 2014-09-23 21:21:17 UTC (rev 173891)
+++ trunk/Source/JavaScriptCore/debugger/Debugger.h 2014-09-23 21:24:01 UTC (rev 173892)
</span><span class="lines">@@ -207,7 +207,7 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<JSC::DebuggerCallFrame> m_currentDebuggerCallFrame;
</span><span class="cx">
</span><del>- friend class DebuggerCallFrameScope;
</del><ins>+ friend class DebuggerPausedScope;
</ins><span class="cx"> friend class TemporaryPausedState;
</span><span class="cx"> friend class LLIntOffsetsExtractor;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredebuggerDebuggerCallFrameh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.h (173891 => 173892)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.h 2014-09-23 21:21:17 UTC (rev 173891)
+++ trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.h 2014-09-23 21:24:01 UTC (rev 173892)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx"> CallFrame* m_callFrame;
</span><span class="cx"> RefPtr<DebuggerCallFrame> m_caller;
</span><span class="cx"> TextPosition m_position;
</span><del>- // The DebuggerCallFrameScope is responsible for calling invalidate() which,
</del><ins>+ // The DebuggerPausedScope is responsible for calling invalidate() which,
</ins><span class="cx"> // in turn, will clear this strong ref.
</span><span class="cx"> Strong<DebuggerScope> m_scope;
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>