<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173654] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173654">173654</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-09-16 01:46:10 -0700 (Tue, 16 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GStreamer] http/tests/media/video-auth.html is failing
https://bugs.webkit.org/show_bug.cgi?id=126619
Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-09-16
Reviewed by Philippe Normand.
Source/WebCore:
Test: http/tests/media/video-auth-cors.html
Use stored credentials when retrieving videos following image loading behavior
(i.e. stored credentials are always used except when in cors anonymous mode),
except that requesting credentials from user remains disabled for cross-origin requests.
Patch is covered by http/tests/media/video-auth.html.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(CachedResourceStreamingClient::CachedResourceStreamingClient): Enable using stored credentials except when using cors anonymous mode.
LayoutTests:
* platform/efl/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
* platform/efl/http/tests/media/video-auth-expected.txt: Added.
* platform/gtk/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
* platform/gtk/http/tests/media/video-auth-expected.txt: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformeflTestExpectations">trunk/LayoutTests/platform/efl/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsgstreamerWebKitWebSourceGStreamercpp">trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformeflhttptestsmediavideoauthexpectedtxt">trunk/LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformgtkhttptestsmediavideoauthexpectedtxt">trunk/LayoutTests/platform/gtk/http/tests/media/video-auth-expected.txt</a></li>
</ul>
<h3>Property Changed</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (173653 => 173654)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-09-16 08:16:36 UTC (rev 173653)
+++ trunk/LayoutTests/ChangeLog 2014-09-16 08:46:10 UTC (rev 173654)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-09-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
+
+ [GStreamer] http/tests/media/video-auth.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=126619
+
+ Reviewed by Philippe Normand.
+
+ * platform/efl/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
+ * platform/efl/http/tests/media/video-auth-expected.txt: Added.
+ * platform/gtk/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
+ * platform/gtk/http/tests/media/video-auth-expected.txt: Added.
+
</ins><span class="cx"> 2014-09-16 Jinho Bang <jinho.bang@samsung.com>
</span><span class="cx">
</span><span class="cx"> Add version of drawFocusIfNeeded that take a Path2D parameter.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/TestExpectations (173653 => 173654)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/TestExpectations 2014-09-16 08:16:36 UTC (rev 173653)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2014-09-16 08:46:10 UTC (rev 173654)
</span><span class="lines">@@ -1821,8 +1821,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/127489 http/tests/misc/will-send-request-returns-null-on-redirect.html [ Failure ]
</span><span class="cx">
</span><del>-webkit.org/b/126619 http/tests/media/video-auth.html [ Failure ]
-
</del><span class="cx"> webkit.org/b/127725 media/video-restricted-no-preload-auto.html [ Failure ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/127731 plugins/embed-prefers-plugins-for-images.html [ Failure ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflhttptestsmediavideoauthexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt (0 => 173654)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt 2014-09-16 08:46:10 UTC (rev 173654)
</span><span class="lines">@@ -0,0 +1,6 @@
</span><ins>+didReceiveAuthenticationChallenge - Responding with username:password
+
+Tests that the media player sends authorization credentials when requesting a media file.
+EVENT(canplay)
+END OF TEST
+
</ins><span class="cx">Property changes on: trunk/LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnexecutable"></a>
<div class="addfile"><h4>Added: svn:executable</h4></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (173653 => 173654)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-09-16 08:16:36 UTC (rev 173653)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-09-16 08:46:10 UTC (rev 173654)
</span><span class="lines">@@ -1852,8 +1852,6 @@
</span><span class="cx">
</span><span class="cx"> webkit.org/b/125406 fast/regions/relative-in-absolute-borders-overflow.html [ ImageOnlyFailure ]
</span><span class="cx">
</span><del>-webkit.org/b/126619 http/tests/media/video-auth.html [ Failure ]
-
</del><span class="cx"> # Subpixel rendering: borders are reporting float values.
</span><span class="cx"> webkit.org/b/128061 fast/css/bidi-override-in-anonymous-block.html [ Failure ]
</span><span class="cx"> webkit.org/b/128061 fast/repaint/repaint-during-scroll-with-zoom.html [ Failure ]
</span><span class="cx">Property changes on: trunk/LayoutTests/platform/gtk/TestExpectations
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnexecutable"></a>
<div class="addfile"><h4>Added: svn:executable</h4></div>
<a id="trunkLayoutTestsplatformgtkhttptestsmediavideoauthexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/gtk/http/tests/media/video-auth-expected.txt (0 => 173654)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/http/tests/media/video-auth-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/http/tests/media/video-auth-expected.txt 2014-09-16 08:46:10 UTC (rev 173654)
</span><span class="lines">@@ -0,0 +1,6 @@
</span><ins>+didReceiveAuthenticationChallenge - Responding with username:password
+
+Tests that the media player sends authorization credentials when requesting a media file.
+EVENT(canplay)
+END OF TEST
+
</ins><span class="cx">Property changes on: trunk/LayoutTests/platform/gtk/http/tests/media/video-auth-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnexecutable"></a>
<div class="addfile"><h4>Added: svn:executable</h4></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (173653 => 173654)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-09-16 08:16:36 UTC (rev 173653)
+++ trunk/Source/WebCore/ChangeLog 2014-09-16 08:46:10 UTC (rev 173654)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-09-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
+
+ [GStreamer] http/tests/media/video-auth.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=126619
+
+ Reviewed by Philippe Normand.
+
+ Test: http/tests/media/video-auth-cors.html
+
+ Use stored credentials when retrieving videos following image loading behavior
+ (i.e. stored credentials are always used except when in cors anonymous mode),
+ except that requesting credentials from user remains disabled for cross-origin requests.
+
+ Patch is covered by http/tests/media/video-auth.html.
+
+ * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+ (CachedResourceStreamingClient::CachedResourceStreamingClient): Enable using stored credentials except when using cors anonymous mode.
+
</ins><span class="cx"> 2014-09-16 Jinho Bang <jinho.bang@samsung.com>
</span><span class="cx">
</span><span class="cx"> Add version of drawFocusIfNeeded that take a Path2D parameter.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsgstreamerWebKitWebSourceGStreamercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (173653 => 173654)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2014-09-16 08:16:36 UTC (rev 173653)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2014-09-16 08:46:10 UTC (rev 173654)
</span><span class="lines">@@ -996,7 +996,7 @@
</span><span class="cx"> {
</span><span class="cx"> DataBufferingPolicy bufferingPolicy = request.url().protocolIs("blob") ? BufferData : DoNotBufferData;
</span><span class="cx"> RequestOriginPolicy corsPolicy = corsMode != MediaPlayerClient::Unspecified ? PotentiallyCrossOriginEnabled : UseDefaultOriginRestrictionsForType;
</span><del>- StoredCredentials allowCredentials = corsMode == MediaPlayerClient::UseCredentials ? AllowStoredCredentials : DoNotAllowStoredCredentials;
</del><ins>+ StoredCredentials allowCredentials = corsMode == MediaPlayerClient::Anonymous ? DoNotAllowStoredCredentials : AllowStoredCredentials;
</ins><span class="cx"> ResourceLoaderOptions options(SendCallbacks, DoNotSniffContent, bufferingPolicy, allowCredentials, DoNotAskClientForCrossOriginCredentials, DoSecurityCheck, corsPolicy, DoNotIncludeCertificateInfo);
</span><span class="cx">
</span><span class="cx"> CachedResourceRequest cacheRequest(request, options);
</span></span></pre>
</div>
</div>
</body>
</html>