<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173638] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173638">173638</a></dd>
<dt>Author</dt> <dd>jhoneycutt@apple.com</dd>
<dt>Date</dt> <dd>2014-09-15 16:15:00 -0700 (Mon, 15 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Naming clean-up.
Rubber-stamped by Andy Estes.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::requestAutocomplete):
(WebCore::HTMLFormElement::finishRequestAutocomplete):
Remove superfluous "AutocompleteResult".
* html/HTMLFormElement.h:
Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormElementcpp">trunk/Source/WebCore/html/HTMLFormElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormElementh">trunk/Source/WebCore/html/HTMLFormElement.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (173637 => 173638)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-09-15 23:13:52 UTC (rev 173637)
+++ trunk/Source/WebCore/ChangeLog 2014-09-15 23:15:00 UTC (rev 173638)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-09-15 Jon Honeycutt <jhoneycutt@apple.com>
+
+ Naming clean-up.
+
+ Rubber-stamped by Andy Estes.
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::requestAutocomplete):
+ (WebCore::HTMLFormElement::finishRequestAutocomplete):
+ Remove superfluous "AutocompleteResult".
+
+ * html/HTMLFormElement.h:
+ Ditto.
+
</ins><span class="cx"> 2014-09-15 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Crash when logging in to optionshouse.com
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (173637 => 173638)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormElement.cpp 2014-09-15 23:13:52 UTC (rev 173637)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp 2014-09-15 23:15:00 UTC (rev 173638)
</span><span class="lines">@@ -435,7 +435,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if (!shouldAutocomplete() || !ScriptController::processingUserGesture()) {
</span><del>- finishRequestAutocomplete(AutocompleteResult::AutocompleteResultErrorDisabled);
</del><ins>+ finishRequestAutocomplete(AutocompleteResult::ErrorDisabled);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -450,16 +450,16 @@
</span><span class="cx"> {
</span><span class="cx"> RefPtr<Event> event;
</span><span class="cx"> switch (result) {
</span><del>- case AutocompleteResult::AutocompleteResultSuccess:
</del><ins>+ case AutocompleteResult::Success:
</ins><span class="cx"> event = Event::create(eventNames().autocompleteEvent, false, false);
</span><span class="cx"> break;
</span><del>- case AutocompleteResult::AutocompleteResultErrorDisabled:
</del><ins>+ case AutocompleteResult::ErrorDisabled:
</ins><span class="cx"> event = AutocompleteErrorEvent::create("disabled");
</span><span class="cx"> break;
</span><del>- case AutocompleteResult::AutocompleteResultErrorCancel:
</del><ins>+ case AutocompleteResult::ErrorCancel:
</ins><span class="cx"> event = AutocompleteErrorEvent::create("cancel");
</span><span class="cx"> break;
</span><del>- case AutocompleteResult::AutocompleteResultErrorInvalid:
</del><ins>+ case AutocompleteResult::ErrorInvalid:
</ins><span class="cx"> event = AutocompleteErrorEvent::create("invalid");
</span><span class="cx"> break;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormElement.h (173637 => 173638)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormElement.h 2014-09-15 23:13:52 UTC (rev 173637)
+++ trunk/Source/WebCore/html/HTMLFormElement.h 2014-09-15 23:15:00 UTC (rev 173638)
</span><span class="lines">@@ -114,10 +114,10 @@
</span><span class="cx">
</span><span class="cx"> #if ENABLE(REQUEST_AUTOCOMPLETE)
</span><span class="cx"> enum class AutocompleteResult {
</span><del>- AutocompleteResultSuccess,
- AutocompleteResultErrorDisabled,
- AutocompleteResultErrorCancel,
- AutocompleteResultErrorInvalid,
</del><ins>+ Success,
+ ErrorDisabled,
+ ErrorCancel,
+ ErrorInvalid,
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> void requestAutocomplete();
</span></span></pre>
</div>
</div>
</body>
</html>