<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173613] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173613">173613</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2014-09-14 22:40:56 -0700 (Sun, 14 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix post-mortem nits for <a href="http://trac.webkit.org/projects/webkit/changeset/173528">r173528</a> & <a href="http://trac.webkit.org/projects/webkit/changeset/173549">r173549</a>
https://bugs.webkit.org/show_bug.cgi?id=136808
Reviewed by Darin Adler.
Fix post-mortem nits for <a href="http://trac.webkit.org/projects/webkit/changeset/173528">r173528</a> & <a href="http://trac.webkit.org/projects/webkit/changeset/173549">r173549</a>.
No new tests, no behavior change.
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::alternativeTextForWebArea):
- Use auto* instead of more specific types.
- Use fastGetAttribute() instead of getAttribute() as this is
supported for the "title" attribute.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelectionFromNone):
Use auto* instead of more specific types.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingFrameSelectioncpp">trunk/Source/WebCore/editing/FrameSelection.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (173612 => 173613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-09-15 04:29:26 UTC (rev 173612)
+++ trunk/Source/WebCore/ChangeLog 2014-09-15 05:40:56 UTC (rev 173613)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-09-14 Christophe Dumez <cdumez@apple.com>
+
+ Fix post-mortem nits for r173528 & r173549
+ https://bugs.webkit.org/show_bug.cgi?id=136808
+
+ Reviewed by Darin Adler.
+
+ Fix post-mortem nits for r173528 & r173549.
+
+ No new tests, no behavior change.
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::alternativeTextForWebArea):
+ - Use auto* instead of more specific types.
+ - Use fastGetAttribute() instead of getAttribute() as this is
+ supported for the "title" attribute.
+
+ * editing/FrameSelection.cpp:
+ (WebCore::FrameSelection::setSelectionFromNone):
+ Use auto* instead of more specific types.
+
</ins><span class="cx"> 2014-09-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>
</span><span class="cx">
</span><span class="cx"> Introduce FONT_DATA_TYPE_CASTS, and use it
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (173612 => 173613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-09-15 04:29:26 UTC (rev 173612)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-09-15 05:40:56 UTC (rev 173613)
</span><span class="lines">@@ -1461,9 +1461,9 @@
</span><span class="cx"> return ariaLabel;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (HTMLFrameOwnerElement* owner = document->ownerElement()) {
</del><ins>+ if (auto* owner = document->ownerElement()) {
</ins><span class="cx"> if (owner->hasTagName(frameTag) || owner->hasTagName(iframeTag)) {
</span><del>- const AtomicString& title = owner->getAttribute(titleAttr);
</del><ins>+ const AtomicString& title = owner->fastGetAttribute(titleAttr);
</ins><span class="cx"> if (!title.isEmpty())
</span><span class="cx"> return title;
</span><span class="cx"> }
</span><span class="lines">@@ -1474,7 +1474,7 @@
</span><span class="cx"> if (!documentTitle.isEmpty())
</span><span class="cx"> return documentTitle;
</span><span class="cx">
</span><del>- if (HTMLElement* body = document->body())
</del><ins>+ if (auto* body = document->body())
</ins><span class="cx"> return body->getNameAttribute();
</span><span class="cx">
</span><span class="cx"> return String();
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingFrameSelectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (173612 => 173613)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/FrameSelection.cpp 2014-09-15 04:29:26 UTC (rev 173612)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2014-09-15 05:40:56 UTC (rev 173613)
</span><span class="lines">@@ -2112,7 +2112,7 @@
</span><span class="cx"> return;
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- Element* documentElement = document->documentElement();
</del><ins>+ auto* documentElement = document->documentElement();
</ins><span class="cx"> if (!documentElement)
</span><span class="cx"> return;
</span><span class="cx"> if (auto body = childrenOfType<HTMLBodyElement>(*documentElement).first())
</span></span></pre>
</div>
</div>
</body>
</html>