<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173594] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173594">173594</a></dd>
<dt>Author</dt> <dd>burg@cs.washington.edu</dd>
<dt>Date</dt> <dd>2014-09-12 17:35:19 -0700 (Fri, 12 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: remind about rebaselining generator test results
https://bugs.webkit.org/show_bug.cgi?id=136759
Reviewed by Joseph Pecoraro.
For now, we can implement this as a watchlist message. Add watchlist
groups and messages for the inspector and web replay generators.
* Scripts/webkitpy/common/config/watchlist:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpycommonconfigwatchlist">trunk/Tools/Scripts/webkitpy/common/config/watchlist</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (173593 => 173594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-09-13 00:24:53 UTC (rev 173593)
+++ trunk/Tools/ChangeLog 2014-09-13 00:35:19 UTC (rev 173594)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-09-12 Brian J. Burg <burg@cs.washington.edu>
+
+ Web Inspector: remind about rebaselining generator test results
+ https://bugs.webkit.org/show_bug.cgi?id=136759
+
+ Reviewed by Joseph Pecoraro.
+
+ For now, we can implement this as a watchlist message. Add watchlist
+ groups and messages for the inspector and web replay generators.
+
+ * Scripts/webkitpy/common/config/watchlist:
+
</ins><span class="cx"> 2014-09-12 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> build.webkit.org/dashboard: Overlapping text when status is long
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpycommonconfigwatchlist"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (173593 => 173594)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2014-09-13 00:24:53 UTC (rev 173593)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2014-09-13 00:35:19 UTC (rev 173594)
</span><span class="lines">@@ -199,6 +199,15 @@
</span><span class="cx"> r"|Source/WebCore/inspector/.+\.idl"
</span><span class="cx"> r"|Source/WebCore/page/Console.idl",
</span><span class="cx"> },
</span><ins>+ "WebInspectorGenerator": {
+ "filename": r"Source/JavaScriptCore/inspector/scripts/codegen"
+ r"|Tools/Scripts/generate-inspector-protocol-bindings.py"
+ r"|Tools/Scripts/webkitpy/inspector",
+ },
+ "WebReplayGenerator": {
+ "filename": r"Source/JavaScriptCore/replay/scripts",
+ r"|Tools/Scripts/webkitpy/replay",
+ },
</ins><span class="cx"> "WebSocket": {
</span><span class="cx"> "filename": r"Source/WebCore/Modules/websockets"
</span><span class="cx"> r"|Source/WebCore/platform/network/(|.+/)SocketStream.*",
</span><span class="lines">@@ -366,6 +375,8 @@
</span><span class="cx"> "WebGL": [ "dino@apple.com", "kondapallykalyan@gmail.com" , "roger_fong@apple.com" ],
</span><span class="cx"> "WebIDL": [ "esprehn+autocc@chromium.org", "dchris@gmail.com", "kondapallykalyan@gmail.com" ],
</span><span class="cx"> "WebInspectorAPI": [ "timothy@apple.com", "joepeck@webkit.org", "graouts@webkit.org" ],
</span><ins>+ "WebInspectorGenerator": [ "burg@cs.washington.edu", "joepeck@webkit.org" ],
+ "WebReplayGenerator": [ "burg@cs.washington.edu" ],
</ins><span class="cx"> "WebKitGTKTranslations": [ "gns@gnome.org", "mrobinson@webkit.org" ],
</span><span class="cx"> "WebSocket": [ "yutak@chromium.org", "toyoshim+watchlist@chromium.org" ],
</span><span class="cx"> "XSS": [ "dbates@webkit.org" ],
</span><span class="lines">@@ -382,5 +393,7 @@
</span><span class="cx"> "See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API", ],
</span><span class="cx"> "ANGLE": [ "Note that there are important steps to take when updating ANGLE. "
</span><span class="cx"> "See http://trac.webkit.org/wiki/UpdatingANGLE", ],
</span><ins>+ "WebInspectorGenerator": [ "This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)" ],
+ "WebReplayGenerator": [ "This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`)" ],
</ins><span class="cx"> },
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>