<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173531] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173531">173531</a></dd>
<dt>Author</dt> <dd>betravis@adobe.com</dd>
<dt>Date</dt> <dd>2014-09-11 12:37:29 -0700 (Thu, 11 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Font Loading] Enable CSS Font Loading on Mac
https://bugs.webkit.org/show_bug.cgi?id=135473
Reviewed by Antti Koivisto.
Source/JavaScriptCore:
Enable CSS Font Loading in FeatureDefines.
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Enable CSS Font Loading in FeatureDefines, and in
RuntimeEnabledFeatures.
Font Loading tests have been toggled back on in the Mac
TestExpectations file.
* Configurations/FeatureDefines.xcconfig:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
Source/WebKit/mac:
Enable CSS Font Loading in FeatureDefines.
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Enable CSS Font Loading in FeatureDefines.
* Configurations/FeatureDefines.xcconfig:
LayoutTests:
Enable tests on the Mac platform. As more platforms
are added, this should move from the tests defaulting
to disabled to the tests defaulting to enabled.
* platform/mac/TestExpectations: Mark the Font Loading
tests as enabled.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreConfigurationsFeatureDefinesxcconfig">trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreConfigurationsFeatureDefinesxcconfig">trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig</a></li>
<li><a href="#trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturescpp">trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacConfigurationsFeatureDefinesxcconfig">trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2ConfigurationsFeatureDefinesxcconfig">trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (173530 => 173531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/LayoutTests/ChangeLog 2014-09-11 19:37:29 UTC (rev 173531)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-09-11 Bear Travis <betravis@adobe.com>
+
+ [CSS Font Loading] Enable CSS Font Loading on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=135473
+
+ Reviewed by Antti Koivisto.
+
+ Enable tests on the Mac platform. As more platforms
+ are added, this should move from the tests defaulting
+ to disabled to the tests defaulting to enabled.
+
+ * platform/mac/TestExpectations: Mark the Font Loading
+ tests as enabled.
+
</ins><span class="cx"> 2014-09-11 Roger Fong <roger_fong@apple.com>
</span><span class="cx">
</span><span class="cx"> Temporary change to determine why some snapshotting tests are failing only on bots.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (173530 => 173531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2014-09-11 19:37:29 UTC (rev 173531)
</span><span class="lines">@@ -1374,6 +1374,16 @@
</span><span class="cx"> webkit.org/b/121995 media/video-controls-captions-trackmenu-hide-on-click.html [ Timeout Failure ]
</span><span class="cx"> webkit.org/b/121995 media/video-controls-captions-trackmenu-includes-enabled-track.html [ Timeout Failure ]
</span><span class="cx">
</span><ins>+# CSS Font Loading is only enabled on Mac, and tests are not run by default
+webkit.org/b/135390 fast/css/fontloader-download-error.html [ Pass ]
+webkit.org/b/135390 fast/css/fontloader-events.html [ Pass ]
+webkit.org/b/135390 fast/css/fontloader-loadingdone.html [ Pass ]
+webkit.org/b/135390 fast/css/fontloader-multiple-faces-download-error.html [ Pass ]
+webkit.org/b/135390 fast/css/fontloader-multiple-faces.html [ Pass ]
+webkit.org/b/135390 fast/css/fontloader-multiple-families.html [ Pass ]
+webkit.org/b/135390 fast/css/fontloader-page-cache.html [ Pass ]
+webkit.org/b/135390 http/tests/webfont/fontloader-loading-attribute.html [ Pass ]
+
</ins><span class="cx"> # REGRESSION(r156546): 7 media tests broken (122021)
</span><span class="cx"> webkit.org/b/122021 media/track/track-cue-mutable-text.html
</span><span class="cx"> webkit.org/b/122021 media/track/track-cue-rendering-mode-changed.html
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (173530 => 173531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-09-11 19:37:29 UTC (rev 173531)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-09-11 Bear Travis <betravis@adobe.com>
+
+ [CSS Font Loading] Enable CSS Font Loading on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=135473
+
+ Reviewed by Antti Koivisto.
+
+ Enable CSS Font Loading in FeatureDefines.
+
+ * Configurations/FeatureDefines.xcconfig:
+
</ins><span class="cx"> 2014-09-11 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed rebaseline of inspector generator test results after r173120.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreConfigurationsFeatureDefinesxcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig (173530 => 173531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig 2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig 2014-09-11 19:37:29 UTC (rev 173531)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx"> ENABLE_ENCRYPTED_MEDIA_V2_macosx_1080 = ;
</span><span class="cx"> ENABLE_ENCRYPTED_MEDIA_V2_macosx_1090 = ENABLE_ENCRYPTED_MEDIA_V2;
</span><span class="cx"> ENABLE_ENCRYPTED_MEDIA_V2_macosx_101000 = ENABLE_ENCRYPTED_MEDIA_V2;
</span><del>-ENABLE_FONT_LOAD_EVENTS = ;
</del><ins>+ENABLE_FONT_LOAD_EVENTS = ENABLE_FONT_LOAD_EVENTS;
</ins><span class="cx"> ENABLE_FULLSCREEN_API = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
</span><span class="cx"> ENABLE_FULLSCREEN_API_macosx = ENABLE_FULLSCREEN_API;
</span><span class="cx"> ENABLE_GAMEPAD = $(ENABLE_GAMEPAD_$(PLATFORM_NAME));
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (173530 => 173531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebCore/ChangeLog 2014-09-11 19:37:29 UTC (rev 173531)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-09-11 Bear Travis <betravis@adobe.com>
+
+ [CSS Font Loading] Enable CSS Font Loading on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=135473
+
+ Reviewed by Antti Koivisto.
+
+ Enable CSS Font Loading in FeatureDefines, and in
+ RuntimeEnabledFeatures.
+
+ Font Loading tests have been toggled back on in the Mac
+ TestExpectations file.
+
+ * Configurations/FeatureDefines.xcconfig:
+ * bindings/generic/RuntimeEnabledFeatures.cpp:
+ (WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
+
</ins><span class="cx"> 2014-09-11 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Use tighter typing for Document::ownerElement() return value
</span></span></pre></div>
<a id="trunkSourceWebCoreConfigurationsFeatureDefinesxcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (173530 => 173531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2014-09-11 19:37:29 UTC (rev 173531)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx"> ENABLE_ENCRYPTED_MEDIA_V2_macosx_1080 = ;
</span><span class="cx"> ENABLE_ENCRYPTED_MEDIA_V2_macosx_1090 = ENABLE_ENCRYPTED_MEDIA_V2;
</span><span class="cx"> ENABLE_ENCRYPTED_MEDIA_V2_macosx_101000 = ENABLE_ENCRYPTED_MEDIA_V2;
</span><del>-ENABLE_FONT_LOAD_EVENTS = ;
</del><ins>+ENABLE_FONT_LOAD_EVENTS = ENABLE_FONT_LOAD_EVENTS;
</ins><span class="cx"> ENABLE_FULLSCREEN_API = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
</span><span class="cx"> ENABLE_FULLSCREEN_API_macosx = ENABLE_FULLSCREEN_API;
</span><span class="cx"> ENABLE_GAMEPAD = $(ENABLE_GAMEPAD_$(PLATFORM_NAME));
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (173530 => 173531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2014-09-11 19:37:29 UTC (rev 173531)
</span><span class="lines">@@ -95,7 +95,7 @@
</span><span class="cx"> , m_areExperimentalContentSecurityPolicyFeaturesEnabled(false)
</span><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(FONT_LOAD_EVENTS)
</span><del>- , m_isFontLoadEventsEnabled(false)
</del><ins>+ , m_isFontLoadEventsEnabled(true)
</ins><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(GAMEPAD)
</span><span class="cx"> , m_areGamepadsEnabled(false)
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (173530 => 173531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-09-11 19:37:29 UTC (rev 173531)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-09-11 Bear Travis <betravis@adobe.com>
+
+ [CSS Font Loading] Enable CSS Font Loading on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=135473
+
+ Reviewed by Antti Koivisto.
+
+ Enable CSS Font Loading in FeatureDefines.
+
+ * Configurations/FeatureDefines.xcconfig:
+
</ins><span class="cx"> 2014-09-11 Beth Dakin <bdakin@apple.com>
</span><span class="cx">
</span><span class="cx"> Support rubber-banding in sub-frames
</span></span></pre></div>
<a id="trunkSourceWebKitmacConfigurationsFeatureDefinesxcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig (173530 => 173531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig 2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig 2014-09-11 19:37:29 UTC (rev 173531)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx"> ENABLE_ENCRYPTED_MEDIA_V2_macosx_1080 = ;
</span><span class="cx"> ENABLE_ENCRYPTED_MEDIA_V2_macosx_1090 = ENABLE_ENCRYPTED_MEDIA_V2;
</span><span class="cx"> ENABLE_ENCRYPTED_MEDIA_V2_macosx_101000 = ENABLE_ENCRYPTED_MEDIA_V2;
</span><del>-ENABLE_FONT_LOAD_EVENTS = ;
</del><ins>+ENABLE_FONT_LOAD_EVENTS = ENABLE_FONT_LOAD_EVENTS;
</ins><span class="cx"> ENABLE_FULLSCREEN_API = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
</span><span class="cx"> ENABLE_FULLSCREEN_API_macosx = ENABLE_FULLSCREEN_API;
</span><span class="cx"> ENABLE_GAMEPAD = $(ENABLE_GAMEPAD_$(PLATFORM_NAME));
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (173530 => 173531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebKit2/ChangeLog 2014-09-11 19:37:29 UTC (rev 173531)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-09-11 Bear Travis <betravis@adobe.com>
+
+ [CSS Font Loading] Enable CSS Font Loading on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=135473
+
+ Reviewed by Antti Koivisto.
+
+ Enable CSS Font Loading in FeatureDefines.
+
+ * Configurations/FeatureDefines.xcconfig:
+
</ins><span class="cx"> 2014-09-11 Youenn Fablet <youenn.fablet@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> [WK2] Authentication dialog is displayed for cross-origin XHR
</span></span></pre></div>
<a id="trunkSourceWebKit2ConfigurationsFeatureDefinesxcconfig"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig (173530 => 173531)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig 2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig 2014-09-11 19:37:29 UTC (rev 173531)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx"> ENABLE_ENCRYPTED_MEDIA_V2_macosx_1080 = ;
</span><span class="cx"> ENABLE_ENCRYPTED_MEDIA_V2_macosx_1090 = ENABLE_ENCRYPTED_MEDIA_V2;
</span><span class="cx"> ENABLE_ENCRYPTED_MEDIA_V2_macosx_101000 = ENABLE_ENCRYPTED_MEDIA_V2;
</span><del>-ENABLE_FONT_LOAD_EVENTS = ;
</del><ins>+ENABLE_FONT_LOAD_EVENTS = ENABLE_FONT_LOAD_EVENTS;
</ins><span class="cx"> ENABLE_FULLSCREEN_API = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
</span><span class="cx"> ENABLE_FULLSCREEN_API_macosx = ENABLE_FULLSCREEN_API;
</span><span class="cx"> ENABLE_GAMEPAD = $(ENABLE_GAMEPAD_$(PLATFORM_NAME));
</span></span></pre>
</div>
</div>
</body>
</html>