<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173494] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173494">173494</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-09-10 15:41:20 -0700 (Wed, 10 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Eliminate typeof "undefined" checks
https://bugs.webkit.org/show_bug.cgi?id=136691
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-09-10
Reviewed by Alexey Proskuryakov.
* UserInterface/Base/Main.js:
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyStringAsFragment):
* UserInterface/Protocol/InspectorBackend.js:
(InspectorBackend.Command.prototype._invokeWithArguments):
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.get resizeMethod):
* UserInterface/Views/NavigationBar.js:
(WebInspector.NavigationBar.prototype.get minimumWidth):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseMainjs">trunk/Source/WebInspectorUI/UserInterface/Base/Main.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceProtocolInspectorBackendjs">trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDataGridjs">trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsNavigationBarjs">trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (173493 => 173494)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-09-10 22:22:50 UTC (rev 173493)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-09-10 22:41:20 UTC (rev 173494)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2014-09-10 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Eliminate typeof "undefined" checks
+ https://bugs.webkit.org/show_bug.cgi?id=136691
+
+ Reviewed by Alexey Proskuryakov.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector.linkifyURLAsNode):
+ (WebInspector.linkifyStringAsFragment):
+ * UserInterface/Protocol/InspectorBackend.js:
+ (InspectorBackend.Command.prototype._invokeWithArguments):
+ * UserInterface/Views/DataGrid.js:
+ (WebInspector.DataGrid.prototype.get resizeMethod):
+ * UserInterface/Views/NavigationBar.js:
+ (WebInspector.NavigationBar.prototype.get minimumWidth):
+
+2014-09-10 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Fix obscure ESLint warnings and skip directories
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=136686
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseMainjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (173493 => 173494)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2014-09-10 22:22:50 UTC (rev 173493)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2014-09-10 22:41:20 UTC (rev 173494)
</span><span class="lines">@@ -1626,7 +1626,7 @@
</span><span class="cx"> a.href = url;
</span><span class="cx"> a.className = classes;
</span><span class="cx">
</span><del>- if (typeof tooltipText === "undefined")
</del><ins>+ if (tooltipText === undefined)
</ins><span class="cx"> a.title = url;
</span><span class="cx"> else if (typeof tooltipText !== "string" || tooltipText.length)
</span><span class="cx"> a.title = tooltipText;
</span><span class="lines">@@ -1675,7 +1675,7 @@
</span><span class="cx"> function linkifier(title, url, lineNumber)
</span><span class="cx"> {
</span><span class="cx"> var urlNode = WebInspector.linkifyURLAsNode(url, title, undefined);
</span><del>- if (typeof(lineNumber) !== "undefined")
</del><ins>+ if (lineNumber !== undefined)
</ins><span class="cx"> urlNode.lineNumber = lineNumber;
</span><span class="cx">
</span><span class="cx"> return urlNode;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceProtocolInspectorBackendjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js (173493 => 173494)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js 2014-09-10 22:22:50 UTC (rev 173493)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js 2014-09-10 22:41:20 UTC (rev 173494)
</span><span class="lines">@@ -430,7 +430,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var value = commandArguments.shift();
</span><del>- if (optionalFlag && typeof value === "undefined")
</del><ins>+ if (optionalFlag && value === undefined)
</ins><span class="cx"> continue;
</span><span class="cx">
</span><span class="cx"> if (typeof value !== typeName) {
</span><span class="lines">@@ -442,7 +442,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (commandArguments.length === 1 && !callback) {
</span><del>- if (typeof commandArguments[0] !== "undefined") {
</del><ins>+ if (commandArguments[0] !== undefined) {
</ins><span class="cx"> console.error("Protocol Error: Optional callback argument for method '" + instance.qualifiedName + "' call must be a function but its type is '" + typeof args[0] + "'.");
</span><span class="cx"> return;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDataGridjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (173493 => 173494)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2014-09-10 22:22:50 UTC (rev 173493)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2014-09-10 22:41:20 UTC (rev 173494)
</span><span class="lines">@@ -414,7 +414,7 @@
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> insertColumn: function(columnIdentifier, columnData, insertionIndex) {
</span><del>- if (typeof insertionIndex === "undefined")
</del><ins>+ if (insertionIndex === undefined)
</ins><span class="cx"> insertionIndex = this.orderedColumns.length;
</span><span class="cx"> insertionIndex = Number.constrain(insertionIndex, 0, this.orderedColumns.length);
</span><span class="cx">
</span><span class="lines">@@ -1217,7 +1217,7 @@
</span><span class="cx">
</span><span class="cx"> get resizeMethod()
</span><span class="cx"> {
</span><del>- if (typeof this._resizeMethod === "undefined")
</del><ins>+ if (!this._resizeMethod)
</ins><span class="cx"> return WebInspector.DataGrid.ResizeMethod.Nearest;
</span><span class="cx"> return this._resizeMethod;
</span><span class="cx"> },
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsNavigationBarjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js (173493 => 173494)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js 2014-09-10 22:22:50 UTC (rev 173493)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js 2014-09-10 22:41:20 UTC (rev 173494)
</span><span class="lines">@@ -233,7 +233,7 @@
</span><span class="cx">
</span><span class="cx"> get minimumWidth()
</span><span class="cx"> {
</span><del>- if (typeof this._minimumWidth === "undefined" || this._minimumWidthNeedsRecalculation) {
</del><ins>+ if (this._minimumWidth === undefined || this._minimumWidthNeedsRecalculation) {
</ins><span class="cx"> this._minimumWidth = this._calculateMinimumWidth();
</span><span class="cx"> delete this._minimumWidthNeedsRecalculation;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>