<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173477] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173477">173477</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-09-10 12:15:28 -0700 (Wed, 10 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Fix ESLint consistent-return warnings
https://bugs.webkit.org/show_bug.cgi?id=136682
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-09-10
Reviewed by Timothy Hatcher.
* .eslintrc:
* UserInterface/Controllers/BranchManager.js:
(WebInspector.BranchManager.prototype.createBranch):
* UserInterface/Controllers/FrameResourceManager.js:
(WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
* UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
* UserInterface/Views/BoxModelDetailsSectionRow.js:
(WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.showChild):
(WebInspector.DOMTreeElement.prototype._startEditingTarget):
(WebInspector.DOMTreeElement.prototype._startEditing):
* UserInterface/Views/EditingSupport.js:
* UserInterface/Views/EventListenerSectionGroup.js:
(WebInspector.EventListenerSectionGroup.prototype._nodeTextOrLink):
* UserInterface/Views/FrameContentView.js:
(WebInspector.FrameContentView.prototype._showContentViewForIdentifier):
* UserInterface/Views/NavigationBar.js:
(WebInspector.NavigationBar.prototype.insertNavigationItem):
(WebInspector.NavigationBar.prototype.removeNavigationItem):
* UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
* UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype.addSidebarPanel):
(WebInspector.Sidebar.prototype.removeSidebarPanel):
* UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.prototype.addStyleClassToLine):
(WebInspector.TextEditor.prototype.removeStyleClassFromLine):
(WebInspector.TextEditor.prototype.toggleStyleClassForLine):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIeslintrc">trunk/Source/WebInspectorUI/.eslintrc</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceControllersBranchManagerjs">trunk/Source/WebInspectorUI/UserInterface/Controllers/BranchManager.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceControllersFrameResourceManagerjs">trunk/Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsDOMNodeStylesjs">trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsBoxModelDetailsSectionRowjs">trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsEditingSupportjs">trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsEventListenerSectionGroupjs">trunk/Source/WebInspectorUI/UserInterface/Views/EventListenerSectionGroup.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsFrameContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/FrameContentView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsNavigationBarjs">trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsQuickConsolejs">trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsSidebarjs">trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTextEditorjs">trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIeslintrc"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/.eslintrc (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/.eslintrc 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/.eslintrc 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -58,6 +58,7 @@
</span><span class="cx"> "rules": {
</span><span class="cx"> "eqeqeq": 2,
</span><span class="cx"> "curly": 0,
</span><ins>+ "consistent-return": 2,
</ins><span class="cx"> "no-extra-semi": 2,
</span><span class="cx"> "quotes": [2, "double"],
</span><span class="cx"> "no-trailing-spaces": 2,
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -1,5 +1,43 @@
</span><span class="cx"> 2014-09-10 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Fix ESLint consistent-return warnings
+ https://bugs.webkit.org/show_bug.cgi?id=136682
+
+ Reviewed by Timothy Hatcher.
+
+ * .eslintrc:
+ * UserInterface/Controllers/BranchManager.js:
+ (WebInspector.BranchManager.prototype.createBranch):
+ * UserInterface/Controllers/FrameResourceManager.js:
+ (WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
+ * UserInterface/Models/DOMNodeStyles.js:
+ (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
+ * UserInterface/Views/BoxModelDetailsSectionRow.js:
+ (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
+ * UserInterface/Views/DOMTreeElement.js:
+ (WebInspector.DOMTreeElement.prototype.showChild):
+ (WebInspector.DOMTreeElement.prototype._startEditingTarget):
+ (WebInspector.DOMTreeElement.prototype._startEditing):
+ * UserInterface/Views/EditingSupport.js:
+ * UserInterface/Views/EventListenerSectionGroup.js:
+ (WebInspector.EventListenerSectionGroup.prototype._nodeTextOrLink):
+ * UserInterface/Views/FrameContentView.js:
+ (WebInspector.FrameContentView.prototype._showContentViewForIdentifier):
+ * UserInterface/Views/NavigationBar.js:
+ (WebInspector.NavigationBar.prototype.insertNavigationItem):
+ (WebInspector.NavigationBar.prototype.removeNavigationItem):
+ * UserInterface/Views/QuickConsole.js:
+ (WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
+ * UserInterface/Views/Sidebar.js:
+ (WebInspector.Sidebar.prototype.addSidebarPanel):
+ (WebInspector.Sidebar.prototype.removeSidebarPanel):
+ * UserInterface/Views/TextEditor.js:
+ (WebInspector.TextEditor.prototype.addStyleClassToLine):
+ (WebInspector.TextEditor.prototype.removeStyleClassFromLine):
+ (WebInspector.TextEditor.prototype.toggleStyleClassForLine):
+
+2014-09-10 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Fix ESLint no-undef warnings
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=136660
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceControllersBranchManagerjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/BranchManager.js (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Controllers/BranchManager.js 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/BranchManager.js 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx">
</span><span class="cx"> console.assert(fromBranch instanceof WebInspector.Branch);
</span><span class="cx"> if (!(fromBranch instanceof WebInspector.Branch))
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx">
</span><span class="cx"> var newBranch = fromBranch.fork(displayName);
</span><span class="cx"> this._branches.push(newBranch);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceControllersFrameResourceManagerjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -385,8 +385,6 @@
</span><span class="cx"> _addNewResourceToFrame: function(requestIdentifier, frameIdentifier, loaderIdentifier, url, type, requestMethod, requestHeaders, requestData, timestamp, frameName, frameSecurityOrigin, initiatorSourceCodeLocation)
</span><span class="cx"> {
</span><span class="cx"> console.assert(!this._waitingForMainFrameResourceTreePayload);
</span><del>- if (this._waitingForMainFrameResourceTreePayload)
- return;
</del><span class="cx">
</span><span class="cx"> var resource = null;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsDOMNodeStylesjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -665,7 +665,7 @@
</span><span class="cx"> this._parseStyleDeclarationPayload(payload, styleDeclaration.node, styleDeclaration.inherited, styleDeclaration.type, styleDeclaration.ownerRule);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!styleDeclaration) {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsBoxModelDetailsSectionRowjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -378,8 +378,11 @@
</span><span class="cx">
</span><span class="cx"> _applyUserInput: function(element, userInput, previousContent, context, commitEditor)
</span><span class="cx"> {
</span><del>- if (commitEditor && userInput === previousContent)
- return this._editingCancelled(element, context); // nothing changed, so cancel
</del><ins>+ if (commitEditor && userInput === previousContent) {
+ // Nothing changed, so cancel.
+ this._editingCancelled(element, context);
+ return;
+ }
</ins><span class="cx">
</span><span class="cx"> if (context.box !== "position" && (!userInput || userInput === "\u2012"))
</span><span class="cx"> userInput = "0px";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -167,8 +167,9 @@
</span><span class="cx">
</span><span class="cx"> showChild: function(index)
</span><span class="cx"> {
</span><ins>+ console.assert(!this._elementCloseTag);
</ins><span class="cx"> if (this._elementCloseTag)
</span><del>- return;
</del><ins>+ return false;
</ins><span class="cx">
</span><span class="cx"> if (index >= this.expandedChildrenLimit) {
</span><span class="cx"> this._expandedChildrenLimit = index + 1;
</span><span class="lines">@@ -537,7 +538,7 @@
</span><span class="cx"> _startEditingTarget: function(eventTarget)
</span><span class="cx"> {
</span><span class="cx"> if (this.treeOutline.selectedDOMNode() !== this.representedObject)
</span><del>- return;
</del><ins>+ return false;
</ins><span class="cx">
</span><span class="cx"> if (this.representedObject.nodeType() !== Node.ELEMENT_NODE && this.representedObject.nodeType() !== Node.TEXT_NODE)
</span><span class="cx"> return false;
</span><span class="lines">@@ -613,7 +614,7 @@
</span><span class="cx"> _startEditing: function()
</span><span class="cx"> {
</span><span class="cx"> if (this.treeOutline.selectedDOMNode() !== this.representedObject)
</span><del>- return;
</del><ins>+ return false;
</ins><span class="cx">
</span><span class="cx"> var listItem = this._listItemNode;
</span><span class="cx">
</span><span class="lines">@@ -629,7 +630,7 @@
</span><span class="cx"> var textNode = listItem.getElementsByClassName("html-text-node")[0];
</span><span class="cx"> if (textNode)
</span><span class="cx"> return this._startEditingTextNode(textNode);
</span><del>- return;
</del><ins>+ return false;
</ins><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsEditingSupportjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -105,7 +105,7 @@
</span><span class="cx"> WebInspector.startEditing = function(element, config)
</span><span class="cx"> {
</span><span class="cx"> if (!WebInspector.markBeingEdited(element, true))
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx">
</span><span class="cx"> config = config || new WebInspector.EditingConfig(function() {}, function() {});
</span><span class="cx"> var committedCallback = config.commitHandler;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsEventListenerSectionGroupjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/EventListenerSectionGroup.js (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/EventListenerSectionGroup.js 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/EventListenerSectionGroup.js 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -42,8 +42,9 @@
</span><span class="cx"> _nodeTextOrLink: function()
</span><span class="cx"> {
</span><span class="cx"> var node = this._eventListener.node;
</span><ins>+ console.assert(node);
</ins><span class="cx"> if (!node)
</span><del>- return;
</del><ins>+ return "";
</ins><span class="cx">
</span><span class="cx"> if (node.nodeType() === Node.DOCUMENT_NODE)
</span><span class="cx"> return "document";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsFrameContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FrameContentView.js (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/FrameContentView.js 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FrameContentView.js 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -179,7 +179,7 @@
</span><span class="cx">
</span><span class="cx"> console.assert(representedObjectToShow);
</span><span class="cx"> if (!representedObjectToShow)
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx">
</span><span class="cx"> this._currentContentViewSetting.value = identifier;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsNavigationBarjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -77,7 +77,7 @@
</span><span class="cx"> {
</span><span class="cx"> console.assert(navigationItem instanceof WebInspector.NavigationItem);
</span><span class="cx"> if (!(navigationItem instanceof WebInspector.NavigationItem))
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx">
</span><span class="cx"> if (navigationItem.parentNavigationBar)
</span><span class="cx"> navigationItem.parentNavigationBar.removeNavigationItem(navigationItem);
</span><span class="lines">@@ -111,7 +111,7 @@
</span><span class="cx"> {
</span><span class="cx"> var navigationItem = this._findNavigationItem(navigationItemOrIdentifierOrIndex);
</span><span class="cx"> if (!navigationItem)
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx">
</span><span class="cx"> navigationItem._parentNavigationBar = null;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsQuickConsolejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -246,12 +246,13 @@
</span><span class="cx">
</span><span class="cx"> _insertExecutionContextPathComponentForFrame: function(frame, skipRebuild)
</span><span class="cx"> {
</span><ins>+ console.assert(!frame.isMainFrame());
</ins><span class="cx"> if (frame.isMainFrame())
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx">
</span><span class="cx"> console.assert(!this._frameIdentifierToExecutionContextPathComponentMap[frame.id]);
</span><span class="cx"> if (this._frameIdentifierToExecutionContextPathComponentMap[frame.id])
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx">
</span><span class="cx"> var executionContextPathComponent = this._createExecutionContextPathComponentFromFrame(frame);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsSidebarjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -78,11 +78,11 @@
</span><span class="cx"> {
</span><span class="cx"> console.assert(sidebarPanel instanceof WebInspector.SidebarPanel);
</span><span class="cx"> if (!(sidebarPanel instanceof WebInspector.SidebarPanel))
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx">
</span><span class="cx"> console.assert(!sidebarPanel.parentSidebar);
</span><span class="cx"> if (sidebarPanel.parentSidebar)
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx">
</span><span class="cx"> sidebarPanel._parentSidebar = this;
</span><span class="cx">
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx"> {
</span><span class="cx"> var sidebarPanel = this.findSidebarPanel(sidebarPanelOrIdentifierOrIndex);
</span><span class="cx"> if (!sidebarPanel)
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx">
</span><span class="cx"> sidebarPanel.willRemove();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTextEditorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js (173476 => 173477)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2014-09-10 18:58:05 UTC (rev 173476)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2014-09-10 19:15:28 UTC (rev 173477)
</span><span class="lines">@@ -563,7 +563,7 @@
</span><span class="cx"> var lineHandle = this._codeMirror.getLineHandle(lineNumber);
</span><span class="cx"> console.assert(lineHandle);
</span><span class="cx"> if (!lineHandle)
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx">
</span><span class="cx"> return this._codeMirror.addLineClass(lineHandle, "wrap", styleClassName);
</span><span class="cx"> },
</span><span class="lines">@@ -573,7 +573,7 @@
</span><span class="cx"> var lineHandle = this._codeMirror.getLineHandle(lineNumber);
</span><span class="cx"> console.assert(lineHandle);
</span><span class="cx"> if (!lineHandle)
</span><del>- return;
</del><ins>+ return null;
</ins><span class="cx">
</span><span class="cx"> return this._codeMirror.removeLineClass(lineHandle, "wrap", styleClassName);
</span><span class="cx"> },
</span><span class="lines">@@ -583,7 +583,7 @@
</span><span class="cx"> var lineHandle = this._codeMirror.getLineHandle(lineNumber);
</span><span class="cx"> console.assert(lineHandle);
</span><span class="cx"> if (!lineHandle)
</span><del>- return;
</del><ins>+ return false;
</ins><span class="cx">
</span><span class="cx"> return this._codeMirror.toggleLineClass(lineHandle, "wrap", styleClassName);
</span><span class="cx"> },
</span></span></pre>
</div>
</div>
</body>
</html>