<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173492] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173492">173492</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2014-09-10 15:13:59 -0700 (Wed, 10 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Fix obscure ESLint warnings and skip directories
https://bugs.webkit.org/show_bug.cgi?id=136686
Reviewed by Timothy Hatcher.
* .eslintignore: Added.
Skip directories we do not want ESLint to process.
* .eslintrc:
Add rules we've seen and sort sections.
* UserInterface/Controllers/FormatterContentBuilder.js:
(FormatterContentBuilder.prototype._appendIndent):
* UserInterface/Models/Color.js:
* UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
* UserInterface/Views/DOMTreeDataGridNode.js:
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.ondelete):
(WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
(WebInspector.DOMTreeElement.prototype._distinctClosingTagElement):
* UserInterface/Views/EditingSupport.js:
(WebInspector.EditingConfig):
* UserInterface/Views/LayerTreeDataGridNode.js:
(WebInspector.LayerTreeDataGridNode.prototype._makeOutlet):
* UserInterface/Views/TreeOutline.js:
(TreeOutline.prototype.appendChild):
(TreeOutline.prototype.insertChild):
(TreeOutline.prototype.removeChildAtIndex):
(TreeOutline.prototype.removeChild):
(TreeElement.prototype.expandRecursively):
Fix linter issues.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIeslintrc">trunk/Source/WebInspectorUI/.eslintrc</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceControllersFormatterContentBuilderjs">trunk/Source/WebInspectorUI/UserInterface/Controllers/FormatterContentBuilder.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsColorjs">trunk/Source/WebInspectorUI/UserInterface/Models/Color.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsDOMNodeStylesjs">trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsCSSStyleDeclarationTextEditorjs">trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeDataGridNodejs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGridNode.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsEditingSupportjs">trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLayerTreeDataGridNodejs">trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlinejs">trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIeslintignore">trunk/Source/WebInspectorUI/.eslintignore</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIeslintignore"></a>
<div class="addfile"><h4>Added: trunk/Source/WebInspectorUI/.eslintignore (0 => 173492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/.eslintignore (rev 0)
+++ trunk/Source/WebInspectorUI/.eslintignore 2014-09-10 22:13:59 UTC (rev 173492)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+Localizations
+Tools
+UserInterface/External
</ins></span></pre></div>
<a id="trunkSourceWebInspectorUIeslintrc"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/.eslintrc (173491 => 173492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/.eslintrc 2014-09-10 21:55:01 UTC (rev 173491)
+++ trunk/Source/WebInspectorUI/.eslintrc 2014-09-10 22:13:59 UTC (rev 173492)
</span><span class="lines">@@ -26,19 +26,18 @@
</span><span class="cx"> {
</span><span class="cx"> "env": {
</span><span class="cx"> "browser": true,
</span><del>- "node": false
</del><ins>+ "node": false,
</ins><span class="cx"> },
</span><span class="cx"> "globals": {
</span><del>- "console": true,
</del><span class="cx"> "ApplicationCacheAgent": true,
</span><ins>+ "CSSAgent": true,
</ins><span class="cx"> "CodeMirror": true,
</span><span class="cx"> "ConsoleAgent": true,
</span><del>- "CSSAgent": true,
- "DatabaseAgent": true,
- "DebuggerAgent": true,
</del><span class="cx"> "DOMAgent": true,
</span><span class="cx"> "DOMDebuggerAgent": true,
</span><span class="cx"> "DOMStorageAgent": true,
</span><ins>+ "DatabaseAgent": true,
+ "DebuggerAgent": true,
</ins><span class="cx"> "Formatter": true,
</span><span class="cx"> "IndexedDBAgent": true,
</span><span class="cx"> "InspectorAgent": true,
</span><span class="lines">@@ -53,17 +52,29 @@
</span><span class="cx"> "RuntimeAgent": true,
</span><span class="cx"> "TimelineAgent": true,
</span><span class="cx"> "WebInspector": true,
</span><del>- "WorkerAgent": true
</del><ins>+ "WorkerAgent": true,
+ "console": true,
</ins><span class="cx"> },
</span><span class="cx"> "rules": {
</span><ins>+ "consistent-return": 2,
+ "curly": 0,
</ins><span class="cx"> "eqeqeq": 2,
</span><del>- "curly": 0,
- "consistent-return": 2,
</del><ins>+ "new-parens": 0,
+ "no-comma-dangle": 0,
+ "no-console": 0,
+ "no-constant-condition": 0,
</ins><span class="cx"> "no-extra-semi": 2,
</span><del>- "quotes": [2, "double"],
</del><ins>+ "no-proto": 0,
+ "no-return-assign": 2,
</ins><span class="cx"> "no-trailing-spaces": 2,
</span><span class="cx"> "no-underscore-dangle": 0,
</span><del>- "new-parens": 0,
- "semi": 2
</del><ins>+ "no-unused-expressions": 2,
+ "no-wrap-func": 2,
+ "quotes": [2, "double"],
+ "semi": 2,
+ "space-infix-ops": 2,
+ "space-return-throw-case": 2,
+ "strict": 0,
+ "valid-typeof": 2,
</ins><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (173491 => 173492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-09-10 21:55:01 UTC (rev 173491)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-09-10 22:13:59 UTC (rev 173492)
</span><span class="lines">@@ -1,5 +1,41 @@
</span><span class="cx"> 2014-09-10 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Fix obscure ESLint warnings and skip directories
+ https://bugs.webkit.org/show_bug.cgi?id=136686
+
+ Reviewed by Timothy Hatcher.
+
+ * .eslintignore: Added.
+ Skip directories we do not want ESLint to process.
+
+ * .eslintrc:
+ Add rules we've seen and sort sections.
+
+ * UserInterface/Controllers/FormatterContentBuilder.js:
+ (FormatterContentBuilder.prototype._appendIndent):
+ * UserInterface/Models/Color.js:
+ * UserInterface/Models/DOMNodeStyles.js:
+ (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
+ * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+ * UserInterface/Views/DOMTreeDataGridNode.js:
+ * UserInterface/Views/DOMTreeElement.js:
+ (WebInspector.DOMTreeElement.prototype.ondelete):
+ (WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
+ (WebInspector.DOMTreeElement.prototype._distinctClosingTagElement):
+ * UserInterface/Views/EditingSupport.js:
+ (WebInspector.EditingConfig):
+ * UserInterface/Views/LayerTreeDataGridNode.js:
+ (WebInspector.LayerTreeDataGridNode.prototype._makeOutlet):
+ * UserInterface/Views/TreeOutline.js:
+ (TreeOutline.prototype.appendChild):
+ (TreeOutline.prototype.insertChild):
+ (TreeOutline.prototype.removeChildAtIndex):
+ (TreeOutline.prototype.removeChild):
+ (TreeElement.prototype.expandRecursively):
+ Fix linter issues.
+
+2014-09-10 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Fix ESLint consistent-return warnings
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=136682
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceControllersFormatterContentBuilderjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/FormatterContentBuilder.js (173491 => 173492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Controllers/FormatterContentBuilder.js 2014-09-10 21:55:01 UTC (rev 173491)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/FormatterContentBuilder.js 2014-09-10 22:13:59 UTC (rev 173492)
</span><span class="lines">@@ -196,7 +196,7 @@
</span><span class="cx"> const maxCacheIndent = 20;
</span><span class="cx"> var max = Math.min(this._indent, maxCacheIndent);
</span><span class="cx"> for (var i = this._indentCache.length; i <= max; ++i)
</span><del>- this._indentCache[i] = this._indentCache[i-1] + this._indentString;
</del><ins>+ this._indentCache[i] = this._indentCache[i - 1] + this._indentString;
</ins><span class="cx">
</span><span class="cx"> // Append indents as needed.
</span><span class="cx"> var indent = this._indent;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsColorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Color.js (173491 => 173492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/Color.js 2014-09-10 21:55:01 UTC (rev 173491)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Color.js 2014-09-10 22:13:59 UTC (rev 173492)
</span><span class="lines">@@ -430,9 +430,9 @@
</span><span class="cx"> l + s
</span><span class="cx"> ];
</span><span class="cx"> return [
</span><del>- Math.round(sArray[ ~~h % 6 ] * 255),
- Math.round(sArray[ (h|16) % 6 ] * 255),
- Math.round(sArray[ (h|8) % 6 ] * 255)
</del><ins>+ Math.round(sArray[ ~~h % 6 ] * 255),
+ Math.round(sArray[ (h | 16) % 6 ] * 255),
+ Math.round(sArray[ (h | 8) % 6 ] * 255)
</ins><span class="cx"> ];
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -622,7 +622,7 @@
</span><span class="cx"> if (max === 0)
</span><span class="cx"> s = 0;
</span><span class="cx"> else
</span><del>- s = 1 - (min/max);
</del><ins>+ s = 1 - (min / max);
</ins><span class="cx">
</span><span class="cx"> return [h, s, v];
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsDOMNodeStylesjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js (173491 => 173492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js 2014-09-10 21:55:01 UTC (rev 173491)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js 2014-09-10 22:13:59 UTC (rev 173492)
</span><span class="lines">@@ -692,7 +692,7 @@
</span><span class="cx">
</span><span class="cx"> if (previousStyleDeclarationsMap !== this._styleDeclarationsMap) {
</span><span class="cx"> // If the previous and current maps differ then make sure the found styleDeclaration is added to the current map.
</span><del>- styleDeclarations = mapKey && mapKey in this._styleDeclarationsMap ? this._styleDeclarationsMap[mapKey] : [] ;
</del><ins>+ styleDeclarations = mapKey && mapKey in this._styleDeclarationsMap ? this._styleDeclarationsMap[mapKey] : [];
</ins><span class="cx">
</span><span class="cx"> if (styleDeclaration && !styleDeclarations.contains(styleDeclaration)) {
</span><span class="cx"> styleDeclarations.push(styleDeclaration);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsCSSStyleDeclarationTextEditorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js (173491 => 173492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2014-09-10 21:55:01 UTC (rev 173491)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2014-09-10 22:13:59 UTC (rev 173492)
</span><span class="lines">@@ -530,9 +530,9 @@
</span><span class="cx">
</span><span class="cx"> if (!onlyVisibleProperties) {
</span><span class="cx"> // Filter based on options only when all properties are used.
</span><del>- properties = properties.filter((function(property) {
</del><ins>+ properties = properties.filter(function(property) {
</ins><span class="cx"> return !property.implicit || this._showsImplicitProperties || property.canonicalName in this._alwaysShowPropertyNames;
</span><del>- }).bind(this));
</del><ins>+ }, this);
</ins><span class="cx">
</span><span class="cx"> if (this._sortProperties)
</span><span class="cx"> properties.sort(function(a, b) { return a.name.localeCompare(b.name); });
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeDataGridNodejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGridNode.js (173491 => 173492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGridNode.js 2014-09-10 21:55:01 UTC (rev 173491)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGridNode.js 2014-09-10 22:13:59 UTC (rev 173492)
</span><span class="lines">@@ -86,4 +86,3 @@
</span><span class="cx"> WebInspector.resourceSidebarPanel.showMainFrameDOMTree(this._domNode, true);
</span><span class="cx"> }
</span><span class="cx"> };
</span><del>-
</del></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (173491 => 173492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2014-09-10 21:55:01 UTC (rev 173491)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2014-09-10 22:13:59 UTC (rev 173492)
</span><span class="lines">@@ -479,7 +479,10 @@
</span><span class="cx"> ondelete: function()
</span><span class="cx"> {
</span><span class="cx"> var startTagTreeElement = this.treeOutline.findTreeElement(this.representedObject);
</span><del>- startTagTreeElement ? startTagTreeElement.remove() : this.remove();
</del><ins>+ if (startTagTreeElement)
+ startTagTreeElement.remove();
+ else
+ this.remove();
</ins><span class="cx"> return true;
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -527,7 +530,7 @@
</span><span class="cx"> else {
</span><span class="cx"> var nodeName = tag.textContent.match(/^<(.*?)>$/)[1];
</span><span class="cx"> tag.textContent = "";
</span><del>- tag.appendChild(document.createTextNode("<"+nodeName));
</del><ins>+ tag.appendChild(document.createTextNode("<" + nodeName));
</ins><span class="cx"> tag.appendChild(node);
</span><span class="cx"> tag.appendChild(document.createTextNode(">"));
</span><span class="cx"> }
</span><span class="lines">@@ -962,14 +965,14 @@
</span><span class="cx"> // in the child element list.
</span><span class="cx"> if (this.expanded) {
</span><span class="cx"> var closers = this._childrenListNode.querySelectorAll(".close");
</span><del>- return closers[closers.length-1];
</del><ins>+ return closers[closers.length - 1];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Remaining cases are single line non-expanded elements with a closing
</span><span class="cx"> // tag, or HTML elements without a closing tag (such as <br>). Return
</span><span class="cx"> // null in the case where there isn't a closing tag.
</span><span class="cx"> var tags = this.listItemElement.getElementsByClassName("html-tag");
</span><del>- return (tags.length === 1 ? null : tags[tags.length-1]);
</del><ins>+ return (tags.length === 1 ? null : tags[tags.length - 1]);
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> updateTitle: function(onlySearchQueryChanged)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsEditingSupportjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js (173491 => 173492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js 2014-09-10 21:55:01 UTC (rev 173491)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js 2014-09-10 22:13:59 UTC (rev 173492)
</span><span class="lines">@@ -79,9 +79,6 @@
</span><span class="cx"> this.commitHandler = commitHandler;
</span><span class="cx"> this.cancelHandler = cancelHandler;
</span><span class="cx"> this.context = context;
</span><del>- this.pasteHandler;
- this.multiline;
- this.customFinishHandler;
</del><span class="cx"> this.spellcheck = false;
</span><span class="cx"> };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsLayerTreeDataGridNodejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js (173491 => 173492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js 2014-09-10 21:55:01 UTC (rev 173491)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js 2014-09-10 22:13:59 UTC (rev 173492)
</span><span class="lines">@@ -92,7 +92,8 @@
</span><span class="cx">
</span><span class="cx"> _makeOutlet: function(name, element)
</span><span class="cx"> {
</span><del>- return this._outlets[name] = element;
</del><ins>+ this._outlets[name] = element;
+ return element;
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _makeNameCell: function()
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlinejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (173491 => 173492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2014-09-10 21:55:01 UTC (rev 173491)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2014-09-10 22:13:59 UTC (rev 173492)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx"> TreeOutline.prototype.appendChild = function(child)
</span><span class="cx"> {
</span><span class="cx"> if (!child)
</span><del>- throw("child can't be undefined or null");
</del><ins>+ throw "child can't be undefined or null";
</ins><span class="cx">
</span><span class="cx"> var lastChild = this.children[this.children.length - 1];
</span><span class="cx"> if (lastChild) {
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx"> TreeOutline.prototype.insertChild = function(child, index)
</span><span class="cx"> {
</span><span class="cx"> if (!child)
</span><del>- throw("child can't be undefined or null");
</del><ins>+ throw "child can't be undefined or null";
</ins><span class="cx">
</span><span class="cx"> var previousChild = (index > 0 ? this.children[index - 1] : null);
</span><span class="cx"> if (previousChild) {
</span><span class="lines">@@ -147,7 +147,7 @@
</span><span class="cx"> TreeOutline.prototype.removeChildAtIndex = function(childIndex, suppressOnDeselect, suppressSelectSibling)
</span><span class="cx"> {
</span><span class="cx"> if (childIndex < 0 || childIndex >= this.children.length)
</span><del>- throw("childIndex out of range");
</del><ins>+ throw "childIndex out of range";
</ins><span class="cx">
</span><span class="cx"> var child = this.children[childIndex];
</span><span class="cx"> this.children.splice(childIndex, 1);
</span><span class="lines">@@ -185,11 +185,11 @@
</span><span class="cx"> TreeOutline.prototype.removeChild = function(child, suppressOnDeselect, suppressSelectSibling)
</span><span class="cx"> {
</span><span class="cx"> if (!child)
</span><del>- throw("child can't be undefined or null");
</del><ins>+ throw "child can't be undefined or null";
</ins><span class="cx">
</span><span class="cx"> var childIndex = this.children.indexOf(child);
</span><span class="cx"> if (childIndex === -1)
</span><del>- throw("child not found in this node's children");
</del><ins>+ throw "child not found in this node's children";
</ins><span class="cx">
</span><span class="cx"> this.removeChildAtIndex(childIndex, suppressOnDeselect, suppressSelectSibling);
</span><span class="cx"> };
</span><span class="lines">@@ -869,7 +869,7 @@
</span><span class="cx"> // The Inspector uses TreeOutlines to represents object properties, so recursive expansion
</span><span class="cx"> // in some case can be infinite, since JavaScript objects can hold circular references.
</span><span class="cx"> // So default to a recursion cap of 3 levels, since that gives fairly good results.
</span><del>- if (typeof maxDepth === "undefined" || typeof maxDepth === "null")
</del><ins>+ if (maxDepth === undefined)
</ins><span class="cx"> maxDepth = 3;
</span><span class="cx">
</span><span class="cx"> while (item) {
</span></span></pre>
</div>
</div>
</body>
</html>