<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173428] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173428">173428</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-09-09 08:09:57 -0700 (Tue, 09 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: HTML5 landmark (and related) elements should not be ignored.
https://bugs.webkit.org/show_bug.cgi?id=135116
Patch by Takeshi Kurosawa <taken.spc@gmail.com> on 2014-09-09
Reviewed by Chris Fleizach.
Make sure following element should not be ignored in computeAccessibilityIsIgnored
- header, aside, address, main, nav, article, section
- dt, dd
Source/WebCore:
Tests: platform/mac/accessibility/descriptionlist-not-ignored.html
platform/mac/accessibility/landmark-not-ignored.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
LayoutTests:
* platform/mac/accessibility/descriptionlist-not-ignored-expected.txt: Added.
* platform/mac/accessibility/descriptionlist-not-ignored.html: Added.
* platform/mac/accessibility/landmark-not-ignored-expected.txt: Added.
* platform/mac/accessibility/landmark-not-ignored.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitydescriptionlistnotignoredexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/descriptionlist-not-ignored-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitydescriptionlistnotignoredhtml">trunk/LayoutTests/platform/mac/accessibility/descriptionlist-not-ignored.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitylandmarknotignoredexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/landmark-not-ignored-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitylandmarknotignoredhtml">trunk/LayoutTests/platform/mac/accessibility/landmark-not-ignored.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (173427 => 173428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-09-09 11:39:41 UTC (rev 173427)
+++ trunk/LayoutTests/ChangeLog 2014-09-09 15:09:57 UTC (rev 173428)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-09-09 Takeshi Kurosawa <taken.spc@gmail.com>
+
+ AX: HTML5 landmark (and related) elements should not be ignored.
+ https://bugs.webkit.org/show_bug.cgi?id=135116
+
+ Reviewed by Chris Fleizach.
+
+ Make sure following element should not be ignored in computeAccessibilityIsIgnored
+ - header, aside, address, main, nav, article, section
+ - dt, dd
+
+ * platform/mac/accessibility/descriptionlist-not-ignored-expected.txt: Added.
+ * platform/mac/accessibility/descriptionlist-not-ignored.html: Added.
+ * platform/mac/accessibility/landmark-not-ignored-expected.txt: Added.
+ * platform/mac/accessibility/landmark-not-ignored.html: Added.
+
</ins><span class="cx"> 2014-09-08 Mihnea Ovidenie <mihnea@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSSRegions]Incorrect layout for multicol element transformed into region
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitydescriptionlistnotignoredexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/descriptionlist-not-ignored-expected.txt (0 => 173428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/descriptionlist-not-ignored-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/descriptionlist-not-ignored-expected.txt 2014-09-09 15:09:57 UTC (rev 173428)
</span><span class="lines">@@ -0,0 +1,16 @@
</span><ins>+term
+description
+This tests that dt and dd elements are not ignored if their render objects have block render objects children.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS test.childrenCount is 2
+PASS dt.role is "AXRole: AXGroup"
+PASS dt.subrole is "AXSubrole: AXTerm"
+PASS dd.role is "AXRole: AXGroup"
+PASS dd.subrole is "AXSubrole: AXDescription"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitydescriptionlistnotignoredhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/descriptionlist-not-ignored.html (0 => 173428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/descriptionlist-not-ignored.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/descriptionlist-not-ignored.html 2014-09-09 15:09:57 UTC (rev 173428)
</span><span class="lines">@@ -0,0 +1,37 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<script src="../../../resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+<dl id="test">
+<dt><div>term</div></dt>
+<dd><div>description</div></dd>
+</dl>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that dt and dd elements are not ignored if their render objects have block render objects children.");
+
+ if (window.accessibilityController) {
+ var test = accessibilityController.accessibleElementById("test");
+ shouldBe("test.childrenCount", "2");
+
+ var dt = test.childAtIndex(0);
+ shouldBeEqualToString("dt.role", "AXRole: AXGroup");
+ shouldBeEqualToString("dt.subrole", "AXSubrole: AXTerm");
+
+ var dd = test.childAtIndex(1);
+ shouldBeEqualToString("dd.role", "AXRole: AXGroup");
+ shouldBeEqualToString("dd.subrole", "AXSubrole: AXDescription");
+ }
+
+</script>
+
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitylandmarknotignoredexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/landmark-not-ignored-expected.txt (0 => 173428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/landmark-not-ignored-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/landmark-not-ignored-expected.txt 2014-09-09 15:09:57 UTC (rev 173428)
</span><span class="lines">@@ -0,0 +1,31 @@
</span><ins>+header
+aside
+address
+main
+nav
+article
+section
+This tests that HTML5 elements which have implicit landmark and related semantics are not ignored if their render objects have block render objects children.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS test.childrenCount is 7
+PASS el.role is "AXRole: AXGroup"
+PASS el.subrole is "AXSubrole: AXLandmarkBanner"
+PASS el.role is "AXRole: AXGroup"
+PASS el.subrole is "AXSubrole: AXLandmarkComplementary"
+PASS el.role is "AXRole: AXGroup"
+PASS el.subrole is "AXSubrole: AXLandmarkContentInfo"
+PASS el.role is "AXRole: AXGroup"
+PASS el.subrole is "AXSubrole: AXLandmarkMain"
+PASS el.role is "AXRole: AXGroup"
+PASS el.subrole is "AXSubrole: AXLandmarkNavigation"
+PASS el.role is "AXRole: AXGroup"
+PASS el.subrole is "AXSubrole: AXDocumentArticle"
+PASS el.role is "AXRole: AXGroup"
+PASS el.subrole is "AXSubrole: AXDocumentRegion"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitylandmarknotignoredhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/landmark-not-ignored.html (0 => 173428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/landmark-not-ignored.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/landmark-not-ignored.html 2014-09-09 15:09:57 UTC (rev 173428)
</span><span class="lines">@@ -0,0 +1,49 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<script src="../../../resources/js-test-pre.js"></script>
+</head>
+<body id="body">
+
+<div id="test" tabindex="-1">
+<header><div>header</div></header>
+<aside><div>aside</div></aside>
+<address><div>address</div></address>
+<main><div>main</div></main>
+<nav><div>nav</div></nav>
+<article><div>article</div></article>
+<section><div>section</div></section>
+</div>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that HTML5 elements which have implicit landmark and related semantics are not ignored if their render objects have block render objects children.");
+
+ if (window.accessibilityController) {
+ var test = accessibilityController.accessibleElementById("test");
+ shouldBe("test.childrenCount", "7");
+
+ var subroles = [
+ "LandmarkBanner",
+ "LandmarkComplementary",
+ "LandmarkContentInfo",
+ "LandmarkMain",
+ "LandmarkNavigation",
+ "DocumentArticle",
+ "DocumentRegion"
+ ];
+ for (var i = 0; i < test.childrenCount; i++) {
+ var el = test.childAtIndex(i);
+ shouldBeEqualToString("el.role", "AXRole: AXGroup");
+ shouldBeEqualToString("el.subrole", "AXSubrole: AX" + subroles[i]);
+ }
+ }
+
+</script>
+
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (173427 => 173428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-09-09 11:39:41 UTC (rev 173427)
+++ trunk/Source/WebCore/ChangeLog 2014-09-09 15:09:57 UTC (rev 173428)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-09-09 Takeshi Kurosawa <taken.spc@gmail.com>
+
+ AX: HTML5 landmark (and related) elements should not be ignored.
+ https://bugs.webkit.org/show_bug.cgi?id=135116
+
+ Reviewed by Chris Fleizach.
+
+ Make sure following element should not be ignored in computeAccessibilityIsIgnored
+ - header, aside, address, main, nav, article, section
+ - dt, dd
+
+ Tests: platform/mac/accessibility/descriptionlist-not-ignored.html
+ platform/mac/accessibility/landmark-not-ignored.html
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
+
</ins><span class="cx"> 2014-09-08 Sergio Villar Senin <svillar@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CSS Grid Layout] RenderGrid methods should take RenderBox references
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (173427 => 173428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-09-09 11:39:41 UTC (rev 173427)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2014-09-09 15:09:57 UTC (rev 173428)
</span><span class="lines">@@ -1246,9 +1246,25 @@
</span><span class="cx"> if (isLink())
</span><span class="cx"> return false;
</span><span class="cx">
</span><ins>+ if (isLandmark())
+ return false;
+
</ins><span class="cx"> // all controls are accessible
</span><span class="cx"> if (isControl())
</span><span class="cx"> return false;
</span><ins>+
+ switch (roleValue()) {
+ case AudioRole:
+ case DescriptionListTermRole:
+ case DescriptionListDetailRole:
+ case DocumentArticleRole:
+ case DocumentRegionRole:
+ case ListItemRole:
+ case VideoRole:
+ return false;
+ default:
+ break;
+ }
</ins><span class="cx">
</span><span class="cx"> if (ariaRoleAttribute() != UnknownRole)
</span><span class="cx"> return false;
</span><span class="lines">@@ -1267,14 +1283,6 @@
</span><span class="cx"> if (hasContentEditableAttributeSet())
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- switch (roleValue()) {
- case AudioRole:
- case ListItemRole:
- case VideoRole:
- return false;
- default:
- break;
- }
</del><span class="cx">
</span><span class="cx"> // if this element has aria attributes on it, it should not be ignored.
</span><span class="cx"> if (supportsARIAAttributes())
</span></span></pre>
</div>
</div>
</body>
</html>