<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173432] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173432">173432</a></dd>
<dt>Author</dt> <dd>jonowells@apple.com</dd>
<dt>Date</dt> <dd>2014-09-09 10:31:18 -0700 (Tue, 09 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Fix ESLint no-extra-semi
https://bugs.webkit.org/show_bug.cgi?id=136666
Reviewed by Andy Estes.
Add explicit no-extra-semi rule to .eslintrc. Remove all unnecessary
semicolons as identified by ESLint.
* .eslintrc:
* Tools/PrettyPrinting/Formatter.js:
(Formatter):
* UserInterface/Controllers/Formatter.js:
(Formatter):
* UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.getImageSize.imageDidLoad):
(WebInspector.Resource.prototype.getImageSize):
* UserInterface/Views/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid.comparator):
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
* UserInterface/Views/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIeslintrc">trunk/Source/WebInspectorUI/.eslintrc</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIToolsPrettyPrintingFormatterjs">trunk/Source/WebInspectorUI/Tools/PrettyPrinting/Formatter.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceControllersFormatterjs">trunk/Source/WebInspectorUI/UserInterface/Controllers/Formatter.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsResourcejs">trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLayerTreeSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectPropertiesSectionjs">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPropertiesSection.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIeslintrc"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/.eslintrc (173431 => 173432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/.eslintrc 2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/.eslintrc 2014-09-09 17:31:18 UTC (rev 173432)
</span><span class="lines">@@ -58,6 +58,7 @@
</span><span class="cx"> "rules": {
</span><span class="cx"> "eqeqeq": 2,
</span><span class="cx"> "curly": 0,
</span><ins>+ "no-extra-semi": 2,
</ins><span class="cx"> "quotes": [2, "double"],
</span><span class="cx"> "no-underscore-dangle": 0,
</span><span class="cx"> "new-parens": 0,
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (173431 => 173432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-09-09 17:31:18 UTC (rev 173432)
</span><span class="lines">@@ -1,5 +1,30 @@
</span><span class="cx"> 2014-09-09 Jono Wells <jonowells@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Fix ESLint no-extra-semi
+ https://bugs.webkit.org/show_bug.cgi?id=136666
+
+ Reviewed by Andy Estes.
+
+ Add explicit no-extra-semi rule to .eslintrc. Remove all unnecessary
+ semicolons as identified by ESLint.
+
+ * .eslintrc:
+ * Tools/PrettyPrinting/Formatter.js:
+ (Formatter):
+ * UserInterface/Controllers/Formatter.js:
+ (Formatter):
+ * UserInterface/Models/Resource.js:
+ (WebInspector.Resource.prototype.getImageSize.imageDidLoad):
+ (WebInspector.Resource.prototype.getImageSize):
+ * UserInterface/Views/LayerTreeSidebarPanel.js:
+ (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid.comparator):
+ (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
+ * UserInterface/Views/ObjectPropertiesSection.js:
+ (WebInspector.ObjectPropertyTreeElement.prototype.callback):
+ (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
+
+2014-09-09 Jono Wells <jonowells@apple.com>
+
</ins><span class="cx"> Web Inspector: Fix ESLint semi (missing semicolon)
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=136665
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIToolsPrettyPrintingFormatterjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Tools/PrettyPrinting/Formatter.js (173431 => 173432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Tools/PrettyPrinting/Formatter.js 2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/Tools/PrettyPrinting/Formatter.js 2014-09-09 17:31:18 UTC (rev 173432)
</span><span class="lines">@@ -33,7 +33,7 @@
</span><span class="cx">
</span><span class="cx"> this._lastToken = null;
</span><span class="cx"> this._lastContent = "";
</span><del>-};
</del><ins>+}
</ins><span class="cx">
</span><span class="cx"> Formatter.prototype = {
</span><span class="cx"> constructor: Formatter,
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceControllersFormatterjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/Formatter.js (173431 => 173432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Controllers/Formatter.js 2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/Formatter.js 2014-09-09 17:31:18 UTC (rev 173432)
</span><span class="lines">@@ -33,7 +33,7 @@
</span><span class="cx">
</span><span class="cx"> this._lastToken = null;
</span><span class="cx"> this._lastContent = "";
</span><del>-};
</del><ins>+}
</ins><span class="cx">
</span><span class="cx"> Formatter.prototype = {
</span><span class="cx"> constructor: Formatter,
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsResourcejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js (173431 => 173432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js 2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js 2014-09-09 17:31:18 UTC (rev 173432)
</span><span class="lines">@@ -668,7 +668,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> callback(this._imageSize);
</span><del>- };
</del><ins>+ }
</ins><span class="cx">
</span><span class="cx"> // Create an <img> element that we'll use to load the image resource
</span><span class="cx"> // so that we can query its intrinsic size.
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsLayerTreeSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js (173431 => 173432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js 2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js 2014-09-09 17:31:18 UTC (rev 173432)
</span><span class="lines">@@ -181,7 +181,7 @@
</span><span class="cx"> var item1 = a.layer[sortColumnIdentifier] || 0;
</span><span class="cx"> var item2 = b.layer[sortColumnIdentifier] || 0;
</span><span class="cx"> return item1 - item2;
</span><del>- };
</del><ins>+ }
</ins><span class="cx">
</span><span class="cx"> this._dataGrid.sortNodes(comparator);
</span><span class="cx"> this._updatePopoverForSelectedNode();
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectPropertiesSectionjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPropertiesSection.js (173431 => 173432)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPropertiesSection.js 2014-09-09 17:29:02 UTC (rev 173431)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPropertiesSection.js 2014-09-09 17:31:18 UTC (rev 173432)
</span><span class="lines">@@ -335,7 +335,7 @@
</span><span class="cx"> // Call updateSiblings since their value might be based on the value that just changed.
</span><span class="cx"> this.updateSiblings();
</span><span class="cx"> }
</span><del>- };
</del><ins>+ }
</ins><span class="cx"> this.property.parentObject.setPropertyValue(this.property.name, expression.trim(), callback.bind(this));
</span><span class="cx"> }
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>