<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173406] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173406">173406</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-09-08 17:00:35 -0700 (Mon, 08 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Add layout test for lowercase CSSProperty names
https://bugs.webkit.org/show_bug.cgi?id=135961
Patch by Matt Baker <mattbaker@apple.com> on 2014-09-08
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
Modified test components to support testing CSSStyleManager and related classes:
- Added required models to Test.html
- Added CSSCompletions initialization to Test.js
- CSSCompletions doesn't assume presence of CodeMirror.
* UserInterface/Base/Test.js:
(WebInspector.loaded):
* UserInterface/Models/CSSCompletions.js:
* UserInterface/Test.html:
LayoutTests:
Added test to check that property names in matched CSS rules are returned in lowercase
when specified with upper or mixed case in the original CSS source.
* inspector/css/matched-style-properties-expected.txt: Added.
* inspector/css/matched-style-properties.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseTestjs">trunk/Source/WebInspectorUI/UserInterface/Base/Test.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsCSSCompletionsjs">trunk/Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceTesthtml">trunk/Source/WebInspectorUI/UserInterface/Test.html</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li>trunk/LayoutTests/inspector/css/</li>
<li><a href="#trunkLayoutTestsinspectorcssmatchedstylepropertiesexpectedtxt">trunk/LayoutTests/inspector/css/matched-style-properties-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectorcssmatchedstylepropertieshtml">trunk/LayoutTests/inspector/css/matched-style-properties.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (173405 => 173406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-09-08 23:59:05 UTC (rev 173405)
+++ trunk/LayoutTests/ChangeLog 2014-09-09 00:00:35 UTC (rev 173406)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2014-09-08 Matt Baker <mattbaker@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Add layout test for lowercase CSSProperty names
+ https://bugs.webkit.org/show_bug.cgi?id=135961
+
+ Reviewed by Joseph Pecoraro.
+
+ Added test to check that property names in matched CSS rules are returned in lowercase
+ when specified with upper or mixed case in the original CSS source.
+
+ * inspector/css/matched-style-properties-expected.txt: Added.
+ * inspector/css/matched-style-properties.html: Added.
+
+2014-09-08 Matt Baker <mattbaker@apple.com>
+
</ins><span class="cx"> Web Inspector: Fixes to layout test infrastructure
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=136360
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsinspectorcssmatchedstylepropertiesexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/inspector/css/matched-style-properties-expected.txt (0 => 173406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/css/matched-style-properties-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/css/matched-style-properties-expected.txt 2014-09-09 00:00:35 UTC (rev 173406)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+Testing that the author rules returned by CSSStyleManager.stylesForNode have lowercase property names regardless of CSS source formatting.
+
+Property valid: background-color
+Property valid: color
+Property valid: border-style
+Property valid: border-width
+Property valid: position
+Property valid: top
+Property valid: left
+
</ins></span></pre></div>
<a id="trunkLayoutTestsinspectorcssmatchedstylepropertieshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/inspector/css/matched-style-properties.html (0 => 173406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/css/matched-style-properties.html (rev 0)
+++ trunk/LayoutTests/inspector/css/matched-style-properties.html 2014-09-09 00:00:35 UTC (rev 173406)
</span><span class="lines">@@ -0,0 +1,85 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<style>
+div#node1 {
+ BACKGROUND-COLOR:blue;
+ COLOR:white;
+ border-STYLE:solid;
+ BORDER-width:0;
+ position:absolute;
+ ToP:0;
+ lEfT:0;
+}
+</style>
+<script type="text/javascript" src="../../http/tests/inspector/inspector-test.js"></script>
+<script>
+function test() {
+ var nodeStyles;
+
+ function validatePropertyName(name)
+ {
+ if (typeof name != "string") {
+ InspectorTest.log("Unexpected property name type: " + typeof name);
+ return false;
+ }
+
+ if (name.toLowerCase() != name) {
+ InspectorTest.log("Property name contains uppercase characters: " + name);
+ return false;
+ }
+ return true;
+ }
+
+ function validateStyles()
+ {
+ for (var i = 0; i < nodeStyles.matchedRules.length; ++i) {
+ var rule = nodeStyles.matchedRules[i];
+ if (rule.type != WebInspector.CSSRule.Type.Author)
+ continue;
+
+ for (var j = 0; j < rule.style.properties.length; ++j) {
+ var property = rule.style.properties[j];
+
+ if (property.anonymous)
+ continue;
+
+ if (validatePropertyName(property.name))
+ InspectorTest.log("Property valid: " + property.name);
+ }
+ }
+
+ InspectorTest.completeTest();
+ }
+
+ function onStylesRefreshed()
+ {
+ nodeStyles.removeEventListener(WebInspector.DOMNodeStyles.Event.Refreshed, onStylesRefreshed, this);
+ validateStyles();
+ }
+
+ WebInspector.domTreeManager.requestDocument(function(documentNode) {
+ WebInspector.domTreeManager.querySelector(documentNode.id, "#node1", function(contentNodeId) {
+ if (contentNodeId) {
+ var domNode = WebInspector.domTreeManager.nodeForId(contentNodeId);
+ nodeStyles = WebInspector.cssStyleManager.stylesForNode(domNode);
+
+ if (nodeStyles.needsRefresh)
+ nodeStyles.addEventListener(WebInspector.DOMNodeStyles.Event.Refreshed, onStylesRefreshed, this);
+ else
+ validateStyles();
+ } else {
+ InspectorTest.log("DOM node not found.");
+ InspectorTest.completeTest();
+ }
+ });
+ });
+}
+</script>
+</head>
+<body onload="runTest()">
+ <p>Testing that the author rules returned by CSSStyleManager.stylesForNode have lowercase property names regardless of CSS source formatting.</p>
+
+ <div id="node1"></div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (173405 => 173406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-09-08 23:59:05 UTC (rev 173405)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-09-09 00:00:35 UTC (rev 173406)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2014-09-08 Matt Baker <mattbaker@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Add layout test for lowercase CSSProperty names
+ https://bugs.webkit.org/show_bug.cgi?id=135961
+
+ Reviewed by Joseph Pecoraro.
+
+ Modified test components to support testing CSSStyleManager and related classes:
+ - Added required models to Test.html
+ - Added CSSCompletions initialization to Test.js
+ - CSSCompletions doesn't assume presence of CodeMirror.
+
+ * UserInterface/Base/Test.js:
+ (WebInspector.loaded):
+ * UserInterface/Models/CSSCompletions.js:
+ * UserInterface/Test.html:
+
+2014-09-08 Matt Baker <mattbaker@apple.com>
+
</ins><span class="cx"> Web Inspector: Fixes to layout test infrastructure
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=136360
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseTestjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Test.js (173405 => 173406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Test.js 2014-09-08 23:59:05 UTC (rev 173405)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Test.js 2014-09-09 00:00:35 UTC (rev 173406)
</span><span class="lines">@@ -53,6 +53,9 @@
</span><span class="cx"> // Enable agents.
</span><span class="cx"> InspectorAgent.enable();
</span><span class="cx">
</span><ins>+ // Perform one-time tasks.
+ WebInspector.CSSCompletions.requestCSSNameCompletions();
+
</ins><span class="cx"> // Establish communication with the InspectorBackend.
</span><span class="cx"> InspectorFrontendHost.loaded();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsCSSCompletionsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js (173405 => 173406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js 2014-09-08 23:59:05 UTC (rev 173405)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js 2014-09-09 00:00:35 UTC (rev 173406)
</span><span class="lines">@@ -83,6 +83,11 @@
</span><span class="cx">
</span><span class="cx"> WebInspector.CSSCompletions.cssNameCompletions = new WebInspector.CSSCompletions(names, false);
</span><span class="cx">
</span><ins>+ // CodeMirror is not included by tests so we shouldn't assume it always exists.
+ // If it isn't available we skip MIME type associations.
+ if (!window.CodeMirror)
+ return;
+
</ins><span class="cx"> var propertyNamesForCodeMirror = {};
</span><span class="cx"> var valueKeywordsForCodeMirror = {"inherit": true, "initial": true};
</span><span class="cx"> var colorKeywordsForCodeMirror = {};
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceTesthtml"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Test.html (173405 => 173406)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Test.html 2014-09-08 23:59:05 UTC (rev 173405)
+++ trunk/Source/WebInspectorUI/UserInterface/Test.html 2014-09-09 00:00:35 UTC (rev 173406)
</span><span class="lines">@@ -70,7 +70,14 @@
</span><span class="cx"> <script src="Models/CallFrame.js"></script>
</span><span class="cx"> <script src="Models/Color.js"></script>
</span><span class="cx"> <script src="Models/ContentFlow.js"></script>
</span><ins>+ <script src="Models/CSSCompletions.js"></script>
+ <script src="Models/CSSKeywordCompletions.js"></script>
+ <script src="Models/CSSProperty.js"></script>
+ <script src="Models/CSSRule.js"></script>
+ <script src="Models/CSSStyleDeclaration.js"></script>
+ <script src="Models/CSSStyleSheet.js"></script>
</ins><span class="cx"> <script src="Models/DOMNode.js"></script>
</span><ins>+ <script src="Models/DOMNodeStyles.js"></script>
</ins><span class="cx"> <script src="Models/DOMStorageObject.js"></script>
</span><span class="cx"> <script src="Models/DOMTree.js"></script>
</span><span class="cx"> <script src="Models/ExecutionContext.js"></script>
</span></span></pre>
</div>
</div>
</body>
</html>