<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173405] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173405">173405</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-09-08 16:59:05 -0700 (Mon, 08 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Fixes to layout test infrastructure
https://bugs.webkit.org/show_bug.cgi?id=136360
Patch by Matt Baker <mattbaker@apple.com> on 2014-09-08
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
Added missing includes to Test.html, which was breaking tests that
depended on SourceCodeLocation and LazySourceCodeLocation. Also fixed
bug which prevented test results from being resent after reloading the
page under test.
* UserInterface/Base/Test.js:
(InspectorTest.reloadPage):
* UserInterface/Test.html:
LayoutTests:
Updated expected results to reflect breakpoint resolution changes in <a href="http://trac.webkit.org/projects/webkit/changeset/171784">r171784</a>.
* inspector/debugger/probe-manager-add-remove-actions-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerprobemanageraddremoveactionsexpectedtxt">trunk/LayoutTests/inspector/debugger/probe-manager-add-remove-actions-expected.txt</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseTestjs">trunk/Source/WebInspectorUI/UserInterface/Base/Test.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceTesthtml">trunk/Source/WebInspectorUI/UserInterface/Test.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (173404 => 173405)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-09-08 23:54:20 UTC (rev 173404)
+++ trunk/LayoutTests/ChangeLog 2014-09-08 23:59:05 UTC (rev 173405)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-09-08 Matt Baker <mattbaker@apple.com>
+
+ Web Inspector: Fixes to layout test infrastructure
+ https://bugs.webkit.org/show_bug.cgi?id=136360
+
+ Reviewed by Joseph Pecoraro.
+
+ Updated expected results to reflect breakpoint resolution changes in r171784.
+
+ * inspector/debugger/probe-manager-add-remove-actions-expected.txt:
+
</ins><span class="cx"> 2014-09-08 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Investigate test failures on ML caused by MediaTime refactoring
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerprobemanageraddremoveactionsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/probe-manager-add-remove-actions-expected.txt (173404 => 173405)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/probe-manager-add-remove-actions-expected.txt 2014-09-08 23:54:20 UTC (rev 173404)
+++ trunk/LayoutTests/inspector/debugger/probe-manager-add-remove-actions-expected.txt 2014-09-08 23:59:05 UTC (rev 173405)
</span><span class="lines">@@ -8,9 +8,6 @@
</span><span class="cx"> Probe with identifier 2 was added to probe set.
</span><span class="cx"> Probe set's probe count: 2
</span><span class="cx"> Breakpoint actions changed. New count: 2
</span><del>-Breakpoint resolved state changed: true
-Breakpoint resolved state changed: true
-Breakpoint resolved state changed: false
</del><span class="cx"> Breakpoint was added.
</span><span class="cx"> PASS: Breakpoint should be resolved.
</span><span class="cx"> Breakpoint resolved state changed: true
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (173404 => 173405)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-09-08 23:54:20 UTC (rev 173404)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-09-08 23:59:05 UTC (rev 173405)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-09-08 Matt Baker <mattbaker@apple.com>
+
+ Web Inspector: Fixes to layout test infrastructure
+ https://bugs.webkit.org/show_bug.cgi?id=136360
+
+ Reviewed by Joseph Pecoraro.
+
+ Added missing includes to Test.html, which was breaking tests that
+ depended on SourceCodeLocation and LazySourceCodeLocation. Also fixed
+ bug which prevented test results from being resent after reloading the
+ page under test.
+
+ * UserInterface/Base/Test.js:
+ (InspectorTest.reloadPage):
+ * UserInterface/Test.html:
+
</ins><span class="cx"> 2014-09-07 Timothy Hatcher <timothy@apple.com>
</span><span class="cx">
</span><span class="cx"> Use a <circle> instead of a <path> in DownloadArrow.svg.
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseTestjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Test.js (173404 => 173405)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Test.js 2014-09-08 23:54:20 UTC (rev 173404)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Test.js 2014-09-08 23:59:05 UTC (rev 173405)
</span><span class="lines">@@ -214,7 +214,7 @@
</span><span class="cx"> this._testPageIsReloading = true;
</span><span class="cx">
</span><span class="cx"> return Promise.resolve(null);
</span><del>- });
</del><ins>+ }.bind(this));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> InspectorTest.reportUncaughtException = function(message, url, lineNumber)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceTesthtml"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Test.html (173404 => 173405)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Test.html 2014-09-08 23:54:20 UTC (rev 173404)
+++ trunk/Source/WebInspectorUI/UserInterface/Test.html 2014-09-08 23:59:05 UTC (rev 173405)
</span><span class="lines">@@ -62,6 +62,7 @@
</span><span class="cx">
</span><span class="cx"> <script src="Models/BreakpointAction.js"></script>
</span><span class="cx"> <script src="Models/SourceCode.js"></script>
</span><ins>+ <script src="Models/SourceCodeLocation.js"></script>
</ins><span class="cx"> <script src="Models/Timeline.js"></script>
</span><span class="cx"> <script src="Models/TimelineRecord.js"></script>
</span><span class="cx">
</span><span class="lines">@@ -80,6 +81,7 @@
</span><span class="cx"> <script src="Models/IndexedDatabaseObjectStore.js"></script>
</span><span class="cx"> <script src="Models/IndexedDatabaseObjectStoreIndex.js"></script>
</span><span class="cx"> <script src="Models/LayoutTimelineRecord.js"></script>
</span><ins>+ <script src="Models/LazySourceCodeLocation.js"></script>
</ins><span class="cx"> <script src="Models/NetworkTimeline.js"></script>
</span><span class="cx"> <script src="Models/Probe.js"></script>
</span><span class="cx"> <script src="Models/ProbeSet.js"></script>
</span></span></pre>
</div>
</div>
</body>
</html>