<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173331] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173331">173331</a></dd>
<dt>Author</dt> <dd>clopez@igalia.com</dd>
<dt>Date</dt> <dd>2014-09-05 13:25:01 -0700 (Fri, 05 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
https://bugs.webkit.org/show_bug.cgi?id=136562
Reviewed by Martin Robinson.
Source/WebCore:
No new tests, this makes existing tests pass.
* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::platformSuggestedFilename):
Implement ResourceResponse::platformSuggestedFilename() for SOUP after <a href="http://trac.webkit.org/projects/webkit/changeset/173272">r173272</a>, <a href="http://trac.webkit.org/projects/webkit/changeset/173301">r173301</a> and <a href="http://trac.webkit.org/projects/webkit/changeset/173305">r173305</a>.
Tools:
* Scripts/run-gtk-tests:
(TestRunner): Remove failure expectations for tests that now pass.
LayoutTests:
* platform/gtk/TestExpectations: Remove failure expectations for tests that now pass.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworksoupResourceResponseSoupcpp">trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptsrungtktests">trunk/Tools/Scripts/run-gtk-tests</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (173330 => 173331)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-09-05 20:05:32 UTC (rev 173330)
+++ trunk/LayoutTests/ChangeLog 2014-09-05 20:25:01 UTC (rev 173331)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2014-09-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
+
+ [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
+ https://bugs.webkit.org/show_bug.cgi?id=136562
+
+ Reviewed by Martin Robinson.
+
+ * platform/gtk/TestExpectations: Remove failure expectations for tests that now pass.
+
</ins><span class="cx"> 2014-09-04 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><span class="cx"> ARM32 iOS: JSC Test math.js fails
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (173330 => 173331)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-09-05 20:05:32 UTC (rev 173330)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-09-05 20:25:01 UTC (rev 173331)
</span><span class="lines">@@ -2115,9 +2115,6 @@
</span><span class="cx"> webkit.org/b/136537 css3/flexbox/flex-rounding.html [ Failure ]
</span><span class="cx"> webkit.org/b/136537 fast/sub-pixel/client-width-height-snapping.html [ Failure ]
</span><span class="cx">
</span><del>-webkit.org/b/136562 http/tests/download/basic-ascii.html [ Failure ]
-webkit.org/b/136562 http/tests/download/literal-utf-8.html [ Failure ]
-
</del><span class="cx"> #////////////////////////////////////////////////////////////////////////////////////////
</span><span class="cx"> # End of Tests failing
</span><span class="cx"> #////////////////////////////////////////////////////////////////////////////////////////
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (173330 => 173331)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-09-05 20:05:32 UTC (rev 173330)
+++ trunk/Source/WebCore/ChangeLog 2014-09-05 20:25:01 UTC (rev 173331)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-09-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
+
+ [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
+ https://bugs.webkit.org/show_bug.cgi?id=136562
+
+ Reviewed by Martin Robinson.
+
+ No new tests, this makes existing tests pass.
+
+ * platform/network/soup/ResourceResponseSoup.cpp:
+ (WebCore::ResourceResponse::platformSuggestedFilename):
+ Implement ResourceResponse::platformSuggestedFilename() for SOUP after r173272, r173301 and r173305.
+
</ins><span class="cx"> 2014-09-05 peavo@outlook.com <peavo@outlook.com>
</span><span class="cx">
</span><span class="cx"> [Curl] Compile error.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworksoupResourceResponseSoupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp (173330 => 173331)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2014-09-05 20:05:32 UTC (rev 173330)
+++ trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2014-09-05 20:25:01 UTC (rev 173331)
</span><span class="lines">@@ -103,7 +103,7 @@
</span><span class="cx">
</span><span class="cx"> String ResourceResponse::platformSuggestedFilename() const
</span><span class="cx"> {
</span><del>- return String();
</del><ins>+ return filenameFromHTTPContentDisposition(httpHeaderField(HTTPHeaderName::ContentDisposition));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (173330 => 173331)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-09-05 20:05:32 UTC (rev 173330)
+++ trunk/Tools/ChangeLog 2014-09-05 20:25:01 UTC (rev 173331)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-09-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
+
+ [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
+ https://bugs.webkit.org/show_bug.cgi?id=136562
+
+ Reviewed by Martin Robinson.
+
+ * Scripts/run-gtk-tests:
+ (TestRunner): Remove failure expectations for tests that now pass.
+
</ins><span class="cx"> 2014-09-04 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> Dashboard metrics page wastes a lot of time sorting iterations
</span></span></pre></div>
<a id="trunkToolsScriptsrungtktests"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/run-gtk-tests (173330 => 173331)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/run-gtk-tests 2014-09-05 20:05:32 UTC (rev 173330)
+++ trunk/Tools/Scripts/run-gtk-tests 2014-09-05 20:25:01 UTC (rev 173331)
</span><span class="lines">@@ -67,8 +67,6 @@
</span><span class="cx"> SkippedTest("WebKit2Gtk/TestWebKitWebView", "/webkit2/WebKitWebView/snapshot", "Test fails", 120404),
</span><span class="cx"> SkippedTest("WebKit2Gtk/TestWebKitWebView", "/webkit2/WebKitWebView/page-visibility", "Test fails or times out", 131731),
</span><span class="cx"> SkippedTest("WebKit2Gtk/TestCookieManager", "/webkit2/WebKitCookieManager/persistent-storage", "Test is flaky", 134580),
</span><del>- SkippedTest("WebKit2Gtk/TestDownloads", "/webkit2/Downloads/remote-file", "Test fails since r173272", 136562),
- SkippedTest("WebKit2Gtk/TestResources", "/webkit2/WebKitWebResource/suggested-filename", "Test fails since r173272", 136562),
</del><span class="cx"> SkippedTest("WebKit2/TestWebKit2", "WebKit2.MouseMoveAfterCrash", "Test is flaky", 85066),
</span><span class="cx"> SkippedTest("WebKit2/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutForImages", "Test is flaky", 85066),
</span><span class="cx"> SkippedTest("WebKit2/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutFrames", "Test fails", 85037),
</span></span></pre>
</div>
</div>
</body>
</html>