<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173264] trunk/Source/JavaScriptCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173264">173264</a></dd>
<dt>Author</dt> <dd>burg@cs.washington.edu</dd>
<dt>Date</dt> <dd>2014-09-04 10:21:39 -0700 (Thu, 04 Sep 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Web Inspector: the profiler should not accrue time to nodes while the debugger is paused
https://bugs.webkit.org/show_bug.cgi?id=136352

Reviewed by Timothy Hatcher.

Hook up pause/continue events to the LegacyProfiler and any active
ProfilerGenerators. If the debugger is paused, all intervening call
entries will be created with totalTime as 0.0.

* inspector/ScriptDebugServer.cpp:
(Inspector::ScriptDebugServer::handlePause):
* profiler/LegacyProfiler.cpp: Move from typedef'd callbacks to using
std::function. This allows callbacks to take different argument types.

(JSC::callFunctionForProfilesWithGroup):
(JSC::LegacyProfiler::willExecute):
(JSC::LegacyProfiler::didExecute):
(JSC::LegacyProfiler::exceptionUnwind):
(JSC::LegacyProfiler::didPause):
(JSC::LegacyProfiler::didContinue):
(JSC::dispatchFunctionToProfiles): Deleted.
* profiler/LegacyProfiler.h:
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::ProfileGenerator):
(JSC::ProfileGenerator::endCallEntry):
(JSC::ProfileGenerator::didExecute): Deleted.
* profiler/ProfileGenerator.h:
(JSC::ProfileGenerator::didPause):
(JSC::ProfileGenerator::didContinue):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorScriptDebugServercpp">trunk/Source/JavaScriptCore/inspector/ScriptDebugServer.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreprofilerLegacyProfilercpp">trunk/Source/JavaScriptCore/profiler/LegacyProfiler.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreprofilerLegacyProfilerh">trunk/Source/JavaScriptCore/profiler/LegacyProfiler.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreprofilerProfileGeneratorcpp">trunk/Source/JavaScriptCore/profiler/ProfileGenerator.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreprofilerProfileGeneratorh">trunk/Source/JavaScriptCore/profiler/ProfileGenerator.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (173263 => 173264)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog        2014-09-04 17:10:26 UTC (rev 173263)
+++ trunk/Source/JavaScriptCore/ChangeLog        2014-09-04 17:21:39 UTC (rev 173264)
</span><span class="lines">@@ -1,3 +1,35 @@
</span><ins>+2014-09-04  Brian J. Burg  &lt;burg@cs.washington.edu&gt;
+
+        Web Inspector: the profiler should not accrue time to nodes while the debugger is paused
+        https://bugs.webkit.org/show_bug.cgi?id=136352
+
+        Reviewed by Timothy Hatcher.
+
+        Hook up pause/continue events to the LegacyProfiler and any active
+        ProfilerGenerators. If the debugger is paused, all intervening call
+        entries will be created with totalTime as 0.0.
+
+        * inspector/ScriptDebugServer.cpp:
+        (Inspector::ScriptDebugServer::handlePause):
+        * profiler/LegacyProfiler.cpp: Move from typedef'd callbacks to using
+        std::function. This allows callbacks to take different argument types.
+
+        (JSC::callFunctionForProfilesWithGroup):
+        (JSC::LegacyProfiler::willExecute):
+        (JSC::LegacyProfiler::didExecute):
+        (JSC::LegacyProfiler::exceptionUnwind):
+        (JSC::LegacyProfiler::didPause):
+        (JSC::LegacyProfiler::didContinue):
+        (JSC::dispatchFunctionToProfiles): Deleted.
+        * profiler/LegacyProfiler.h:
+        * profiler/ProfileGenerator.cpp:
+        (JSC::ProfileGenerator::ProfileGenerator):
+        (JSC::ProfileGenerator::endCallEntry):
+        (JSC::ProfileGenerator::didExecute): Deleted.
+        * profiler/ProfileGenerator.h:
+        (JSC::ProfileGenerator::didPause):
+        (JSC::ProfileGenerator::didContinue):
+
</ins><span class="cx"> 2014-09-04  Commit Queue  &lt;commit-queue@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Unreviewed, rolling out r173245.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorScriptDebugServercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/ScriptDebugServer.cpp (173263 => 173264)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/ScriptDebugServer.cpp        2014-09-04 17:10:26 UTC (rev 173263)
+++ trunk/Source/JavaScriptCore/inspector/ScriptDebugServer.cpp        2014-09-04 17:21:39 UTC (rev 173264)
</span><span class="lines">@@ -38,6 +38,7 @@
</span><span class="cx"> #include &quot;JSJavaScriptCallFrame.h&quot;
</span><span class="cx"> #include &quot;JSLock.h&quot;
</span><span class="cx"> #include &quot;JavaScriptCallFrame.h&quot;
</span><ins>+#include &quot;LegacyProfiler.h&quot;
</ins><span class="cx"> #include &quot;ScriptValue.h&quot;
</span><span class="cx"> #include &quot;SourceProvider.h&quot;
</span><span class="cx"> #include &lt;wtf/NeverDestroyed.h&gt;
</span><span class="lines">@@ -316,12 +317,14 @@
</span><span class="cx"> void ScriptDebugServer::handlePause(Debugger::ReasonForPause, JSGlobalObject* vmEntryGlobalObject)
</span><span class="cx"> {
</span><span class="cx">     dispatchFunctionToListeners(&amp;ScriptDebugServer::dispatchDidPause, vmEntryGlobalObject);
</span><ins>+    LegacyProfiler::profiler()-&gt;didPause(currentDebuggerCallFrame());
</ins><span class="cx">     didPause(vmEntryGlobalObject);
</span><span class="cx"> 
</span><span class="cx">     m_doneProcessingDebuggerEvents = false;
</span><span class="cx">     runEventLoopWhilePaused();
</span><span class="cx"> 
</span><span class="cx">     didContinue(vmEntryGlobalObject);
</span><ins>+    LegacyProfiler::profiler()-&gt;didContinue(currentDebuggerCallFrame());
</ins><span class="cx">     dispatchFunctionToListeners(&amp;ScriptDebugServer::dispatchDidContinue, vmEntryGlobalObject);
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreprofilerLegacyProfilercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/profiler/LegacyProfiler.cpp (173263 => 173264)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/profiler/LegacyProfiler.cpp        2014-09-04 17:10:26 UTC (rev 173263)
+++ trunk/Source/JavaScriptCore/profiler/LegacyProfiler.cpp        2014-09-04 17:21:39 UTC (rev 173264)
</span><span class="lines">@@ -32,6 +32,7 @@
</span><span class="cx"> #include &quot;CallFrame.h&quot;
</span><span class="cx"> #include &quot;CodeBlock.h&quot;
</span><span class="cx"> #include &quot;CommonIdentifiers.h&quot;
</span><ins>+#include &quot;DebuggerCallFrame.h&quot;
</ins><span class="cx"> #include &quot;InternalFunction.h&quot;
</span><span class="cx"> #include &quot;JSFunction.h&quot;
</span><span class="cx"> #include &quot;JSGlobalObject.h&quot;
</span><span class="lines">@@ -114,11 +115,11 @@
</span><span class="cx">     }
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-static inline void dispatchFunctionToProfiles(ExecState* callerOrHandlerCallFrame, const Vector&lt;RefPtr&lt;ProfileGenerator&gt;&gt;&amp; profiles, ProfileGenerator::ProfileFunction function, const CallIdentifier&amp; callIdentifier, unsigned currentProfileTargetGroup)
</del><ins>+static inline void callFunctionForProfilesWithGroup(std::function&lt;void(ProfileGenerator*)&gt; callback, const Vector&lt;RefPtr&lt;ProfileGenerator&gt;&gt;&amp; profiles, unsigned targetProfileGroup)
</ins><span class="cx"> {
</span><del>-    for (size_t i = 0; i &lt; profiles.size(); ++i) {
-        if (profiles[i]-&gt;profileGroup() == currentProfileTargetGroup || !profiles[i]-&gt;origin())
-            (profiles[i].get()-&gt;*function)(callerOrHandlerCallFrame, callIdentifier);
</del><ins>+    for (const RefPtr&lt;ProfileGenerator&gt;&amp; profile : profiles) {
+        if (profile-&gt;profileGroup() == targetProfileGroup || !profile-&gt;origin())
+            callback(profile.get());
</ins><span class="cx">     }
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -126,7 +127,9 @@
</span><span class="cx"> {
</span><span class="cx">     ASSERT(!m_currentProfiles.isEmpty());
</span><span class="cx"> 
</span><del>-    dispatchFunctionToProfiles(callerCallFrame, m_currentProfiles, &amp;ProfileGenerator::willExecute, createCallIdentifier(callerCallFrame, function, StringImpl::empty(), 0, 0), callerCallFrame-&gt;lexicalGlobalObject()-&gt;profileGroup());
</del><ins>+    CallIdentifier callIdentifier = createCallIdentifier(callerCallFrame, function, StringImpl::empty(), 0, 0);
+
+    callFunctionForProfilesWithGroup(std::bind(&amp;ProfileGenerator::willExecute, std::placeholders::_1, callerCallFrame, callIdentifier), m_currentProfiles, callerCallFrame-&gt;lexicalGlobalObject()-&gt;profileGroup());
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void LegacyProfiler::willExecute(ExecState* callerCallFrame, const String&amp; sourceURL, unsigned startingLineNumber, unsigned startingColumnNumber)
</span><span class="lines">@@ -135,30 +138,58 @@
</span><span class="cx"> 
</span><span class="cx">     CallIdentifier callIdentifier = createCallIdentifier(callerCallFrame, JSValue(), sourceURL, startingLineNumber, startingColumnNumber);
</span><span class="cx"> 
</span><del>-    dispatchFunctionToProfiles(callerCallFrame, m_currentProfiles, &amp;ProfileGenerator::willExecute, callIdentifier, callerCallFrame-&gt;lexicalGlobalObject()-&gt;profileGroup());
</del><ins>+    callFunctionForProfilesWithGroup(std::bind(&amp;ProfileGenerator::willExecute, std::placeholders::_1, callerCallFrame, callIdentifier), m_currentProfiles, callerCallFrame-&gt;lexicalGlobalObject()-&gt;profileGroup());
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void LegacyProfiler::didExecute(ExecState* callerCallFrame, JSValue function)
</span><span class="cx"> {
</span><span class="cx">     ASSERT(!m_currentProfiles.isEmpty());
</span><span class="cx"> 
</span><del>-    dispatchFunctionToProfiles(callerCallFrame, m_currentProfiles, &amp;ProfileGenerator::didExecute, createCallIdentifier(callerCallFrame, function, StringImpl::empty(), 0, 0), callerCallFrame-&gt;lexicalGlobalObject()-&gt;profileGroup());
</del><ins>+    CallIdentifier callIdentifier = createCallIdentifier(callerCallFrame, function, StringImpl::empty(), 0, 0);
+
+    callFunctionForProfilesWithGroup(std::bind(&amp;ProfileGenerator::didExecute, std::placeholders::_1, callerCallFrame, callIdentifier), m_currentProfiles, callerCallFrame-&gt;lexicalGlobalObject()-&gt;profileGroup());
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void LegacyProfiler::didExecute(ExecState* callerCallFrame, const String&amp; sourceURL, unsigned startingLineNumber, unsigned startingColumnNumber)
</span><span class="cx"> {
</span><span class="cx">     ASSERT(!m_currentProfiles.isEmpty());
</span><span class="cx"> 
</span><del>-    dispatchFunctionToProfiles(callerCallFrame, m_currentProfiles, &amp;ProfileGenerator::didExecute, createCallIdentifier(callerCallFrame, JSValue(), sourceURL, startingLineNumber, startingColumnNumber), callerCallFrame-&gt;lexicalGlobalObject()-&gt;profileGroup());
</del><ins>+    CallIdentifier callIdentifier = createCallIdentifier(callerCallFrame, JSValue(), sourceURL, startingLineNumber, startingColumnNumber);
+
+    callFunctionForProfilesWithGroup(std::bind(&amp;ProfileGenerator::didExecute, std::placeholders::_1, callerCallFrame, callIdentifier), m_currentProfiles, callerCallFrame-&gt;lexicalGlobalObject()-&gt;profileGroup());
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void LegacyProfiler::exceptionUnwind(ExecState* handlerCallFrame)
</span><span class="cx"> {
</span><span class="cx">     ASSERT(!m_currentProfiles.isEmpty());
</span><span class="cx"> 
</span><del>-    dispatchFunctionToProfiles(handlerCallFrame, m_currentProfiles, &amp;ProfileGenerator::exceptionUnwind, createCallIdentifier(handlerCallFrame, JSValue(), StringImpl::empty(), 0, 0), handlerCallFrame-&gt;lexicalGlobalObject()-&gt;profileGroup());
</del><ins>+    CallIdentifier callIdentifier = createCallIdentifier(handlerCallFrame, JSValue(), StringImpl::empty(), 0, 0);
+
+    callFunctionForProfilesWithGroup(std::bind(&amp;ProfileGenerator::exceptionUnwind, std::placeholders::_1, handlerCallFrame, callIdentifier), m_currentProfiles, handlerCallFrame-&gt;lexicalGlobalObject()-&gt;profileGroup());
</ins><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void LegacyProfiler::didPause(PassRefPtr&lt;DebuggerCallFrame&gt; prpCallFrame)
+{
+    if (m_currentProfiles.isEmpty())
+        return;
+
+    RefPtr&lt;DebuggerCallFrame&gt; callFrame = prpCallFrame;
+    CallIdentifier callIdentifier = createCallIdentifier(callFrame-&gt;exec(), JSValue(), StringImpl::empty(), 0, 0);
+
+    callFunctionForProfilesWithGroup(std::bind(&amp;ProfileGenerator::didPause, std::placeholders::_1, callFrame, callIdentifier), m_currentProfiles, callFrame-&gt;vmEntryGlobalObject()-&gt;profileGroup());
+}
+
+void LegacyProfiler::didContinue(PassRefPtr&lt;DebuggerCallFrame&gt; prpCallFrame)
+{
+    if (m_currentProfiles.isEmpty())
+        return;
+
+    RefPtr&lt;DebuggerCallFrame&gt; callFrame = prpCallFrame;
+    CallIdentifier callIdentifier = createCallIdentifier(callFrame-&gt;exec(), JSValue(), StringImpl::empty(), 0, 0);
+
+    callFunctionForProfilesWithGroup(std::bind(&amp;ProfileGenerator::didContinue, std::placeholders::_1, callFrame, callIdentifier), m_currentProfiles, callFrame-&gt;vmEntryGlobalObject()-&gt;profileGroup());
+}
+
</ins><span class="cx"> CallIdentifier LegacyProfiler::createCallIdentifier(ExecState* exec, JSValue functionValue, const String&amp; defaultSourceURL, unsigned defaultLineNumber, unsigned defaultColumnNumber)
</span><span class="cx"> {
</span><span class="cx">     if (!functionValue)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreprofilerLegacyProfilerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/profiler/LegacyProfiler.h (173263 => 173264)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/profiler/LegacyProfiler.h        2014-09-04 17:10:26 UTC (rev 173263)
+++ trunk/Source/JavaScriptCore/profiler/LegacyProfiler.h        2014-09-04 17:21:39 UTC (rev 173264)
</span><span class="lines">@@ -36,6 +36,7 @@
</span><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><ins>+class DebuggerCallFrame;
</ins><span class="cx"> class ExecState;
</span><span class="cx"> class VM;
</span><span class="cx"> class JSGlobalObject;
</span><span class="lines">@@ -61,6 +62,9 @@
</span><span class="cx"> 
</span><span class="cx">     void exceptionUnwind(ExecState* handlerCallFrame);
</span><span class="cx"> 
</span><ins>+    void didPause(PassRefPtr&lt;DebuggerCallFrame&gt;);
+    void didContinue(PassRefPtr&lt;DebuggerCallFrame&gt;);
+
</ins><span class="cx">     const Vector&lt;RefPtr&lt;ProfileGenerator&gt;&gt;&amp; currentProfiles() { return m_currentProfiles; };
</span><span class="cx"> 
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreprofilerProfileGeneratorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/profiler/ProfileGenerator.cpp (173263 => 173264)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/profiler/ProfileGenerator.cpp        2014-09-04 17:10:26 UTC (rev 173263)
+++ trunk/Source/JavaScriptCore/profiler/ProfileGenerator.cpp        2014-09-04 17:21:39 UTC (rev 173264)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx"> 
</span><span class="cx"> #include &quot;CallFrame.h&quot;
</span><span class="cx"> #include &quot;CodeBlock.h&quot;
</span><ins>+#include &quot;Debugger.h&quot;
</ins><span class="cx"> #include &quot;JSGlobalObject.h&quot;
</span><span class="cx"> #include &quot;JSStringRef.h&quot;
</span><span class="cx"> #include &quot;JSFunction.h&quot;
</span><span class="lines">@@ -48,7 +49,11 @@
</span><span class="cx">     : m_origin(exec ? exec-&gt;lexicalGlobalObject() : nullptr)
</span><span class="cx">     , m_profileGroup(exec ? exec-&gt;lexicalGlobalObject()-&gt;profileGroup() : 0)
</span><span class="cx">     , m_foundConsoleStartParent(false)
</span><ins>+    , m_debuggerPaused(false)
</ins><span class="cx"> {
</span><ins>+    if (Debugger* debugger = exec-&gt;lexicalGlobalObject()-&gt;debugger())
+        m_debuggerPaused = debugger-&gt;isPaused();
+
</ins><span class="cx">     m_profile = Profile::create(title, uid);
</span><span class="cx">     m_currentNode = m_rootNode = m_profile-&gt;rootNode();
</span><span class="cx">     if (exec)
</span><span class="lines">@@ -123,7 +128,7 @@
</span><span class="cx">     ProfileNode::Call&amp; last = node-&gt;lastCall();
</span><span class="cx">     ASSERT(isnan(last.totalTime()));
</span><span class="cx"> 
</span><del>-    last.setTotalTime(currentTime() - last.startTime());
</del><ins>+    last.setTotalTime(m_debuggerPaused ? 0.0 : currentTime() - last.startTime());
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void ProfileGenerator::willExecute(ExecState* callerCallFrame, const CallIdentifier&amp; callIdentifier)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreprofilerProfileGeneratorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/profiler/ProfileGenerator.h (173263 => 173264)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/profiler/ProfileGenerator.h        2014-09-04 17:10:26 UTC (rev 173263)
+++ trunk/Source/JavaScriptCore/profiler/ProfileGenerator.h        2014-09-04 17:21:39 UTC (rev 173264)
</span><span class="lines">@@ -33,6 +33,7 @@
</span><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><ins>+    class DebuggerCallFrame;
</ins><span class="cx">     class ExecState;
</span><span class="cx">     class JSGlobalObject;
</span><span class="cx">     class Profile;
</span><span class="lines">@@ -53,6 +54,9 @@
</span><span class="cx">         void didExecute(ExecState* callerCallFrame, const CallIdentifier&amp;);
</span><span class="cx">         void exceptionUnwind(ExecState* handlerCallFrame, const CallIdentifier&amp;);
</span><span class="cx"> 
</span><ins>+        void didPause(PassRefPtr&lt;DebuggerCallFrame&gt;, const CallIdentifier&amp;) { m_debuggerPaused = true; }
+        void didContinue(PassRefPtr&lt;DebuggerCallFrame&gt;, const CallIdentifier&amp;) { m_debuggerPaused = false; }
+
</ins><span class="cx">         void stopProfiling();
</span><span class="cx"> 
</span><span class="cx">         typedef void (ProfileGenerator::*ProfileFunction)(ExecState* callerOrHandlerCallFrame, const CallIdentifier&amp; callIdentifier);
</span><span class="lines">@@ -73,6 +77,7 @@
</span><span class="cx">         RefPtr&lt;ProfileNode&gt; m_rootNode;
</span><span class="cx">         RefPtr&lt;ProfileNode&gt; m_currentNode;
</span><span class="cx">         bool m_foundConsoleStartParent;
</span><ins>+        bool m_debuggerPaused;
</ins><span class="cx">     };
</span><span class="cx"> 
</span><span class="cx"> } // namespace JSC
</span></span></pre>
</div>
</div>

</body>
</html>