<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173278] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173278">173278</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-09-04 14:07:00 -0700 (Thu, 04 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use WTFString::find(char) in more places
https://bugs.webkit.org/show_bug.cgi?id=136541
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-09-04
Reviewed by Daniel Bates.
* Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::queryKeysAndValues):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseAttribute):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin):
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::decodedSnippetForAttribute):
* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulespluginsYouTubePluginReplacementcpp">trunk/Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLEmbedElementcpp">trunk/Source/WebCore/html/HTMLEmbedElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLObjectElementcpp">trunk/Source/WebCore/html/HTMLObjectElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlparserXSSAuditorcpp">trunk/Source/WebCore/html/parser/XSSAuditor.cpp</a></li>
<li><a href="#trunkSourceWebCorepageUserContentURLPatterncpp">trunk/Source/WebCore/page/UserContentURLPattern.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (173277 => 173278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-09-04 20:59:43 UTC (rev 173277)
+++ trunk/Source/WebCore/ChangeLog 2014-09-04 21:07:00 UTC (rev 173278)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-09-04 Joseph Pecoraro <pecoraro@apple.com>
+
+ Use WTFString::find(char) in more places
+ https://bugs.webkit.org/show_bug.cgi?id=136541
+
+ Reviewed by Daniel Bates.
+
+ * Modules/plugins/YouTubePluginReplacement.cpp:
+ (WebCore::queryKeysAndValues):
+ * html/HTMLEmbedElement.cpp:
+ (WebCore::HTMLEmbedElement::parseAttribute):
+ * html/HTMLObjectElement.cpp:
+ (WebCore::HTMLObjectElement::parametersForPlugin):
+ * html/parser/XSSAuditor.cpp:
+ (WebCore::XSSAuditor::decodedSnippetForAttribute):
+ * page/UserContentURLPattern.cpp:
+ (WebCore::UserContentURLPattern::parse):
+
</ins><span class="cx"> 2014-09-04 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> Try to fix iOS build.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulespluginsYouTubePluginReplacementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp (173277 => 173278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp 2014-09-04 20:59:43 UTC (rev 173277)
+++ trunk/Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp 2014-09-04 21:07:00 UTC (rev 173278)
</span><span class="lines">@@ -128,7 +128,7 @@
</span><span class="cx"> while (equalSearchLocation < queryLength - 1 && equalSearchLength) {
</span><span class="cx">
</span><span class="cx"> // Search for "=".
</span><del>- size_t equalLocation = queryString.find("=", equalSearchLocation);
</del><ins>+ size_t equalLocation = queryString.find('=', equalSearchLocation);
</ins><span class="cx"> if (equalLocation == notFound)
</span><span class="cx"> break;
</span><span class="cx">
</span><span class="lines">@@ -141,7 +141,7 @@
</span><span class="cx"> size_t keyLength = equalLocation - equalSearchLocation;
</span><span class="cx">
</span><span class="cx"> // Seach for the ampersand.
</span><del>- size_t ampersandLocation = queryString.find("&", indexAfterEqual);
</del><ins>+ size_t ampersandLocation = queryString.find('&', indexAfterEqual);
</ins><span class="cx">
</span><span class="cx"> // Get the value after the "=", before the ampersand.
</span><span class="cx"> size_t valueLocation = indexAfterEqual;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLEmbedElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLEmbedElement.cpp (173277 => 173278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLEmbedElement.cpp 2014-09-04 20:59:43 UTC (rev 173277)
+++ trunk/Source/WebCore/html/HTMLEmbedElement.cpp 2014-09-04 21:07:00 UTC (rev 173278)
</span><span class="lines">@@ -101,7 +101,7 @@
</span><span class="cx"> void HTMLEmbedElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
</span><span class="cx"> {
</span><span class="cx"> if (name == typeAttr) {
</span><del>- m_serviceType = value.string().left(value.find(";")).lower();
</del><ins>+ m_serviceType = value.string().left(value.find(';')).lower();
</ins><span class="cx"> // FIXME: The only difference between this and HTMLObjectElement's corresponding
</span><span class="cx"> // code is that HTMLObjectElement does setNeedsWidgetUpdate(true). Consider moving
</span><span class="cx"> // this up to the HTMLPlugInImageElement to be shared.
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLObjectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLObjectElement.cpp (173277 => 173278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLObjectElement.cpp 2014-09-04 20:59:43 UTC (rev 173277)
+++ trunk/Source/WebCore/html/HTMLObjectElement.cpp 2014-09-04 21:07:00 UTC (rev 173278)
</span><span class="lines">@@ -180,7 +180,7 @@
</span><span class="cx"> // FIXME: serviceType calculation does not belong in this function.
</span><span class="cx"> if (serviceType.isEmpty() && equalIgnoringCase(name, "type")) {
</span><span class="cx"> serviceType = param.value();
</span><del>- size_t pos = serviceType.find(";");
</del><ins>+ size_t pos = serviceType.find(';');
</ins><span class="cx"> if (pos != notFound)
</span><span class="cx"> serviceType = serviceType.left(pos);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlparserXSSAuditorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/parser/XSSAuditor.cpp (173277 => 173278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/parser/XSSAuditor.cpp 2014-09-04 20:59:43 UTC (rev 173277)
+++ trunk/Source/WebCore/html/parser/XSSAuditor.cpp 2014-09-04 21:07:00 UTC (rev 173278)
</span><span class="lines">@@ -618,7 +618,7 @@
</span><span class="cx"> // !-- following a less-than sign. We stop instead on any ampersand
</span><span class="cx"> // slash, or less-than sign.
</span><span class="cx"> size_t position = 0;
</span><del>- if ((position = decodedSnippet.find("=")) != notFound
</del><ins>+ if ((position = decodedSnippet.find('=')) != notFound
</ins><span class="cx"> && (position = decodedSnippet.find(isNotHTMLSpace, position + 1)) != notFound
</span><span class="cx"> && (position = decodedSnippet.find(isTerminatingCharacter, isHTMLQuote(decodedSnippet[position]) ? position + 1 : position)) != notFound) {
</span><span class="cx"> decodedSnippet.truncate(position);
</span></span></pre></div>
<a id="trunkSourceWebCorepageUserContentURLPatterncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/UserContentURLPattern.cpp (173277 => 173278)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/UserContentURLPattern.cpp 2014-09-04 20:59:43 UTC (rev 173277)
+++ trunk/Source/WebCore/page/UserContentURLPattern.cpp 2014-09-04 21:07:00 UTC (rev 173278)
</span><span class="lines">@@ -81,7 +81,7 @@
</span><span class="cx"> if (equalIgnoringCase(m_scheme, "file"))
</span><span class="cx"> pathStartPos = hostStartPos;
</span><span class="cx"> else {
</span><del>- size_t hostEndPos = pattern.find("/", hostStartPos);
</del><ins>+ size_t hostEndPos = pattern.find('/', hostStartPos);
</ins><span class="cx"> if (hostEndPos == notFound)
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // No other '*' can occur in the host.
</span><del>- if (m_host.find("*") != notFound)
</del><ins>+ if (m_host.find('*') != notFound)
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> pathStartPos = hostEndPos;
</span></span></pre>
</div>
</div>
</body>
</html>