<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173260] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173260">173260</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2014-09-04 09:33:17 -0700 (Thu, 04 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Buildbot metrics page gives wrong results after a new bot gets added
https://bugs.webkit.org/show_bug.cgi?id=136516
Part 1: Fix red/green counters. Dashboard is considered green at a given time
if all the bots that ever had results before this time are green.
This doesn't (and cannot) address situations where the bot gets removed and then
re-added. It also gives wrong results after a bot gets removed, because it doesn't
know that it was ever displayed on the dashboard.
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
(Analyzer.prototype._dashboardIsAllGreen):
(Analyzer.prototype._updateStretchOfRedCounters):
(Analyzer.prototype._countPercentageOfGreen):
(Analyzer.prototype._allQueuesAreSuccessful): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMetricsAnalyzerjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMetricsAnalyzerjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js (173259 => 173260)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js 2014-09-04 16:13:35 UTC (rev 173259)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js 2014-09-04 16:33:17 UTC (rev 173260)
</span><span class="lines">@@ -91,15 +91,14 @@
</span><span class="cx"> return result;
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _allQueuesAreSuccessful: function(topIterationByQueue, queues)
</del><ins>+ _dashboardIsAllGreen: function(topIterationByQueue)
</ins><span class="cx"> {
</span><span class="cx"> var countOfQueuesWithKnownColor = Object.keys(topIterationByQueue).length;
</span><del>- console.assert(countOfQueuesWithKnownColor <= queues.length);
- if (countOfQueuesWithKnownColor !== queues.length)
</del><ins>+ if (countOfQueuesWithKnownColor === 0)
</ins><span class="cx"> return undefined;
</span><span class="cx">
</span><del>- for (var i = queues.length - 1; i >= 0; --i) {
- if (!topIterationByQueue[queues[i].id].successful)
</del><ins>+ for (var queueID in topIterationByQueue) {
+ if (!topIterationByQueue[queueID].successful)
</ins><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx"> return true;
</span><span class="lines">@@ -107,19 +106,22 @@
</span><span class="cx">
</span><span class="cx"> _updateStretchOfRedCounters: function(topIterationByQueue, currentTime, stretchOfRedCounters)
</span><span class="cx"> {
</span><del>- var isRedNow = false;
- for (queueID in topIterationByQueue) {
- if (!topIterationByQueue[queueID].successful) {
- isRedNow = true;
- break;
</del><ins>+ var dashboardIsAllGreen = this._dashboardIsAllGreen(topIterationByQueue);
+
+ if (dashboardIsAllGreen === undefined) {
+ console.assert(stretchOfRedCounters.currentStretchOfRedStart === undefined);
+ console.assert(stretchOfRedCounters.longestStretchOfRed === 0);
+ return;
+ }
+
+ if (dashboardIsAllGreen) {
+ if (stretchOfRedCounters.currentStretchOfRedStart !== undefined) {
+ stretchOfRedCounters.longestStretchOfRed = Math.max(stretchOfRedCounters.longestStretchOfRed, currentTime - stretchOfRedCounters.currentStretchOfRedStart);
+ stretchOfRedCounters.currentStretchOfRedStart = undefined;
</ins><span class="cx"> }
</span><del>- }
- if (isRedNow) {
</del><ins>+ } else {
</ins><span class="cx"> if (stretchOfRedCounters.currentStretchOfRedStart === undefined)
</span><span class="cx"> stretchOfRedCounters.currentStretchOfRedStart = currentTime;
</span><del>- } else if (stretchOfRedCounters.currentStretchOfRedStart !== undefined) {
- stretchOfRedCounters.longestStretchOfRed = Math.max(stretchOfRedCounters.longestStretchOfRed, currentTime - stretchOfRedCounters.currentStretchOfRedStart);
- stretchOfRedCounters.currentStretchOfRedStart = undefined;
</del><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -153,9 +155,9 @@
</span><span class="cx"> longestStretchOfRed: 0,
</span><span class="cx"> currentStretchOfRedStart: undefined
</span><span class="cx"> };
</span><del>- var earliestTimeInRangeWhereAllQueuesHaveResults;
- if (this._allQueuesAreSuccessful(topIterationByQueue, queues) !== undefined)
- earliestTimeInRangeWhereAllQueuesHaveResults = this._rangeStartTime;
</del><ins>+ var earliestTimeInRangeWithColor;
+ if (this._dashboardIsAllGreen(topIterationByQueue) !== undefined)
+ earliestTimeInRangeWithColor = this._rangeStartTime;
</ins><span class="cx"> this._updateStretchOfRedCounters(topIterationByQueue, this._rangeStartTime, stretchOfRedCounters);
</span><span class="cx"> for (var i = iterations.length - 1; i >= 0; --i) {
</span><span class="cx"> if (iterations[i].endTime <= this._rangeStartTime) {
</span><span class="lines">@@ -163,11 +165,10 @@
</span><span class="cx"> continue;
</span><span class="cx"> }
</span><span class="cx"> if (!(iterations[i].queue.id in topIterationByQueue)) {
</span><del>- console.assert(earliestTimeInRangeWhereAllQueuesHaveResults === undefined);
</del><span class="cx"> topIterationByQueue[iterations[i].queue.id] = iterations[i];
</span><del>- if (this._allQueuesAreSuccessful(topIterationByQueue, queues) !== undefined) {
</del><ins>+ if (earliestTimeInRangeWithColor === undefined) {
</ins><span class="cx"> currentTime = iterations[i].endTime;
</span><del>- earliestTimeInRangeWhereAllQueuesHaveResults = currentTime;
</del><ins>+ earliestTimeInRangeWithColor = currentTime;
</ins><span class="cx"> }
</span><span class="cx"> this._updateStretchOfRedCounters(topIterationByQueue, currentTime, stretchOfRedCounters);
</span><span class="cx"> continue;
</span><span class="lines">@@ -175,17 +176,18 @@
</span><span class="cx"> if (iterations[i].openSourceRevision <= topIterationByQueue[iterations[i].queue.id].openSourceRevision)
</span><span class="cx"> continue;
</span><span class="cx">
</span><del>- var allQueuesWereSuccessful = this._allQueuesAreSuccessful(topIterationByQueue, queues);
</del><ins>+ var dashboardWasAllGreen = this._dashboardIsAllGreen(topIterationByQueue);
+ console.assert(dashboardWasAllGreen !== undefined);
</ins><span class="cx"> topIterationByQueue[iterations[i].queue.id] = iterations[i];
</span><span class="cx">
</span><del>- if (allQueuesWereSuccessful === true)
</del><ins>+ if (dashboardWasAllGreen === true)
</ins><span class="cx"> greenTime += iterations[i].endTime - currentTime;
</span><span class="cx">
</span><span class="cx"> currentTime = iterations[i].endTime;
</span><span class="cx"> this._updateStretchOfRedCounters(topIterationByQueue, currentTime, stretchOfRedCounters);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (this._allQueuesAreSuccessful(topIterationByQueue, queues) === true)
</del><ins>+ if (this._dashboardIsAllGreen(topIterationByQueue) === true)
</ins><span class="cx"> greenTime += this._rangeEndTime - currentTime;
</span><span class="cx">
</span><span class="cx"> if (stretchOfRedCounters.currentStretchOfRedStart !== undefined)
</span><span class="lines">@@ -193,13 +195,13 @@
</span><span class="cx">
</span><span class="cx"> result.longestStretchOfRed = stretchOfRedCounters.longestStretchOfRed / 1000;
</span><span class="cx">
</span><del>- if (earliestTimeInRangeWhereAllQueuesHaveResults === this._rangeStartTime)
</del><ins>+ if (earliestTimeInRangeWithColor === this._rangeStartTime)
</ins><span class="cx"> result.percentageOfGreen = greenTime / (this._rangeEndTime - this._rangeStartTime) * 100;
</span><span class="cx"> else {
</span><span class="cx"> result.buildbotRangeError = true;
</span><del>- if (earliestTimeInRangeWhereAllQueuesHaveResults !== undefined) {
- result.buildbotRangeErrorText = "Queue only has results starting " + earliestTimeInRangeWhereAllQueuesHaveResults;
- result.percentageOfGreen = greenTime / (this._rangeEndTime - earliestTimeInRangeWhereAllQueuesHaveResults) * 100;
</del><ins>+ if (earliestTimeInRangeWithColor !== undefined) {
+ result.buildbotRangeErrorText = "Queue only has results starting " + earliestTimeInRangeWithColor;
+ result.percentageOfGreen = greenTime / (this._rangeEndTime - earliestTimeInRangeWithColor) * 100;
</ins><span class="cx"> } else
</span><span class="cx"> result.buildbotRangeErrorText = "Queue has no results in this range";
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (173259 => 173260)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-09-04 16:13:35 UTC (rev 173259)
+++ trunk/Tools/ChangeLog 2014-09-04 16:33:17 UTC (rev 173260)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2014-09-03 Alexey Proskuryakov <ap@apple.com>
+
+ Buildbot metrics page gives wrong results after a new bot gets added
+ https://bugs.webkit.org/show_bug.cgi?id=136516
+
+ Part 1: Fix red/green counters. Dashboard is considered green at a given time
+ if all the bots that ever had results before this time are green.
+
+ This doesn't (and cannot) address situations where the bot gets removed and then
+ re-added. It also gives wrong results after a bot gets removed, because it doesn't
+ know that it was ever displayed on the dashboard.
+
+ Reviewed by Darin Adler.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
+ (Analyzer.prototype._dashboardIsAllGreen):
+ (Analyzer.prototype._updateStretchOfRedCounters):
+ (Analyzer.prototype._countPercentageOfGreen):
+ (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
+
</ins><span class="cx"> 2014-09-03 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Unreviewed test fix.
</span></span></pre>
</div>
</div>
</body>
</html>