<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173212] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173212">173212</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-09-03 11:42:54 -0700 (Wed, 03 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use StringBuilder append(char) and appendLiteral in more places
https://bugs.webkit.org/show_bug.cgi?id=136470
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-09-03
Reviewed by Andreas Kling.
* Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::loggingString):
* Modules/websockets/WebSocket.cpp:
(WebCore::encodeProtocolString):
* Modules/websockets/WebSocketExtensionDispatcher.cpp:
(WebCore::WebSocketExtensionDispatcher::createHeaderValue):
(WebCore::WebSocketExtensionDispatcher::appendAcceptedExtension):
* Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientLocation):
(WebCore::WebSocketHandshake::clientHandshakeMessage):
* css/CSSCalculationValue.cpp:
(WebCore::buildCssText):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::cssText):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::cssText):
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::selectorsText):
* css/CSSSupportsRule.cpp:
(WebCore::CSSSupportsRule::cssText):
* css/MediaQuery.cpp:
(WebCore::MediaQuery::serialize):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::generateUniquePrefix):
* editing/markup.cpp:
(WebCore::urlToMarkup):
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::convertToDataURL):
* html/EmailInputType.cpp:
(WebCore::EmailInputType::sanitizeValue):
* html/FormController.cpp:
(WebCore::recordFormStructure):
* html/parser/XSSAuditorDelegate.cpp:
(WebCore::buildConsoleError):
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::collectCueText):
* mathml/MathMLMencloseElement.cpp:
(WebCore::MathMLMencloseElement::longDivLeftPadding):
* page/PageSerializer.cpp:
(WebCore::SerializerMarkupAccumulator::appendElement):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::toRawString):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::synchronousScrollingReasonsAsText):
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::logThreadedScrollingMode):
* platform/PODInterval.h:
(WebCore::PODInterval::toString):
* platform/PODRedBlackTree.h:
(WebCore::PODRedBlackTree::dumpFromNode):
* platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
* platform/network/ProxyServer.cpp:
(WebCore::appendProxyServerString):
(WebCore::toString):
* platform/text/DateTimeFormat.cpp:
(WebCore::DateTimeFormat::quoteAndAppendLiteral):
* platform/text/PlatformLocale.cpp:
(WebCore::DateTimeStringBuilder::zeroPadString):
(WebCore::Locale::convertFromLocalizedNumber):
* platform/text/TextStream.cpp:
(WebCore::TextStream::operator<<):
* rendering/RenderListMarker.cpp:
(WebCore::listMarkerText):
* testing/Internals.cpp:
(WebCore::Internals::parserMetaData):
(WebCore::Internals::getCurrentCursorInfo):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBKeyDatacpp">trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsWebSocketcpp">trunk/Source/WebCore/Modules/websockets/WebSocket.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsWebSocketExtensionDispatchercpp">trunk/Source/WebCore/Modules/websockets/WebSocketExtensionDispatcher.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsWebSocketHandshakecpp">trunk/Source/WebCore/Modules/websockets/WebSocketHandshake.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSCalculationValuecpp">trunk/Source/WebCore/css/CSSCalculationValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSComputedStyleDeclarationcpp">trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSMediaRulecpp">trunk/Source/WebCore/css/CSSMediaRule.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSSelectorListcpp">trunk/Source/WebCore/css/CSSSelectorList.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSSupportsRulecpp">trunk/Source/WebCore/css/CSSSupportsRule.cpp</a></li>
<li><a href="#trunkSourceWebCorecssMediaQuerycpp">trunk/Source/WebCore/css/MediaQuery.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingMarkupAccumulatorcpp">trunk/Source/WebCore/editing/MarkupAccumulator.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingmarkupcpp">trunk/Source/WebCore/editing/markup.cpp</a></li>
<li><a href="#trunkSourceWebCorefileapiFileReaderLoadercpp">trunk/Source/WebCore/fileapi/FileReaderLoader.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlEmailInputTypecpp">trunk/Source/WebCore/html/EmailInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlFormControllercpp">trunk/Source/WebCore/html/FormController.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlparserXSSAuditorDelegatecpp">trunk/Source/WebCore/html/parser/XSSAuditorDelegate.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackWebVTTParsercpp">trunk/Source/WebCore/html/track/WebVTTParser.cpp</a></li>
<li><a href="#trunkSourceWebCoremathmlMathMLMencloseElementcpp">trunk/Source/WebCore/mathml/MathMLMencloseElement.cpp</a></li>
<li><a href="#trunkSourceWebCorepagePageSerializercpp">trunk/Source/WebCore/page/PageSerializer.cpp</a></li>
<li><a href="#trunkSourceWebCorepageSecurityOrigincpp">trunk/Source/WebCore/page/SecurityOrigin.cpp</a></li>
<li><a href="#trunkSourceWebCorepagescrollingScrollingCoordinatorcpp">trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp</a></li>
<li><a href="#trunkSourceWebCorepagescrollingmacScrollingTreeFrameScrollingNodeMacmm">trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformPODIntervalh">trunk/Source/WebCore/platform/PODInterval.h</a></li>
<li><a href="#trunkSourceWebCoreplatformPODRedBlackTreeh">trunk/Source/WebCore/platform/PODRedBlackTree.h</a></li>
<li><a href="#trunkSourceWebCoreplatformUUIDcpp">trunk/Source/WebCore/platform/UUID.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkProxyServercpp">trunk/Source/WebCore/platform/network/ProxyServer.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformtextDateTimeFormatcpp">trunk/Source/WebCore/platform/text/DateTimeFormat.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformtextPlatformLocalecpp">trunk/Source/WebCore/platform/text/PlatformLocale.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformtextTextStreamcpp">trunk/Source/WebCore/platform/text/TextStream.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderListMarkercpp">trunk/Source/WebCore/rendering/RenderListMarker.cpp</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/ChangeLog 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -1,3 +1,78 @@
</span><ins>+2014-09-03 Joseph Pecoraro <pecoraro@apple.com>
+
+ Use StringBuilder append(char) and appendLiteral in more places
+ https://bugs.webkit.org/show_bug.cgi?id=136470
+
+ Reviewed by Andreas Kling.
+
+ * Modules/indexeddb/IDBKeyData.cpp:
+ (WebCore::IDBKeyData::loggingString):
+ * Modules/websockets/WebSocket.cpp:
+ (WebCore::encodeProtocolString):
+ * Modules/websockets/WebSocketExtensionDispatcher.cpp:
+ (WebCore::WebSocketExtensionDispatcher::createHeaderValue):
+ (WebCore::WebSocketExtensionDispatcher::appendAcceptedExtension):
+ * Modules/websockets/WebSocketHandshake.cpp:
+ (WebCore::WebSocketHandshake::clientLocation):
+ (WebCore::WebSocketHandshake::clientHandshakeMessage):
+ * css/CSSCalculationValue.cpp:
+ (WebCore::buildCssText):
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::CSSComputedStyleDeclaration::cssText):
+ * css/CSSMediaRule.cpp:
+ (WebCore::CSSMediaRule::cssText):
+ * css/CSSSelectorList.cpp:
+ (WebCore::CSSSelectorList::selectorsText):
+ * css/CSSSupportsRule.cpp:
+ (WebCore::CSSSupportsRule::cssText):
+ * css/MediaQuery.cpp:
+ (WebCore::MediaQuery::serialize):
+ * editing/MarkupAccumulator.cpp:
+ (WebCore::MarkupAccumulator::generateUniquePrefix):
+ * editing/markup.cpp:
+ (WebCore::urlToMarkup):
+ * fileapi/FileReaderLoader.cpp:
+ (WebCore::FileReaderLoader::convertToDataURL):
+ * html/EmailInputType.cpp:
+ (WebCore::EmailInputType::sanitizeValue):
+ * html/FormController.cpp:
+ (WebCore::recordFormStructure):
+ * html/parser/XSSAuditorDelegate.cpp:
+ (WebCore::buildConsoleError):
+ * html/track/WebVTTParser.cpp:
+ (WebCore::WebVTTParser::collectCueText):
+ * mathml/MathMLMencloseElement.cpp:
+ (WebCore::MathMLMencloseElement::longDivLeftPadding):
+ * page/PageSerializer.cpp:
+ (WebCore::SerializerMarkupAccumulator::appendElement):
+ * page/SecurityOrigin.cpp:
+ (WebCore::SecurityOrigin::toRawString):
+ * page/scrolling/ScrollingCoordinator.cpp:
+ (WebCore::ScrollingCoordinator::synchronousScrollingReasonsAsText):
+ * page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
+ (WebCore::logThreadedScrollingMode):
+ * platform/PODInterval.h:
+ (WebCore::PODInterval::toString):
+ * platform/PODRedBlackTree.h:
+ (WebCore::PODRedBlackTree::dumpFromNode):
+ * platform/UUID.cpp:
+ (WebCore::createCanonicalUUIDString):
+ * platform/network/ProxyServer.cpp:
+ (WebCore::appendProxyServerString):
+ (WebCore::toString):
+ * platform/text/DateTimeFormat.cpp:
+ (WebCore::DateTimeFormat::quoteAndAppendLiteral):
+ * platform/text/PlatformLocale.cpp:
+ (WebCore::DateTimeStringBuilder::zeroPadString):
+ (WebCore::Locale::convertFromLocalizedNumber):
+ * platform/text/TextStream.cpp:
+ (WebCore::TextStream::operator<<):
+ * rendering/RenderListMarker.cpp:
+ (WebCore::listMarkerText):
+ * testing/Internals.cpp:
+ (WebCore::Internals::parserMetaData):
+ (WebCore::Internals::getCurrentCursorInfo):
+
</ins><span class="cx"> 2014-09-03 Bear Travis <betravis@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSS Font Loading] Enable Page Caching
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBKeyDatacpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -266,9 +266,9 @@
</span><span class="cx"> for (size_t i = 0; i < arrayValue.size(); ++i) {
</span><span class="cx"> result.append(arrayValue[i].loggingString());
</span><span class="cx"> if (i < arrayValue.size() - 1)
</span><del>- result.append(", ");
</del><ins>+ result.appendLiteral(", ");
</ins><span class="cx"> }
</span><del>- result.append(" }");
</del><ins>+ result.appendLiteral(" }");
</ins><span class="cx"> return result.toString();
</span><span class="cx"> }
</span><span class="cx"> case IDBKey::StringType:
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsWebSocketcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -97,7 +97,7 @@
</span><span class="cx"> if (protocol[i] < 0x20 || protocol[i] > 0x7E)
</span><span class="cx"> builder.append(String::format("\\u%04X", protocol[i]));
</span><span class="cx"> else if (protocol[i] == 0x5c)
</span><del>- builder.append("\\\\");
</del><ins>+ builder.appendLiteral("\\\\");
</ins><span class="cx"> else
</span><span class="cx"> builder.append(protocol[i]);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsWebSocketExtensionDispatchercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/WebSocketExtensionDispatcher.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/WebSocketExtensionDispatcher.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/Modules/websockets/WebSocketExtensionDispatcher.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -69,7 +69,7 @@
</span><span class="cx"> StringBuilder builder;
</span><span class="cx"> builder.append(m_processors[0]->handshakeString());
</span><span class="cx"> for (size_t i = 1; i < numProcessors; ++i) {
</span><del>- builder.append(", ");
</del><ins>+ builder.appendLiteral(", ");
</ins><span class="cx"> builder.append(m_processors[i]->handshakeString());
</span><span class="cx"> }
</span><span class="cx"> return builder.toString();
</span><span class="lines">@@ -78,14 +78,14 @@
</span><span class="cx"> void WebSocketExtensionDispatcher::appendAcceptedExtension(const String& extensionToken, HashMap<String, String>& extensionParameters)
</span><span class="cx"> {
</span><span class="cx"> if (!m_acceptedExtensionsBuilder.isEmpty())
</span><del>- m_acceptedExtensionsBuilder.append(", ");
</del><ins>+ m_acceptedExtensionsBuilder.appendLiteral(", ");
</ins><span class="cx"> m_acceptedExtensionsBuilder.append(extensionToken);
</span><span class="cx"> // FIXME: Should use ListHashSet to keep the order of the parameters.
</span><span class="cx"> for (HashMap<String, String>::const_iterator iterator = extensionParameters.begin(); iterator != extensionParameters.end(); ++iterator) {
</span><del>- m_acceptedExtensionsBuilder.append("; ");
</del><ins>+ m_acceptedExtensionsBuilder.appendLiteral("; ");
</ins><span class="cx"> m_acceptedExtensionsBuilder.append(iterator->key);
</span><span class="cx"> if (!iterator->value.isNull()) {
</span><del>- m_acceptedExtensionsBuilder.append("=");
</del><ins>+ m_acceptedExtensionsBuilder.append('=');
</ins><span class="cx"> m_acceptedExtensionsBuilder.append(iterator->value);
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsWebSocketHandshakecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/WebSocketHandshake.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/WebSocketHandshake.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/Modules/websockets/WebSocketHandshake.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -172,7 +172,7 @@
</span><span class="cx"> {
</span><span class="cx"> StringBuilder builder;
</span><span class="cx"> builder.append(m_secure ? "wss" : "ws");
</span><del>- builder.append("://");
</del><ins>+ builder.appendLiteral("://");
</ins><span class="cx"> builder.append(hostName(m_url, m_secure));
</span><span class="cx"> builder.append(resourceName(m_url));
</span><span class="cx"> return builder.toString();
</span><span class="lines">@@ -183,9 +183,9 @@
</span><span class="cx"> // Keep the following consistent with clientHandshakeRequest().
</span><span class="cx"> StringBuilder builder;
</span><span class="cx">
</span><del>- builder.append("GET ");
</del><ins>+ builder.appendLiteral("GET ");
</ins><span class="cx"> builder.append(resourceName(m_url));
</span><del>- builder.append(" HTTP/1.1\r\n");
</del><ins>+ builder.appendLiteral(" HTTP/1.1\r\n");
</ins><span class="cx">
</span><span class="cx"> Vector<String> fields;
</span><span class="cx"> fields.append("Upgrade: websocket");
</span><span class="lines">@@ -226,10 +226,10 @@
</span><span class="cx">
</span><span class="cx"> for (size_t i = 0; i < fields.size(); i++) {
</span><span class="cx"> builder.append(fields[i]);
</span><del>- builder.append("\r\n");
</del><ins>+ builder.appendLiteral("\r\n");
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- builder.append("\r\n");
</del><ins>+ builder.appendLiteral("\r\n");
</ins><span class="cx">
</span><span class="cx"> return builder.toString().utf8();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSCalculationValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSCalculationValue.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSCalculationValue.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/css/CSSCalculationValue.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -159,7 +159,7 @@
</span><span class="cx"> static String buildCssText(const String& expression)
</span><span class="cx"> {
</span><span class="cx"> StringBuilder result;
</span><del>- result.append("calc");
</del><ins>+ result.appendLiteral("calc");
</ins><span class="cx"> bool expressionHasSingleTerm = expression[0] != '(';
</span><span class="cx"> if (expressionHasSingleTerm)
</span><span class="cx"> result.append('(');
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSComputedStyleDeclarationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -1278,7 +1278,7 @@
</span><span class="cx"> if (i)
</span><span class="cx"> result.append(' ');
</span><span class="cx"> result.append(getPropertyName(computedProperties[i]));
</span><del>- result.append(": ", 2);
</del><ins>+ result.appendLiteral(": ");
</ins><span class="cx"> result.append(getPropertyValue(computedProperties[i]));
</span><span class="cx"> result.append(';');
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSMediaRulecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSMediaRule.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSMediaRule.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/css/CSSMediaRule.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx"> String CSSMediaRule::cssText() const
</span><span class="cx"> {
</span><span class="cx"> StringBuilder result;
</span><del>- result.append("@media ");
</del><ins>+ result.appendLiteral("@media ");
</ins><span class="cx"> if (mediaQueries()) {
</span><span class="cx"> result.append(mediaQueries()->mediaText());
</span><span class="cx"> result.append(' ');
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSSelectorListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSSelectorList.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSSelectorList.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/css/CSSSelectorList.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -125,7 +125,7 @@
</span><span class="cx">
</span><span class="cx"> for (const CSSSelector* s = first(); s; s = next(s)) {
</span><span class="cx"> if (s != first())
</span><del>- result.append(", ");
</del><ins>+ result.appendLiteral(", ");
</ins><span class="cx"> result.append(s->selectorText());
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSSupportsRulecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSSupportsRule.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSSupportsRule.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/css/CSSSupportsRule.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -50,9 +50,9 @@
</span><span class="cx"> {
</span><span class="cx"> StringBuilder result;
</span><span class="cx">
</span><del>- result.append("@supports ");
</del><ins>+ result.appendLiteral("@supports ");
</ins><span class="cx"> result.append(conditionText());
</span><del>- result.append(" {\n");
</del><ins>+ result.appendLiteral(" {\n");
</ins><span class="cx"> appendCssTextForItems(result);
</span><span class="cx"> result.append('}');
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecssMediaQuerycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/MediaQuery.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/MediaQuery.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/css/MediaQuery.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -41,10 +41,10 @@
</span><span class="cx"> if (!m_ignored) {
</span><span class="cx"> switch (m_restrictor) {
</span><span class="cx"> case MediaQuery::Only:
</span><del>- result.append("only ");
</del><ins>+ result.appendLiteral("only ");
</ins><span class="cx"> break;
</span><span class="cx"> case MediaQuery::Not:
</span><del>- result.append("not ");
</del><ins>+ result.appendLiteral("not ");
</ins><span class="cx"> break;
</span><span class="cx"> case MediaQuery::None:
</span><span class="cx"> break;
</span><span class="lines">@@ -57,17 +57,17 @@
</span><span class="cx">
</span><span class="cx"> if (m_mediaType != "all" || m_restrictor != None) {
</span><span class="cx"> result.append(m_mediaType);
</span><del>- result.append(" and ");
</del><ins>+ result.appendLiteral(" and ");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> result.append(m_expressions->at(0)->serialize());
</span><span class="cx"> for (size_t i = 1; i < m_expressions->size(); ++i) {
</span><del>- result.append(" and ");
</del><ins>+ result.appendLiteral(" and ");
</ins><span class="cx"> result.append(m_expressions->at(i)->serialize());
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><span class="cx"> // If query is invalid, serialized text should turn into "not all".
</span><del>- result.append("not all");
</del><ins>+ result.appendLiteral("not all");
</ins><span class="cx"> }
</span><span class="cx"> return result.toString();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingMarkupAccumulatorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/MarkupAccumulator.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/MarkupAccumulator.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/editing/MarkupAccumulator.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -493,7 +493,7 @@
</span><span class="cx"> StringBuilder builder;
</span><span class="cx"> do {
</span><span class="cx"> builder.clear();
</span><del>- builder.append("NS");
</del><ins>+ builder.appendLiteral("NS");
</ins><span class="cx"> builder.appendNumber(++m_prefixLevel);
</span><span class="cx"> const AtomicString& name = builder.toAtomicString();
</span><span class="cx"> if (!namespaces.get(name.impl())) {
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingmarkupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/markup.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/markup.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/editing/markup.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -858,11 +858,11 @@
</span><span class="cx"> String urlToMarkup(const URL& url, const String& title)
</span><span class="cx"> {
</span><span class="cx"> StringBuilder markup;
</span><del>- markup.append("<a href=\"");
</del><ins>+ markup.appendLiteral("<a href=\"");
</ins><span class="cx"> markup.append(url.string());
</span><del>- markup.append("\">");
</del><ins>+ markup.appendLiteral("\">");
</ins><span class="cx"> MarkupAccumulator::appendCharactersReplacingEntities(markup, title, 0, title.length(), EntityMaskInPCDATA);
</span><del>- markup.append("</a>");
</del><ins>+ markup.appendLiteral("</a>");
</ins><span class="cx"> return markup.toString();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorefileapiFileReaderLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/fileapi/FileReaderLoader.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/fileapi/FileReaderLoader.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/fileapi/FileReaderLoader.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -326,7 +326,7 @@
</span><span class="cx"> void FileReaderLoader::convertToDataURL()
</span><span class="cx"> {
</span><span class="cx"> StringBuilder builder;
</span><del>- builder.append("data:");
</del><ins>+ builder.appendLiteral("data:");
</ins><span class="cx">
</span><span class="cx"> if (!m_bytesLoaded) {
</span><span class="cx"> m_stringResult = builder.toString();
</span><span class="lines">@@ -334,7 +334,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> builder.append(m_dataType);
</span><del>- builder.append(";base64,");
</del><ins>+ builder.appendLiteral(";base64,");
</ins><span class="cx">
</span><span class="cx"> Vector<char> out;
</span><span class="cx"> base64Encode(m_rawData->data(), m_bytesLoaded, out);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlEmailInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/EmailInputType.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/EmailInputType.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/html/EmailInputType.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -102,7 +102,7 @@
</span><span class="cx"> StringBuilder strippedValue;
</span><span class="cx"> for (unsigned i = 0; i < addresses.size(); ++i) {
</span><span class="cx"> if (i > 0)
</span><del>- strippedValue.append(",");
</del><ins>+ strippedValue.append(',');
</ins><span class="cx"> strippedValue.append(stripLeadingAndTrailingHTMLSpaces(addresses[i]));
</span><span class="cx"> }
</span><span class="cx"> return strippedValue.toString();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlFormControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/FormController.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/FormController.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/html/FormController.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -302,7 +302,7 @@
</span><span class="cx"> // 2 is enough to distinguish forms in webkit.org/b/91209#c0
</span><span class="cx"> const size_t namedControlsToBeRecorded = 2;
</span><span class="cx"> const Vector<FormAssociatedElement*>& controls = form.associatedElements();
</span><del>- builder.append(" [");
</del><ins>+ builder.appendLiteral(" [");
</ins><span class="cx"> for (size_t i = 0, namedControls = 0; i < controls.size() && namedControls < namedControlsToBeRecorded; ++i) {
</span><span class="cx"> if (!controls[i]->isFormControlElementWithState())
</span><span class="cx"> continue;
</span><span class="lines">@@ -314,9 +314,9 @@
</span><span class="cx"> continue;
</span><span class="cx"> namedControls++;
</span><span class="cx"> builder.append(name);
</span><del>- builder.append(" ");
</del><ins>+ builder.append(' ');
</ins><span class="cx"> }
</span><del>- builder.append("]");
</del><ins>+ builder.append(']');
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static inline String formSignature(const HTMLFormElement& form)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlparserXSSAuditorDelegatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/parser/XSSAuditorDelegate.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/parser/XSSAuditorDelegate.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/html/parser/XSSAuditorDelegate.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -53,20 +53,20 @@
</span><span class="cx"> static inline String buildConsoleError(const XSSInfo& xssInfo)
</span><span class="cx"> {
</span><span class="cx"> StringBuilder message;
</span><del>- message.append("The XSS Auditor ");
</del><ins>+ message.appendLiteral("The XSS Auditor ");
</ins><span class="cx"> message.append(xssInfo.m_didBlockEntirePage ? "blocked access to" : "refused to execute a script in");
</span><del>- message.append(" '");
</del><ins>+ message.appendLiteral(" '");
</ins><span class="cx"> message.append(xssInfo.m_originalURL);
</span><del>- message.append("' because ");
</del><ins>+ message.appendLiteral("' because ");
</ins><span class="cx"> message.append(xssInfo.m_didBlockEntirePage ? "the source code of a script" : "its source code");
</span><del>- message.append(" was found within the request.");
</del><ins>+ message.appendLiteral(" was found within the request.");
</ins><span class="cx">
</span><span class="cx"> if (xssInfo.m_didSendCSPHeader)
</span><del>- message.append(" The server sent a 'Content-Security-Policy' header requesting this behavior.");
</del><ins>+ message.appendLiteral(" The server sent a 'Content-Security-Policy' header requesting this behavior.");
</ins><span class="cx"> else if (xssInfo.m_didSendXSSProtectionHeader)
</span><del>- message.append(" The server sent an 'X-XSS-Protection' header requesting this behavior.");
</del><ins>+ message.appendLiteral(" The server sent an 'X-XSS-Protection' header requesting this behavior.");
</ins><span class="cx"> else
</span><del>- message.append(" The auditor was enabled as the server sent neither an 'X-XSS-Protection' nor 'Content-Security-Policy' header.");
</del><ins>+ message.appendLiteral(" The auditor was enabled as the server sent neither an 'X-XSS-Protection' nor 'Content-Security-Policy' header.");
</ins><span class="cx">
</span><span class="cx"> return message.toString();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackWebVTTParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/WebVTTParser.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/WebVTTParser.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/html/track/WebVTTParser.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -349,7 +349,7 @@
</span><span class="cx"> return recoverCue(line);
</span><span class="cx"> }
</span><span class="cx"> if (!m_currentContent.isEmpty())
</span><del>- m_currentContent.append("\n");
</del><ins>+ m_currentContent.append('\n');
</ins><span class="cx"> m_currentContent.append(line);
</span><span class="cx">
</span><span class="cx"> return CueText;
</span></span></pre></div>
<a id="trunkSourceWebCoremathmlMathMLMencloseElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/mathml/MathMLMencloseElement.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/mathml/MathMLMencloseElement.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/mathml/MathMLMencloseElement.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -129,15 +129,13 @@
</span><span class="cx"> String MathMLMencloseElement::longDivLeftPadding() const
</span><span class="cx"> {
</span><span class="cx"> StringBuilder padding;
</span><del>- float fontSize = 0;
</del><span class="cx"> String closingBrace = ")";
</span><span class="cx"> TextRun run(closingBrace.impl(), closingBrace.length());
</span><span class="cx"> Node* node = parentNode();
</span><span class="cx"> if (node && node->renderer()) {
</span><span class="cx"> const Font& font = node->renderer()->style().font();
</span><del>- fontSize = font.width(run);
- padding.append(String::number(fontSize));
- padding.append("px");
</del><ins>+ padding.appendNumber(font.width(run));
+ padding.appendLiteral("px");
</ins><span class="cx"> }
</span><span class="cx"> return padding.toString();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageSerializercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/PageSerializer.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/PageSerializer.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/page/PageSerializer.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -136,9 +136,9 @@
</span><span class="cx"> MarkupAccumulator::appendElement(out, element, namespaces);
</span><span class="cx">
</span><span class="cx"> if (element.hasTagName(HTMLNames::headTag)) {
</span><del>- out.append("<meta charset=\"");
</del><ins>+ out.appendLiteral("<meta charset=\"");
</ins><span class="cx"> out.append(m_document.charset());
</span><del>- out.append("\">");
</del><ins>+ out.appendLiteral("\">");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // FIXME: For object (plugins) tags and video tag we could replace them by an image of their current contents.
</span></span></pre></div>
<a id="trunkSourceWebCorepageSecurityOrigincpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/SecurityOrigin.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/SecurityOrigin.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/page/SecurityOrigin.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -477,7 +477,7 @@
</span><span class="cx"> StringBuilder result;
</span><span class="cx"> result.reserveCapacity(m_protocol.length() + m_host.length() + 10);
</span><span class="cx"> result.append(m_protocol);
</span><del>- result.append("://");
</del><ins>+ result.appendLiteral("://");
</ins><span class="cx"> result.append(m_host);
</span><span class="cx">
</span><span class="cx"> if (m_port) {
</span></span></pre></div>
<a id="trunkSourceWebCorepagescrollingScrollingCoordinatorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -395,15 +395,15 @@
</span><span class="cx"> StringBuilder stringBuilder;
</span><span class="cx">
</span><span class="cx"> if (reasons & ScrollingCoordinator::ForcedOnMainThread)
</span><del>- stringBuilder.append("Forced on main thread, ");
</del><ins>+ stringBuilder.appendLiteral("Forced on main thread, ");
</ins><span class="cx"> if (reasons & ScrollingCoordinator::HasSlowRepaintObjects)
</span><del>- stringBuilder.append("Has slow repaint objects, ");
</del><ins>+ stringBuilder.appendLiteral("Has slow repaint objects, ");
</ins><span class="cx"> if (reasons & ScrollingCoordinator::HasViewportConstrainedObjectsWithoutSupportingFixedLayers)
</span><del>- stringBuilder.append("Has viewport constrained objects without supporting fixed layers, ");
</del><ins>+ stringBuilder.appendLiteral("Has viewport constrained objects without supporting fixed layers, ");
</ins><span class="cx"> if (reasons & ScrollingCoordinator::HasNonLayerViewportConstrainedObjects)
</span><del>- stringBuilder.append("Has non-layer viewport-constrained objects, ");
</del><ins>+ stringBuilder.appendLiteral("Has non-layer viewport-constrained objects, ");
</ins><span class="cx"> if (reasons & ScrollingCoordinator::IsImageDocument)
</span><del>- stringBuilder.append("Is image document, ");
</del><ins>+ stringBuilder.appendLiteral("Is image document, ");
</ins><span class="cx">
</span><span class="cx"> if (stringBuilder.length())
</span><span class="cx"> stringBuilder.resize(stringBuilder.length() - 2);
</span></span></pre></div>
<a id="trunkSourceWebCorepagescrollingmacScrollingTreeFrameScrollingNodeMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -517,15 +517,15 @@
</span><span class="cx"> StringBuilder reasonsDescription;
</span><span class="cx">
</span><span class="cx"> if (synchronousScrollingReasons & ScrollingCoordinator::ForcedOnMainThread)
</span><del>- reasonsDescription.append("forced,");
</del><ins>+ reasonsDescription.appendLiteral("forced,");
</ins><span class="cx"> if (synchronousScrollingReasons & ScrollingCoordinator::HasSlowRepaintObjects)
</span><del>- reasonsDescription.append("slow-repaint objects,");
</del><ins>+ reasonsDescription.appendLiteral("slow-repaint objects,");
</ins><span class="cx"> if (synchronousScrollingReasons & ScrollingCoordinator::HasViewportConstrainedObjectsWithoutSupportingFixedLayers)
</span><del>- reasonsDescription.append("viewport-constrained objects,");
</del><ins>+ reasonsDescription.appendLiteral("viewport-constrained objects,");
</ins><span class="cx"> if (synchronousScrollingReasons & ScrollingCoordinator::HasNonLayerViewportConstrainedObjects)
</span><del>- reasonsDescription.append("non-layer viewport-constrained objects,");
</del><ins>+ reasonsDescription.appendLiteral("non-layer viewport-constrained objects,");
</ins><span class="cx"> if (synchronousScrollingReasons & ScrollingCoordinator::IsImageDocument)
</span><del>- reasonsDescription.append("image document,");
</del><ins>+ reasonsDescription.appendLiteral("image document,");
</ins><span class="cx">
</span><span class="cx"> // Strip the trailing comma.
</span><span class="cx"> String reasonsDescriptionTrimmed = reasonsDescription.toString().left(reasonsDescription.length() - 1);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformPODIntervalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/PODInterval.h (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/PODInterval.h 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/platform/PODInterval.h 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -144,7 +144,7 @@
</span><span class="cx"> builder.append(ValueToString<UserData>::string(data()));
</span><span class="cx"> builder.append(", maxHigh=");
</span><span class="cx"> builder.append(ValueToString<T>::string(maxHigh()));
</span><del>- builder.append("]");
</del><ins>+ builder.append(']');
</ins><span class="cx"> return builder.toString();
</span><span class="cx"> }
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformPODRedBlackTreeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/PODRedBlackTree.h (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/PODRedBlackTree.h 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/platform/PODRedBlackTree.h 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -792,10 +792,10 @@
</span><span class="cx"> {
</span><span class="cx"> StringBuilder builder;
</span><span class="cx"> for (int i = 0; i < indentation; i++)
</span><del>- builder.append(" ");
- builder.append("-");
</del><ins>+ builder.append(' ');
+ builder.append('-');
</ins><span class="cx"> if (node) {
</span><del>- builder.append(" ");
</del><ins>+ builder.append(' ');
</ins><span class="cx"> builder.append(ValueToString<T>::string(node->data()));
</span><span class="cx"> builder.append((node->color() == Black) ? " (black)" : " (red)");
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformUUIDcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/UUID.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/UUID.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/platform/UUID.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -46,14 +46,14 @@
</span><span class="cx"> StringBuilder builder;
</span><span class="cx"> builder.reserveCapacity(36);
</span><span class="cx"> appendUnsignedAsHexFixedSize(randomData[0], builder, 8, Lowercase);
</span><del>- builder.append("-");
</del><ins>+ builder.append('-');
</ins><span class="cx"> appendUnsignedAsHexFixedSize(randomData[1] >> 16, builder, 4, Lowercase);
</span><del>- builder.append("-4");
</del><ins>+ builder.appendLiteral("-4");
</ins><span class="cx"> appendUnsignedAsHexFixedSize(randomData[1] & 0x00000fff, builder, 3, Lowercase);
</span><del>- builder.append("-");
</del><ins>+ builder.append('-');
</ins><span class="cx"> appendUnsignedAsHexFixedSize((randomData[2] >> 30) | 0x8, builder, 1, Lowercase);
</span><span class="cx"> appendUnsignedAsHexFixedSize((randomData[2] >> 16) & 0x00000fff, builder, 3, Lowercase);
</span><del>- builder.append("-");
</del><ins>+ builder.append('-');
</ins><span class="cx"> appendUnsignedAsHexFixedSize(randomData[2] & 0x0000ffff, builder, 4, Lowercase);
</span><span class="cx"> appendUnsignedAsHexFixedSize(randomData[3], builder, 8, Lowercase);
</span><span class="cx"> return builder.toString();
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkProxyServercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/ProxyServer.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/ProxyServer.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/platform/network/ProxyServer.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -34,14 +34,14 @@
</span><span class="cx"> {
</span><span class="cx"> switch (proxyServer.type()) {
</span><span class="cx"> case ProxyServer::Direct:
</span><del>- builder.append("DIRECT");
</del><ins>+ builder.appendLiteral("DIRECT");
</ins><span class="cx"> return;
</span><span class="cx"> case ProxyServer::HTTP:
</span><span class="cx"> case ProxyServer::HTTPS:
</span><del>- builder.append("PROXY");
</del><ins>+ builder.appendLiteral("PROXY");
</ins><span class="cx"> break;
</span><span class="cx"> case ProxyServer::SOCKS:
</span><del>- builder.append("SOCKS");
</del><ins>+ builder.appendLiteral("SOCKS");
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx"> StringBuilder stringBuilder;
</span><span class="cx"> for (size_t i = 0; i < proxyServers.size(); ++i) {
</span><span class="cx"> if (i)
</span><del>- stringBuilder.append("; ");
</del><ins>+ stringBuilder.appendLiteral("; ");
</ins><span class="cx">
</span><span class="cx"> appendProxyServerString(stringBuilder, proxyServers[i]);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformtextDateTimeFormatcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/text/DateTimeFormat.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/text/DateTimeFormat.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/platform/text/DateTimeFormat.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -257,9 +257,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (literal.find('\'') == notFound) {
</span><del>- buffer.append("'");
</del><ins>+ buffer.append('\'');
</ins><span class="cx"> buffer.append(literal);
</span><del>- buffer.append("'");
</del><ins>+ buffer.append('\'');
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -268,10 +268,10 @@
</span><span class="cx"> buffer.append("''");
</span><span class="cx"> else {
</span><span class="cx"> String escaped = literal.substring(i);
</span><del>- escaped.replace(ASCIILiteral("'"), ASCIILiteral("''"));
- buffer.append("'");
</del><ins>+ escaped.replace('\'', "''");
+ buffer.append('\'');
</ins><span class="cx"> buffer.append(escaped);
</span><del>- buffer.append("'");
</del><ins>+ buffer.append('\'');
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformtextPlatformLocalecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/text/PlatformLocale.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/text/PlatformLocale.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/platform/text/PlatformLocale.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -81,7 +81,7 @@
</span><span class="cx"> StringBuilder zeroPaddedStringBuilder;
</span><span class="cx"> zeroPaddedStringBuilder.reserveCapacity(width);
</span><span class="cx"> for (size_t i = string.length(); i < width; ++i)
</span><del>- zeroPaddedStringBuilder.append("0");
</del><ins>+ zeroPaddedStringBuilder.append('0');
</ins><span class="cx"> zeroPaddedStringBuilder.append(string);
</span><span class="cx"> return zeroPaddedStringBuilder.toString();
</span><span class="cx"> }
</span><span class="lines">@@ -311,7 +311,7 @@
</span><span class="cx"> StringBuilder builder;
</span><span class="cx"> builder.reserveCapacity(input.length());
</span><span class="cx"> if (isNegative)
</span><del>- builder.append("-");
</del><ins>+ builder.append('-');
</ins><span class="cx"> for (unsigned i = startIndex; i < endIndex;) {
</span><span class="cx"> unsigned symbolIndex = matchedDecimalSymbolIndex(input, i);
</span><span class="cx"> if (symbolIndex >= DecimalSymbolsSize)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformtextTextStreamcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/text/TextStream.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/text/TextStream.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/platform/text/TextStream.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -91,13 +91,13 @@
</span><span class="cx">
</span><span class="cx"> TextStream& TextStream::operator<<(float f)
</span><span class="cx"> {
</span><del>- m_text.append(String::numberToStringFixedWidth(f, 2));
</del><ins>+ m_text.appendFixedWidthNumber(f, 2);
</ins><span class="cx"> return *this;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> TextStream& TextStream::operator<<(double d)
</span><span class="cx"> {
</span><del>- m_text.append(String::numberToStringFixedWidth(d, 2));
</del><ins>+ m_text.appendFixedWidthNumber(d, 2);
</ins><span class="cx"> return *this;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderListMarkercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderListMarker.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderListMarker.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/rendering/RenderListMarker.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -644,7 +644,7 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> if (value < 0) {
</span><del>- builder.append("-0");
</del><ins>+ builder.appendLiteral("-0");
</ins><span class="cx"> builder.appendNumber(-value); // -01 to -09
</span><span class="cx"> break;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (173211 => 173212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp 2014-09-03 17:57:25 UTC (rev 173211)
+++ trunk/Source/WebCore/testing/Internals.cpp 2014-09-03 18:42:54 UTC (rev 173212)
</span><span class="lines">@@ -1213,25 +1213,25 @@
</span><span class="cx"> if (executable->isFunctionExecutable()) {
</span><span class="cx"> FunctionExecutable* funcExecutable = reinterpret_cast<FunctionExecutable*>(executable);
</span><span class="cx"> String inferredName = funcExecutable->inferredName().string();
</span><del>- result.append("function \"");
</del><ins>+ result.appendLiteral("function \"");
</ins><span class="cx"> result.append(inferredName);
</span><del>- result.append("\"");
</del><ins>+ result.append('"');
</ins><span class="cx"> } else if (executable->isEvalExecutable())
</span><del>- result.append("eval");
</del><ins>+ result.appendLiteral("eval");
</ins><span class="cx"> else {
</span><span class="cx"> ASSERT(executable->isProgramExecutable());
</span><del>- result.append("program");
</del><ins>+ result.appendLiteral("program");
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- result.append(" { ");
</del><ins>+ result.appendLiteral(" { ");
</ins><span class="cx"> result.appendNumber(startLine);
</span><del>- result.append(":");
</del><ins>+ result.append(':');
</ins><span class="cx"> result.appendNumber(startColumn);
</span><del>- result.append(" - ");
</del><ins>+ result.appendLiteral(" - ");
</ins><span class="cx"> result.appendNumber(endLine);
</span><del>- result.append(":");
</del><ins>+ result.append(':');
</ins><span class="cx"> result.appendNumber(endColumn);
</span><del>- result.append(" }");
</del><ins>+ result.appendLiteral(" }");
</ins><span class="cx">
</span><span class="cx"> return result.toString();
</span><span class="cx"> }
</span><span class="lines">@@ -1996,22 +1996,22 @@
</span><span class="cx"> Cursor cursor = document->frame()->eventHandler().currentMouseCursor();
</span><span class="cx">
</span><span class="cx"> StringBuilder result;
</span><del>- result.append("type=");
</del><ins>+ result.appendLiteral("type=");
</ins><span class="cx"> result.append(cursorTypeToString(cursor.type()));
</span><del>- result.append(" hotSpot=");
</del><ins>+ result.appendLiteral(" hotSpot=");
</ins><span class="cx"> result.appendNumber(cursor.hotSpot().x());
</span><del>- result.append(",");
</del><ins>+ result.append(',');
</ins><span class="cx"> result.appendNumber(cursor.hotSpot().y());
</span><span class="cx"> if (cursor.image()) {
</span><span class="cx"> FloatSize size = cursor.image()->size();
</span><del>- result.append(" image=");
</del><ins>+ result.appendLiteral(" image=");
</ins><span class="cx"> result.appendNumber(size.width());
</span><del>- result.append("x");
</del><ins>+ result.append('x');
</ins><span class="cx"> result.appendNumber(size.height());
</span><span class="cx"> }
</span><span class="cx"> #if ENABLE(MOUSE_CURSOR_SCALE)
</span><span class="cx"> if (cursor.imageScaleFactor() != 1) {
</span><del>- result.append(" scale=");
</del><ins>+ result.appendLiteral(" scale=");
</ins><span class="cx"> NumberToStringBuffer buffer;
</span><span class="cx"> result.append(numberToFixedPrecisionString(cursor.imageScaleFactor(), 8, buffer, true));
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>