<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173220] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173220">173220</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2014-09-03 13:18:36 -0700 (Wed, 03 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Get rid of DOMImplementationFront
https://bugs.webkit.org/show_bug.cgi?id=136495
Reviewed by Andreas Kling.
DOMImplementationFront was used in a workaround for a GCC bug, and since we're building with clang
on Mac this is no longer an issue.
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOMImplementationFront.cpp: Removed.
* bindings/objc/DOMImplementationFront.h: Removed.
Remove files.
* bindings/objc/DOMUtility.mm:
(JSC::createDOMWrapper):
Remove call to implementationFront.
* bindings/scripts/CodeGeneratorObjC.pm:
(GetImplClassName):
Remove DOMImplementation special case
(AddIncludesForType):
Ditto.
(GenerateHeader):
Use the class header name in the #import in the internal header.
(GenerateImplementation):
Remove DOMImplementation special case.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebCorebindingsobjcDOMUtilitymm">trunk/Source/WebCore/bindings/objc/DOMUtility.mm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorObjCpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceWebCorebindingsobjcDOMImplementationFrontcpp">trunk/Source/WebCore/bindings/objc/DOMImplementationFront.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsobjcDOMImplementationFronth">trunk/Source/WebCore/bindings/objc/DOMImplementationFront.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (173219 => 173220)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-09-03 20:12:31 UTC (rev 173219)
+++ trunk/Source/WebCore/ChangeLog 2014-09-03 20:18:36 UTC (rev 173220)
</span><span class="lines">@@ -1,3 +1,35 @@
</span><ins>+2014-09-03 Anders Carlsson <andersca@apple.com>
+
+ Get rid of DOMImplementationFront
+ https://bugs.webkit.org/show_bug.cgi?id=136495
+
+ Reviewed by Andreas Kling.
+
+ DOMImplementationFront was used in a workaround for a GCC bug, and since we're building with clang
+ on Mac this is no longer an issue.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/objc/DOMImplementationFront.cpp: Removed.
+ * bindings/objc/DOMImplementationFront.h: Removed.
+ Remove files.
+
+ * bindings/objc/DOMUtility.mm:
+ (JSC::createDOMWrapper):
+ Remove call to implementationFront.
+
+ * bindings/scripts/CodeGeneratorObjC.pm:
+ (GetImplClassName):
+ Remove DOMImplementation special case
+
+ (AddIncludesForType):
+ Ditto.
+
+ (GenerateHeader):
+ Use the class header name in the #import in the internal header.
+
+ (GenerateImplementation):
+ Remove DOMImplementation special case.
+
</ins><span class="cx"> 2014-09-03 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Improper release of unretained AVCFAssetResourceLoaderRef
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (173219 => 173220)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-09-03 20:12:31 UTC (rev 173219)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-09-03 20:18:36 UTC (rev 173220)
</span><span class="lines">@@ -3290,8 +3290,6 @@
</span><span class="cx"> 93C4A4151629DF5A00C3EB6E /* ScrollingTreeFrameScrollingNodeMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 93C4A4131629DF5A00C3EB6E /* ScrollingTreeFrameScrollingNodeMac.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><span class="cx"> 93C4A4161629DF5A00C3EB6E /* ScrollingTreeFrameScrollingNodeMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 93C4A4141629DF5A00C3EB6E /* ScrollingTreeFrameScrollingNodeMac.mm */; };
</span><span class="cx"> 93C4F6EB1108F9A50099D0DB /* AccessibilityScrollbar.h in Headers */ = {isa = PBXBuildFile; fileRef = 93C4F6E91108F9A50099D0DB /* AccessibilityScrollbar.h */; };
</span><del>- 93C841F809CE855C00DFF5E5 /* DOMImplementationFront.h in Headers */ = {isa = PBXBuildFile; fileRef = 93C841F709CE855C00DFF5E5 /* DOMImplementationFront.h */; };
- 93C841FF09CE858300DFF5E5 /* DOMImplementationFront.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93C841FE09CE858300DFF5E5 /* DOMImplementationFront.cpp */; };
</del><span class="cx"> 93CCF0270AF6C52900018E89 /* NavigationAction.h in Headers */ = {isa = PBXBuildFile; fileRef = 93CCF0260AF6C52900018E89 /* NavigationAction.h */; settings = {ATTRIBUTES = (Private, ); }; };
</span><span class="cx"> 93CCF0600AF6CA7600018E89 /* NavigationAction.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93CCF05F0AF6CA7600018E89 /* NavigationAction.cpp */; };
</span><span class="cx"> 93D3C1590F97A9D70053C013 /* DOMHTMLCanvasElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 93D3C1580F97A9D70053C013 /* DOMHTMLCanvasElement.h */; };
</span><span class="lines">@@ -10411,8 +10409,6 @@
</span><span class="cx"> 93C4A4131629DF5A00C3EB6E /* ScrollingTreeFrameScrollingNodeMac.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ScrollingTreeFrameScrollingNodeMac.h; sourceTree = "<group>"; };
</span><span class="cx"> 93C4A4141629DF5A00C3EB6E /* ScrollingTreeFrameScrollingNodeMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ScrollingTreeFrameScrollingNodeMac.mm; sourceTree = "<group>"; };
</span><span class="cx"> 93C4F6E91108F9A50099D0DB /* AccessibilityScrollbar.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AccessibilityScrollbar.h; sourceTree = "<group>"; };
</span><del>- 93C841F709CE855C00DFF5E5 /* DOMImplementationFront.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMImplementationFront.h; sourceTree = "<group>"; };
- 93C841FE09CE858300DFF5E5 /* DOMImplementationFront.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DOMImplementationFront.cpp; sourceTree = "<group>"; };
</del><span class="cx"> 93CA4C9909DF93FA00DF8677 /* html.css */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = html.css; sourceTree = "<group>"; };
</span><span class="cx"> 93CA4C9A09DF93FA00DF8677 /* make-css-file-arrays.pl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.script.perl; path = "make-css-file-arrays.pl"; sourceTree = "<group>"; };
</span><span class="cx"> 93CA4C9B09DF93FA00DF8677 /* makeprop.pl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = makeprop.pl; sourceTree = "<group>"; };
</span><span class="lines">@@ -16759,8 +16755,6 @@
</span><span class="cx"> 854F12AC0A8EBC18000940B5 /* Core */ = {
</span><span class="cx"> isa = PBXGroup;
</span><span class="cx"> children = (
</span><del>- 93C841FE09CE858300DFF5E5 /* DOMImplementationFront.cpp */,
- 93C841F709CE855C00DFF5E5 /* DOMImplementationFront.h */,
</del><span class="cx"> 856C8AE20A912649005C687B /* DOMObject.h */,
</span><span class="cx"> 856C8AE30A912649005C687B /* DOMObject.mm */,
</span><span class="cx"> );
</span><span class="lines">@@ -23946,7 +23940,6 @@
</span><span class="cx"> 85BA4D170AA688680088052D /* DOMHTMLUListElement.h in Headers */,
</span><span class="cx"> 85E711D00AC5D5350053270F /* DOMHTMLUListElementInternal.h in Headers */,
</span><span class="cx"> A8185F3B09765766005826D9 /* DOMImplementation.h in Headers */,
</span><del>- 93C841F809CE855C00DFF5E5 /* DOMImplementationFront.h in Headers */,
</del><span class="cx"> BC1A37B9097C715F0019F3D8 /* DOMInternal.h in Headers */,
</span><span class="cx"> 85FF315A0AAFBFCB00374F38 /* DOMKeyboardEvent.h in Headers */,
</span><span class="cx"> 85989DCC0ACC8BBD00A0BC51 /* DOMKeyboardEventInternal.h in Headers */,
</span><span class="lines">@@ -27489,7 +27482,6 @@
</span><span class="cx"> 85992EC10AA5069500AC0785 /* DOMHTMLTitleElement.mm in Sources */,
</span><span class="cx"> 85BA4D180AA688680088052D /* DOMHTMLUListElement.mm in Sources */,
</span><span class="cx"> A8185F3E09765766005826D9 /* DOMImplementation.cpp in Sources */,
</span><del>- 93C841FF09CE858300DFF5E5 /* DOMImplementationFront.cpp in Sources */,
</del><span class="cx"> BC1A37BA097C715F0019F3D8 /* DOMInternal.mm in Sources */,
</span><span class="cx"> 85FF315B0AAFBFCB00374F38 /* DOMKeyboardEvent.mm in Sources */,
</span><span class="cx"> 850656FF0AAB4763002D15C0 /* DOMMediaList.mm in Sources */,
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsobjcDOMImplementationFrontcpp"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/bindings/objc/DOMImplementationFront.cpp (173219 => 173220)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/objc/DOMImplementationFront.cpp 2014-09-03 20:12:31 UTC (rev 173219)
+++ trunk/Source/WebCore/bindings/objc/DOMImplementationFront.cpp 2014-09-03 20:18:36 UTC (rev 173220)
</span><span class="lines">@@ -1,82 +0,0 @@
</span><del>-/*
- * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB. If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- *
- */
-
-#include "config.h"
-#include "DOMImplementationFront.h"
-
-#include "CSSStyleSheet.h"
-#include "DocumentType.h"
-#include "DOMImplementation.h"
-#include "HTMLDocument.h"
-#include "JSDOMImplementation.h"
-
-namespace WebCore {
-
-DOMImplementationFront* implementationFront(Document* document)
-{
- return reinterpret_cast<DOMImplementationFront*>(document->implementation());
-}
-
-DOMImplementationFront* implementationFront(JSDOMImplementation* wrapper)
-{
- return reinterpret_cast<DOMImplementationFront*>(&wrapper->impl());
-}
-
-void DOMImplementationFront::ref()
-{
- reinterpret_cast<DOMImplementation*>(this)->ref();
-}
-
-void DOMImplementationFront::deref()
-{
- reinterpret_cast<DOMImplementation*>(this)->deref();
-}
-
-bool DOMImplementationFront::hasFeature(const String& feature, const String& version) const
-{
- return reinterpret_cast<const DOMImplementation*>(this)->hasFeature(feature, version);
-}
-
-PassRefPtr<DocumentType> DOMImplementationFront::createDocumentType(const String& qualifiedName, const String& publicId, const String& systemId, ExceptionCode& ec)
-{
- return reinterpret_cast<DOMImplementation*>(this)->createDocumentType(qualifiedName, publicId, systemId, ec);
-}
-
-PassRefPtr<Document> DOMImplementationFront::createDocument(const String& namespaceURI, const String& qualifiedName, DocumentType* type, ExceptionCode& ec)
-{
- return reinterpret_cast<DOMImplementation*>(this)->createDocument(namespaceURI, qualifiedName, type, ec);
-}
-
-DOMImplementationFront* DOMImplementationFront::getInterface(const String& feature)
-{
- return reinterpret_cast<DOMImplementationFront*>(reinterpret_cast<DOMImplementation*>(this)->getInterface(feature));
-}
-
-PassRefPtr<CSSStyleSheet> DOMImplementationFront::createCSSStyleSheet(const String& title, const String& media, ExceptionCode& ec)
-{
- return reinterpret_cast<DOMImplementation*>(this)->createCSSStyleSheet(title, media, ec);
-}
-
-PassRefPtr<HTMLDocument> DOMImplementationFront::createHTMLDocument(const String& title)
-{
- return reinterpret_cast<DOMImplementation*>(this)->createHTMLDocument(title);
-}
-
-} //namespace
</del></span></pre></div>
<a id="trunkSourceWebCorebindingsobjcDOMImplementationFronth"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebCore/bindings/objc/DOMImplementationFront.h (173219 => 173220)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/objc/DOMImplementationFront.h 2014-09-03 20:12:31 UTC (rev 173219)
+++ trunk/Source/WebCore/bindings/objc/DOMImplementationFront.h 2014-09-03 20:18:36 UTC (rev 173220)
</span><span class="lines">@@ -1,60 +0,0 @@
</span><del>-/*
- * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
- * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB. If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- *
- */
-
-#ifndef DOMImplementationFront_h
-#define DOMImplementationFront_h
-
-// FIXME: This source file exists to work around a problem that occurs trying
-// to mix DOMImplementation and WebCore::DOMImplementation in DOM.mm.
-// It seems to affect only older versions of gcc. Once the buildbot is upgraded,
-// we should consider increasing the minimum required version of gcc to build
-// WebCore, and rolling the change that introduced this file back.
-
-#include <wtf/Forward.h>
-
-namespace WebCore {
-
-class CSSStyleSheet;
-class Document;
-class DocumentType;
-class HTMLDocument;
-class JSDOMImplementation;
-
-typedef int ExceptionCode;
-
-class DOMImplementationFront {
-public:
- void ref();
- void deref();
- bool hasFeature(const String& feature, const String& version) const;
- PassRefPtr<DocumentType> createDocumentType(const String& qualifiedName, const String& publicId, const String& systemId, ExceptionCode&);
- PassRefPtr<Document> createDocument(const String& namespaceURI, const String& qualifiedName, DocumentType*, ExceptionCode&);
- DOMImplementationFront* getInterface(const String& feature);
- PassRefPtr<CSSStyleSheet> createCSSStyleSheet(const String& title, const String& media, ExceptionCode&);
- PassRefPtr<HTMLDocument> createHTMLDocument(const String& title);
-};
-
-DOMImplementationFront* implementationFront(Document*);
-DOMImplementationFront* implementationFront(JSDOMImplementation*);
-
-} // namespace WebCore
-
-#endif // DOMImplementationFront_h
</del></span></pre></div>
<a id="trunkSourceWebCorebindingsobjcDOMUtilitymm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/objc/DOMUtility.mm (173219 => 173220)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/objc/DOMUtility.mm 2014-09-03 20:12:31 UTC (rev 173219)
+++ trunk/Source/WebCore/bindings/objc/DOMUtility.mm 2014-09-03 20:18:36 UTC (rev 173220)
</span><span class="lines">@@ -32,9 +32,9 @@
</span><span class="cx"> #import "DOMCSSStyleDeclarationInternal.h"
</span><span class="cx"> #import "DOMCSSValueInternal.h"
</span><span class="cx"> #import "DOMCounterInternal.h"
</span><ins>+#import "DOMDOMImplementationInternal.h"
</ins><span class="cx"> #import "DOMEventInternal.h"
</span><span class="cx"> #import "DOMHTMLCollectionInternal.h"
</span><del>-#import "DOMImplementationFront.h"
</del><span class="cx"> #import "DOMInternal.h"
</span><span class="cx"> #import "DOMMediaListInternal.h"
</span><span class="cx"> #import "DOMNamedNodeMapInternal.h"
</span><span class="lines">@@ -76,9 +76,6 @@
</span><span class="cx"> #import "WebScriptObjectPrivate.h"
</span><span class="cx"> #import "runtime_root.h"
</span><span class="cx">
</span><del>-// FIXME: Couldn't get an include of "DOMDOMImplementationInternal.h" to work here.
-DOMImplementation *kit(WebCore::DOMImplementationFront*);
-
</del><span class="cx"> // This file makes use of both the ObjC DOM API and the C++ DOM API, so we need to be careful about what
</span><span class="cx"> // headers are included and what namespaces we use to avoid naming conflicts.
</span><span class="cx">
</span><span class="lines">@@ -127,7 +124,7 @@
</span><span class="cx"> return kit(&static_cast<WebCore::JSDOMWindowShell*>(object)->impl());
</span><span class="cx">
</span><span class="cx"> if (object->inherits(WebCore::JSDOMImplementation::info()))
</span><del>- return kit(implementationFront(static_cast<WebCore::JSDOMImplementation*>(object)));
</del><ins>+ return kit(&static_cast<WebCore::JSDOMImplementation*>(object)->impl());
</ins><span class="cx">
</span><span class="cx"> return nil;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorObjCpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm (173219 => 173220)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2014-09-03 20:12:31 UTC (rev 173219)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2014-09-03 20:18:36 UTC (rev 173220)
</span><span class="lines">@@ -420,7 +420,6 @@
</span><span class="cx"> {
</span><span class="cx"> my $name = shift;
</span><span class="cx">
</span><del>- return "DOMImplementationFront" if $name eq "DOMImplementation";
</del><span class="cx"> return "DOMWindow" if $name eq "AbstractView";
</span><span class="cx"> return $name;
</span><span class="cx"> }
</span><span class="lines">@@ -680,12 +679,6 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ($type eq "DOMImplementation") {
- $implIncludes{"DOMDOMImplementationInternal.h"} = 1;
- $implIncludes{"DOMImplementationFront.h"} = 1;
- return;
- }
-
</del><span class="cx"> if ($type eq "EventTarget") {
</span><span class="cx"> $implIncludes{"Node.h"} = 1;
</span><span class="cx"> $implIncludes{"DOMEventTarget.h"} = 1;
</span><span class="lines">@@ -1101,7 +1094,8 @@
</span><span class="cx"> @internalHeaderContent = split("\r", $implementationLicenseTemplate);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- push(@internalHeaderContent, "\n#import <WebCore/$className.h>\n\n");
</del><ins>+ my $classHeaderName = GetClassHeaderName($className);
+ push(@internalHeaderContent, "\n#import <WebCore/$classHeaderName.h>\n\n");
</ins><span class="cx">
</span><span class="cx"> if ($interfaceName eq "Node") {
</span><span class="cx"> push(@internalHeaderContent, "\@protocol DOMEventTarget;\n\n");
</span><span class="lines">@@ -1303,11 +1297,7 @@
</span><span class="cx">
</span><span class="cx"> # Special cases
</span><span class="cx"> my @customGetterContent = ();
</span><del>- if ($attributeTypeSansPtr eq "DOMImplementation") {
- # FIXME: We have to special case DOMImplementation until DOMImplementationFront is removed
- $getterContentHead = "kit(implementationFront(IMPL";
- $getterContentTail .= ")";
- } elsif ($attributeName =~ /(\w+)DisplayString$/) {
</del><ins>+ if ($attributeName =~ /(\w+)DisplayString$/) {
</ins><span class="cx"> my $attributeToDisplay = $1;
</span><span class="cx"> $getterContentHead = "WebCore::displayString(IMPL->$attributeToDisplay(), core(self)";
</span><span class="cx"> $implIncludes{"HitTestResult.h"} = 1;
</span></span></pre>
</div>
</div>
</body>
</html>