<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173169] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173169">173169</a></dd>
<dt>Author</dt> <dd>rego@igalia.com</dd>
<dt>Date</dt> <dd>2014-09-02 01:36:14 -0700 (Tue, 02 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[CSS Grid Layout] Test coverage for first-line pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=135770
Reviewed by Zoltan Horvath.
According to the spec the ::first-line pseudo-element do not apply to
grid containers.
This was already working as expected but we were missing some tests
checking it, so we are adding new tests to have coverage.
* fast/css-grid-layout/grid-container-ignore-first-line-expected.txt: Added.
* fast/css-grid-layout/grid-container-ignore-first-line.html: Added.
* fast/css-grid-layout/grid-item-first-line-valid-expected.txt: Added.
* fast/css-grid-layout/grid-item-first-line-valid.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssgridlayoutgridcontainerignorefirstlineexpectedtxt">trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssgridlayoutgridcontainerignorefirstlinehtml">trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line.html</a></li>
<li><a href="#trunkLayoutTestsfastcssgridlayoutgriditemfirstlinevalidexpectedtxt">trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcssgridlayoutgriditemfirstlinevalidhtml">trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (173168 => 173169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-09-02 08:06:17 UTC (rev 173168)
+++ trunk/LayoutTests/ChangeLog 2014-09-02 08:36:14 UTC (rev 173169)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-09-02 Manuel Rego Casasnovas <rego@igalia.com>
+
+ [CSS Grid Layout] Test coverage for first-line pseudo-element
+ https://bugs.webkit.org/show_bug.cgi?id=135770
+
+ Reviewed by Zoltan Horvath.
+
+ According to the spec the ::first-line pseudo-element do not apply to
+ grid containers.
+
+ This was already working as expected but we were missing some tests
+ checking it, so we are adding new tests to have coverage.
+
+ * fast/css-grid-layout/grid-container-ignore-first-line-expected.txt: Added.
+ * fast/css-grid-layout/grid-container-ignore-first-line.html: Added.
+ * fast/css-grid-layout/grid-item-first-line-valid-expected.txt: Added.
+ * fast/css-grid-layout/grid-item-first-line-valid.html: Added.
+
</ins><span class="cx"> 2014-08-29 Sergio Villar Senin <svillar@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CSS Grid Layout] Resolved value of grid-template-* must include every track listed
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssgridlayoutgridcontainerignorefirstlineexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line-expected.txt (0 => 173169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line-expected.txt 2014-09-02 08:36:14 UTC (rev 173169)
</span><span class="lines">@@ -0,0 +1,22 @@
</span><ins>+This test grid item should ignore grid container's first-line pseudo-element.
+
+The first item.
+The second item.
+PASS
+The first item.
+The second item.
+PASS
+Anonymous item.
+PASS
+Anonymous item.
+PASS
+The first item.
+The second item.
+PASS
+The first item.
+The second item.
+ PASS
+Anonymous item.
+PASS
+Anonymous item.
+PASS
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssgridlayoutgridcontainerignorefirstlinehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line.html (0 => 173169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line.html (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-container-ignore-first-line.html 2014-09-02 08:36:14 UTC (rev 173169)
</span><span class="lines">@@ -0,0 +1,59 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<link href="resources/grid.css" rel="stylesheet">
+<style>
+ body { line-height: 20px; }
+ .grid-first-line::first-line { line-height: 100px; }
+ .container::first-line { line-height: 200px; }
+</style>
+
+<script src="../../resources/check-layout.js"></script>
+<body onload="checkLayout('.grid-first-line');">
+<p>This test grid item should ignore grid container's first-line pseudo-element.</p>
+
+<div class="grid grid-first-line">
+ <div class="item" data-expected-height=20>The first item.</div>
+ <div class="item" data-expected-height=20>The second item.</div>
+</div>
+
+<div class="inline-grid grid-first-line">
+ <div class="item" data-expected-height=20>The first item.</div>
+ <div class="item" data-expected-height=20>The second item.</div>
+</div>
+
+<div class="grid grid-first-line" data-expected-height=20>
+ Anonymous item.
+</div>
+
+<div class="inline-grid grid-first-line" data-expected-height=20>
+ Anonymous item.
+</div>
+
+<div class="container">
+ <div class="grid grid-first-line">
+ <div class="item" data-expected-height=20>The first item.</div>
+ <div class="item" data-expected-height=20>The second item.</div>
+ </div>
+</div>
+
+<div class="container">
+ <div class="inline-grid grid-first-line">
+ <div class="item" data-expected-height=20>The first item.</div>
+ <div class="item" data-expected-height=20>The second item.</div>
+ </div>
+</div>
+
+<div class="container">
+ <div class="grid grid-first-line" data-expected-height=20>
+ Anonymous item.
+ </div>
+</div>
+
+<div class="container">
+ <div class="inline-grid grid-first-line" data-expected-height=20>
+ Anonymous item.
+ </div>
+</div>
+
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssgridlayoutgriditemfirstlinevalidexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid-expected.txt (0 => 173169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid-expected.txt 2014-09-02 08:36:14 UTC (rev 173169)
</span><span class="lines">@@ -0,0 +1,8 @@
</span><ins>+This test grid item's first-line pseudo-element should be valid.
+
+The first item.
+The second item.
+PASS
+The first item.
+The second item.
+PASS
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssgridlayoutgriditemfirstlinevalidhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid.html (0 => 173169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid.html (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-first-line-valid.html 2014-09-02 08:36:14 UTC (rev 173169)
</span><span class="lines">@@ -0,0 +1,23 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<link href="resources/grid.css" rel="stylesheet">
+<style>
+ .item::first-line { line-height: 100px; }
+</style>
+
+<script src="../../resources/check-layout.js"></script>
+<body onload="checkLayout('.grid'); checkLayout('.inline-grid');">
+<p>This test grid item's first-line pseudo-element should be valid.</p>
+
+<div class="grid">
+ <div class="item" data-expected-height=100>The first item.</div>
+ <div class="item" data-expected-height=100>The second item.</div>
+</div>
+
+<div class="inline-grid">
+ <div class="item" data-expected-height=100>The first item.</div>
+ <div class="item" data-expected-height=100>The second item.</div>
+</div>
+
+</body>
+</html>
</ins></span></pre>
</div>
</div>
</body>
</html>