<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173065] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173065">173065</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2014-08-28 10:26:08 -0700 (Thu, 28 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Dashboard metrics page could show longest stretch of red
https://bugs.webkit.org/show_bug.cgi?id=136334
Reviewed by Sam Weinig.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
(Analyzer.prototype._updateStretchOfRedCounters):
(Analyzer.prototype._countPercentageOfGreen):
When counting percentage of green, also keep track of how long the page was red.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
(MetricsView.prototype._update.addDivider):
(MetricsView.prototype._update.appendQueueResults):
Show it in aggregate queues (can't think of a reason to have it in individual ones).
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
Changed to use an explicit divider element between green time and performance groups,
as there are too many combinations to easily express in CSS.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMetricsAnalyzerjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMetricsViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesMetricscss">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMetricsAnalyzerjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js (173064 => 173065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js 2014-08-28 17:22:59 UTC (rev 173064)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js 2014-08-28 17:26:08 UTC (rev 173065)
</span><span class="lines">@@ -105,6 +105,24 @@
</span><span class="cx"> return true;
</span><span class="cx"> },
</span><span class="cx">
</span><ins>+ _updateStretchOfRedCounters: function(topIterationByQueue, currentTime, stretchOfRedCounters)
+ {
+ var isRedNow = false;
+ for (queueID in topIterationByQueue) {
+ if (!topIterationByQueue[queueID].successful) {
+ isRedNow = true;
+ break;
+ }
+ }
+ if (isRedNow) {
+ if (stretchOfRedCounters.currentStretchOfRedStart === undefined)
+ stretchOfRedCounters.currentStretchOfRedStart = currentTime;
+ } else if (stretchOfRedCounters.currentStretchOfRedStart !== undefined) {
+ stretchOfRedCounters.longestStretchOfRed = Math.max(stretchOfRedCounters.longestStretchOfRed, currentTime - stretchOfRedCounters.currentStretchOfRedStart);
+ stretchOfRedCounters.currentStretchOfRedStart = undefined;
+ }
+ },
+
</ins><span class="cx"> _countPercentageOfGreen: function(queues, result)
</span><span class="cx"> {
</span><span class="cx"> var topIterationByQueue = {};
</span><span class="lines">@@ -131,9 +149,14 @@
</span><span class="cx"> // Go forward in time, ignoring out of order iterations that didn't affect queue color.
</span><span class="cx"> var currentTime = this._rangeStartTime;
</span><span class="cx"> var greenTime = 0;
</span><ins>+ var stretchOfRedCounters = {
+ longestStretchOfRed: 0,
+ currentStretchOfRedStart: undefined
+ };
</ins><span class="cx"> var earliestTimeInRangeWhereAllQueuesHaveResults;
</span><span class="cx"> if (this._allQueuesAreSuccessful(topIterationByQueue, queues) !== undefined)
</span><span class="cx"> earliestTimeInRangeWhereAllQueuesHaveResults = this._rangeStartTime;
</span><ins>+ this._updateStretchOfRedCounters(topIterationByQueue, this._rangeStartTime, stretchOfRedCounters);
</ins><span class="cx"> for (var i = iterations.length - 1; i >= 0; --i) {
</span><span class="cx"> if (iterations[i].endTime <= this._rangeStartTime) {
</span><span class="cx"> console.assert(iterations[i].queue.id in topIterationByQueue);
</span><span class="lines">@@ -146,6 +169,7 @@
</span><span class="cx"> currentTime = iterations[i].endTime;
</span><span class="cx"> earliestTimeInRangeWhereAllQueuesHaveResults = currentTime;
</span><span class="cx"> }
</span><ins>+ this._updateStretchOfRedCounters(topIterationByQueue, currentTime, stretchOfRedCounters);
</ins><span class="cx"> continue;
</span><span class="cx"> }
</span><span class="cx"> if (iterations[i].openSourceRevision <= topIterationByQueue[iterations[i].queue.id].openSourceRevision)
</span><span class="lines">@@ -158,11 +182,17 @@
</span><span class="cx"> greenTime += iterations[i].endTime - currentTime;
</span><span class="cx">
</span><span class="cx"> currentTime = iterations[i].endTime;
</span><ins>+ this._updateStretchOfRedCounters(topIterationByQueue, currentTime, stretchOfRedCounters);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (this._allQueuesAreSuccessful(topIterationByQueue, queues) === true)
</span><span class="cx"> greenTime += this._rangeEndTime - currentTime;
</span><span class="cx">
</span><ins>+ if (stretchOfRedCounters.currentStretchOfRedStart !== undefined)
+ stretchOfRedCounters.longestStretchOfRed = Math.max(stretchOfRedCounters.longestStretchOfRed, this._rangeEndTime - stretchOfRedCounters.currentStretchOfRedStart);
+
+ result.longestStretchOfRed = stretchOfRedCounters.longestStretchOfRed / 1000;
+
</ins><span class="cx"> if (earliestTimeInRangeWhereAllQueuesHaveResults === this._rangeStartTime)
</span><span class="cx"> result.percentageOfGreen = greenTime / (this._rangeEndTime - this._rangeStartTime) * 100;
</span><span class="cx"> else {
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsMetricsViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js (173064 => 173065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js 2014-08-28 17:22:59 UTC (rev 173064)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js 2014-08-28 17:26:08 UTC (rev 173065)
</span><span class="lines">@@ -90,6 +90,13 @@
</span><span class="cx"> element.lastChild.classList.add("error-line");
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ function addDivider(element)
+ {
+ var divider = document.createElement("div");
+ divider.classList.add("divider");
+ element.appendChild(divider);
+ }
+
</ins><span class="cx"> function appendQueueResults(queue)
</span><span class="cx"> {
</span><span class="cx"> if (!(queue.id in this._results))
</span><span class="lines">@@ -97,13 +104,21 @@
</span><span class="cx">
</span><span class="cx"> var result = this._results[queue.id];
</span><span class="cx">
</span><del>- if (result.buildbotRangeError && -1 === this._aggregatePseudoQueues.indexOf(queue))
</del><ins>+ var isAggregateQueue = -1 !== this._aggregatePseudoQueues.indexOf(queue);
+
+ if (result.buildbotRangeError && !isAggregateQueue)
</ins><span class="cx"> addError(this.element, result.buildbotRangeErrorText);
</span><span class="cx">
</span><span class="cx"> if ("percentageOfGreen" in result)
</span><span class="cx"> addLine(this.element, "Green " + Math.round(result.percentageOfGreen * 100) / 100 + "% of time");
</span><span class="cx">
</span><del>- if (queue.builder || -1 !== this._aggregatePseudoQueues.indexOf(queue)) {
</del><ins>+ if (isAggregateQueue && result.longestStretchOfRed) {
+ addLine(this.element, "Longest red: " + Math.round(result.longestStretchOfRed / 60) + " minutes");
+ addDivider(this.element);
+ } else if ("percentageOfGreen" in result)
+ addDivider(this.element);
+
+ if (queue.builder || isAggregateQueue) {
</ins><span class="cx"> addLine(this.element, "Time from commit: ");
</span><span class="cx"> addLine(this.element, "Average: " + Math.round(result.averageSecondsFromCommit / 60) + " minutes");
</span><span class="cx"> addLine(this.element, "Median: " + Math.round(result.medianSecondsFromCommit / 60) + " minutes");
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardStylesMetricscss"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css (173064 => 173065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css 2014-08-28 17:22:59 UTC (rev 173064)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css 2014-08-28 17:26:08 UTC (rev 173065)
</span><span class="lines">@@ -58,7 +58,7 @@
</span><span class="cx"> .queue-view .error-line + .result-line,
</span><span class="cx"> .result-line:first-child
</span><span class="cx"> {
</span><del>- padding: 10px 0 6px 0;
</del><ins>+ padding: 10px 0 2px 0;
</ins><span class="cx"> font-weight: bold;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -66,6 +66,14 @@
</span><span class="cx"> color: rgb(191, 67, 41);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.queue-view .divider {
+ height: 6px;
+}
+
+table.aggregate-grid .queue-view .divider {
+ height: 10px;
+}
+
</ins><span class="cx"> .metrics-loading-indicator {
</span><span class="cx"> font-family: "HelveticaNeue-Light", sans-serif;
</span><span class="cx"> font-size: 14px;
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (173064 => 173065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-08-28 17:22:59 UTC (rev 173064)
+++ trunk/Tools/ChangeLog 2014-08-28 17:26:08 UTC (rev 173065)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-08-28 Alexey Proskuryakov <ap@apple.com>
+
+ Dashboard metrics page could show longest stretch of red
+ https://bugs.webkit.org/show_bug.cgi?id=136334
+
+ Reviewed by Sam Weinig.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
+ (Analyzer.prototype._updateStretchOfRedCounters):
+ (Analyzer.prototype._countPercentageOfGreen):
+ When counting percentage of green, also keep track of how long the page was red.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
+ (MetricsView.prototype._update.addDivider):
+ (MetricsView.prototype._update.appendQueueResults):
+ Show it in aggregate queues (can't think of a reason to have it in individual ones).
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
+ Changed to use an explicit divider element between green time and performance groups,
+ as there are too many combinations to easily express in CSS.
+
</ins><span class="cx"> 2014-08-28 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
</span></span></pre>
</div>
</div>
</body>
</html>