<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173027] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173027">173027</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2014-08-27 15:35:18 -0700 (Wed, 27 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>https://bugs.webkit.org/show_bug.cgi?id=136317
Dashboard metrics page sometimes shows 0 for best time
Reviewed by Tim Horton.
This also affects regular dashboard display in a good way - iterations that failed
due to infrastructure misbehavior will more reliably show up as yellow and not red.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration): Added a list of steps that we actually care about. It will need to be
updated if we rename steps.
(BuildbotIteration.prototype.get productive): Now that computation is more involved,
do it once.
(BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
that failed e.g. at downloading built archive step are not productive.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (173026 => 173027)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2014-08-27 22:34:02 UTC (rev 173026)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2014-08-27 22:35:18 UTC (rev 173027)
</span><span class="lines">@@ -41,6 +41,7 @@
</span><span class="cx">
</span><span class="cx"> this.loaded = false;
</span><span class="cx"> this.isLoading = false;
</span><ins>+ this._productive = false;
</ins><span class="cx">
</span><span class="cx"> this.openSourceRevision = null;
</span><span class="cx"> this.internalRevision = null;
</span><span class="lines">@@ -66,6 +67,20 @@
</span><span class="cx"> BuildbotIteration.EXCEPTION = 4;
</span><span class="cx"> BuildbotIteration.RETRY = 5;
</span><span class="cx">
</span><ins>+// If none of these steps ran, then we didn't get any real results, and the iteration was not productive.
+BuildbotIteration.ProductiveSteps = {
+ "compile-webkit": 1,
+ "build archive": 1,
+ "Build" : 1,
+ "layout-test": 1,
+ "jscore-test": 1,
+ "run-api-tests": 1,
+ "API tests": 1,
+ "webkitpy-test": 1,
+ "webkitperl-test": 1,
+ "bindings-generation-tests": 1,
+};
+
</ins><span class="cx"> BuildbotIteration.Event = {
</span><span class="cx"> Updated: "updated",
</span><span class="cx"> UnauthorizedAccess: "unauthorized-access"
</span><span class="lines">@@ -106,7 +121,7 @@
</span><span class="cx">
</span><span class="cx"> get productive()
</span><span class="cx"> {
</span><del>- return this.loaded && this._finished && this._result !== BuildbotIteration.EXCEPTION && this._result !== BuildbotIteration.RETRY;
</del><ins>+ return this._productive;
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> // It is not a real failure if Buildbot itself failed with codes like EXCEPTION or RETRY.
</span><span class="lines">@@ -172,7 +187,7 @@
</span><span class="cx"> var testResults = {};
</span><span class="cx">
</span><span class="cx"> if (!testStep.isFinished) {
</span><del>- // The step never even ran, or hasn't finish running.
</del><ins>+ // The step never even ran, or hasn't finished running.
</ins><span class="cx"> testResults.finished = false;
</span><span class="cx"> return testResults;
</span><span class="cx"> }
</span><span class="lines">@@ -275,6 +290,21 @@
</span><span class="cx"> if (!data.currentStep)
</span><span class="cx"> this.finished = true;
</span><span class="cx">
</span><ins>+ this._productive = this._finished && this._result !== BuildbotIteration.EXCEPTION && this._result !== BuildbotIteration.RETRY;
+ if (this._productive) {
+ var finishedAnyProductiveStep = false;
+ for (var i = 0; i < data.steps.length; ++i) {
+ var step = data.steps[i];
+ if (!step.isFinished)
+ break;
+ if (step.name in BuildbotIteration.ProductiveSteps) {
+ finishedAnyProductiveStep = true;
+ break;
+ }
+ }
+ this._productive = finishedAnyProductiveStep;
+ }
+
</ins><span class="cx"> // Update the sorting since it is based on the revisions we just loaded.
</span><span class="cx"> this.queue.sortIterations();
</span><span class="cx"> },
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (173026 => 173027)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-08-27 22:34:02 UTC (rev 173026)
+++ trunk/Tools/ChangeLog 2014-08-27 22:35:18 UTC (rev 173027)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-08-27 Alexey Proskuryakov <ap@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=136317
+ Dashboard metrics page sometimes shows 0 for best time
+
+ Reviewed by Tim Horton.
+
+ This also affects regular dashboard display in a good way - iterations that failed
+ due to infrastructure misbehavior will more reliably show up as yellow and not red.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
+ updated if we rename steps.
+ (BuildbotIteration.prototype.get productive): Now that computation is more involved,
+ do it once.
+ (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
+ that failed e.g. at downloading built archive step are not productive.
+
</ins><span class="cx"> 2014-08-27 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Unreviewed gardening.
</span></span></pre>
</div>
</div>
</body>
</html>