<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[173042] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/173042">173042</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2014-08-27 18:35:02 -0700 (Wed, 27 Aug 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Update placeholder-shown-basics.html for GTK

GTK does not support the color input type. This was causing placeholder-shown-basics.html
to fail when testing the non-support of placeholder by input[type=color].

Since this is a minor part of the test, it is more valuable getting the test running everywhere
than skipping it. I removed the subtest causing troubles.

Patch by Benjamin Poulain &lt;bpoulain@apple.com&gt; on 2014-08-27

* fast/css/placeholder-shown-basics-expected.html:
* fast/css/placeholder-shown-basics.html:
* platform/gtk/TestExpectations:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastcssplaceholdershownbasicsexpectedhtml">trunk/LayoutTests/fast/css/placeholder-shown-basics-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastcssplaceholdershownbasicshtml">trunk/LayoutTests/fast/css/placeholder-shown-basics.html</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (173041 => 173042)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2014-08-28 01:23:57 UTC (rev 173041)
+++ trunk/LayoutTests/ChangeLog        2014-08-28 01:35:02 UTC (rev 173042)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-08-27  Benjamin Poulain  &lt;bpoulain@apple.com&gt;
+
+        Update placeholder-shown-basics.html for GTK
+
+        GTK does not support the color input type. This was causing placeholder-shown-basics.html
+        to fail when testing the non-support of placeholder by input[type=color].
+
+        Since this is a minor part of the test, it is more valuable getting the test running everywhere
+        than skipping it. I removed the subtest causing troubles.
+
+        * fast/css/placeholder-shown-basics-expected.html:
+        * fast/css/placeholder-shown-basics.html:
+        * platform/gtk/TestExpectations:
+
</ins><span class="cx"> 2014-08-27  Andreas Kling  &lt;akling@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Drawing text in an SVG font causes load events to be fired.
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssplaceholdershownbasicsexpectedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/placeholder-shown-basics-expected.html (173041 => 173042)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/placeholder-shown-basics-expected.html        2014-08-28 01:23:57 UTC (rev 173041)
+++ trunk/LayoutTests/fast/css/placeholder-shown-basics-expected.html        2014-08-28 01:35:02 UTC (rev 173042)
</span><span class="lines">@@ -102,12 +102,5 @@
</span><span class="cx">         &lt;input type=&quot;submit&quot; placeholder=&quot;WebKit&quot;&gt;
</span><span class="cx">         &lt;input type=&quot;submit&quot; placeholder=&quot;WebKit&quot; value=&quot;Foobar&quot;&gt;
</span><span class="cx">     &lt;/div&gt;
</span><del>-    &lt;div&gt;
-        &lt;input type=&quot;color&quot;&gt;
-        &lt;input type=&quot;color&quot; placeholder&gt;
-        &lt;input type=&quot;color&quot; placeholder=&quot;WebKit&quot;&gt;
-        &lt;input type=&quot;color&quot; placeholder=&quot;WebKit&quot; value=&quot;Foobar&quot;&gt;
-    &lt;/div&gt;
-
</del><span class="cx"> &lt;/body&gt;
</span><span class="cx"> &lt;/html&gt;
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssplaceholdershownbasicshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/placeholder-shown-basics.html (173041 => 173042)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/placeholder-shown-basics.html        2014-08-28 01:23:57 UTC (rev 173041)
+++ trunk/LayoutTests/fast/css/placeholder-shown-basics.html        2014-08-28 01:35:02 UTC (rev 173042)
</span><span class="lines">@@ -102,12 +102,5 @@
</span><span class="cx">         &lt;input type=&quot;submit&quot; placeholder=&quot;WebKit&quot;&gt;
</span><span class="cx">         &lt;input type=&quot;submit&quot; placeholder=&quot;WebKit&quot; value=&quot;Foobar&quot;&gt;
</span><span class="cx">     &lt;/div&gt;
</span><del>-    &lt;div&gt;
-        &lt;input type=&quot;color&quot;&gt;
-        &lt;input type=&quot;color&quot; placeholder&gt;
-        &lt;input type=&quot;color&quot; placeholder=&quot;WebKit&quot;&gt;
-        &lt;input type=&quot;color&quot; placeholder=&quot;WebKit&quot; value=&quot;Foobar&quot;&gt;
-    &lt;/div&gt;
-
</del><span class="cx"> &lt;/body&gt;
</span><span class="cx"> &lt;/html&gt;
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (173041 => 173042)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations        2014-08-28 01:23:57 UTC (rev 173041)
+++ trunk/LayoutTests/platform/gtk/TestExpectations        2014-08-28 01:35:02 UTC (rev 173042)
</span><span class="lines">@@ -2098,7 +2098,6 @@
</span><span class="cx"> 
</span><span class="cx"> webkit.org/b/136255 fast/block/float/overhanging-tall-block.html [ Failure ]
</span><span class="cx"> 
</span><del>-webkit.org/b/136257 fast/css/placeholder-shown-basics.html [ ImageOnlyFailure ]
</del><span class="cx"> webkit.org/b/136257 fast/forms/input-placeholder-visibility-1.html [ Failure ]
</span><span class="cx"> webkit.org/b/136257 fast/forms/input-placeholder-visibility-3.html [ Failure ]
</span><span class="cx"> webkit.org/b/136257 fast/forms/textarea-placeholder-visibility-1.html [ Failure ]
</span></span></pre>
</div>
</div>

</body>
</html>