<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[172998] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/172998">172998</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2014-08-26 23:58:51 -0700 (Tue, 26 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
https://bugs.webkit.org/show_bug.cgi?id=136281
Reviewed by Tim Horton.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
Track and expose whether the itertion is being loaded. Made update() a no-op if
the iteration is already being loaded.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
loading everything at once, ask the queue to load a little more. We can always repeat
if we still don't have enough data.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
10 more iterations intelligently.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotBuilderQueueViewjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueuejs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotBuilderQueueViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js (172997 => 172998)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2014-08-27 06:56:54 UTC (rev 172997)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2014-08-27 06:58:51 UTC (rev 172998)
</span><span class="lines">@@ -108,9 +108,7 @@
</span><span class="cx">
</span><span class="cx"> if (firstRecentUnsuccessfulIteration) {
</span><span class="cx"> // We have a failed iteration but no successful. It might be further back in time.
</span><del>- // Update all the iterations so we get more history.
- // FIXME: It can be very time consuming to load all iterations, we should load progressively.
- queue.iterations.forEach(function(iteration) { iteration.update(); });
</del><ins>+ queue.loadMoreHistoricalIterations();
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotIterationjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (172997 => 172998)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2014-08-27 06:56:54 UTC (rev 172997)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2014-08-27 06:58:51 UTC (rev 172998)
</span><span class="lines">@@ -40,6 +40,7 @@
</span><span class="cx"> this.id = dataOrID;
</span><span class="cx">
</span><span class="cx"> this.loaded = false;
</span><ins>+ this.isLoading = false;
</ins><span class="cx">
</span><span class="cx"> this.openSourceRevision = null;
</span><span class="cx"> this.internalRevision = null;
</span><span class="lines">@@ -295,7 +296,13 @@
</span><span class="cx"> if (this.queue.buildbot.needsAuthentication && this.queue.buildbot.authenticationStatus === Buildbot.AuthenticationStatus.InvalidCredentials)
</span><span class="cx"> return;
</span><span class="cx">
</span><ins>+ if (this.isLoading)
+ return;
+
+ this.isLoading = true;
+
</ins><span class="cx"> JSON.load(this.queue.baseURL + "/builds/" + this.id, function(data) {
</span><ins>+ this.isLoading = false;
</ins><span class="cx"> this.queue.buildbot.isAuthenticated = true;
</span><span class="cx"> if (!data || !data.properties)
</span><span class="cx"> return;
</span><span class="lines">@@ -303,6 +310,7 @@
</span><span class="cx"> this._updateWithData(data);
</span><span class="cx"> }.bind(this),
</span><span class="cx"> function(data) {
</span><ins>+ this.isLoading = false;
</ins><span class="cx"> if (data.errorType === JSON.LoadError && data.errorHTTPCode === 401) {
</span><span class="cx"> this.queue.buildbot.isAuthenticated = false;
</span><span class="cx"> this.dispatchEventToListeners(BuildbotIteration.Event.UnauthorizedAccess);
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsBuildbotQueuejs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (172997 => 172998)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2014-08-27 06:56:54 UTC (rev 172997)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2014-08-27 06:58:51 UTC (rev 172998)
</span><span class="lines">@@ -152,6 +152,32 @@
</span><span class="cx"> );
</span><span class="cx"> },
</span><span class="cx">
</span><ins>+ loadMoreHistoricalIterations: function()
+ {
+ var indexOfFirstNewlyLoadingIteration;
+ for (var i = 0; i < this.iterations.length; ++i) {
+ if (indexOfFirstNewlyLoadingIteration !== undefined && i >= indexOfFirstNewlyLoadingIteration + BuildbotQueue.RecentIterationsToLoad)
+ return;
+ var iteration = this.iterations[i];
+ if (!iteration.finished)
+ continue;
+ if (iteration.isLoading) {
+ // Caller lacks visibility into loading, so it is likely to call this function too often.
+ // Give it a chance to analyze everything that's been already requested first, and then it can decide whether it needs more.
+ return;
+ }
+ if (iteration.loaded && indexOfFirstNewlyLoadingIteration !== undefined) {
+ // There was a gap between loaded iterations, which we've closed now.
+ return;
+ }
+ if (!iteration.loaded) {
+ if (indexOfFirstNewlyLoadingIteration === undefined)
+ indexOfFirstNewlyLoadingIteration = i;
+ iteration.update();
+ }
+ }
+ },
+
</ins><span class="cx"> update: function()
</span><span class="cx"> {
</span><span class="cx"> this._load(this.baseURL, function(data) {
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (172997 => 172998)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-08-27 06:56:54 UTC (rev 172997)
+++ trunk/Tools/ChangeLog 2014-08-27 06:58:51 UTC (rev 172998)
</span><span class="lines">@@ -1,5 +1,25 @@
</span><span class="cx"> 2014-08-26 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><ins>+ build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
+ https://bugs.webkit.org/show_bug.cgi?id=136281
+
+ Reviewed by Tim Horton.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ Track and expose whether the itertion is being loaded. Made update() a no-op if
+ the iteration is already being loaded.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
+ (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
+ loading everything at once, ask the queue to load a little more. We can always repeat
+ if we still don't have enough data.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
+ (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
+ 10 more iterations intelligently.
+
+2014-08-26 Alexey Proskuryakov <ap@apple.com>
+
</ins><span class="cx"> build.webkit.org/dashboard raises an exception when Trac RSS fails to load
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=136283
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>