<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[172941] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/172941">172941</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2014-08-25 16:06:29 -0700 (Mon, 25 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make build.webkit.org/dashboard work with changeset_show_files=location
https://bugs.webkit.org/show_bug.cgi?id=136237
Reviewed by Tim Horton.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._convertCommitInfoElementToObject): Remove location information
from description before getting title, and also actually parse the location into
result object when available.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
(String.prototype.startsWith): Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsTracjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsUtilitiesjs">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsTracjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js (172940 => 172941)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js 2014-08-25 22:35:40 UTC (rev 172940)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js 2014-08-25 23:06:29 UTC (rev 172941)
</span><span class="lines">@@ -98,9 +98,17 @@
</span><span class="cx"> date = new Date(Date.parse(date));
</span><span class="cx"> var description = doc.evaluate("./description", commitElement, null, XPathResult.STRING_TYPE).stringValue;
</span><span class="cx">
</span><del>- // The feed contains a <title>, but it's not parsed as well as what we are getting from description.
</del><span class="cx"> var parsedDescription = document.createElement("div");
</span><span class="cx"> parsedDescription.innerHTML = description;
</span><ins>+
+ var location = "";
+ if (parsedDescription.firstChild.className === "changes") {
+ // We can extract branch information when trac.ini contains "changeset_show_files=location".
+ location = doc.evaluate("//strong", parsedDescription.firstChild, null, XPathResult.STRING_TYPE).stringValue
+ parsedDescription.removeChild(parsedDescription.firstChild);
+ }
+
+ // The feed contains a <title>, but it's not parsed as well as what we are getting from description.
</ins><span class="cx"> var title = document.createElement("div");
</span><span class="cx"> var node = parsedDescription.firstChild.firstChild;
</span><span class="cx"> while (node && node.tagName != "BR") {
</span><span class="lines">@@ -112,14 +120,34 @@
</span><span class="cx"> if (title.firstChild && title.firstChild.nodeType == Node.TEXT_NODE && title.firstChild.textContent.length > 0 && title.firstChild.textContent[0] == "\n")
</span><span class="cx"> title.firstChild.textContent = title.firstChild.textContent.substring(1);
</span><span class="cx">
</span><del>- return {
</del><ins>+ var result = {
</ins><span class="cx"> revisionNumber: revisionNumber,
</span><span class="cx"> link: link,
</span><span class="cx"> title: title,
</span><span class="cx"> author: author,
</span><span class="cx"> date: date,
</span><del>- description: description
</del><ins>+ description: parsedDescription.innerHTML,
+ containsBranchLocation: location !== ""
</ins><span class="cx"> };
</span><ins>+
+ if (result.containsBranchLocation) {
+ console.assert(location[location.length - 1] !== "/");
+ location = location += "/";
+ if (location.startsWith("tags/"))
+ result.tag = location.substr(5, location.indexOf("/", 5) - 5);
+ else if (location.startsWith("branches/"))
+ result.branch = location.substr(9, location.indexOf("/", 9) - 9);
+ else if (location.startsWith("releases/"))
+ result.release = location.substr(9, location.indexOf("/", 9) - 9);
+ else if (location.startsWith("trunk/"))
+ result.branch = "trunk";
+ else {
+ console.assert(false);
+ result.containsBranchLocation = false;
+ }
+ }
+
+ return result;
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _loaded: function(dataDocument)
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigpublic_htmldashboardScriptsUtilitiesjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js (172940 => 172941)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js 2014-08-25 22:35:40 UTC (rev 172940)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js 2014-08-25 23:06:29 UTC (rev 172941)
</span><span class="lines">@@ -170,3 +170,8 @@
</span><span class="cx"> {
</span><span class="cx"> return this.indexOf(substring) >= 0;
</span><span class="cx"> };
</span><ins>+
+String.prototype.startsWith = function(substring)
+{
+ return this.lastIndexOf(substring, 0) === 0;
+}
</ins></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (172940 => 172941)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-08-25 22:35:40 UTC (rev 172940)
+++ trunk/Tools/ChangeLog 2014-08-25 23:06:29 UTC (rev 172941)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-08-25 Alexey Proskuryakov <ap@apple.com>
+
+ Make build.webkit.org/dashboard work with changeset_show_files=location
+ https://bugs.webkit.org/show_bug.cgi?id=136237
+
+ Reviewed by Tim Horton.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
+ (Trac.prototype._convertCommitInfoElementToObject): Remove location information
+ from description before getting title, and also actually parse the location into
+ result object when available.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
+ (String.prototype.startsWith): Added.
+
</ins><span class="cx"> 2014-08-25 Tanay C <tanay.c@samsung.com>
</span><span class="cx">
</span><span class="cx"> [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
</span></span></pre>
</div>
</div>
</body>
</html>