<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[172947] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/172947">172947</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-08-25 18:52:42 -0700 (Mon, 25 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Rename RenderObject::showTree() and showTreeForThis() to showNodeTree*().
https://bugs.webkit.org/show_bug.cgi?id=136238
Reviewed by Simon Fraser.
showNodeTree()/showNodeTreeForThis() reflects the functionality better.
No change in functionality.
* rendering/InlineBox.cpp:
(WebCore::InlineBox::showNodeTreeForThis):
(showNodeTree):
(WebCore::InlineBox::showTreeForThis): Deleted.
(showTree): Deleted.
* rendering/InlineBox.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::showNodeTreeForThis):
(showNodeTree):
(WebCore::RenderObject::showTreeForThis): Deleted.
(showTree): Deleted.
* rendering/RenderObject.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingInlineBoxcpp">trunk/Source/WebCore/rendering/InlineBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingInlineBoxh">trunk/Source/WebCore/rendering/InlineBox.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjectcpp">trunk/Source/WebCore/rendering/RenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjecth">trunk/Source/WebCore/rendering/RenderObject.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (172946 => 172947)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-08-26 00:56:23 UTC (rev 172946)
+++ trunk/Source/WebCore/ChangeLog 2014-08-26 01:52:42 UTC (rev 172947)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2014-08-25 Zalan Bujtas <zalan@apple.com>
+
+ Rename RenderObject::showTree() and showTreeForThis() to showNodeTree*().
+ https://bugs.webkit.org/show_bug.cgi?id=136238
+
+ Reviewed by Simon Fraser.
+
+ showNodeTree()/showNodeTreeForThis() reflects the functionality better.
+
+ No change in functionality.
+
+ * rendering/InlineBox.cpp:
+ (WebCore::InlineBox::showNodeTreeForThis):
+ (showNodeTree):
+ (WebCore::InlineBox::showTreeForThis): Deleted.
+ (showTree): Deleted.
+ * rendering/InlineBox.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::showNodeTreeForThis):
+ (showNodeTree):
+ (WebCore::RenderObject::showTreeForThis): Deleted.
+ (showTree): Deleted.
+ * rendering/RenderObject.h:
+
</ins><span class="cx"> 2014-08-25 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> Don't pass priority as parameter to ResourceLoadScheduler
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingInlineBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/InlineBox.cpp (172946 => 172947)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/InlineBox.cpp 2014-08-26 00:56:23 UTC (rev 172946)
+++ trunk/Source/WebCore/rendering/InlineBox.cpp 2014-08-26 01:52:42 UTC (rev 172947)
</span><span class="lines">@@ -91,9 +91,9 @@
</span><span class="cx"> return "InlineBox";
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InlineBox::showTreeForThis() const
</del><ins>+void InlineBox::showNodeTreeForThis() const
</ins><span class="cx"> {
</span><del>- m_renderer.showTreeForThis();
</del><ins>+ m_renderer.showNodeTreeForThis();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void InlineBox::showLineTreeForThis() const
</span><span class="lines">@@ -334,10 +334,10 @@
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span><span class="cx">
</span><del>-void showTree(const WebCore::InlineBox* b)
</del><ins>+void showNodeTree(const WebCore::InlineBox* b)
</ins><span class="cx"> {
</span><span class="cx"> if (b)
</span><del>- b->showTreeForThis();
</del><ins>+ b->showNodeTreeForThis();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void showLineTree(const WebCore::InlineBox* b)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingInlineBoxh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/InlineBox.h (172946 => 172947)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/InlineBox.h 2014-08-26 00:56:23 UTC (rev 172946)
+++ trunk/Source/WebCore/rendering/InlineBox.h 2014-08-26 01:52:42 UTC (rev 172947)
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx"> virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom) = 0;
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span><del>- void showTreeForThis() const;
</del><ins>+ void showNodeTreeForThis() const;
</ins><span class="cx"> void showLineTreeForThis() const;
</span><span class="cx">
</span><span class="cx"> virtual void showBox(int = 0) const;
</span><span class="lines">@@ -441,7 +441,7 @@
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span><span class="cx"> // Outside the WebCore namespace for ease of invocation from gdb.
</span><del>-void showTree(const WebCore::InlineBox*);
</del><ins>+void showNodeTree(const WebCore::InlineBox*);
</ins><span class="cx"> void showLineTree(const WebCore::InlineBox*);
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (172946 => 172947)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.cpp 2014-08-26 00:56:23 UTC (rev 172946)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2014-08-26 01:52:42 UTC (rev 172947)
</span><span class="lines">@@ -1410,7 +1410,7 @@
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span><span class="cx">
</span><del>-void RenderObject::showTreeForThis() const
</del><ins>+void RenderObject::showNodeTreeForThis() const
</ins><span class="cx"> {
</span><span class="cx"> if (node())
</span><span class="cx"> node()->showTreeForThis();
</span><span class="lines">@@ -2510,10 +2510,10 @@
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span><span class="cx">
</span><del>-void showTree(const WebCore::RenderObject* object)
</del><ins>+void showNodeTree(const WebCore::RenderObject* object)
</ins><span class="cx"> {
</span><span class="cx"> if (object)
</span><del>- object->showTreeForThis();
</del><ins>+ object->showNodeTreeForThis();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void showLineTree(const WebCore::RenderObject* object)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.h (172946 => 172947)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.h 2014-08-26 00:56:23 UTC (rev 172946)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2014-08-26 01:52:42 UTC (rev 172947)
</span><span class="lines">@@ -281,7 +281,7 @@
</span><span class="cx">
</span><span class="cx"> public:
</span><span class="cx"> #ifndef NDEBUG
</span><del>- void showTreeForThis() const;
</del><ins>+ void showNodeTreeForThis() const;
</ins><span class="cx"> void showRenderTreeForThis() const;
</span><span class="cx"> void showLineTreeForThis() const;
</span><span class="cx">
</span><span class="lines">@@ -1139,7 +1139,7 @@
</span><span class="cx">
</span><span class="cx"> #ifndef NDEBUG
</span><span class="cx"> // Outside the WebCore namespace for ease of invocation from gdb.
</span><del>-void showTree(const WebCore::RenderObject*);
</del><ins>+void showNodeTree(const WebCore::RenderObject*);
</ins><span class="cx"> void showLineTree(const WebCore::RenderObject*);
</span><span class="cx"> void showRenderTree(const WebCore::RenderObject* object1);
</span><span class="cx"> // We don't make object2 an optional parameter so that showRenderTree
</span></span></pre>
</div>
</div>
</body>
</html>