<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[172912] releases/WebKitGTK/webkit-2.4</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/172912">172912</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2014-08-25 03:36:58 -0700 (Mon, 25 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/172472">r172472</a> - [GStreamer] playback rate is rounded to integer
https://bugs.webkit.org/show_bug.cgi?id=135802
Patch by Fabien Vallée <fvallee@connected-labs.com> on 2014-08-12
Reviewed by Philippe Normand.
Source/WebCore:
Test: media/video-ended-event-slow-motion-playback.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setRate):
LayoutTests:
add test to ensure playback is actually working
in slow motion (playback rate = 0.5): Player
should reach EOS and dispatch ended event.
* media/video-ended-event-slow-motion-playback-expected.txt: Added.
* media/video-ended-event-slow-motion-playback.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit24SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit24SourceWebCoreplatformgraphicsgstreamerMediaPlayerPrivateGStreamercpp">releases/WebKitGTK/webkit-2.4/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsmediavideoendedeventslowmotionplaybackexpectedtxt">releases/WebKitGTK/webkit-2.4/LayoutTests/media/video-ended-event-slow-motion-playback-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit24LayoutTestsmediavideoendedeventslowmotionplaybackhtml">releases/WebKitGTK/webkit-2.4/LayoutTests/media/video-ended-event-slow-motion-playback.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit24LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog (172911 => 172912)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2014-08-25 10:30:47 UTC (rev 172911)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/ChangeLog 2014-08-25 10:36:58 UTC (rev 172912)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-08-12 Fabien Vallée <fvallee@connected-labs.com>
+
+ [GStreamer] playback rate is rounded to integer
+ https://bugs.webkit.org/show_bug.cgi?id=135802
+
+ Reviewed by Philippe Normand.
+
+ add test to ensure playback is actually working
+ in slow motion (playback rate = 0.5): Player
+ should reach EOS and dispatch ended event.
+
+ * media/video-ended-event-slow-motion-playback-expected.txt: Added.
+ * media/video-ended-event-slow-motion-playback.html: Added.
+
</ins><span class="cx"> 2014-08-21 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] WebkitWebProcess crashing navigating away from ogg video element
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestsmediavideoendedeventslowmotionplaybackexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/media/video-ended-event-slow-motion-playback-expected.txt (0 => 172912)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/media/video-ended-event-slow-motion-playback-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/media/video-ended-event-slow-motion-playback-expected.txt 2014-08-25 10:36:58 UTC (rev 172912)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+
+EVENT(canplaythrough)
+EVENT(ended)
+END OF TEST
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit24LayoutTestsmediavideoendedeventslowmotionplaybackhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.4/LayoutTests/media/video-ended-event-slow-motion-playback.html (0 => 172912)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/LayoutTests/media/video-ended-event-slow-motion-playback.html (rev 0)
+++ releases/WebKitGTK/webkit-2.4/LayoutTests/media/video-ended-event-slow-motion-playback.html 2014-08-25 10:36:58 UTC (rev 172912)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+<html>
+ <head>
+ <script src=media-file.js></script>
+ <script src=video-test.js></script>
+ <script>
+ function start() {
+ findMediaElement();
+ waitForEventAndEnd('ended');
+ video.src = findMediaFile("video", "content/test");
+ waitForEventOnce('canplaythrough',
+ function ()
+ {
+ video.currentTime = 5;
+ video.playbackRate = 0.5;
+ video.play();
+ failTestIn(2500);
+ });
+ }
+ </script>
+ </head>
+ <body onload="start()">
+ <video />
+ </body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit24SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog (172911 => 172912)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-08-25 10:30:47 UTC (rev 172911)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-08-25 10:36:58 UTC (rev 172912)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-08-12 Fabien Vallée <fvallee@connected-labs.com>
+
+ [GStreamer] playback rate is rounded to integer
+ https://bugs.webkit.org/show_bug.cgi?id=135802
+
+ Reviewed by Philippe Normand.
+
+ Test: media/video-ended-event-slow-motion-playback.html
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::setRate):
+
</ins><span class="cx"> 2014-08-24 Michael Catanzaro <mcatanzaro@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Toggle buttons visually broken with GTK+ 3.13.7
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit24SourceWebCoreplatformgraphicsgstreamerMediaPlayerPrivateGStreamercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (172911 => 172912)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.4/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2014-08-25 10:30:47 UTC (rev 172911)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2014-08-25 10:36:58 UTC (rev 172912)
</span><span class="lines">@@ -891,7 +891,7 @@
</span><span class="cx"> void MediaPlayerPrivateGStreamer::setRate(float rate)
</span><span class="cx"> {
</span><span class="cx"> // Higher rate causes crash.
</span><del>- rate = clampTo(rate, -20, 20);
</del><ins>+ rate = clampTo(rate, -20.0, 20.0);
</ins><span class="cx">
</span><span class="cx"> // Avoid useless playback rate update.
</span><span class="cx"> if (m_playbackRate == rate) {
</span></span></pre>
</div>
</div>
</body>
</html>