<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[172948] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/172948">172948</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-08-25 19:11:44 -0700 (Mon, 25 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Subpixel layout: remove roundedLayoutPoint/roundedLayoutSize functions.
https://bugs.webkit.org/show_bug.cgi?id=136236
Reviewed by Simon Fraser.
These functions simply call LayoutPoint/LayoutSize c'tors. They don't round the input value at all.
Non change in functionality.
Source/WebCore:
* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::computePageLocation):
(WebCore::MouseRelatedEvent::computeRelativePosition):
* dom/Touch.cpp:
(WebCore::Touch::Touch):
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint):
* page/DragController.cpp:
(WebCore::elementUnderMouse):
* page/EventHandler.cpp:
(WebCore::selectionExtentRespectingEditingBoundary):
* page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:
(WebCore::ScrollingTreeFrameScrollingNodeIOS::updateChildNodesAfterScroll):
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollLayerPosition):
* platform/graphics/LayoutPoint.h:
(WebCore::roundedLayoutPoint): Deleted.
* platform/graphics/LayoutSize.h:
(WebCore::roundedLayoutSize): Deleted.
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::nodeAtPoint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::positionLineBox):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
* rendering/RenderEmbeddedObject.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::localCaretRect):
(WebCore::RenderInline::mapLocalToContainer):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::absoluteToContents):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::mapAbsoluteToLocalPoint):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::mapLocalToContainer):
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::createShapeForImage):
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::nodeAtFloatPoint):
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::nodeAtFloatPoint):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::nodeAtFloatPoint):
* testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):
Source/WebKit2:
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::computeCustomFixedPositionRect):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomMouseRelatedEventcpp">trunk/Source/WebCore/dom/MouseRelatedEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoredomTouchcpp">trunk/Source/WebCore/dom/Touch.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowSliderThumbElementcpp">trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp</a></li>
<li><a href="#trunkSourceWebCorepageDragControllercpp">trunk/Source/WebCore/page/DragController.cpp</a></li>
<li><a href="#trunkSourceWebCorepageEventHandlercpp">trunk/Source/WebCore/page/EventHandler.cpp</a></li>
<li><a href="#trunkSourceWebCorepagescrollingiosScrollingTreeFrameScrollingNodeIOSmm">trunk/Source/WebCore/page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm</a></li>
<li><a href="#trunkSourceWebCorepagescrollingmacScrollingTreeFrameScrollingNodeMacmm">trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsLayoutPointh">trunk/Source/WebCore/platform/graphics/LayoutPoint.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsLayoutSizeh">trunk/Source/WebCore/platform/graphics/LayoutSize.h</a></li>
<li><a href="#trunkSourceWebCorerenderingEllipsisBoxcpp">trunk/Source/WebCore/rendering/EllipsisBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockcpp">trunk/Source/WebCore/rendering/RenderBlock.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderEmbeddedObjectcpp">trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderEmbeddedObjecth">trunk/Source/WebCore/rendering/RenderEmbeddedObject.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderInlinecpp">trunk/Source/WebCore/rendering/RenderInline.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderMultiColumnFlowThreadcpp">trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjectcpp">trunk/Source/WebCore/rendering/RenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingshapesShapeOutsideInfocpp">trunk/Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGContainercpp">trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGForeignObjectcpp">trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGImagecpp">trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGShapecpp">trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosWebPageProxyIOSmm">trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/ChangeLog 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -1,5 +1,68 @@
</span><span class="cx"> 2014-08-25 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><ins>+ Subpixel layout: remove roundedLayoutPoint/roundedLayoutSize functions.
+ https://bugs.webkit.org/show_bug.cgi?id=136236
+
+ Reviewed by Simon Fraser.
+
+ These functions simply call LayoutPoint/LayoutSize c'tors. They don't round the input value at all.
+
+ Non change in functionality.
+
+ * dom/MouseRelatedEvent.cpp:
+ (WebCore::MouseRelatedEvent::computePageLocation):
+ (WebCore::MouseRelatedEvent::computeRelativePosition):
+ * dom/Touch.cpp:
+ (WebCore::Touch::Touch):
+ * html/shadow/SliderThumbElement.cpp:
+ (WebCore::SliderThumbElement::setPositionFromPoint):
+ * page/DragController.cpp:
+ (WebCore::elementUnderMouse):
+ * page/EventHandler.cpp:
+ (WebCore::selectionExtentRespectingEditingBoundary):
+ * page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:
+ (WebCore::ScrollingTreeFrameScrollingNodeIOS::updateChildNodesAfterScroll):
+ * page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
+ (WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollLayerPosition):
+ * platform/graphics/LayoutPoint.h:
+ (WebCore::roundedLayoutPoint): Deleted.
+ * platform/graphics/LayoutSize.h:
+ (WebCore::roundedLayoutSize): Deleted.
+ * rendering/EllipsisBox.cpp:
+ (WebCore::EllipsisBox::nodeAtPoint):
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::selectionGapRectsForRepaint):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::mapLocalToContainer):
+ (WebCore::RenderBox::positionLineBox):
+ * rendering/RenderEmbeddedObject.cpp:
+ (WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
+ * rendering/RenderEmbeddedObject.h:
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::localCaretRect):
+ (WebCore::RenderInline::mapLocalToContainer):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::absoluteToContents):
+ (WebCore::RenderLayer::calculateClipRects):
+ * rendering/RenderMultiColumnFlowThread.cpp:
+ (WebCore::RenderMultiColumnFlowThread::mapAbsoluteToLocalPoint):
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::mapLocalToContainer):
+ * rendering/shapes/ShapeOutsideInfo.cpp:
+ (WebCore::ShapeOutsideInfo::createShapeForImage):
+ * rendering/svg/RenderSVGContainer.cpp:
+ (WebCore::RenderSVGContainer::nodeAtFloatPoint):
+ * rendering/svg/RenderSVGForeignObject.cpp:
+ (WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
+ * rendering/svg/RenderSVGImage.cpp:
+ (WebCore::RenderSVGImage::nodeAtFloatPoint):
+ * rendering/svg/RenderSVGShape.cpp:
+ (WebCore::RenderSVGShape::nodeAtFloatPoint):
+ * testing/Internals.cpp:
+ (WebCore::Internals::nodesFromRect):
+
+2014-08-25 Zalan Bujtas <zalan@apple.com>
+
</ins><span class="cx"> Rename RenderObject::showTree() and showTreeForThis() to showNodeTree*().
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=136238
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomMouseRelatedEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MouseRelatedEvent.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MouseRelatedEvent.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/dom/MouseRelatedEvent.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -140,7 +140,7 @@
</span><span class="cx"> void MouseRelatedEvent::computePageLocation()
</span><span class="cx"> {
</span><span class="cx"> float scaleFactor = pageZoomFactor(this) * frameScaleFactor(this);
</span><del>- setAbsoluteLocation(roundedLayoutPoint(FloatPoint(pageX() * scaleFactor, pageY() * scaleFactor)));
</del><ins>+ setAbsoluteLocation(LayoutPoint(pageX() * scaleFactor, pageY() * scaleFactor));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void MouseRelatedEvent::receivedTarget()
</span><span class="lines">@@ -163,8 +163,7 @@
</span><span class="cx">
</span><span class="cx"> // Adjust offsetLocation to be relative to the target's position.
</span><span class="cx"> if (RenderObject* r = targetNode->renderer()) {
</span><del>- FloatPoint localPos = r->absoluteToLocal(absoluteLocation(), UseTransforms);
- m_offsetLocation = roundedLayoutPoint(localPos);
</del><ins>+ m_offsetLocation = LayoutPoint(r->absoluteToLocal(absoluteLocation(), UseTransforms));
</ins><span class="cx"> float scaleFactor = 1 / (pageZoomFactor(this) * frameScaleFactor(this));
</span><span class="cx"> if (scaleFactor != 1.0f)
</span><span class="cx"> m_offsetLocation.scale(scaleFactor, scaleFactor);
</span></span></pre></div>
<a id="trunkSourceWebCoredomTouchcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Touch.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Touch.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/dom/Touch.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -70,9 +70,7 @@
</span><span class="cx"> , m_force(force)
</span><span class="cx"> {
</span><span class="cx"> float scaleFactor = frame->pageZoomFactor() * frame->frameScaleFactor();
</span><del>- float x = pageX * scaleFactor;
- float y = pageY * scaleFactor;
- m_absoluteLocation = roundedLayoutPoint(FloatPoint(x, y));
</del><ins>+ m_absoluteLocation = LayoutPoint(pageX * scaleFactor, pageY * scaleFactor);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Touch::Touch(EventTarget* target, unsigned identifier, int clientX, int clientY, int screenX, int screenY, int pageX, int pageY, int radiusX, int radiusY, float rotationAngle, float force, LayoutPoint absoluteLocation)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowSliderThumbElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -268,7 +268,7 @@
</span><span class="cx"> bool isVertical = hasVerticalAppearance(input.get());
</span><span class="cx"> bool isLeftToRightDirection = renderBox()->style().isLeftToRightDirection();
</span><span class="cx">
</span><del>- LayoutPoint offset = roundedLayoutPoint(inputRenderer.absoluteToLocal(absolutePoint, UseTransforms));
</del><ins>+ LayoutPoint offset(inputRenderer.absoluteToLocal(absolutePoint, UseTransforms));
</ins><span class="cx"> FloatRect trackBoundingBox = trackRenderer.localToContainerQuad(FloatRect(0, 0, trackRenderer.width(), trackRenderer.height()), &inputRenderer).enclosingBoundingBox();
</span><span class="cx">
</span><span class="cx"> LayoutUnit trackLength;
</span></span></pre></div>
<a id="trunkSourceWebCorepageDragControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DragController.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DragController.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/page/DragController.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -284,7 +284,7 @@
</span><span class="cx"> {
</span><span class="cx"> Frame* frame = documentUnderMouse->frame();
</span><span class="cx"> float zoomFactor = frame ? frame->pageZoomFactor() : 1;
</span><del>- LayoutPoint point = roundedLayoutPoint(FloatPoint(p.x() * zoomFactor, p.y() * zoomFactor));
</del><ins>+ LayoutPoint point(p.x() * zoomFactor, p.y() * zoomFactor);
</ins><span class="cx">
</span><span class="cx"> HitTestRequest request(HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::DisallowShadowContent);
</span><span class="cx"> HitTestResult result(point);
</span></span></pre></div>
<a id="trunkSourceWebCorepageEventHandlercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/EventHandler.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/EventHandler.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -898,7 +898,7 @@
</span><span class="cx">
</span><span class="cx"> static VisiblePosition selectionExtentRespectingEditingBoundary(const VisibleSelection& selection, const LayoutPoint& localPoint, Node* targetNode)
</span><span class="cx"> {
</span><del>- LayoutPoint selectionEndPoint = localPoint;
</del><ins>+ FloatPoint selectionEndPoint = localPoint;
</ins><span class="cx"> Element* editableElement = selection.rootEditableElement();
</span><span class="cx">
</span><span class="cx"> if (!targetNode->renderer())
</span><span class="lines">@@ -909,11 +909,11 @@
</span><span class="cx"> return VisiblePosition();
</span><span class="cx">
</span><span class="cx"> FloatPoint absolutePoint = targetNode->renderer()->localToAbsolute(FloatPoint(selectionEndPoint));
</span><del>- selectionEndPoint = roundedLayoutPoint(editableElement->renderer()->absoluteToLocal(absolutePoint));
</del><ins>+ selectionEndPoint = editableElement->renderer()->absoluteToLocal(absolutePoint);
</ins><span class="cx"> targetNode = editableElement;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return targetNode->renderer()->positionForPoint(selectionEndPoint, nullptr);
</del><ins>+ return targetNode->renderer()->positionForPoint(LayoutPoint(selectionEndPoint), nullptr);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void EventHandler::updateSelectionForMouseDrag(const HitTestResult& hitTestResult)
</span></span></pre></div>
<a id="trunkSourceWebCorepagescrollingiosScrollingTreeFrameScrollingNodeIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -148,7 +148,7 @@
</span><span class="cx"> ScrollBehaviorForFixedElements behaviorForFixed = scrollBehaviorForFixedElements();
</span><span class="cx"> FloatPoint scrollOffset = scrollPosition - toIntSize(scrollOrigin());
</span><span class="cx"> FloatRect viewportRect(FloatPoint(), scrollableAreaSize());
</span><del>- FloatSize scrollOffsetForFixedChildren = FrameView::scrollOffsetForFixedPosition(enclosingLayoutRect(viewportRect), roundedLayoutSize(totalContentsSize()), roundedLayoutPoint(scrollOffset), scrollOrigin(), frameScaleFactor(), false, behaviorForFixed, headerHeight(), footerHeight());
</del><ins>+ FloatSize scrollOffsetForFixedChildren = FrameView::scrollOffsetForFixedPosition(enclosingLayoutRect(viewportRect), LayoutSize(totalContentsSize()), LayoutPoint(scrollOffset), scrollOrigin(), frameScaleFactor(), false, behaviorForFixed, headerHeight(), footerHeight());
</ins><span class="cx">
</span><span class="cx"> [m_counterScrollingLayer setPosition:FloatPoint(scrollOffsetForFixedChildren)];
</span><span class="cx">
</span><span class="lines">@@ -158,7 +158,7 @@
</span><span class="cx"> // then we should recompute scrollOffsetForFixedChildren for the banner with a scale factor of 1.
</span><span class="cx"> float horizontalScrollOffsetForBanner = scrollOffsetForFixedChildren.width();
</span><span class="cx"> if (frameScaleFactor() != 1)
</span><del>- horizontalScrollOffsetForBanner = FrameView::scrollOffsetForFixedPosition(enclosingLayoutRect(viewportRect), roundedLayoutSize(totalContentsSize()), roundedLayoutPoint(scrollOffset), scrollOrigin(), 1, false, behaviorForFixed, headerHeight(), footerHeight()).width();
</del><ins>+ horizontalScrollOffsetForBanner = FrameView::scrollOffsetForFixedPosition(enclosingLayoutRect(viewportRect), LayoutSize(totalContentsSize()), LayoutPoint(scrollOffset), scrollOrigin(), 1, false, behaviorForFixed, headerHeight(), footerHeight()).width();
</ins><span class="cx">
</span><span class="cx"> if (m_headerLayer)
</span><span class="cx"> [m_headerLayer setPosition:FloatPoint(horizontalScrollOffsetForBanner, 0)];
</span></span></pre></div>
<a id="trunkSourceWebCorepagescrollingmacScrollingTreeFrameScrollingNodeMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -376,11 +376,11 @@
</span><span class="cx"> m_scrollLayer.get().position = CGPointMake(-position.x() + scrollOrigin().x(), -position.y() + scrollOrigin().y());
</span><span class="cx">
</span><span class="cx"> ScrollBehaviorForFixedElements behaviorForFixed = scrollBehaviorForFixedElements();
</span><del>- FloatPoint scrollOffset = position - toFloatSize(scrollOrigin());
</del><ins>+ LayoutPoint scrollOffset = LayoutPoint(position) - toLayoutSize(scrollOrigin());
</ins><span class="cx"> FloatRect viewportRect(FloatPoint(), scrollableAreaSize());
</span><span class="cx">
</span><del>- FloatSize scrollOffsetForFixedChildren = FrameView::scrollOffsetForFixedPosition(enclosingLayoutRect(viewportRect),
- roundedLayoutSize(totalContentsSize()), roundedLayoutPoint(scrollOffset), scrollOrigin(), frameScaleFactor(), false, behaviorForFixed, headerHeight(), footerHeight());
</del><ins>+ FloatSize scrollOffsetForFixedChildren = FrameView::scrollOffsetForFixedPosition(enclosingLayoutRect(viewportRect), LayoutSize(totalContentsSize()), scrollOffset, scrollOrigin(), frameScaleFactor(),
+ false, behaviorForFixed, headerHeight(), footerHeight());
</ins><span class="cx">
</span><span class="cx"> if (m_counterScrollingLayer)
</span><span class="cx"> m_counterScrollingLayer.get().position = FloatPoint(scrollOffsetForFixedChildren);
</span><span class="lines">@@ -400,7 +400,7 @@
</span><span class="cx"> // then we should recompute scrollOffsetForFixedChildren for the banner with a scale factor of 1.
</span><span class="cx"> float horizontalScrollOffsetForBanner = scrollOffsetForFixedChildren.width();
</span><span class="cx"> if (frameScaleFactor() != 1)
</span><del>- horizontalScrollOffsetForBanner = FrameView::scrollOffsetForFixedPosition(enclosingLayoutRect(viewportRect), roundedLayoutSize(totalContentsSize()), roundedLayoutPoint(scrollOffset), scrollOrigin(), 1, false, behaviorForFixed, headerHeight(), footerHeight()).width();
</del><ins>+ horizontalScrollOffsetForBanner = FrameView::scrollOffsetForFixedPosition(enclosingLayoutRect(viewportRect), LayoutSize(totalContentsSize()), scrollOffset, scrollOrigin(), 1, false, behaviorForFixed, headerHeight(), footerHeight()).width();
</ins><span class="cx">
</span><span class="cx"> if (m_headerLayer)
</span><span class="cx"> m_headerLayer.get().position = FloatPoint(horizontalScrollOffsetForBanner, FrameView::yPositionForHeaderLayer(position, topContentInset));
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsLayoutPointh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/LayoutPoint.h (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/LayoutPoint.h 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/platform/graphics/LayoutPoint.h 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -199,11 +199,6 @@
</span><span class="cx"> return FloatPoint(ceilToDevicePixel(point.x(), pixelSnappingFactor), ceilToDevicePixel(point.y(), pixelSnappingFactor));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline LayoutPoint roundedLayoutPoint(const FloatPoint& p)
-{
- return LayoutPoint(p);
-}
-
</del><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // LayoutPoint_h
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsLayoutSizeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/LayoutSize.h (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/LayoutSize.h 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/platform/graphics/LayoutSize.h 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -183,11 +183,6 @@
</span><span class="cx"> return IntSize(s.width().round(), s.height().round());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline LayoutSize roundedLayoutSize(const FloatSize& s)
-{
- return LayoutSize(s);
-}
-
</del><span class="cx"> inline FloatSize flooredForPainting(const LayoutSize& size, float pixelSnappingFactor)
</span><span class="cx"> {
</span><span class="cx"> return FloatSize(floorToDevicePixel(size.width(), pixelSnappingFactor), floorToDevicePixel(size.height(), pixelSnappingFactor));
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingEllipsisBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/EllipsisBox.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/EllipsisBox.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/EllipsisBox.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -142,7 +142,7 @@
</span><span class="cx">
</span><span class="cx"> bool EllipsisBox::nodeAtPoint(const HitTestRequest& request, HitTestResult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom)
</span><span class="cx"> {
</span><del>- LayoutPoint adjustedLocation = accumulatedOffset + roundedLayoutPoint(topLeft());
</del><ins>+ LayoutPoint adjustedLocation = accumulatedOffset + LayoutPoint(topLeft());
</ins><span class="cx">
</span><span class="cx"> // Hit test the markup box.
</span><span class="cx"> if (InlineBox* markupBox = this->markupBox()) {
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -1847,7 +1847,7 @@
</span><span class="cx">
</span><span class="cx"> TransformState transformState(TransformState::ApplyTransformDirection, FloatPoint());
</span><span class="cx"> mapLocalToContainer(repaintContainer, transformState, ApplyContainerFlip | UseTransforms);
</span><del>- LayoutPoint offsetFromRepaintContainer = roundedLayoutPoint(transformState.mappedPoint()) - scrolledContentOffset();
</del><ins>+ LayoutPoint offsetFromRepaintContainer(transformState.mappedPoint() - scrolledContentOffset());
</ins><span class="cx">
</span><span class="cx"> LogicalSelectionOffsetCaches cache(*this);
</span><span class="cx"> LayoutUnit lastTop = 0;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -1902,7 +1902,7 @@
</span><span class="cx"> if (wasFixed)
</span><span class="cx"> *wasFixed = mode & IsFixed;
</span><span class="cx">
</span><del>- LayoutSize containerOffset = offsetFromContainer(o, roundedLayoutPoint(transformState.mappedPoint()));
</del><ins>+ LayoutSize containerOffset = offsetFromContainer(o, LayoutPoint(transformState.mappedPoint()));
</ins><span class="cx">
</span><span class="cx"> bool preserve3D = mode & UseTransforms && (o->style().preserves3D() || style().preserves3D());
</span><span class="cx"> if (mode & UseTransforms && shouldUseTransformFromContainer(o)) {
</span><span class="lines">@@ -2051,7 +2051,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (isReplaced()) {
</span><del>- setLocation(roundedLayoutPoint(box.topLeft()));
</del><ins>+ setLocation(LayoutPoint(box.topLeft()));
</ins><span class="cx"> setInlineBoxWrapper(&box);
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderEmbeddedObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -578,7 +578,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span><del>-bool RenderEmbeddedObject::isInUnavailablePluginIndicator(const LayoutPoint& point) const
</del><ins>+bool RenderEmbeddedObject::isInUnavailablePluginIndicator(const FloatPoint& point) const
</ins><span class="cx"> {
</span><span class="cx"> FloatRect contentRect;
</span><span class="cx"> FloatRect indicatorRect;
</span><span class="lines">@@ -593,7 +593,7 @@
</span><span class="cx">
</span><span class="cx"> bool RenderEmbeddedObject::isInUnavailablePluginIndicator(MouseEvent* event) const
</span><span class="cx"> {
</span><del>- return isInUnavailablePluginIndicator(roundedLayoutPoint(absoluteToLocal(event->absoluteLocation(), UseTransforms)));
</del><ins>+ return isInUnavailablePluginIndicator(absoluteToLocal(event->absoluteLocation(), UseTransforms));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent(Event* event)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderEmbeddedObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderEmbeddedObject.h (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderEmbeddedObject.h 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/RenderEmbeddedObject.h 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx">
</span><span class="cx"> void setUnavailablePluginIndicatorIsPressed(bool);
</span><span class="cx"> bool isInUnavailablePluginIndicator(MouseEvent*) const;
</span><del>- bool isInUnavailablePluginIndicator(const LayoutPoint&) const;
</del><ins>+ bool isInUnavailablePluginIndicator(const FloatPoint&) const;
</ins><span class="cx"> bool getReplacementTextGeometry(const LayoutPoint& accumulatedOffset, FloatRect& contentRect, FloatRect& indicatorRect, FloatRect& replacementTextRect, FloatRect& arrowRect, Font&, TextRun&, float& textWidth) const;
</span><span class="cx"> LayoutRect unavailablePluginIndicatorBounds(const LayoutPoint&) const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderInlinecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderInline.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderInline.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/RenderInline.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -263,7 +263,7 @@
</span><span class="cx"> LayoutRect caretRect = localCaretRectForEmptyElement(horizontalBorderAndPaddingExtent(), 0);
</span><span class="cx">
</span><span class="cx"> if (InlineBox* firstBox = firstLineBox())
</span><del>- caretRect.moveBy(roundedLayoutPoint(firstBox->topLeft()));
</del><ins>+ caretRect.moveBy(LayoutPoint(firstBox->topLeft()));
</ins><span class="cx">
</span><span class="cx"> return caretRect;
</span><span class="cx"> }
</span><span class="lines">@@ -1234,13 +1234,13 @@
</span><span class="cx">
</span><span class="cx"> if (mode & ApplyContainerFlip && o->isBox()) {
</span><span class="cx"> if (o->style().isFlippedBlocksWritingMode()) {
</span><del>- LayoutPoint centerPoint = roundedLayoutPoint(transformState.mappedPoint());
</del><ins>+ LayoutPoint centerPoint(transformState.mappedPoint());
</ins><span class="cx"> transformState.move(toRenderBox(o)->flipForWritingMode(centerPoint) - centerPoint);
</span><span class="cx"> }
</span><span class="cx"> mode &= ~ApplyContainerFlip;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- LayoutSize containerOffset = offsetFromContainer(o, roundedLayoutPoint(transformState.mappedPoint()));
</del><ins>+ LayoutSize containerOffset = offsetFromContainer(o, LayoutPoint(transformState.mappedPoint()));
</ins><span class="cx">
</span><span class="cx"> bool preserve3D = mode & UseTransforms && (o->style().preserves3D() || style().preserves3D());
</span><span class="cx"> if (mode & UseTransforms && shouldUseTransformFromContainer(o)) {
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -1547,7 +1547,7 @@
</span><span class="cx"> LayoutPoint RenderLayer::absoluteToContents(const LayoutPoint& absolutePoint) const
</span><span class="cx"> {
</span><span class="cx"> // We don't use convertToLayerCoords because it doesn't know about transforms
</span><del>- return roundedLayoutPoint(renderer().absoluteToLocal(absolutePoint, UseTransforms));
</del><ins>+ return LayoutPoint(renderer().absoluteToLocal(absolutePoint, UseTransforms));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool RenderLayer::cannotBlitToWindow() const
</span><span class="lines">@@ -5296,8 +5296,7 @@
</span><span class="cx"> // This offset cannot use convertToLayerCoords, because sometimes our rootLayer may be across
</span><span class="cx"> // some transformed layer boundary, for example, in the RenderLayerCompositor overlapMap, where
</span><span class="cx"> // clipRects are needed in view space.
</span><del>- LayoutPoint offset;
- offset = roundedLayoutPoint(renderer().localToContainerPoint(FloatPoint(), &clipRectsContext.rootLayer->renderer()));
</del><ins>+ LayoutPoint offset(renderer().localToContainerPoint(FloatPoint(), &clipRectsContext.rootLayer->renderer()));
</ins><span class="cx"> if (clipRects.fixed() && &clipRectsContext.rootLayer->renderer() == &renderer().view())
</span><span class="cx"> offset -= renderer().view().frameView().scrollOffsetForFixedPosition();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderMultiColumnFlowThreadcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -647,7 +647,7 @@
</span><span class="cx"> {
</span><span class="cx"> // First get the transform state's point into the block flow thread's physical coordinate space.
</span><span class="cx"> parent()->mapAbsoluteToLocalPoint(mode, transformState);
</span><del>- LayoutPoint transformPoint = roundedLayoutPoint(transformState.mappedPoint());
</del><ins>+ LayoutPoint transformPoint(transformState.mappedPoint());
</ins><span class="cx">
</span><span class="cx"> // Now walk through each region.
</span><span class="cx"> const RenderMultiColumnSet* candidateColumnSet = nullptr;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -1647,10 +1647,10 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> // FIXME: this should call offsetFromContainer to share code, but I'm not sure it's ever called.
</span><del>- LayoutPoint centerPoint = roundedLayoutPoint(transformState.mappedPoint());
</del><ins>+ LayoutPoint centerPoint(transformState.mappedPoint());
</ins><span class="cx"> if (mode & ApplyContainerFlip && o->isBox()) {
</span><span class="cx"> if (o->style().isFlippedBlocksWritingMode())
</span><del>- transformState.move(toRenderBox(o)->flipForWritingMode(roundedLayoutPoint(transformState.mappedPoint())) - centerPoint);
</del><ins>+ transformState.move(toRenderBox(o)->flipForWritingMode(LayoutPoint(transformState.mappedPoint())) - centerPoint);
</ins><span class="cx"> mode &= ~ApplyContainerFlip;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingshapesShapeOutsideInfocpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -146,7 +146,7 @@
</span><span class="cx">
</span><span class="cx"> std::unique_ptr<Shape> ShapeOutsideInfo::createShapeForImage(StyleImage* styleImage, float shapeImageThreshold, WritingMode writingMode, float margin) const
</span><span class="cx"> {
</span><del>- const LayoutSize& imageSize = m_renderer.calculateImageIntrinsicDimensions(styleImage, roundedLayoutSize(m_referenceBoxLogicalSize), RenderImage::ScaleByEffectiveZoom);
</del><ins>+ const LayoutSize& imageSize = m_renderer.calculateImageIntrinsicDimensions(styleImage, m_referenceBoxLogicalSize, RenderImage::ScaleByEffectiveZoom);
</ins><span class="cx"> styleImage->setContainerSizeForRenderer(&m_renderer, imageSize, m_renderer.style().effectiveZoom());
</span><span class="cx">
</span><span class="cx"> const LayoutRect& marginRect = getShapeImageMarginRect(m_renderer, m_referenceBoxLogicalSize);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGContainercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -180,14 +180,14 @@
</span><span class="cx">
</span><span class="cx"> for (RenderObject* child = lastChild(); child; child = child->previousSibling()) {
</span><span class="cx"> if (child->nodeAtFloatPoint(request, result, localPoint, hitTestAction)) {
</span><del>- updateHitTestResult(result, roundedLayoutPoint(localPoint));
</del><ins>+ updateHitTestResult(result, LayoutPoint(localPoint));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Accessibility wants to return SVG containers, if appropriate.
</span><span class="cx"> if (request.type() & HitTestRequest::AccessibilityHitTest && m_objectBoundingBox.contains(localPoint)) {
</span><del>- updateHitTestResult(result, roundedLayoutPoint(localPoint));
</del><ins>+ updateHitTestResult(result, LayoutPoint(localPoint));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGForeignObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -184,7 +184,7 @@
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> // FOs establish a stacking context, so we need to hit-test all layers.
</span><del>- HitTestLocation hitTestLocation(roundedLayoutPoint(localPoint));
</del><ins>+ HitTestLocation hitTestLocation(localPoint);
</ins><span class="cx"> return RenderBlock::nodeAtPoint(request, result, hitTestLocation, LayoutPoint(), HitTestForeground)
</span><span class="cx"> || RenderBlock::nodeAtPoint(request, result, hitTestLocation, LayoutPoint(), HitTestFloat)
</span><span class="cx"> || RenderBlock::nodeAtPoint(request, result, hitTestLocation, LayoutPoint(), HitTestChildBlockBackgrounds);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGImagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -191,7 +191,7 @@
</span><span class="cx">
</span><span class="cx"> if (hitRules.canHitFill) {
</span><span class="cx"> if (m_objectBoundingBox.contains(localPoint)) {
</span><del>- updateHitTestResult(result, roundedLayoutPoint(localPoint));
</del><ins>+ updateHitTestResult(result, LayoutPoint(localPoint));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGShapecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -346,7 +346,7 @@
</span><span class="cx"> fillRule = svgStyle.clipRule();
</span><span class="cx"> if ((hitRules.canHitStroke && (svgStyle.hasStroke() || !hitRules.requireStroke) && strokeContains(localPoint, hitRules.requireStroke))
</span><span class="cx"> || (hitRules.canHitFill && (svgStyle.hasFill() || !hitRules.requireFill) && fillContains(localPoint, hitRules.requireFill, fillRule))) {
</span><del>- updateHitTestResult(result, roundedLayoutPoint(localPoint));
</del><ins>+ updateHitTestResult(result, LayoutPoint(localPoint));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebCore/testing/Internals.cpp 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -1115,7 +1115,7 @@
</span><span class="cx"> document->updateLayoutIgnorePendingStylesheets();
</span><span class="cx">
</span><span class="cx"> float zoomFactor = frame->pageZoomFactor();
</span><del>- LayoutPoint point = roundedLayoutPoint(FloatPoint(centerX * zoomFactor + frameView->scrollX(), centerY * zoomFactor + frameView->scrollY()));
</del><ins>+ LayoutPoint point(centerX * zoomFactor + frameView->scrollX(), centerY * zoomFactor + frameView->scrollY());
</ins><span class="cx">
</span><span class="cx"> HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active;
</span><span class="cx"> if (ignoreClipping)
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebKit2/ChangeLog 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-08-25 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel layout: remove roundedLayoutPoint/roundedLayoutSize functions.
+ https://bugs.webkit.org/show_bug.cgi?id=136236
+
+ Reviewed by Simon Fraser.
+
+ These functions simply call LayoutPoint/LayoutSize c'tors. They don't round the input value at all.
+
+ Non change in functionality.
+
+ * UIProcess/ios/WebPageProxyIOS.mm:
+ (WebKit::WebPageProxy::computeCustomFixedPositionRect):
+
</ins><span class="cx"> 2014-08-25 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> Don't pass priority as parameter to ResourceLoadScheduler
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosWebPageProxyIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm (172947 => 172948)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm 2014-08-26 01:52:42 UTC (rev 172947)
+++ trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm 2014-08-26 02:11:44 UTC (rev 172948)
</span><span class="lines">@@ -238,7 +238,7 @@
</span><span class="cx"> constrainedUnobscuredRect.setHeight(adjustedUnexposedMaxEdge(documentRect.maxY(), constrainedUnobscuredRect.maxY(), factor) - constrainedUnobscuredRect.y());
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return FrameView::rectForViewportConstrainedObjects(enclosingLayoutRect(constrainedUnobscuredRect), roundedLayoutSize(contentsSize), displayedContentScale, false, StickToViewportBounds);
</del><ins>+ return FrameView::rectForViewportConstrainedObjects(enclosingLayoutRect(constrainedUnobscuredRect), LayoutSize(contentsSize), displayedContentScale, false, StickToViewportBounds);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebPageProxy::overflowScrollViewWillStartPanGesture()
</span></span></pre>
</div>
</div>
</body>
</html>