<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[172748] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/172748">172748</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-08-19 01:09:10 -0700 (Tue, 19 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove obsolete run-javascriptcore-tests result parsing from master.cfg
https://bugs.webkit.org/show_bug.cgi?id=136039
Patch by Renato Nagy <nagy.renato@stud.u-szeged.hu> on 2014-08-19
Reviewed by Csaba Osztrogonác.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunJavaScriptCoreTests.commandComplete):
* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(RunJavaScriptCoreTestsTest.test_no_failure_new_output):
(RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
(RunJavaScriptCoreTestsTest):
(RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
(RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
(test_layout_failure_new_output): Deleted.
(test_layout_crash_new_output): Deleted.
(test_mozilla_and_layout_failure_new_output): Deleted.
(test_jsc_stress_failure_new_output): Deleted.
(test_js_crashes_and_jsc_stress_failures_new_output): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigmastercfg">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg</a></li>
<li><a href="#trunkToolsBuildSlaveSupportbuildwebkitorgconfigmastercfg_unittestpy">trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigmastercfg"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (172747 => 172748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-08-19 07:37:45 UTC (rev 172747)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-08-19 08:09:10 UTC (rev 172748)
</span><span class="lines">@@ -309,8 +309,6 @@
</span><span class="cx">
</span><span class="cx"> expressions = [
</span><span class="cx"> ('failing Mozilla test', re.compile(r'^Results for Mozilla tests:\r?\n\s+(\d+) regression', re.MULTILINE)),
</span><del>- ('failing js test', re.compile(r'^Results for LayoutTests/js tests:\r?\n\s+(\d+) failure', re.MULTILINE)),
- ('crashing js test', re.compile(r'^Results for LayoutTests/js tests:\r?\n.*\n\s+(\d+) crash', re.MULTILINE)),
</del><span class="cx"> ('failing JSC stress test', re.compile(r'^Results for JSC stress tests:\r?\n\s+(\d+) failure', re.MULTILINE)),
</span><span class="cx"> ]
</span><span class="cx"> resultLines = {}
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportbuildwebkitorgconfigmastercfg_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py (172747 => 172748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py 2014-08-19 07:37:45 UTC (rev 172747)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py 2014-08-19 08:09:10 UTC (rev 172748)
</span><span class="lines">@@ -118,89 +118,30 @@
</span><span class="cx"> 0 tests fixed.
</span><span class="cx"> OK.""")
</span><span class="cx">
</span><ins>+ def test_no_failure_new_output(self):
+ self.assertResults(SUCCESS, ["jscore-test"], 0, """Results for JSC stress tests:
+ 0 failures found.
+ OK.""")
+
</ins><span class="cx"> def test_mozilla_failure_old_output(self):
</span><span class="cx"> self.assertResults(FAILURE, ["jscore-test", '1 failing Mozilla test '], 1, """Results for Mozilla tests:
</span><span class="cx"> 1 regression found.
</span><span class="cx"> 0 tests fixed.""")
</span><span class="cx">
</span><del>- def test_mozilla_failure_new_output(self):
- self.assertResults(FAILURE, ["jscore-test", '1 failing Mozilla test '], 1, """Results for Mozilla tests:
- 1 regression found.
- 0 tests fixed.
</del><ins>+ def test_mozilla_failures_old_output(self):
+ self.assertResults(FAILURE, ["jscore-test", '2 failing Mozilla tests '], 1, """Results for Mozilla tests:
+ 2 regressions found.
+ 0 tests fixed.""")
</ins><span class="cx">
</span><del>-Results for LayoutTests/js tests:
- 0 failures found.
- 0 crashes found.
- OK.""")
-
- def test_layout_failure_new_output(self):
- self.assertResults(FAILURE, ["jscore-test", '469 failing js tests '], 1, """Results for Mozilla tests:
- 0 regressions found.
- 0 tests fixed.
- OK.
-
-Results for LayoutTests/js tests:
- 469 failures found.
- 0 crashes found.
-
-Results for JSC stress tests:
- 0 failures found.
- OK.""")
-
- def test_layout_crash_new_output(self):
- self.assertResults(FAILURE, ["jscore-test", '1 crashing js test '], 1, """Results for Mozilla tests:
- 0 regressions found.
- 0 tests fixed.
- OK.
-
-Results for LayoutTests/js tests:
- 0 failures found.
- 1 crashes found.
-
-Results for JSC stress tests:
- 0 failures found.
- OK.""")
-
- def test_mozilla_and_layout_failure_new_output(self):
- self.assertResults(FAILURE, ["jscore-test", '1 failing Mozilla test ', '469 failing js tests '], 1, """Results for Mozilla tests:
- 1 regression found.
- 0 tests fixed.
-
-Results for LayoutTests/js tests:
- 469 failures found.
- 0 crashes found.
-
-Results for JSC stress tests:
- 0 failures found.
- OK.""")
-
</del><span class="cx"> def test_jsc_stress_failure_new_output(self):
</span><del>- self.assertResults(FAILURE, ["jscore-test", '1 failing JSC stress test '], 1, """Results for Mozilla tests:
- 0 regression found.
- 0 tests fixed.
</del><ins>+ self.assertResults(FAILURE, ["jscore-test", '1 failing JSC stress test '], 1, """Results for JSC stress tests:
+ 1 failure found.""")
</ins><span class="cx">
</span><del>-Results for LayoutTests/js tests:
- 0 failures found.
- 0 crashes found.
</del><ins>+ def test_jsc_stress_failures_new_output(self):
+ self.assertResults(FAILURE, ["jscore-test", '5 failing JSC stress tests '], 1, """Results for JSC stress tests:
+ 5 failures found.""")
</ins><span class="cx">
</span><del>-Results for JSC stress tests:
- 1 failures found.
- OK.""")
</del><span class="cx">
</span><del>- def test_js_crashes_and_jsc_stress_failures_new_output(self):
- self.assertResults(FAILURE, ["jscore-test", '25 crashing js tests ', '284 failing JSC stress tests '], 1, """Results for Mozilla tests:
- 0 regression found.
- 0 tests fixed.
-
-Results for LayoutTests/js tests:
- 0 failures found.
- 25 crashes found.
-
-Results for JSC stress tests:
- 284 failures found.
- OK.""")
-
-
</del><span class="cx"> class RunUnitTestsTest(unittest.TestCase):
</span><span class="cx"> def assertFailures(self, expected_failure_count, stdio):
</span><span class="cx"> if expected_failure_count:
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (172747 => 172748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-08-19 07:37:45 UTC (rev 172747)
+++ trunk/Tools/ChangeLog 2014-08-19 08:09:10 UTC (rev 172748)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-08-19 Renato Nagy <nagy.renato@stud.u-szeged.hu>
+
+ Remove obsolete run-javascriptcore-tests result parsing from master.cfg
+ https://bugs.webkit.org/show_bug.cgi?id=136039
+
+ Reviewed by Csaba Osztrogonác.
+
+ * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+ (RunJavaScriptCoreTests.commandComplete):
+ * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
+ (RunJavaScriptCoreTestsTest.test_no_failure_new_output):
+ (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
+ (RunJavaScriptCoreTestsTest):
+ (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
+ (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
+ (test_layout_failure_new_output): Deleted.
+ (test_layout_crash_new_output): Deleted.
+ (test_mozilla_and_layout_failure_new_output): Deleted.
+ (test_jsc_stress_failure_new_output): Deleted.
+ (test_js_crashes_and_jsc_stress_failures_new_output): Deleted.
+
</ins><span class="cx"> 2014-08-19 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> build.webkit.org/dashboard should not request 50 revisions from trac each time
</span></span></pre>
</div>
</div>
</body>
</html>