<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[172738] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/172738">172738</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2014-08-18 18:04:37 -0700 (Mon, 18 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Provide default implementations of all GraphicsLayerClient methods
https://bugs.webkit.org/show_bug.cgi?id=136054
Reviewed by Tim Horton.
Source/WebCore:
Make none of the functions in GraphicsLayerClient pure virtual, since in many cases
subclasses don't need to provide their own implementations.
* platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::notifyAnimationStarted):
(WebCore::GraphicsLayerClient::notifyFlushRequired):
(WebCore::GraphicsLayerClient::paintContents):
* rendering/RenderLayerCompositor.h:
Source/WebKit2:
Remove overrides which are no longer required.
* WebProcess/WebPage/PageOverlayController.h:
* WebProcess/WebPage/ServicesOverlayController.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsGraphicsLayerClienth">trunk/Source/WebCore/platform/graphics/GraphicsLayerClient.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerCompositorh">trunk/Source/WebCore/rendering/RenderLayerCompositor.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagePageOverlayControllerh">trunk/Source/WebKit2/WebProcess/WebPage/PageOverlayController.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageServicesOverlayControllerh">trunk/Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacRemoteLayerTreeDrawingAreah">trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (172737 => 172738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-08-19 00:55:31 UTC (rev 172737)
+++ trunk/Source/WebCore/ChangeLog        2014-08-19 01:04:37 UTC (rev 172738)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-08-18 Simon Fraser <simon.fraser@apple.com>
+
+ Provide default implementations of all GraphicsLayerClient methods
+ https://bugs.webkit.org/show_bug.cgi?id=136054
+
+ Reviewed by Tim Horton.
+
+ Make none of the functions in GraphicsLayerClient pure virtual, since in many cases
+ subclasses don't need to provide their own implementations.
+
+ * platform/graphics/GraphicsLayerClient.h:
+ (WebCore::GraphicsLayerClient::notifyAnimationStarted):
+ (WebCore::GraphicsLayerClient::notifyFlushRequired):
+ (WebCore::GraphicsLayerClient::paintContents):
+ * rendering/RenderLayerCompositor.h:
+
</ins><span class="cx"> 2014-08-18 Pratik Solanki <psolanki@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove PurgeableBuffer since it is not very useful any more
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsGraphicsLayerClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayerClient.h (172737 => 172738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/GraphicsLayerClient.h        2014-08-19 00:55:31 UTC (rev 172737)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayerClient.h        2014-08-19 01:04:37 UTC (rev 172738)
</span><span class="lines">@@ -62,16 +62,16 @@
</span><span class="cx"> virtual void tiledBackingUsageChanged(const GraphicsLayer*, bool /*usingTiledBacking*/) { }
</span><span class="cx">
</span><span class="cx"> // Callback for when hardware-accelerated animation started.
</span><del>- virtual void notifyAnimationStarted(const GraphicsLayer*, double time) = 0;
</del><ins>+ virtual void notifyAnimationStarted(const GraphicsLayer*, double /*time*/) { }
</ins><span class="cx">
</span><span class="cx"> // Notification that a layer property changed that requires a subsequent call to flushCompositingState()
</span><span class="cx"> // to appear on the screen.
</span><del>- virtual void notifyFlushRequired(const GraphicsLayer*) = 0;
</del><ins>+ virtual void notifyFlushRequired(const GraphicsLayer*) { }
</ins><span class="cx">
</span><span class="cx"> // Notification that this layer requires a flush before the next display refresh.
</span><span class="cx"> virtual void notifyFlushBeforeDisplayRefresh(const GraphicsLayer*) { }
</span><span class="cx">
</span><del>- virtual void paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const FloatRect& inClip) = 0;
</del><ins>+ virtual void paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const FloatRect& /* inClip */) { }
</ins><span class="cx"> virtual void didCommitChangesForLayer(const GraphicsLayer*) const { }
</span><span class="cx">
</span><span class="cx"> // Provides current transform (taking transform-origin and animations into account). Input matrix has been
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerCompositorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.h (172737 => 172738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerCompositor.h        2014-08-19 00:55:31 UTC (rev 172737)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.h        2014-08-19 01:04:37 UTC (rev 172738)
</span><span class="lines">@@ -305,7 +305,6 @@
</span><span class="cx"> class OverlapMap;
</span><span class="cx">
</span><span class="cx"> // GraphicsLayerClient implementation
</span><del>- virtual void notifyAnimationStarted(const GraphicsLayer*, double) override { }
</del><span class="cx"> virtual void notifyFlushRequired(const GraphicsLayer*) override;
</span><span class="cx"> virtual void paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const FloatRect&) override;
</span><span class="cx"> virtual void customPositionForVisibleRectComputation(const GraphicsLayer*, FloatPoint&) const override;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (172737 => 172738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog        2014-08-19 00:55:31 UTC (rev 172737)
+++ trunk/Source/WebKit2/ChangeLog        2014-08-19 01:04:37 UTC (rev 172738)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-08-18 Simon Fraser <simon.fraser@apple.com>
+
+ Provide default implementations of all GraphicsLayerClient methods
+ https://bugs.webkit.org/show_bug.cgi?id=136054
+
+ Reviewed by Tim Horton.
+
+ Remove overrides which are no longer required.
+
+ * WebProcess/WebPage/PageOverlayController.h:
+ * WebProcess/WebPage/ServicesOverlayController.h:
+ * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
+
</ins><span class="cx"> 2014-08-18 Pratik Solanki <psolanki@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove PurgeableBuffer since it is not very useful any more
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagePageOverlayControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/PageOverlayController.h (172737 => 172738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/PageOverlayController.h        2014-08-19 00:55:31 UTC (rev 172737)
+++ trunk/Source/WebKit2/WebProcess/WebPage/PageOverlayController.h        2014-08-19 01:04:37 UTC (rev 172738)
</span><span class="lines">@@ -82,11 +82,9 @@
</span><span class="cx"> void updateForceSynchronousScrollLayerPositionUpdates();
</span><span class="cx">
</span><span class="cx"> // WebCore::GraphicsLayerClient
</span><del>- virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) override { }
</del><span class="cx"> virtual void notifyFlushRequired(const WebCore::GraphicsLayer*) override;
</span><span class="cx"> virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::FloatRect& clipRect) override;
</span><span class="cx"> virtual float deviceScaleFactor() const override;
</span><del>- virtual void didCommitChangesForLayer(const WebCore::GraphicsLayer*) const override { }
</del><span class="cx"> virtual bool shouldSkipLayerInDump(const WebCore::GraphicsLayer*) const override { return true; }
</span><span class="cx">
</span><span class="cx"> std::unique_ptr<WebCore::GraphicsLayer> m_documentOverlayRootLayer;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageServicesOverlayControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h (172737 => 172738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h        2014-08-19 00:55:31 UTC (rev 172737)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h        2014-08-19 01:04:37 UTC (rev 172738)
</span><span class="lines">@@ -84,7 +84,6 @@
</span><span class="cx"> explicit Highlight(ServicesOverlayController&, Type, RetainPtr<DDHighlightRef>, PassRefPtr<WebCore::Range>);
</span><span class="cx">
</span><span class="cx"> // GraphicsLayerClient
</span><del>- virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) override { }
</del><span class="cx"> virtual void notifyFlushRequired(const WebCore::GraphicsLayer*) override;
</span><span class="cx"> virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::FloatRect& inClip) override;
</span><span class="cx"> virtual float deviceScaleFactor() const override;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacRemoteLayerTreeDrawingAreah"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h (172737 => 172738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h        2014-08-19 00:55:31 UTC (rev 172737)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h        2014-08-19 01:04:37 UTC (rev 172738)
</span><span class="lines">@@ -105,11 +105,6 @@
</span><span class="cx">
</span><span class="cx"> virtual bool adjustLayerFlushThrottling(WebCore::LayerFlushThrottleState::Flags) override;
</span><span class="cx">
</span><del>- // GraphicsLayerClient
- virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) override { }
- virtual void notifyFlushRequired(const WebCore::GraphicsLayer*) override { }
- virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::FloatRect& inClip) override { }
-
</del><span class="cx"> void updateScrolledExposedRect();
</span><span class="cx">
</span><span class="cx"> void layerFlushTimerFired(WebCore::Timer<RemoteLayerTreeDrawingArea>*);
</span></span></pre>
</div>
</div>
</body>
</html>