<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[172583] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/172583">172583</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2014-08-14 06:10:37 -0700 (Thu, 14 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] REGRESSION(<a href="http://trac.webkit.org/projects/webkit/changeset/171598">r171598</a>, CMake): Introspection files are installed at the wrong path
https://bugs.webkit.org/show_bug.cgi?id=135934
Reviewed by Gustavo Noronha Silva.
Since <a href="http://trac.webkit.org/projects/webkit/changeset/171598">r171598</a> gir files are installed under $datadir/webkitgtk-4.0/gir-1.0/.
The gir files should installed in $datadir/gir-1.0/ together with all other
gir files. We don't need to install introspection files in a versioned
directory because their filenames already contain the binary version. But before
<a href="http://trac.webkit.org/projects/webkit/changeset/171598">r171598</a>, the files were only installed to the right directory if the
gobject-instrospection pkg-config file was in the same prefix than the one we
wanted to install, because the gir and typelibs directories were extracted from
the pkg-config file. We should define INTROSPECTION_INSTALL_GIRDIR and
INTROSPECTION_INSTALL_TYPELIBDIR in OptionsGTK.cmake based on $datadir and $libdir
like we do in the autotools build.
* Source/cmake/FindGObjectIntrospection.cmake: Do not define
INTROSPECTION_INSTALL_GIRDIR and INTROSPECTION_INSTALL_TYPELIBDIR.
* Source/cmake/OptionsGTK.cmake: Define
INTROSPECTION_INSTALL_GIRDIR and INTROSPECTION_INSTALL_TYPELIBDIR.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkSourcecmakeFindGObjectIntrospectioncmake">trunk/Source/cmake/FindGObjectIntrospection.cmake</a></li>
<li><a href="#trunkSourcecmakeOptionsGTKcmake">trunk/Source/cmake/OptionsGTK.cmake</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (172582 => 172583)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2014-08-14 11:13:02 UTC (rev 172582)
+++ trunk/ChangeLog 2014-08-14 13:10:37 UTC (rev 172583)
</span><span class="lines">@@ -1,5 +1,28 @@
</span><span class="cx"> 2014-08-14 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><ins>+ [GTK] REGRESSION(r171598, CMake): Introspection files are installed at the wrong path
+ https://bugs.webkit.org/show_bug.cgi?id=135934
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Since r171598 gir files are installed under $datadir/webkitgtk-4.0/gir-1.0/.
+ The gir files should installed in $datadir/gir-1.0/ together with all other
+ gir files. We don't need to install introspection files in a versioned
+ directory because their filenames already contain the binary version. But before
+ r171598, the files were only installed to the right directory if the
+ gobject-instrospection pkg-config file was in the same prefix than the one we
+ wanted to install, because the gir and typelibs directories were extracted from
+ the pkg-config file. We should define INTROSPECTION_INSTALL_GIRDIR and
+ INTROSPECTION_INSTALL_TYPELIBDIR in OptionsGTK.cmake based on $datadir and $libdir
+ like we do in the autotools build.
+
+ * Source/cmake/FindGObjectIntrospection.cmake: Do not define
+ INTROSPECTION_INSTALL_GIRDIR and INTROSPECTION_INSTALL_TYPELIBDIR.
+ * Source/cmake/OptionsGTK.cmake: Define
+ INTROSPECTION_INSTALL_GIRDIR and INTROSPECTION_INSTALL_TYPELIBDIR.
+
+2014-08-14 Carlos Garcia Campos <cgarcia@igalia.com>
+
</ins><span class="cx"> [GTK] WebKit DOM documentation (webkitdomgtk) not installed after make install
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=135836
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourcecmakeFindGObjectIntrospectioncmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/cmake/FindGObjectIntrospection.cmake (172582 => 172583)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/cmake/FindGObjectIntrospection.cmake 2014-08-14 11:13:02 UTC (rev 172582)
+++ trunk/Source/cmake/FindGObjectIntrospection.cmake 2014-08-14 13:10:37 UTC (rev 172583)
</span><span class="lines">@@ -44,8 +44,6 @@
</span><span class="cx"> _gir_get_pkgconfig_var(INTROSPECTION_GENERATE "g_ir_generate" "")
</span><span class="cx"> _gir_get_pkgconfig_var(INTROSPECTION_GIRDIR "girdir" "")
</span><span class="cx"> _gir_get_pkgconfig_var(INTROSPECTION_TYPELIBDIR "typelibdir" "")
</span><del>- _gir_get_pkgconfig_var(INTROSPECTION_INSTALL_GIRDIR "girdir" "--define-variable=datadir=${DATA_INSTALL_DIR}")
- _gir_get_pkgconfig_var(INTROSPECTION_INSTALL_TYPELIBDIR "typelibdir" "--define-variable=libdir=${LIB_INSTALL_DIR}")
</del><span class="cx"> set(INTROSPECTION_CFLAGS "${_pc_gir_CFLAGS}")
</span><span class="cx"> set(INTROSPECTION_LIBS "${_pc_gir_LIBS}")
</span><span class="cx"> endif ()
</span><span class="lines">@@ -59,6 +57,4 @@
</span><span class="cx"> INTROSPECTION_TYPELIBDIR
</span><span class="cx"> INTROSPECTION_CFLAGS
</span><span class="cx"> INTROSPECTION_LIBS
</span><del>- INTROSPECTION_INSTALL_GIRDIR
- INTROSPECTION_INSTALL_TYPELIBDIR
</del><span class="cx"> )
</span></span></pre></div>
<a id="trunkSourcecmakeOptionsGTKcmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/cmake/OptionsGTK.cmake (172582 => 172583)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/cmake/OptionsGTK.cmake 2014-08-14 11:13:02 UTC (rev 172582)
+++ trunk/Source/cmake/OptionsGTK.cmake 2014-08-14 13:10:37 UTC (rev 172583)
</span><span class="lines">@@ -25,6 +25,8 @@
</span><span class="cx"> set(DATA_BUILD_DIR "${CMAKE_BINARY_DIR}/share/${WebKit_OUTPUT_NAME}")
</span><span class="cx"> set(DATA_INSTALL_DIR "${CMAKE_INSTALL_DATADIR}/webkitgtk-${WEBKITGTK_API_VERSION}")
</span><span class="cx"> set(WEBKITGTK_HEADER_INSTALL_DIR "${CMAKE_INSTALL_INCLUDEDIR}/webkitgtk-${WEBKITGTK_API_VERSION}")
</span><ins>+set(INTROSPECTION_INSTALL_GIRDIR "${CMAKE_INSTALL_FULL_DATADIR}/gir-1.0")
+set(INTROSPECTION_INSTALL_TYPELIBDIR "${LIB_INSTALL_DIR}/girepository-1.0")
</ins><span class="cx">
</span><span class="cx"> find_package(Cairo 1.10.2 REQUIRED)
</span><span class="cx"> find_package(Fontconfig 2.8.0 REQUIRED)
</span></span></pre>
</div>
</div>
</body>
</html>