<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[172437] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/172437">172437</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-08-12 01:22:05 -0700 (Tue, 12 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
https://bugs.webkit.org/show_bug.cgi?id=135791
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-08-12
Reviewed by Gyuyoung Kim.
Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
user.
* MiniBrowser/efl/main.c:
(on_download_request):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsMiniBrowsereflmainc">trunk/Tools/MiniBrowser/efl/main.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (172436 => 172437)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-08-12 08:16:22 UTC (rev 172436)
+++ trunk/Tools/ChangeLog 2014-08-12 08:22:05 UTC (rev 172437)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-08-12 Shivakumar JM <shiva.jm@samsung.com>
+
+ [EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
+ https://bugs.webkit.org/show_bug.cgi?id=135791
+
+ Reviewed by Gyuyoung Kim.
+
+ Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
+ user.
+
+ * MiniBrowser/efl/main.c:
+ (on_download_request):
+
</ins><span class="cx"> 2014-08-11 Grzegorz Czajkowski <g.czajkowski@samsung.com>
</span><span class="cx">
</span><span class="cx"> [EFL] Prevent the client from creating ewk_view when EWebkit is not initialized
</span></span></pre></div>
<a id="trunkToolsMiniBrowsereflmainc"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/efl/main.c (172436 => 172437)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/efl/main.c 2014-08-12 08:16:22 UTC (rev 172436)
+++ trunk/Tools/MiniBrowser/efl/main.c 2014-08-12 08:22:05 UTC (rev 172437)
</span><span class="lines">@@ -654,26 +654,37 @@
</span><span class="cx"> on_download_request(void *user_data, Evas_Object *ewk_view, void *event_info)
</span><span class="cx"> {
</span><span class="cx"> Ewk_Download_Job *download = (Ewk_Download_Job *)event_info;
</span><ins>+ Browser_Window *window = (Browser_Window *)user_data;
</ins><span class="cx">
</span><del>- // FIXME: The destination folder should be selected by the user but we set it to '/tmp' for now.
</del><span class="cx"> Eina_Strbuf *destination_path = eina_strbuf_new();
</span><span class="cx">
</span><ins>+ const char *home_path = getenv("HOME");
+ Eina_Stringshare *save_file_path = show_file_entry_dialog(window, "DOWNLOAD", home_path ? home_path : "/tmp");
+
+ if (save_file_path)
+ eina_strbuf_append_printf(destination_path, "%s", save_file_path);
+ else
+ eina_strbuf_append(destination_path, "/tmp");
+
</ins><span class="cx"> const char *suggested_name = ewk_download_job_suggested_filename_get(download);
</span><span class="cx"> if (suggested_name && *suggested_name)
</span><del>- eina_strbuf_append_printf(destination_path, "/tmp/%s", suggested_name);
</del><ins>+ eina_strbuf_append_printf(destination_path, "/%s", suggested_name);
</ins><span class="cx"> else {
</span><span class="cx"> // Generate a unique file name since no name was suggested.
</span><del>- char unique_path[] = "/tmp/downloaded-file.XXXXXX";
- if (mkstemp(unique_path) == -1) {
</del><ins>+ eina_strbuf_append(destination_path, "/downloaded-file.XXXXXX");
+ char *url = NULL;
+ url = eina_strbuf_string_steal(destination_path);
+ if (mkstemp(url) == -1) {
</ins><span class="cx"> info("ERROR: Could not generate a unique file name.");
</span><span class="cx"> return;
</span><span class="cx"> }
</span><del>- eina_strbuf_append(destination_path, unique_path);
</del><ins>+ eina_strbuf_append(destination_path, url);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ewk_download_job_destination_set(download, eina_strbuf_string_get(destination_path));
</span><span class="cx"> info("Downloading: %s", eina_strbuf_string_get(destination_path));
</span><span class="cx"> eina_strbuf_free(destination_path);
</span><ins>+ eina_stringshare_del(save_file_path);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static void on_filepicker_parent_deletion(void *user_data, Evas *evas, Evas_Object *elm_window, void *event);
</span></span></pre>
</div>
</div>
</body>
</html>