<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[172445] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/172445">172445</a></dd>
<dt>Author</dt> <dd>g.czajkowski@samsung.com</dd>
<dt>Date</dt> <dd>2014-08-12 05:07:55 -0700 (Tue, 12 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL] Rename ewk_private.h to EwkDebug.h
https://bugs.webkit.org/show_bug.cgi?id=135797
Reviewed by Gyuyoung Kim.
ewk_private.h contains only debug macros alllowing
logging.
* UIProcess/API/efl/EwkView.cpp:
* UIProcess/API/efl/ewk_main.cpp:
* UIProcess/efl/EwkDebug.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_private.h.
* UIProcess/efl/ViewClientEfl.cpp:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIeflEwkViewcpp">trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIeflewk_maincpp">trunk/Source/WebKit2/UIProcess/API/efl/ewk_main.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcesseflViewClientEflcpp">trunk/Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2UIProcesseflEwkDebugh">trunk/Source/WebKit2/UIProcess/efl/EwkDebug.h</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2UIProcessAPIeflewk_privateh">trunk/Source/WebKit2/UIProcess/API/efl/ewk_private.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (172444 => 172445)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-08-12 11:42:33 UTC (rev 172444)
+++ trunk/Source/WebKit2/ChangeLog 2014-08-12 12:07:55 UTC (rev 172445)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-08-12 Grzegorz Czajkowski <g.czajkowski@samsung.com>
+
+ [EFL] Rename ewk_private.h to EwkDebug.h
+ https://bugs.webkit.org/show_bug.cgi?id=135797
+
+ Reviewed by Gyuyoung Kim.
+
+ ewk_private.h contains only debug macros alllowing
+ logging.
+
+ * UIProcess/API/efl/EwkView.cpp:
+ * UIProcess/API/efl/ewk_main.cpp:
+ * UIProcess/efl/EwkDebug.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_private.h.
+ * UIProcess/efl/ViewClientEfl.cpp:
+
</ins><span class="cx"> 2014-08-12 Carlos Garcia Campos <cgarcia@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] The plugins metadata cache doesn't work if the user cache directory doesn't exist
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIeflEwkViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp (172444 => 172445)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp 2014-08-12 11:42:33 UTC (rev 172444)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp 2014-08-12 12:07:55 UTC (rev 172445)
</span><span class="lines">@@ -25,6 +25,7 @@
</span><span class="cx"> #include "EflScreenUtilities.h"
</span><span class="cx"> #include "EvasGLContext.h"
</span><span class="cx"> #include "EvasGLSurface.h"
</span><ins>+#include "EwkDebug.h"
</ins><span class="cx"> #include "FindClientEfl.h"
</span><span class="cx"> #include "FormClientEfl.h"
</span><span class="cx"> #include "InputMethodContextEfl.h"
</span><span class="lines">@@ -59,7 +60,6 @@
</span><span class="cx"> #include "ewk_page_group_private.h"
</span><span class="cx"> #include "ewk_popup_menu_item_private.h"
</span><span class="cx"> #include "ewk_popup_menu_private.h"
</span><del>-#include "ewk_private.h"
</del><span class="cx"> #include "ewk_security_origin_private.h"
</span><span class="cx"> #include "ewk_settings_private.h"
</span><span class="cx"> #include "ewk_window_features_private.h"
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIeflewk_maincpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_main.cpp (172444 => 172445)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_main.cpp 2014-08-12 11:42:33 UTC (rev 172444)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_main.cpp 2014-08-12 12:07:55 UTC (rev 172445)
</span><span class="lines">@@ -22,8 +22,8 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "ewk_main.h"
</span><span class="cx">
</span><ins>+#include "EwkDebug.h"
</ins><span class="cx"> #include "ewk_main_private.h"
</span><del>-#include "ewk_private.h"
</del><span class="cx"> #include <Ecore.h>
</span><span class="cx"> #include <Ecore_Evas.h>
</span><span class="cx"> #include <Ecore_IMF.h>
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIeflewk_privateh"></a>
<div class="delfile"><h4>Deleted: trunk/Source/WebKit2/UIProcess/API/efl/ewk_private.h (172444 => 172445)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_private.h 2014-08-12 11:42:33 UTC (rev 172444)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_private.h 2014-08-12 12:07:55 UTC (rev 172445)
</span><span class="lines">@@ -1,37 +0,0 @@
</span><del>-/*
- * Copyright (C) 2012 Intel Corporation. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef ewk_private_h
-#define ewk_private_h
-
-#include "ewk_main_private.h"
-
-#define CRITICAL(...) EINA_LOG_DOM_CRIT(EwkMain::shared().logDomainId(), __VA_ARGS__)
-#define ERR(...) EINA_LOG_DOM_ERR(EwkMain::shared().logDomainId(), __VA_ARGS__)
-#define WARN(...) EINA_LOG_DOM_WARN(EwkMain::shared().logDomainId(), __VA_ARGS__)
-#define INFO(...) EINA_LOG_DOM_INFO(EwkMain::shared().logDomainId(), __VA_ARGS__)
-#define DBG(...) EINA_LOG_DOM_DBG(EwkMain::shared().logDomainId(), __VA_ARGS__)
-
-#endif // ewk_private_h
</del></span></pre></div>
<a id="trunkSourceWebKit2UIProcesseflEwkDebughfromrev172443trunkSourceWebKit2UIProcessAPIeflewk_privateh"></a>
<div class="copfile"><h4>Copied: trunk/Source/WebKit2/UIProcess/efl/EwkDebug.h (from rev 172443, trunk/Source/WebKit2/UIProcess/API/efl/ewk_private.h) (0 => 172445)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/efl/EwkDebug.h (rev 0)
+++ trunk/Source/WebKit2/UIProcess/efl/EwkDebug.h 2014-08-12 12:07:55 UTC (rev 172445)
</span><span class="lines">@@ -0,0 +1,38 @@
</span><ins>+/*
+ * Copyright (C) 2012 Intel Corporation. All rights reserved.
+ * Copyright (C) 2014 Samsung Electronics. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef EwkDebug_h
+#define EwkDebug_h
+
+#include "ewk_main_private.h"
+
+#define CRITICAL(...) EINA_LOG_DOM_CRIT(EwkMain::shared().logDomainId(), __VA_ARGS__)
+#define ERR(...) EINA_LOG_DOM_ERR(EwkMain::shared().logDomainId(), __VA_ARGS__)
+#define WARN(...) EINA_LOG_DOM_WARN(EwkMain::shared().logDomainId(), __VA_ARGS__)
+#define INFO(...) EINA_LOG_DOM_INFO(EwkMain::shared().logDomainId(), __VA_ARGS__)
+#define DBG(...) EINA_LOG_DOM_DBG(EwkMain::shared().logDomainId(), __VA_ARGS__)
+
+#endif // EwkDebug_h
</ins></span></pre></div>
<a id="trunkSourceWebKit2UIProcesseflViewClientEflcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp (172444 => 172445)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp 2014-08-12 11:42:33 UTC (rev 172444)
+++ trunk/Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp 2014-08-12 12:07:55 UTC (rev 172445)
</span><span class="lines">@@ -26,10 +26,10 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "ViewClientEfl.h"
</span><span class="cx">
</span><ins>+#include "EwkDebug.h"
</ins><span class="cx"> #include "EwkView.h"
</span><span class="cx"> #include "PageViewportController.h"
</span><span class="cx"> #include "WebViewportAttributes.h"
</span><del>-#include "ewk_private.h"
</del><span class="cx"> #include "ewk_view.h"
</span><span class="cx"> #include <WebKit/WKString.h>
</span><span class="cx"> #include <WebKit/WKView.h>
</span></span></pre>
</div>
</div>
</body>
</html>